Skip to contentSkip to conversation

generic/611: remove _supported_os line

PATCH In review Zorro Lang 4 participants 4 messages Sep 21, 2020 – Sep 27, 2020

lore
Share & tools
lore

Zorro Lang

author
#0 lore raw

PATCH 1/1 generic/611: remove _supported_os line

The current xfstests doesn't support _supported_os() function, the generic/611 always hit an error:

xfstests-dev/tests/generic/611: line 39: _supported_os: command not found

So remove the "_supported_os Linux" line directly.

---
 tests/generic/611 | 1 -
 1 file changed, 1 deletion(-)
tests/generic/611 +0 -1
index 069db6f9..f4158bb3 100755
@@ -36,7 +36,6 @@ rm -f $seqres.full
 # real QA test starts here
 
 _supported_fs generic
-_supported_os Linux
 _require_scratch
 _require_attrs
 
Signature · 1 line
2.20.1
Reviewed-by on v1 1/1
#2 lore raw
In reply to Zorro Lang
Quoted 6 lines · Zorro Lang

The current xfstests doesn't support _supported_os() function, the generic/611 always hit an error:

xfstests-dev/tests/generic/611: line 39: _supported_os: command not found

So remove the "_supported_os Linux" line directly.

Hi Zorro,

It seems better to add a fix tag:

Fixes a860a167d87a ("common: kill _supported_os")

Other than that it is fine for me. :-)

Best Regards,
Xiao Yang

Quoted 17 lines
---
 tests/generic/611 | 1 -
 1 file changed, 1 deletion(-)
tests/generic/611 +0 -1
index 069db6f9..f4158bb3 100755
@@ -36,7 +36,6 @@ rm -f $seqres.full
 # real QA test starts here
 
 _supported_fs generic
-_supported_os Linux
 _require_scratch
 _require_attrs
 
#3 lore raw
Quoted 11 lines · Xiao Yang
Quoted 6 lines · Zorro Lang

The current xfstests doesn't support _supported_os() function, the generic/611 always hit an error:

xfstests-dev/tests/generic/611: line 39: _supported_os: command not found

So remove the "_supported_os Linux" line directly.

Hi Zorro,

It seems better to add a fix tag:

Fixes a860a167d87a ("common: kill _supported_os")

Actually it was my fault, not the above commit, I applied the new test first, then applied above commit, which of cource didn't handle generic/611..

Quoted 3 lines

Other than that it is fine for me. :-)

Thanks for the fix and review!

Eryu

Quoted 22 lines

Best Regards,
Xiao Yang

Quoted 17 lines
---
 tests/generic/611 | 1 -
 1 file changed, 1 deletion(-)
tests/generic/611 +0 -1
index 069db6f9..f4158bb3 100755
@@ -36,7 +36,6 @@ rm -f $seqres.full
 # real QA test starts here
 
 _supported_fs generic
-_supported_os Linux
 _require_scratch
 _require_attrs