vmlinux.lds.h: Handle clang's module.{c,d}tor sections
Subsystems (2)
PATCH 1/1 vmlinux.lds.h: Handle clang's module.{c,d}tor sections
A recent change in LLVM causes module_{c,d}tor sections to appear when CONFIG_K{A,C}SAN are enabled, which results in orphan section warnings because these are not handled anywhere:
ld.lld: warning: arch/x86/pci/built-in.a(legacy.o):(.text.asan.module_ctor) is being placed in '.text.asan.module_ctor' ld.lld: warning: arch/x86/pci/built-in.a(legacy.o):(.text.asan.module_dtor) is being placed in '.text.asan.module_dtor' ld.lld: warning: arch/x86/pci/built-in.a(legacy.o):(.text.tsan.module_ctor) is being placed in '.text.tsan.module_ctor'
Place them in the TEXT_TEXT section so that these technologies continue to work with the newer compiler versions. All of the KASAN and KCSAN KUnit tests continue to pass after this change.
--- include/asm-generic/vmlinux.lds.h | 1 + 1 file changed, 1 insertion(+)
include/asm-generic/vmlinux.lds.h +1 -0
@@ -586,6 +586,7 @@ NOINSTR_TEXT \ *(.text..refcount) \ *(.ref.text) \ + *(.text.asan .text.asan.*) \ TEXT_CFI_JT \ MEM_KEEP(init.text*) \ MEM_KEEP(exit.text*) \
base-commit: 4669e13cd67f8532be12815ed3d37e775a9bdc16
Signature · 1 line
2.32.0.264.g75ae10bc75
Quoted 8 lines · Nathan Chancellor
A recent change in LLVM causes module_{c,d}tor sections to appear when CONFIG_K{A,C}SAN are enabled, which results in orphan section warnings because these are not handled anywhere:
ld.lld: warning: arch/x86/pci/built-in.a(legacy.o):(.text.asan.module_ctor) is being placed in '.text.asan.module_ctor' ld.lld: warning: arch/x86/pci/built-in.a(legacy.o):(.text.asan.module_dtor) is being placed in '.text.asan.module_dtor' ld.lld: warning: arch/x86/pci/built-in.a(legacy.o):(.text.tsan.module_ctor) is being placed in '.text.tsan.module_ctor'
^ .text.tsan.*
Quoted 18 lines
Place them in the
TEXT_TEXTsection so that these technologies continue to work with the newer compiler versions. All of the KASAN and KCSAN KUnit tests continue to pass after this change.Signed-off-by Nathan Chancellor <[email protected]>--- include/asm-generic/vmlinux.lds.h | 1 + 1 file changed, 1 insertion(+)include/asm-generic/vmlinux.lds.h +0
-0
include/asm-generic/vmlinux.lds.h line 589
Quoted 4 lines
include/asm-generic/vmlinux.lds.h +1
-0@@ -586,6 +586,7 @@NOINSTR_TEXT \ *(.text..refcount) \ *(.ref.text) \ + *(.text.asan .text.asan.*) \
Will this match .text.tsan.module_ctor?
Do we want to add these conditionally on CONFIG_KASAN_GENERIC/CONFIG_KCSAN like we do for SANITIZER_DISCARDS?
Quoted 6 lines
include/asm-generic/vmlinux.lds.h +0
-0TEXT_CFI_JT \ MEM_KEEP(init.text*) \ MEM_KEEP(exit.text*) \base-commit:
4669e13cd67f8532be12815ed3d37e775a9bdc16--
Signature · 2 lines
Thanks, ~Nick Desaulniers
Quoted 11 lines · Nick Desaulniers
Quoted 8 lines · Nathan Chancellor
A recent change in LLVM causes module_{c,d}tor sections to appear when CONFIG_K{A,C}SAN are enabled, which results in orphan section warnings because these are not handled anywhere:
ld.lld: warning: arch/x86/pci/built-in.a(legacy.o):(.text.asan.module_ctor) is being placed in '.text.asan.module_ctor' ld.lld: warning: arch/x86/pci/built-in.a(legacy.o):(.text.asan.module_dtor) is being placed in '.text.asan.module_dtor' ld.lld: warning: arch/x86/pci/built-in.a(legacy.o):(.text.tsan.module_ctor) is being placed in '.text.tsan.module_ctor'
^ .text.tsan.*
I was wondering why the orphan section warning only arose recently. Now I see: the function asan.module_ctor has the SHF_GNU_RETAIN flag, so it is in a separate section even with -fno-function-sections (default).
It seems that with -ffunction-sections the issue should have been caught much earlier.
Quoted 13 lines
Quoted 13 lines
Place them in the
TEXT_TEXTsection so that these technologies continue to work with the newer compiler versions. All of the KASAN and KCSAN KUnit tests continue to pass after this change.Signed-off-by Nathan Chancellor <[email protected]>--- include/asm-generic/vmlinux.lds.h | 1 + 1 file changed, 1 insertion(+)
Quoted 11 lines
include/asm-generic/vmlinux.lds.h line 589
Quoted 9 lines
include/asm-generic/vmlinux.lds.h +1
-0@@ -586,6 +586,7 @@NOINSTR_TEXT \ *(.text..refcount) \ *(.ref.text) \ + *(.text.asan .text.asan.*) \Will this match .text.tsan.module_ctor?
asan.module_ctor is the only function AddressSanitizer synthesizes in the instrumented translation unit. There is no function called "asan".
(Even if a function "asan" exists due to -ffunction-sections -funique-section-names, TEXT_MAIN will match .text.asan, so the .text.asan pattern will match nothing.)
Quoted 14 lines
Do we want to add these conditionally on CONFIG_KASAN_GENERIC/CONFIG_KCSAN like we do for
SANITIZER_DISCARDS?Quoted 6 lines
include/asm-generic/vmlinux.lds.h +0
-0TEXT_CFI_JT \ MEM_KEEP(init.text*) \ MEM_KEEP(exit.text*) \base-commit:
4669e13cd67f8532be12815ed3d37e775a9bdc16--Signature · 2 lines
Thanks, ~Nick Desaulniers
Quoted 11 lines · Fangrui Song
Quoted 10 lines · Nick Desaulniers
Quoted 8 lines · Nathan Chancellor
A recent change in LLVM causes module_{c,d}tor sections to appear when CONFIG_K{A,C}SAN are enabled, which results in orphan section warnings because these are not handled anywhere:
ld.lld: warning: arch/x86/pci/built-in.a(legacy.o):(.text.asan.module_ctor) is being placed in '.text.asan.module_ctor' ld.lld: warning: arch/x86/pci/built-in.a(legacy.o):(.text.asan.module_dtor) is being placed in '.text.asan.module_dtor' ld.lld: warning: arch/x86/pci/built-in.a(legacy.o):(.text.tsan.module_ctor) is being placed in '.text.tsan.module_ctor'
Quoted 5 lines
Quoted 1 line
^ .text.tsan.*
I was wondering why the orphan section warning only arose recently. Now I see: the function asan.module_ctor has the
SHF_GNU_RETAINflag, so it is in a separate section even with -fno-function-sections (default).
Thanks for the explanation, I will add this to the commit message.
Quoted 32 lines
It seems that with -ffunction-sections the issue should have been caught much earlier.
Quoted 29 lines
Quoted 26 lines
Place them in the
TEXT_TEXTsection so that these technologies continue to work with the newer compiler versions. All of the KASAN and KCSAN KUnit tests continue to pass after this change.Signed-off-by Nathan Chancellor <[email protected]>---
include/asm-generic/vmlinux.lds.h | 1 +1 file changed, 1 insertion(+)include/asm-generic/vmlinux.lds.h +1
-0@@ -586,6 +586,7 @@ NOINSTR_TEXT \ *(.text..refcount) \ *(.ref.text) \ + *(.text.asanQuoted 1 line
.text.asan.*) \
Will this match .text.tsan.module_ctor?
No, I forgot to test CONFIG_KCSAN with this version, rather than the prior one I had on GitHub so I will send v2 shortly.
Quoted 6 lines
asan.module_ctor is the only function AddressSanitizer synthesizes in the instrumented translation unit. There is no function called "asan".
(Even if a function "asan" exists due to -ffunction-sections -funique-section-names,
TEXT_MAINwill match .text.asan, so the .text.asan pattern will match nothing.)
Sounds good, I will update it to remove the .text.asan and replace it with .text.tsan.*
Quoted 2 lines
Quoted 2 lines
Do we want to add these conditionally on CONFIG_KASAN_GENERIC/CONFIG_KCSAN like we do for
SANITIZER_DISCARDS?
I do not think there is a point in doing so but I can if others feel strongly.
Thank you both for the comments for the comments!
Cheers,
Nathan
PATCH v2 1/1 vmlinux.lds.h: Handle clang's module.{c,d}tor sections
In reply to Nathan ChancellorA recent change in LLVM causes module_{c,d}tor sections to appear when CONFIG_K{A,C}SAN are enabled, which results in orphan section warnings because these are not handled anywhere:
ld.lld: warning: arch/x86/pci/built-in.a(legacy.o):(.text.asan.module_ctor) is being placed in '.text.asan.module_ctor' ld.lld: warning: arch/x86/pci/built-in.a(legacy.o):(.text.asan.module_dtor) is being placed in '.text.asan.module_dtor' ld.lld: warning: arch/x86/pci/built-in.a(legacy.o):(.text.tsan.module_ctor) is being placed in '.text.tsan.module_ctor'
Fangrui explains: "the function asan.module_ctor has the SHF_GNU_RETAIN flag, so it is in a separate section even with -fno-function-sections (default)".
Place them in the TEXT_TEXT section so that these technologies continue to work with the newer compiler versions. All of the KASAN and KCSAN KUnit tests continue to pass after this change.
---
v1 -> v2:
* Fix inclusion of .text.tsan.* (Nick)
* Drop .text.asan as it does not exist plus it would be handled by a different line (Fangrui)
* Add Fangrui's explanation about why the LLVM commit caused these sections to appear.
include/asm-generic/vmlinux.lds.h | 1 + 1 file changed, 1 insertion(+)
include/asm-generic/vmlinux.lds.h +1 -0
@@ -586,6 +586,7 @@ NOINSTR_TEXT \ *(.text..refcount) \ *(.ref.text) \ + *(.text.asan.* .text.tsan.*) \ TEXT_CFI_JT \ MEM_KEEP(init.text*) \ MEM_KEEP(exit.text*) \
base-commit: 4669e13cd67f8532be12815ed3d37e775a9bdc16
Signature · 1 line
2.32.0.264.g75ae10bc75
Quoted 11 lines · Nathan Chancellor
A recent change in LLVM causes module_{c,d}tor sections to appear when CONFIG_K{A,C}SAN are enabled, which results in orphan section warnings because these are not handled anywhere:
ld.lld: warning: arch/x86/pci/built-in.a(legacy.o):(.text.asan.module_ctor) is being placed in '.text.asan.module_ctor' ld.lld: warning: arch/x86/pci/built-in.a(legacy.o):(.text.asan.module_dtor) is being placed in '.text.asan.module_dtor' ld.lld: warning: arch/x86/pci/built-in.a(legacy.o):(.text.tsan.module_ctor) is being placed in '.text.tsan.module_ctor'
Fangrui explains: "the function asan.module_ctor has the
SHF_GNU_RETAINflag, so it is in a separate section even with -fno-function-sections (default)".
If my theory is true, we should see orphan section warning with CONFIG_LD_DEAD_CODE_DATA_ELIMINATION
before my sanitizer change.
Quoted 28 lines
Place them in the
TEXT_TEXTsection so that these technologies continue to work with the newer compiler versions. All of the KASAN and KCSAN KUnit tests continue to pass after this change.Signed-off-by Nathan Chancellor <[email protected]>---
v1 -> v2:
* Fix inclusion of .text.tsan.* (Nick)
* Drop .text.asan as it does not exist plus it would be handled by a different line (Fangrui)
* Add Fangrui's explanation about why the LLVM commit caused these sections to appear.
include/asm-generic/vmlinux.lds.h| 1 +1 file changed, 1 insertion(+)include/asm-generic/vmlinux.lds.h +0
-0
include/asm-generic/vmlinux.lds.h line 589
Quoted 4 lines
include/asm-generic/vmlinux.lds.h +1
-0@@ -586,6 +586,7 @@NOINSTR_TEXT \ *(.text..refcount) \ *(.ref.text) \ + *(.text.asan.* .text.tsan.*) \
When kmsan is upstreamed, we may need to add .text.msan.* :)
(
I wondered why we cannot just change the TEXT_MAIN pattern to .text.*
For large userspace applications, separating .text.unlikely .text.hot can help do things like hugepage and mlock, which can improve instruction cache localize and reduce instruction TLB miss rates,,, but not sure this helps much for the kernel.
Or perhaps some .text.FOOBAR has special usage which cannot be placed into the output .text
)
Quoted 8 lines
include/asm-generic/vmlinux.lds.h +0
-0TEXT_CFI_JT \ MEM_KEEP(init.text*) \ MEM_KEEP(exit.text*) \base-commit:
4669e13cd67f8532be12815ed3d37e775a9bdc16Signature · 1 line
2.32.0.264.g75ae10bc75
Quoted 12 lines · Nathan Chancellor
A recent change in LLVM causes module_{c,d}tor sections to appear when CONFIG_K{A,C}SAN are enabled, which results in orphan section warnings because these are not handled anywhere:
ld.lld: warning: arch/x86/pci/built-in.a(legacy.o):(.text.asan.module_ctor) is being placed in '.text.asan.module_ctor' ld.lld: warning: arch/x86/pci/built-in.a(legacy.o):(.text.asan.module_dtor) is being placed in '.text.asan.module_dtor' ld.lld: warning: arch/x86/pci/built-in.a(legacy.o):(.text.tsan.module_ctor) is being placed in '.text.tsan.module_ctor'
Fangrui explains: "the function asan.module_ctor has the
SHF_GNU_RETAINflag, so it is in a separate section even with -fno-function-sections (default)".
Quoted 8 lines
Place them in the
TEXT_TEXTsection so that these technologies continue to work with the newer compiler versions. All of the KASAN and KCSAN KUnit tests continue to pass after this change.
For KASAN module_ctors are very much required to support detecting globals out-of-bounds: https://reviews.llvm.org/D81390
For KASAN the test would have revealed that at the latest.
KCSAN does not yet have much use for the module_ctors, but it may change in future, so keeping them all was the right call.
Thanks,
-- Marco
Quoted 32 lines
---
v1 -> v2:
* Fix inclusion of .text.tsan.* (Nick)
* Drop .text.asan as it does not exist plus it would be handled by a different line (Fangrui)
* Add Fangrui's explanation about why the LLVM commit caused these sections to appear.
include/asm-generic/vmlinux.lds.h | 1 + 1 file changed, 1 insertion(+)include/asm-generic/vmlinux.lds.h +1
-0@@ -586,6 +586,7 @@ NOINSTR_TEXT \ *(.text..refcount) \ *(.ref.text) \ + *(.text.asan.* .text.tsan.*) \ TEXT_CFI_JT \ MEM_KEEP(init.text*) \ MEM_KEEP(exit.text*) \base-commit:
4669e13cd67f8532be12815ed3d37e775a9bdc16--
2.32.0.264.g75ae10bc75
Quoted 13 lines · Nathan Chancellor
A recent change in LLVM causes module_{c,d}tor sections to appear when CONFIG_K{A,C}SAN are enabled, which results in orphan section warnings because these are not handled anywhere:
ld.lld: warning: arch/x86/pci/built-in.a(legacy.o):(.text.asan.module_ctor) is being placed in '.text.asan.module_ctor' ld.lld: warning: arch/x86/pci/built-in.a(legacy.o):(.text.asan.module_dtor) is being placed in '.text.asan.module_dtor' ld.lld: warning: arch/x86/pci/built-in.a(legacy.o):(.text.tsan.module_ctor) is being placed in '.text.tsan.module_ctor'
Fangrui explains: "the function asan.module_ctor has the
SHF_GNU_RETAINflag, so it is in a separate section even with -fno-function-sections (default)".
Quoted 8 lines
Place them in the
TEXT_TEXTsection so that these technologies continue to work with the newer compiler versions. All of the KASAN and KCSAN KUnit tests continue to pass after this change.
Quoted 32 lines
---
v1 -> v2:
* Fix inclusion of .text.tsan.* (Nick)
* Drop .text.asan as it does not exist plus it would be handled by a different line (Fangrui)
* Add Fangrui's explanation about why the LLVM commit caused these sections to appear.
include/asm-generic/vmlinux.lds.h | 1 + 1 file changed, 1 insertion(+)include/asm-generic/vmlinux.lds.h +1
-0@@ -586,6 +586,7 @@ NOINSTR_TEXT \ *(.text..refcount) \ *(.ref.text) \ + *(.text.asan.* .text.tsan.*) \ TEXT_CFI_JT \ MEM_KEEP(init.text*) \ MEM_KEEP(exit.text*) \base-commit:
4669e13cd67f8532be12815ed3d37e775a9bdc16--
2.32.0.264.g75ae10bc75
Signature · 2 lines
Thanks, ~Nick Desaulniers