scripts: use env to invoke bash
PATCH v2 1/1 scripts: use env to invoke bash
Not all systems have bash at a fixed location like /bin/bash. FreeBSD, for example, would typically have it at /usr/local/bin/bash. When building OpenSBI on freebsd system, the build breaks.
Its advisable to use: #!/usr/bin/env bash
[v2] In this version:
* Change remaining two scripts to use env
--- scripts/carray.sh | 2 +- scripts/create-binary-archive.sh | 2 +- scripts/d2c.sh | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
scripts/carray.sh +1 -1
@@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash function usage() {
scripts/create-binary-archive.sh +1 -1
@@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash function usage() {
scripts/d2c.sh +1 -1
@@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash function usage() {
Signature · 1 line
2.38.1
PATCH v2 1/1 scripts: use env to invoke bash
? 2022-12-09???? 11:43 +0530?Himanshu Chauhan???
Quoted 10 lines
Not all systems have bash at a fixed location like
/bin/bash. FreeBSD, for example, would typically have it at/usr/local/bin/bash. When building OpenSBI on freebsd system, the build breaks.Its advisable to use: #!/usr/bin/env bash
[v2] In this version:
* Change remaining two scripts to use envSigned-off-by Himanshu Chauhan <[email protected]>
LGTM
Quoted 40 lines
---
?scripts/carray.sh??????????????? | 2 +- ?scripts/create-binary-archive.sh | 2 +- ?scripts/d2c.sh?????????????????? | 2 +-?3 files changed, 3 insertions(+), 3 deletions(-)
scripts/carray.sh +1
-1@@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash?
?functionusage()
?{scripts/create-binary-archive.sh +1
-1@@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash?
?functionusage()
?{scripts/d2c.sh +1
-1@@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash?
?functionusage()
?{Signature · 1 line
2.38.1
Anup Patel
AppliedPATCH v2 1/1 scripts: use env to invoke bash
In reply to Himanshu ChauhanQuoted 9 lines · Himanshu Chauhan
Not all systems have bash at a fixed location like
/bin/bash. FreeBSD, for example, would typically have it at/usr/local/bin/bash. When building OpenSBI on freebsd system, the build breaks.Its advisable to use: #!/usr/bin/env bash
[v2] In this version:
* Change remaining two scripts to use env
The change log should be after the "---" line below for a single patch otherwise it becomes part of the commit description.
Quoted 2 lines
Signed-off-by Himanshu Chauhan <[email protected]>
Looks good to me.
Applied this patch to the riscv/opensbi repo.
Thanks,
Anup
Quoted 44 lines
--- scripts/carray.sh | 2 +- scripts/create-binary-archive.sh | 2 +- scripts/d2c.sh | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)scripts/carray.sh +1
-1@@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash function usage() {scripts/create-binary-archive.sh +1
-1@@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash function usage() {scripts/d2c.sh +1
-2@@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash function usage() { --2.38.1
--
opensbi mailing list
opensbi at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/opensbi