Skip to contentSkip to conversation

nvme: mask CSE effects for security receive

PATCH In review Keith Busch 5 participants 6 messages Jan 20, 2023 – Jan 23, 2023 NVMe

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nvme: mask CSE effects for security receive

From: Keith Busch <[email protected]>

The nvme driver will freeze the IO queues in response to an admin command with CSE bits set. These bits notify the host that the command that's about to be executed needs to be done exclusively, hence the freeze.

The Security Receive command is often reported by multiple vendors with CSE bits set. The reason for this is that the result depends on the previous Security Send. This has nothing to do with IO queues, though, so the driver is taking an overly cautious response to seeing this passthrough command, while unable to fufill the intended admin queue action.

Rather than freeze IO during this harmless command, mask off the effects. This freezing is observed to cause IO latency spikes when host software periodically validates the security state of the drives.

---
 drivers/nvme/host/core.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
drivers/nvme/host/core.c +17 -0
index d7d2c2b342ba4..1b10b27deb999 100644
@@ -3101,6 +3101,23 @@ static void nvme_init_known_nvm_effects(struct nvme_ctrl *ctrl)
 	log->acs[nvme_admin_sanitize_nvm] |= cpu_to_le32(NVME_CMD_EFFECTS_LBCC |
 						NVME_CMD_EFFECTS_CSE_MASK);
 
+	/*
+	 * The spec says the result of a security receive command depends on
+	 * the previous security send command. As such, many vendors logs this
+	 * command as one to submitted only when no other commands to the same
+	 * namespace are outstanding. The intention is to tell the host to
+	 * prevent mixing security send and receive.
+	 *
+	 * This driver can only enforce such exclusive access against IO
+	 * queues, though. We are not readily able to enforce such a rule for
+	 * two commands to the admin queue, which is the only queue that
+	 * matters for this command.
+	 *
+	 * Rather than blindly freezing the IO queues for this effect that
+	 * doesn't even apply to IO, mask it off.
+	 */
+	log->acs[nvme_admin_security_recv] &= ~NVME_CMD_EFFECTS_CSE_MASK;
+
 	log->iocs[nvme_cmd_write] |= cpu_to_le32(NVME_CMD_EFFECTS_LBCC);
 	log->iocs[nvme_cmd_write_zeroes] |= cpu_to_le32(NVME_CMD_EFFECTS_LBCC);
 	log->iocs[nvme_cmd_write_uncor] |= cpu_to_le32(NVME_CMD_EFFECTS_LBCC);
Signature · 1 line
2.30.2
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 14 lines · Keith Busch

From: Keith Busch <[email protected]>

The nvme driver will freeze the IO queues in response to an admin command with CSE bits set. These bits notify the host that the command that's about to be executed needs to be done exclusively, hence the freeze.

The Security Receive command is often reported by multiple vendors with CSE bits set. The reason for this is that the result depends on the previous Security Send. This has nothing to do with IO queues, though, so the driver is taking an overly cautious response to seeing this passthrough command, while unable to fufill the intended admin queue action.

Quoted 3 lines

Rather than freeze IO during this harmless command, mask off the effects. This freezing is observed to cause IO latency spikes when host software periodically validates the security state of the drives.

Signature · 1 line
Jens Axboe
#4 lore raw
Quoted 1 line · Christoph Hellwig

As-is this only applies to nvme-6.3, is that intended?

In fact it doesn't apply to nvme-6.3 either, I guess we need your CSE initialization patch first.

maintainer
#5 lore raw
In reply to Christoph Hellwig
Quoted 1 line · Christoph Hellwig

As-is this only applies to nvme-6.3, is that intended?

Yeah, it also has a dependency on my other pending patch that always allocates the log page, which isn't in 6.3 yet (I have to send a new version of that, anyway).

I can backport if desired for 6.2, but I don't think this is urgent enough to get in right away.