i40e: remove enum i40e_client_state
Subsystems (3)
Jakub Kicinski
maintainerPATCH 1/1 i40e: remove enum i40e_client_state
It's not used.
--- include/linux/net/intel/i40e_client.h | 10 ---------- 1 file changed, 10 deletions(-)
include/linux/net/intel/i40e_client.h +0 -10
@@ -26,11 +26,6 @@ struct i40e_client_version {u8 rsvd; }; -enum i40e_client_state { - __I40E_CLIENT_NULL, - __I40E_CLIENT_REGISTERED -}; -enum i40e_client_instance_state { __I40E_CLIENT_INSTANCE_NONE, __I40E_CLIENT_INSTANCE_OPENED,
@@ -190,11 +185,6 @@ struct i40e_client {const struct i40e_client_ops *ops;/* client ops provided by the client */ }; -static inline bool i40e_client_is_registered (struct i40e_client *client) -{ -return test_bit (__I40E_CLIENT_REGISTERED, &client->state); -} -void i40e_client_device_register (struct i40e_info *ldev,struct i40e_client *client);void i40e_client_device_unregister (struct i40e_info *ldev);
Signature · 1 line
2.34.1
Thanks Jakub!
Quoted 1 line · Jakub Kicinski
It's not used.
minor nit, you didn't say if you wanted this to go to net or net-next or add a Fixes: tag?
maybe:
driver")
Quoted 2 lines
Signed-off-by Jakub Kicinski <[email protected]>
for the patch itself, it looks fine to me, so if you spin this
Quoted 32 lines
--- include/linux/net/intel/i40e_client.h | 10 ---------- 1 file changed, 10 deletions(-)include/linux/net/intel/i40e_client.h +0
-10@@ -26,11 +26,6 @@ struct i40e_client_version {u8 rsvd; }; -enum i40e_client_state { - __I40E_CLIENT_NULL, - __I40E_CLIENT_REGISTERED -}; -enum i40e_client_instance_state { __I40E_CLIENT_INSTANCE_NONE, __I40E_CLIENT_INSTANCE_OPENED,@@ -190,11 +185,6 @@ struct i40e_client {const struct i40e_client_ops *ops;/* client ops provided by the client */ }; -static inline bool i40e_client_is_registered (struct i40e_client *client) -{ -return test_bit (__I40E_CLIENT_REGISTERED, &client->state); -} -void i40e_client_device_register (struct i40e_info *ldev,struct i40e_client *client);void i40e_client_device_unregister (struct i40e_info *ldev);
Jakub Kicinski
maintainerQuoted 5 lines · On Wed, 26 Jan 2022 11:53:29 -0800 Jesse Brandeburg wrote:
Quoted 1 line · Jakub Kicinski
It's not used.
minor nit, you didn't say if you wanted this to go to net or net-next or add a Fixes: tag?
Right, I'm not targeting net or net-next directly. I should have put something like "intel-next", probably.
Quoted 8 lines
maybe:
Fixes e3219ce6a775 ("i40e: Add support for client interface for IWARPdriver")
Quoted 1 line
Signed-off-by Jakub Kicinski <[email protected]>for the patch itself, it looks fine to me, so if you spin this
Reviewed-by Jesse Brandeburg <[email protected]>
Quoted 11 lines
-----Original Message-----
From: Intel-wired-lan <[email protected]> On Behalf Of Jakub Kicinski
Sent: Thursday, January 27, 2022 12:26 AM
To: Nguyen, Anthony L <[email protected]>
Cc: netdev at vger.kernel.org; intel-wired-lan at lists.osuosl.org; Saleem, Shiraz <[email protected]>; Jakub Kicinski <[email protected]>
Subject: [Intel-wired-lan] [PATCH] i40e: remove enumi40e_client_state
Quoted 7 lines
It's not used.
Signed-off-by Jakub Kicinski <[email protected]>--- include/linux/net/intel/i40e_client.h | 10 ---------- 1 file changed, 10 deletions(-)