Skip to contentSkip to conversation

hwtracing: coresight: Replace acpi_bus_get_device()

PATCH In review Rafael J. Wysocki 3 participants 5 messages Feb 1, 2022 – Feb 2, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hwtracing: coresight: Replace acpi_bus_get_device()

From: Rafael J. Wysocki <[email protected]>

Replace acpi_bus_get_device() that is going to be dropped with acpi_fetch_acpi_dev().

No intentional functional impact.

---
 drivers/hwtracing/coresight/coresight-platform.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/hwtracing/coresight/coresight-platform.c +4 -4
Index: linux-pm/drivers/hwtracing/coresight/coresight-platform.c
===================================================================
@@ -626,7 +626,7 @@ static int acpi_coresight_parse_link(str
 				     const union acpi_object *link,
 				     struct coresight_connection *conn)
 {
-	int rc, dir;
+	int dir;
 	const union acpi_object *fields;
 	struct acpi_device *r_adev;
 	struct device *rdev;
@@ -643,9 +643,9 @@ static int acpi_coresight_parse_link(str
 	    fields[3].type != ACPI_TYPE_INTEGER)
 		return -EINVAL;
 
-	rc = acpi_bus_get_device(fields[2].reference.handle, &r_adev);
-	if (rc)
-		return rc;
+	r_adev = acpi_fetch_acpi_dev(fields[2].reference.handle);
+	if (!r_adev)
+		return -ENODEV;
 
 	dir = fields[3].integer.value;
 	if (dir == ACPI_CORESIGHT_LINK_MASTER) {
maintainer
#1 lore raw

Hi Rafael

Quoted 28 lines · Rafael J. Wysocki

From: Rafael J. Wysocki <[email protected]>

Replace acpi_bus_get_device() that is going to be dropped with acpi_fetch_acpi_dev().

No intentional functional impact.

---
  drivers/hwtracing/coresight/coresight-platform.c |    8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)

Index: linux-pm/drivers/hwtracing/coresight/coresight-platform.c
===================================================================

drivers/hwtracing/coresight/coresight-platform.c +1 -1
@@ -626,7 +626,7 @@ static int acpi_coresight_parse_link(str
  				     const union acpi_object *link,
  				     struct coresight_connection *conn)
  {
-	int rc, dir;
+	int dir;
  	const union acpi_object *fields;
  	struct acpi_device *r_adev;
  	struct device *rdev;

drivers/hwtracing/coresight/coresight-platform.c static int acpi_coresight_parse_link(str · line 649

Quoted 10 lines
drivers/hwtracing/coresight/coresight-platform.c +3 -3
@@ -643,9 +643,9 @@ static int acpi_coresight_parse_link(str
  	    fields[3].type != ACPI_TYPE_INTEGER)
  		return -EINVAL;
 
-	rc = acpi_bus_get_device(fields[2].reference.handle, &r_adev);
-	if (rc)
-		return rc;
+	r_adev = acpi_fetch_acpi_dev(fields[2].reference.handle);
+	if (!r_adev)
+		return -ENODEV;
 

Is this patch part of a series ? I don't see acpi_fetch_acpi_dev() in v5.17-rc1, which our tree is based on at the moment. Please could you point us to the changes ?

Also do you expect to pull this via your tree ?

Cheers
Suzuki

Quoted 5 lines
drivers/hwtracing/coresight/coresight-platform.c +0 -0
  	dir = fields[3].integer.value;
  	if (dir == ACPI_CORESIGHT_LINK_MASTER) {
#2 lore raw
Quoted 35 lines · Suzuki K Poulose

Hi Rafael

Quoted 31 lines · Rafael J. Wysocki

From: Rafael J. Wysocki <[email protected]>

Replace acpi_bus_get_device() that is going to be dropped with acpi_fetch_acpi_dev().

No intentional functional impact.

---
  drivers/hwtracing/coresight/coresight-platform.c |    8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)

Index: linux-pm/drivers/hwtracing/coresight/coresight-platform.c
===================================================================

drivers/hwtracing/coresight/coresight-platform.c +1 -1
@@ -626,7 +626,7 @@ static int acpi_coresight_parse_link(str
                                   const union acpi_object *link,
                                   struct coresight_connection *conn)
  {
-     int rc, dir;
+     int dir;
      const union acpi_object *fields;
      struct acpi_device *r_adev;
      struct device *rdev;
@@ -643,9 +643,9 @@ static int acpi_coresight_parse_link(str
          fields[3].type != ACPI_TYPE_INTEGER)
              return -EINVAL;
 
Quoted 9 lines

drivers/hwtracing/coresight/coresight-platform.c static int acpi_coresight_parse_link(str · line 649

Quoted 7 lines
drivers/hwtracing/coresight/coresight-platform.c +3 -3
-     rc = acpi_bus_get_device(fields[2].reference.handle, &r_adev);
-     if (rc)
-             return rc;
+     r_adev = acpi_fetch_acpi_dev(fields[2].reference.handle);
+     if (!r_adev)
+             return -ENODEV;
 

Is this patch part of a series ?

No, it isn't.

Quoted 1 line

I don't see acpi_fetch_acpi_dev() in v5.17-rc1, which our tree is based on at the moment.

acpi_fetch_acpi_dev() is there in v5.17-rc1. Please see

https://elixir.bootlin.com/linux/v5.17-rc1/A/ident/acpi_fetch_acpi_dev

Quoted 3 lines

Please could you point us to the changes ?

Also do you expect to pull this via your tree ?

I can route it via the ACPI tree, but it may as well be routed along with other coresight-platform.c changes, if any.

maintainer
#3 lore raw
Quoted 52 lines · Rafael J. Wysocki
Quoted 35 lines · Suzuki K Poulose

Hi Rafael

Quoted 31 lines · Rafael J. Wysocki

From: Rafael J. Wysocki <[email protected]>

Replace acpi_bus_get_device() that is going to be dropped with acpi_fetch_acpi_dev().

No intentional functional impact.

---
   drivers/hwtracing/coresight/coresight-platform.c |    8 ++++----
   1 file changed, 4 insertions(+), 4 deletions(-)

Index: linux-pm/drivers/hwtracing/coresight/coresight-platform.c
===================================================================

drivers/hwtracing/coresight/coresight-platform.c +1 -1
@@ -626,7 +626,7 @@ static int acpi_coresight_parse_link(str
                                    const union acpi_object *link,
                                    struct coresight_connection *conn)
   {
-     int rc, dir;
+     int dir;
       const union acpi_object *fields;
       struct acpi_device *r_adev;
       struct device *rdev;
@@ -643,9 +643,9 @@ static int acpi_coresight_parse_link(str
           fields[3].type != ACPI_TYPE_INTEGER)
               return -EINVAL;
 
Quoted 9 lines

drivers/hwtracing/coresight/coresight-platform.c static int acpi_coresight_parse_link(str · line 649

Quoted 7 lines
drivers/hwtracing/coresight/coresight-platform.c +3 -3
-     rc = acpi_bus_get_device(fields[2].reference.handle, &r_adev);
-     if (rc)
-             return rc;
+     r_adev = acpi_fetch_acpi_dev(fields[2].reference.handle);
+     if (!r_adev)
+             return -ENODEV;
 

Is this patch part of a series ?

No, it isn't.

Quoted 1 line

I don't see acpi_fetch_acpi_dev() in v5.17-rc1, which our tree is based on at the moment.

acpi_fetch_acpi_dev() is there in v5.17-rc1. Please see

Quoted 8 lines

https://elixir.bootlin.com/linux/v5.17-rc1/A/ident/acpi_fetch_acpi_dev

Quoted 3 lines

Please could you point us to the changes ?

Also do you expect to pull this via your tree ?

I can route it via the ACPI tree, but it may as well be routed along with other coresight-platform.c changes, if any.

Apologies, obviously, I was looking at the wrong tree. I will queue this

Thanks
Suzuki

#4 lore raw
Quoted 56 lines · Suzuki K Poulose
Quoted 54 lines · Rafael J. Wysocki
Quoted 35 lines · Suzuki K Poulose

Hi Rafael

Quoted 31 lines · Rafael J. Wysocki

From: Rafael J. Wysocki <[email protected]>

Replace acpi_bus_get_device() that is going to be dropped with acpi_fetch_acpi_dev().

No intentional functional impact.

---
   drivers/hwtracing/coresight/coresight-platform.c |    8 ++++----
   1 file changed, 4 insertions(+), 4 deletions(-)

Index: linux-pm/drivers/hwtracing/coresight/coresight-platform.c
===================================================================

drivers/hwtracing/coresight/coresight-platform.c +1 -1
@@ -626,7 +626,7 @@ static int acpi_coresight_parse_link(str
                                    const union acpi_object *link,
                                    struct coresight_connection *conn)
   {
-     int rc, dir;
+     int dir;
       const union acpi_object *fields;
       struct acpi_device *r_adev;
       struct device *rdev;
@@ -643,9 +643,9 @@ static int acpi_coresight_parse_link(str
           fields[3].type != ACPI_TYPE_INTEGER)
               return -EINVAL;
 
Quoted 9 lines

drivers/hwtracing/coresight/coresight-platform.c static int acpi_coresight_parse_link(str · line 649

Quoted 7 lines
drivers/hwtracing/coresight/coresight-platform.c +3 -3
-     rc = acpi_bus_get_device(fields[2].reference.handle, &r_adev);
-     if (rc)
-             return rc;
+     r_adev = acpi_fetch_acpi_dev(fields[2].reference.handle);
+     if (!r_adev)
+             return -ENODEV;
 

Is this patch part of a series ?

No, it isn't.

Quoted 1 line

I don't see acpi_fetch_acpi_dev() in v5.17-rc1, which our tree is based on at the moment.

acpi_fetch_acpi_dev() is there in v5.17-rc1. Please see

https://elixir.bootlin.com/linux/v5.17-rc1/A/ident/acpi_fetch_acpi_dev

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

Please could you point us to the changes ?

Also do you expect to pull this via your tree ?

I can route it via the ACPI tree, but it may as well be routed along with other coresight-platform.c changes, if any.

Apologies, obviously, I was looking at the wrong tree. I will queue this

Thanks!