KVM: x86/pmu: Stop adding speculative Intel GP PMCs that don't exist yet
PATCH v3 1/3 KVM: x86/pmu: Stop adding speculative Intel GP PMCs that don't exist yet
From: Like Xu <[email protected]>
The Intel April 2022 SDM - Table 2-2. IA-32 Architectural MSRs adds a new architectural IA32_OVERCLOCKING_STATUS msr (0x195), plus the presence of IA32_CORE_CAPABILITIES (0xCF), the theoretical effective maximum value of the Intel GP PMCs is 14 (0xCF - 0xC1) instead of 18.
But the conclusion of this speculation "14" is very fragile and can easily be overturned once Intel declares another meaningful arch msr in the above reserved range, and even worse, just conjecture, Intel probably put PMCs 8-15 in a completely different range of MSR indices.
A conservative proposal would be to stop at the maximum number of Intel GP PMCs supported today. Also subsequent changes would limit both AMD and Intel on the number of GP counter supported by KVM.
There are some boxes like Intel P4 (non Architectural PMU) may indeed have 18 counters , but those counters are in a completely different msr address range and is not supported by KVM.
---
Previous:
https://lore.kernel.org/kvm/[email protected]/
V2 -> V3 Changelog:
- Append "Reviewed-by" from Jim;
- Refine commit message a little bit; (Jim)
- Put the "Fixes" tag back; (Jim)
arch/x86/kvm/x86.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-)
arch/x86/kvm/x86.c +2 -12
@@ -1428,20 +1428,10 @@ static const u32 msrs_to_save_all[] = {MSR_ARCH_PERFMON_PERFCTR0 +2 ,MSR_ARCH_PERFMON_PERFCTR0 +3 ,MSR_ARCH_PERFMON_PERFCTR0 +4 ,MSR_ARCH_PERFMON_PERFCTR0 +5 ,MSR_ARCH_PERFMON_PERFCTR0 +6 ,MSR_ARCH_PERFMON_PERFCTR0 +7 , -MSR_ARCH_PERFMON_PERFCTR0 +8 ,MSR_ARCH_PERFMON_PERFCTR0 +9 , -MSR_ARCH_PERFMON_PERFCTR0 +10 ,MSR_ARCH_PERFMON_PERFCTR0 +11 , -MSR_ARCH_PERFMON_PERFCTR0 +12 ,MSR_ARCH_PERFMON_PERFCTR0 +13 , -MSR_ARCH_PERFMON_PERFCTR0 +14 ,MSR_ARCH_PERFMON_PERFCTR0 +15 , -MSR_ARCH_PERFMON_PERFCTR0 +16 ,MSR_ARCH_PERFMON_PERFCTR0 +17 ,MSR_ARCH_PERFMON_EVENTSEL0 ,MSR_ARCH_PERFMON_EVENTSEL1 ,MSR_ARCH_PERFMON_EVENTSEL0 +2 ,MSR_ARCH_PERFMON_EVENTSEL0 +3 ,MSR_ARCH_PERFMON_EVENTSEL0 +4 ,MSR_ARCH_PERFMON_EVENTSEL0 +5 ,MSR_ARCH_PERFMON_EVENTSEL0 +6 ,MSR_ARCH_PERFMON_EVENTSEL0 +7 , -MSR_ARCH_PERFMON_EVENTSEL0 +8 ,MSR_ARCH_PERFMON_EVENTSEL0 +9 , -MSR_ARCH_PERFMON_EVENTSEL0 +10 ,MSR_ARCH_PERFMON_EVENTSEL0 +11 , -MSR_ARCH_PERFMON_EVENTSEL0 +12 ,MSR_ARCH_PERFMON_EVENTSEL0 +13 , -MSR_ARCH_PERFMON_EVENTSEL0 +14 ,MSR_ARCH_PERFMON_EVENTSEL0 +15 , -MSR_ARCH_PERFMON_EVENTSEL0 +16 ,MSR_ARCH_PERFMON_EVENTSEL0 +17 ,MSR_IA32_PEBS_ENABLE ,MSR_IA32_DS_AREA ,MSR_PEBS_DATA_CFG , MSR_K7_EVNTSEL0, MSR_K7_EVNTSEL1, MSR_K7_EVNTSEL2, MSR_K7_EVNTSEL3,
@@ -6926,12 +6916,12 @@ static void kvm_init_msr_list(void) intel_pt_validate_hw_cap(PT_CAP_num_address_ranges) * 2)continue ;break ; - case MSR_ARCH_PERFMON_PERFCTR0 ... MSR_ARCH_PERFMON_PERFCTR0 + 17: + case MSR_ARCH_PERFMON_PERFCTR0 ... MSR_ARCH_PERFMON_PERFCTR0 + 7:if (msrs_to_save_all[i] -MSR_ARCH_PERFMON_PERFCTR0 >=min (INTEL_PMC_MAX_GENERIC , kvm_pmu_cap.num_counters_gp))continue ;break ; - case MSR_ARCH_PERFMON_EVENTSEL0 ... MSR_ARCH_PERFMON_EVENTSEL0 + 17: + case MSR_ARCH_PERFMON_EVENTSEL0 ... MSR_ARCH_PERFMON_EVENTSEL0 + 7:if (msrs_to_save_all[i] -MSR_ARCH_PERFMON_EVENTSEL0 >=min (INTEL_PMC_MAX_GENERIC , kvm_pmu_cap.num_counters_gp))continue ;
Signature · 1 line
2.37.3
PATCH v3 2/3 KVM: x86/pmu: Limit the maximum number of supported Intel GP counters
From: Like Xu <[email protected]>
The Intel Architectural IA32_PMCx MSRs addresses range allows for a maximum of 8 GP counters. A local macro (named KVM_INTEL_PMC_MAX_GENERIC) is introduced to take back control of this virtual capability to avoid errors introduced by the out-of-bound counter emulations.
--- arch/x86/include/asm/kvm_host.h | 6 +++++- arch/x86/kvm/pmu.c | 2 +- arch/x86/kvm/vmx/pmu_intel.c | 4 ++-- arch/x86/kvm/x86.c | 12 +++++++----- 4 files changed, 15 insertions(+), 9 deletions(-)
arch/x86/include/asm/kvm_host.h +5 -1
@@ -501,6 +501,10 @@ struct kvm_pmc {bool intr; }; +/* More counters may conflict with other existing Architectural MSRs */ +#define KVM_INTEL_PMC_MAX_GENERIC 8 +#define MSR_ARCH_PERFMON_PERFCTR_MAX (MSR_ARCH_PERFMON_PERFCTR0 + KVM_INTEL_PMC_MAX_GENERIC - 1) +#define MSR_ARCH_PERFMON_EVENTSEL_MAX (MSR_ARCH_PERFMON_EVENTSEL0 + KVM_INTEL_PMC_MAX_GENERIC - 1)#define KVM_PMC_MAX_FIXED 3struct kvm_pmu {unsigned nr_arch_gp_counters;
@@ -516,7 +520,7 @@ struct kvm_pmu {u64 reserved_bits;u64 raw_event_mask;u8 version; -struct kvm_pmc gp_counters[INTEL_PMC_MAX_GENERIC ]; +struct kvm_pmc gp_counters[KVM_INTEL_PMC_MAX_GENERIC ];struct kvm_pmc fixed_counters[KVM_PMC_MAX_FIXED ];struct irq_work irq_work;DECLARE_BITMAP (reprogram_pmi,X86_PMC_IDX_MAX );
arch/x86/kvm/pmu.c +1 -1
@@ -56,7 +56,7 @@ static const struct x86_cpu_id vmx_icl_pebs_cpu[] = {* code. Each pmc, stored in kvm_pmc.idx field, is unique across * all perf counters (both gp and fixed). The mapping relationship * between pmc and perf counters is as the following: -* * Intel: [0 .. INTEL_PMC_MAX_GENERIC-1] <=> gp counters +* * Intel: [0 .. KVM_INTEL_PMC_MAX_GENERIC-1] <=> gp counters * [INTEL_PMC_IDX_FIXED .. INTEL_PMC_IDX_FIXED + 2] <=> fixed * * AMD: [0 .. AMD64_NUM_COUNTERS-1] and, for families 15H * and later, [0 .. AMD64_NUM_COUNTERS_CORE-1] <=> gp counters
arch/x86/kvm/vmx/pmu_intel.c +2 -2
@@ -617,7 +617,7 @@ static void intel_pmu_init(struct kvm_vcpu *vcpu)struct kvm_pmu *pmu =vcpu_to_pmu (vcpu);struct lbr_desc *lbr_desc =vcpu_to_lbr_desc (vcpu); -for (i =0 ; i <INTEL_PMC_MAX_GENERIC ; i++) { +for (i =0 ; i <KVM_INTEL_PMC_MAX_GENERIC ; i++) { pmu->gp_counters[i].type =KVM_PMC_GP ; pmu->gp_counters[i].vcpu = vcpu; pmu->gp_counters[i].idx = i;
@@ -643,7 +643,7 @@ static void intel_pmu_reset(struct kvm_vcpu *vcpu)struct kvm_pmc *pmc =NULL ;int i; -for (i =0 ; i <INTEL_PMC_MAX_GENERIC ; i++) { +for (i =0 ; i <KVM_INTEL_PMC_MAX_GENERIC ; i++) { pmc = &pmu->gp_counters[i];pmc_stop_counter (pmc);
arch/x86/kvm/x86.c +7 -5
@@ -1424,6 +1424,9 @@ static const u32 msrs_to_save_all[] = {MSR_ARCH_PERFMON_FIXED_CTR0 +2 ,MSR_CORE_PERF_FIXED_CTR_CTRL ,MSR_CORE_PERF_GLOBAL_STATUS ,MSR_CORE_PERF_GLOBAL_CTRL ,MSR_CORE_PERF_GLOBAL_OVF_CTRL , +MSR_IA32_PEBS_ENABLE ,MSR_IA32_DS_AREA ,MSR_PEBS_DATA_CFG , + +/* This part of MSRs should match KVM_INTEL_PMC_MAX_GENERIC. */ MSR_ARCH_PERFMON_PERFCTR0 ,MSR_ARCH_PERFMON_PERFCTR1 ,MSR_ARCH_PERFMON_PERFCTR0 +2 ,MSR_ARCH_PERFMON_PERFCTR0 +3 , MSR_ARCH_PERFMON_PERFCTR0 + 4, MSR_ARCH_PERFMON_PERFCTR0 + 5,
@@ -1432,7 +1435,6 @@ static const u32 msrs_to_save_all[] = {MSR_ARCH_PERFMON_EVENTSEL0 +2 ,MSR_ARCH_PERFMON_EVENTSEL0 +3 ,MSR_ARCH_PERFMON_EVENTSEL0 +4 ,MSR_ARCH_PERFMON_EVENTSEL0 +5 ,MSR_ARCH_PERFMON_EVENTSEL0 +6 ,MSR_ARCH_PERFMON_EVENTSEL0 +7 , -MSR_IA32_PEBS_ENABLE ,MSR_IA32_DS_AREA ,MSR_PEBS_DATA_CFG ,MSR_K7_EVNTSEL0 ,MSR_K7_EVNTSEL1 ,MSR_K7_EVNTSEL2 ,MSR_K7_EVNTSEL3 , MSR_K7_PERFCTR0, MSR_K7_PERFCTR1, MSR_K7_PERFCTR2, MSR_K7_PERFCTR3,
@@ -6916,14 +6918,14 @@ static void kvm_init_msr_list(void) intel_pt_validate_hw_cap(PT_CAP_num_address_ranges) * 2)continue ;break ; - case MSR_ARCH_PERFMON_PERFCTR0 ... MSR_ARCH_PERFMON_PERFCTR0 + 7: + case MSR_ARCH_PERFMON_PERFCTR0 ... MSR_ARCH_PERFMON_PERFCTR_MAX:if (msrs_to_save_all[i] -MSR_ARCH_PERFMON_PERFCTR0 >= -min (INTEL_PMC_MAX_GENERIC , kvm_pmu_cap.num_counters_gp)) +min (KVM_INTEL_PMC_MAX_GENERIC , kvm_pmu_cap.num_counters_gp))continue ;break ; - case MSR_ARCH_PERFMON_EVENTSEL0 ... MSR_ARCH_PERFMON_EVENTSEL0 + 7: + case MSR_ARCH_PERFMON_EVENTSEL0 ... MSR_ARCH_PERFMON_EVENTSEL_MAX:if (msrs_to_save_all[i] -MSR_ARCH_PERFMON_EVENTSEL0 >= -min (INTEL_PMC_MAX_GENERIC , kvm_pmu_cap.num_counters_gp)) +min (KVM_INTEL_PMC_MAX_GENERIC , kvm_pmu_cap.num_counters_gp))continue ;break ;case MSR_IA32_XFD :
Signature · 1 line
2.37.3
Sean Christopherson
maintainerRe: [PATCH v3 2/3] KVM: x86/pmu: Limit the maximum number of supported Intel GP counters
Quoted 6 lines · Like Xu
From: Like Xu <[email protected]>
The Intel Architectural
IA32_PMCxMSRs addresses range allows for a maximum of 8 GP counters. A local macro (namedKVM_INTEL_PMC_MAX_GENERIC) is introduced to take back control of this virtual capability to avoid errors introduced by the out-of-bound counter emulations.
Phrase changelogs as commands.
Quoted 15 lines
Suggested-by Jim Mattson <[email protected]>Signed-off-by Like Xu <[email protected]>Reviewed-by Jim Mattson <[email protected]>--- arch/x86/include/asm/kvm_host.h | 6 +++++- arch/x86/kvm/pmu.c | 2 +- arch/x86/kvm/vmx/pmu_intel.c | 4 ++-- arch/x86/kvm/x86.c | 12 +++++++----- 4 files changed, 15 insertions(+), 9 deletions(-)arch/x86/include/asm/kvm_host.h +0
-0
arch/x86/include/asm/kvm_host.h struct kvm_pmc { · line 505
Quoted 5 lines
arch/x86/include/asm/kvm_host.h +2
-0@@ -501,6 +501,10 @@ struct kvm_pmc {bool intr; }; +/* More counters may conflict with other existing Architectural MSRs */ +#define KVM_INTEL_PMC_MAX_GENERIC 8
This is weird and backwards. Common x86 code shouldn't "prefer" Intel over AMD, or vice versa. Similar to KVM_MAX_NR_USER_RETURN_MSRS, the way to do this is to define KVM's common software limit, and then verify that the vendor limits are below that common limit. E.g.
#define KVM_MAX_NR_PMU_GP_COUNTERS 8
and then add compile-time assertions that Intel stays below the max (and obviously AMD as well).
arch/x86/include/asm/kvm_host.h struct kvm_pmc { · line 507
Quoted 2 lines
arch/x86/include/asm/kvm_host.h +2
-0+#define MSR_ARCH_PERFMON_PERFCTR_MAX (MSR_ARCH_PERFMON_PERFCTR0 + KVM_INTEL_PMC_MAX_GENERIC - 1) +#define MSR_ARCH_PERFMON_EVENTSEL_MAX (MSR_ARCH_PERFMON_EVENTSEL0 + KVM_INTEL_PMC_MAX_GENERIC - 1)
These are Intel specific, correct? I.e. "arch" means "Intel architectural MSRs"?
The perf-defined names are out of KVM's control, but adding what appears to be generic #defines in common KVM that are actually Intel specific is confusing. Given that there's only a single user, I think the easiest thing is to just open code the users, e.g.
case MSR_ARCH_PERFMON_PERFCTR0 ...
MSR_ARCH_PERFMON_PERFCTR0 + KVM_MAX_NR_PMU_GP_COUNTERS - 1:
if (msrs_to_save_all[i] - MSR_ARCH_PERFMON_PERFCTR0 >=
min(KVM_MAX_NR_PMU_GP_COUNTERS, kvm_pmu_cap.num_counters_gp))
continue;
break;
case MSR_ARCH_PERFMON_EVENTSEL0 ...
MSR_ARCH_PERFMON_EVENTSEL0 + KVM_MAX_NR_PMU_GP_COUNTERS - 1:
if (msrs_to_save_all[i] - MSR_ARCH_PERFMON_EVENTSEL0 >=
min(KVM_INTEL_PMC_MAX_GENERIC, kvm_pmu_cap.num_counters_gp))
continue;
break;
PATCH v3 3/3 KVM: x86/pmu: Limit the maximum number of supported AMD GP counters
In reply to Like XuFrom: Like Xu <[email protected]>
The AMD PerfMonV2 specification allows for a maximum of 16 GP counters, which is clearly not supported with zero code effort in the current KVM.
A local macro (named like INTEL_PMC_MAX_GENERIC) is introduced to take back control of this virt capability, which also makes it easier to statically partition all available counters between hosts and guests.
--- arch/x86/include/asm/kvm_host.h | 1 + arch/x86/kvm/svm/pmu.c | 7 ++++--- arch/x86/kvm/x86.c | 3 +++ 3 files changed, 8 insertions(+), 3 deletions(-)
arch/x86/include/asm/kvm_host.h +1 -0
@@ -506,6 +506,7 @@ struct kvm_pmc {#define MSR_ARCH_PERFMON_PERFCTR_MAX (MSR_ARCH_PERFMON_PERFCTR0 + KVM_INTEL_PMC_MAX_GENERIC - 1)#define MSR_ARCH_PERFMON_EVENTSEL_MAX (MSR_ARCH_PERFMON_EVENTSEL0 + KVM_INTEL_PMC_MAX_GENERIC - 1)#define KVM_PMC_MAX_FIXED 3 +#define KVM_AMD_PMC_MAX_GENERIC AMD64_NUM_COUNTERS_COREstruct kvm_pmu {unsigned nr_arch_gp_counters;unsigned nr_arch_fixed_counters;
arch/x86/kvm/svm/pmu.c +4 -3
@@ -271,9 +271,10 @@ static void amd_pmu_init(struct kvm_vcpu *vcpu)struct kvm_pmu *pmu =vcpu_to_pmu (vcpu);int i; -BUILD_BUG_ON (AMD64_NUM_COUNTERS_CORE >INTEL_PMC_MAX_GENERIC ); +BUILD_BUG_ON (AMD64_NUM_COUNTERS_CORE >KVM_AMD_PMC_MAX_GENERIC ); +BUILD_BUG_ON (KVM_AMD_PMC_MAX_GENERIC >INTEL_PMC_MAX_GENERIC ); -for (i =0 ; i <AMD64_NUM_COUNTERS_CORE ; i++) { +for (i =0 ; i <KVM_AMD_PMC_MAX_GENERIC ; i++) { pmu->gp_counters[i].type =KVM_PMC_GP ; pmu->gp_counters[i].vcpu = vcpu; pmu->gp_counters[i].idx = i;
@@ -286,7 +287,7 @@ static void amd_pmu_reset(struct kvm_vcpu *vcpu)struct kvm_pmu *pmu =vcpu_to_pmu (vcpu);int i; -for (i =0 ; i <AMD64_NUM_COUNTERS_CORE ; i++) { +for (i =0 ; i <KVM_AMD_PMC_MAX_GENERIC ; i++) {struct kvm_pmc *pmc = &pmu->gp_counters[i];pmc_stop_counter (pmc);
arch/x86/kvm/x86.c +3 -0
@@ -1438,10 +1438,13 @@ static const u32 msrs_to_save_all[] = {MSR_K7_EVNTSEL0 ,MSR_K7_EVNTSEL1 ,MSR_K7_EVNTSEL2 ,MSR_K7_EVNTSEL3 ,MSR_K7_PERFCTR0 ,MSR_K7_PERFCTR1 ,MSR_K7_PERFCTR2 ,MSR_K7_PERFCTR3 , + +/* This part of MSRs should match KVM_AMD_PMC_MAX_GENERIC. */ MSR_F15H_PERF_CTL0 ,MSR_F15H_PERF_CTL1 ,MSR_F15H_PERF_CTL2 ,MSR_F15H_PERF_CTL3 ,MSR_F15H_PERF_CTL4 ,MSR_F15H_PERF_CTL5 ,MSR_F15H_PERF_CTR0 ,MSR_F15H_PERF_CTR1 ,MSR_F15H_PERF_CTR2 ,MSR_F15H_PERF_CTR3 ,MSR_F15H_PERF_CTR4 ,MSR_F15H_PERF_CTR5 , + MSR_IA32_XFD, MSR_IA32_XFD_ERR, };
Signature · 1 line
2.37.3
Paolo Bonzini
maintainerRe: [PATCH v3 3/3] KVM: x86/pmu: Limit the maximum number of supported AMD GP counters
arch/x86/include/asm/kvm_host.h struct kvm_pmc { · line 510
Quoted 6 lines · Like Xu
arch/x86/include/asm/kvm_host.h +1
-0@@ -506,6 +506,7 @@ struct kvm_pmc {#define MSR_ARCH_PERFMON_PERFCTR_MAX (MSR_ARCH_PERFMON_PERFCTR0 + KVM_INTEL_PMC_MAX_GENERIC - 1)#define MSR_ARCH_PERFMON_EVENTSEL_MAX (MSR_ARCH_PERFMON_EVENTSEL0 + KVM_INTEL_PMC_MAX_GENERIC - 1)#define KVM_PMC_MAX_FIXED 3 +#define KVM_AMD_PMC_MAX_GENERIC AMD64_NUM_COUNTERS_COREstruct kvm_pmu {
Even though the BUILD_BUG_ON prevents out-of-bounds accesses, this should be hardcoded to 6 to avoid mismatches with msrs_to_save_all[].
arch/x86/kvm/svm/pmu.c static void amd_pmu_init(struct kvm_vcpu *vcpu) · line 274
Quoted 1 line
arch/x86/kvm/svm/pmu.c +1
-0+BUILD_BUG_ON (AMD64_NUM_COUNTERS_CORE >KVM_AMD_PMC_MAX_GENERIC );
This should be KVM_AMD_PMC_MAX_GENERIC > AMD64_NUM_COUNTERS_CORE, not the opposite.
Fixed up and changed the commit message to follow:
The AMD PerfMonV2 specification allows for a maximum of 16 GP counters, but currently only 6 pairs of MSRs are accepted by KVM.
While AMD64_NUM_COUNTERS_CORE is already equal to 6, increasing without adjusting msrs_to_save_all[] could result in out-of-bounds accesses. Therefore introduce a macro (named KVM_AMD_PMC_MAX_GENERIC) to refer to the number of counters supported by KVM.
Paolo
Sean Christopherson
maintainerQuoted 9 lines · Like Xu
From: Like Xu <[email protected]>
The Intel April 2022 SDM - Table 2-2. IA-32 Architectural MSRs adds a new architectural
IA32_OVERCLOCKING_STATUSmsr (0x195), plus the presence ofIA32_CORE_CAPABILITIES(0xCF), the theoretical effective maximum value of the Intel GP PMCs is 14 (0xCF-0xC1) instead of 18.But the conclusion of this speculation "14" is very fragile and can easily be overturned once Intel declares another meaningful arch msr
s/msr/MSR for consistency
Quoted 9 lines
in the above reserved range, and even worse, just conjecture, Intel probably put PMCs 8-15 in a completely different range of MSR indices.
A conservative proposal would be to stop at the maximum number of Intel GP PMCs supported today. Also subsequent changes would limit both AMD and Intel on the number of GP counter supported by KVM.
There are some boxes like Intel P4 (non Architectural PMU) may indeed have 18 counters , but those counters are in a completely different msr
unnecessary whitespace before the comma. And s/msr/MSR again.
Quoted 4 lines
address range and is not supported by KVM.
Cc Vitaly Kuznetsov <[email protected]>Fixes cf05a67b68b8 ("KVM: x86: omit "impossible" pmu MSRs from MSR list")
Does this need Cc: [email protected]? Or is this benign enough that we don't care?
No need for a v4, the above nits can be handled when applying.
Quoted 4 lines
Suggested-by Jim Mattson <[email protected]>Signed-off-by Like Xu <[email protected]>Reviewed-by Jim Mattson <[email protected]>---
In the future, please provide a cover letter even for trivial series, it helps (me at least) mentally organize patches.
Thanks!
Quoted 2 lines · Sean Christopherson
Does this need Cc:[email protected]? Or is this benign enough that we don't care?
Considering stable kernel may access IA32_OVERCLOCKING_STATUS as well,
cc stable list helps to remove the illusion of pmu msr scope for stable tree maintainers.
Quoted 2 lines
No need for a v4, the above nits can be handled when applying.
Thanks, so kind of you.
Quoted 7 lines
Quoted 5 lines
Suggested-by Jim Mattson<[email protected]>Signed-off-by Like Xu<[email protected]>Reviewed-by Jim Mattson<[email protected]>---
In the future, please provide a cover letter even for trivial series, it helps (me at least) mentally organize patches.
Roger that.
Quoted 3 lines
Thanks!
Sean Christopherson
maintainerQuoted 7 lines · Like Xu
Quoted 2 lines · Sean Christopherson
Does this need Cc:[email protected]? Or is this benign enough that we don't care?
Considering stable kernel may access
IA32_OVERCLOCKING_STATUSas well, cc stable list helps to remove the illusion of pmu msr scope for stable tree maintainers.
Is that a "yes, this should be Cc'd stable" or "no, don't bother"?
Quoted 10 lines · Sean Christopherson
Quoted 7 lines · Like Xu
Quoted 2 lines · Sean Christopherson
Does this need Cc:[email protected]? Or is this benign enough that we don't care?
Considering stable kernel may access
IA32_OVERCLOCKING_STATUSas well, cc stable list helps to remove the illusion of pmu msr scope for stable tree maintainers.Is that a "yes, this should be Cc'd stable" or "no, don't bother"?
Oops, I missed this one. "Yes, this should be Cc'd" as I have received a few complaints on this.
Please let me know if I need to post a new version of this minor patch set, considering the previous comment "No need for a v4, the above nits can be handled when applying. "
Thanks,
Like Xu
Quoted 10 lines · Like Xu
Quoted 9 lines · Sean Christopherson
Quoted 7 lines · Like Xu
Quoted 2 lines · Sean Christopherson
Does this need Cc:[email protected]? Or is this benign enough that we don't care?
Considering stable kernel may access
IA32_OVERCLOCKING_STATUSas well, cc stable list helps to remove the illusion of pmu msr scope for stable tree maintainers.
Quoted 6 lines
Quoted 1 line
Is that a "yes, this should be Cc'd stable" or "no, don't bother"?
Oops, I missed this one. "Yes, this should be Cc'd" as I have received a few complaints on this.
Please let me know if I need to post a new version of this minor patch set, considering the previous comment "No need for a v4, the above nits can be handled when applying. "
Queued, thanks.
Paolo