defer/rcuusage: Put path name of singleton get/set code snippets
PATCH 1/2 defer/rcuusage: Put path name of singleton get/set code snippets
As Listing 9.20 shows set_config() as a whole, replace the reference to the line-count range with that to the Listing itself. Also adjust conjugation of verbs.
Fixes 787eb4586767 ("defer/rcuusage: Add RCU space-time code and diagram")
Signed-off-by Akira Yokosawa <[email protected]>
---
Hi Paul,
These patches are trivial fixes independent of the planned colon-related changes.
Thanks, Akira
--
defer/rcuusage.tex | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
defer/rcuusage.tex +4 -4
@@ -798,7 +798,7 @@ by the RCU singleton data structure illustrated in \cref{fig:defer:Insertion With Concurrent Readers,fig:defer:Deletion With Concurrent Readers}. This structure is defined on \clnrefrange{myconfig.b}{myconfig.e} of \cref{lst:defer:Singleton Get}, and contains two integer fields, -\co{->a} and \co{->b}. +\co{->a} and \co{->b} (\path{singleton.c}). The current instance of this structure is referenced by the \co{curconfig} pointer defined on \clnref{myconfig.e}. \end{fcvref}
@@ -828,9 +828,9 @@ with each other. \end{fcvref} \begin{fcvref}[ln:defer:singleton:set] -The structure is updated by the \co{set_config()} function shown on -\clnrefrange{set_config.b}{set_config.e}. -\Clnrefrange{allocinit.b}{allocinit.e} allocates and initializes a +The structure is updated by the \co{set_config()} function shown in +\cref{lst:defer:Singleton Set}. +\Clnrefrange{allocinit.b}{allocinit.e} allocate and initialize a new \co{myconfig} structure. \Clnref{xchg} atomically exchanges a pointer to this new structure with the pointer to the old structure in \co{curconfig}, while also
Signature · 1 line
2.17.1
PATCH 2/2 Fix typos (scalability)
Signed-off-by Akira Yokosawa <[email protected]>
--- appendix/questions/ordering.tex | 2 +- intro/intro.tex | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
appendix/questions/ordering.tex +1 -1
@@ -16,7 +16,7 @@ the other? The answer, as is so often the case, is ``it depends''. One approach is to construct a strongly ordered system, then examine -its performance and scalablity. +its performance and scalability. If these suffice, the system is good and sufficient, and no more need be done. Otherwise, undertake careful analysis
intro/intro.tex +1 -1
@@ -934,7 +934,7 @@ However, partitioning the work requires great care. For example, uneven partitioning can result in sequential execution once the small partitions have completed~\cite{GeneAmdahl1967AmdahlsLaw}. In less extreme cases, load balancing can be used to fully utilize -available hardware and restore performance and scalabilty. +available hardware and restore performance and scalability. Although partitioning can greatly improve performance and scalability, it can also increase complexity.
Signature · 1 line
2.17.1
Quoted 11 lines · Akira Yokosawa
As Listing 9.20 shows
set_config()as a whole, replace the reference to the line-count range with that to the Listing itself. Also adjust conjugation of verbs.Fixes 787eb4586767 ("defer/rcuusage: Add RCU space-time code and diagram")Signed-off-by Akira Yokosawa <[email protected]>---
Hi Paul,These patches are trivial fixes independent of the planned colon-related changes.
Good eyes on both patches, queued and pushed, thank you!
Thanx, Paul
Quoted 34 lines
Thanks, Akira
--defer/rcuusage.tex | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)defer/rcuusage.tex +4
-4@@ -798,7 +798,7 @@ by the RCU singleton data structure illustrated in \cref{fig:defer:Insertion With Concurrent Readers,fig:defer:Deletion With Concurrent Readers}. This structure is defined on \clnrefrange{myconfig.b}{myconfig.e} of \cref{lst:defer:Singleton Get}, and contains two integer fields, -\co{->a} and \co{->b}. +\co{->a} and \co{->b} (\path{singleton.c}). The current instance of this structure is referenced by the \co{curconfig} pointer defined on \clnref{myconfig.e}. \end{fcvref}@@ -828,9 +828,9 @@ with each other. \end{fcvref} \begin{fcvref}[ln:defer:singleton:set] -The structure is updated by the \co{set_config()} function shown on -\clnrefrange{set_config.b}{set_config.e}. -\Clnrefrange{allocinit.b}{allocinit.e} allocates and initializes a +The structure is updated by the \co{set_config()} function shown in +\cref{lst:defer:Singleton Set}. +\Clnrefrange{allocinit.b}{allocinit.e} allocate and initialize a new \co{myconfig} structure. \Clnref{xchg} atomically exchanges a pointer to this new structure with the pointer to the old structure in \co{curconfig}, while alsoSignature · 1 line
2.17.1