xen/ppc: Add PowerNV bare metal support
cover xen/ppc: Add PowerNV bare metal support
Hello all,
This series adds support for booting and using the serial console on bare metal PowerNV/OpenPOWER systems. Up until now, Xen could only be booted on the QEMU pseries model, which was initially targetted for ease of development, but which differs significantly from the bare metal systems where this port is likely to be the most useful.
In addition to adding support for the PowerNV boot protocol and firmware interface, changes required to get libfdt from xen/libfdt building are included. This is required to obtain the firmware entrypoint address on PowerNV.
Thanks,
Shawn
Shawn Anastasio (5):
xen/lib: Move simple_strtoul from common/vsprintf.c to lib xen/ppc: Switch to medium PIC code model xen/ppc: Add OPAL API definition header file xen/ppc: Parse device tree for OPAL node on PowerNV xen/ppc: Implement early serial console on PowerNV
xen/arch/ppc/Kconfig | 1 + xen/arch/ppc/Makefile | 1 + xen/arch/ppc/arch.mk | 6 +- xen/arch/ppc/include/asm/asm-defns.h | 19 + xen/arch/ppc/include/asm/boot.h | 16 +- xen/arch/ppc/include/asm/bug.h | 18 + xen/arch/ppc/include/asm/cache.h | 6 + xen/arch/ppc/include/asm/config.h | 2 +- xen/arch/ppc/include/asm/opal-api.h | 1190 ++++++++++++++++++++++++++ xen/arch/ppc/include/asm/processor.h | 13 +- xen/arch/ppc/include/asm/string.h | 6 + xen/arch/ppc/include/asm/system.h | 6 + xen/arch/ppc/opal.c | 73 ++ xen/arch/ppc/ppc64/Makefile | 1 + xen/arch/ppc/ppc64/asm-offsets.c | 4 + xen/arch/ppc/ppc64/head.S | 13 +- xen/arch/ppc/ppc64/opal-calls.S | 82 ++ xen/arch/ppc/setup.c | 9 +- xen/arch/ppc/xen.lds.S | 44 +- xen/common/vsprintf.c | 37 - xen/lib/Makefile | 1 + xen/lib/simple_strtoul.c | 40 + 22 files changed, 1511 insertions(+), 77 deletions(-) create mode 100644 xen/arch/ppc/include/asm/bug.h create mode 100644 xen/arch/ppc/include/asm/cache.h create mode 100644 xen/arch/ppc/include/asm/opal-api.h create mode 100644 xen/arch/ppc/include/asm/string.h create mode 100644 xen/arch/ppc/include/asm/system.h create mode 100644 xen/arch/ppc/opal.c create mode 100644 xen/arch/ppc/ppc64/opal-calls.S create mode 100644 xen/lib/simple_strtoul.c
--
2.30.2
PATCH 1/5 xen/lib: Move simple_strtoul from common/vsprintf.c to lib
Move the simple_strtoul routine which is used throughout the codebase from vsprintf.c to its own file in xen/lib.
This allows libfdt to be built on ppc64 even though xen/common doesn't build yet.
--- xen/common/vsprintf.c | 37 ------------------------------------- xen/lib/Makefile | 1 + xen/lib/simple_strtoul.c | 40 ++++++++++++++++++++++++++++++++++++++++ 3 files changed, 41 insertions(+), 37 deletions(-) create mode 100644 xen/lib/simple_strtoul.c
xen/common/vsprintf.c +0 -37
@@ -24,43 +24,6 @@#include <asm/div64.h> #include <asm/page.h> -/** -* simple_strtoul - convert a string to an unsigned long -* @cp: The start of the string -* @endp: A pointer to the end of the parsed string will be placed here -* @base: The number base to use -*/ -unsigned long simple_strtoul ( -const char *cp,const char **endp,unsigned int base) -{ -unsigned long result =0 ,value; - -if (!base) { - base =10 ; -if (*cp =='0' ) { - base =8 ; - cp++; -if ((toupper (*cp) =='X' ) &&isxdigit (cp[1 ])) { - cp++; - base =16 ; - } - } - }else if (base ==16 ) { -if (cp[0 ] =='0' &&toupper (cp[1 ]) =='X' ) - cp +=2 ; - } -while (isxdigit (*cp) && - (value =isdigit (*cp) ? *cp-'0' :toupper (*cp)-'A' +10 ) < base) { - result = result*base + value; - cp++; - } -if (endp) - *endp = cp; -return result; -} - -EXPORT_SYMBOL (simple_strtoul); -/** * simple_strtol - convert a string to a signed long * @cp: The start of the string
xen/lib/Makefile +1 -0
@@ -13,6 +13,7 @@ lib-y += memset.o lib-y += muldiv64.o lib-y += parse-size.o lib-y += rbtree.o +lib-y += simple_strtoul.o lib-y += sort.o lib-y += strcasecmp.o lib-y += strchr.o
xen/lib/simple_strtoul.c new file +40 -0
@@ -0,0 +1,40 @@ +/* +* Copyright (C) 1991, 1992 Linus Torvalds +*/ + +#include <xen/ctype.h> + +/** +* simple_strtoul - convert a string to an unsigned long +* @cp: The start of the string +* @endp: A pointer to the end of the parsed string will be placed here +* @base: The number base to use +*/ +unsigned long simple_strtoul ( +const char *cp,const char **endp,unsigned int base) +{ +unsigned long result =0 ,value; + +if (!base) { + base =10 ; +if (*cp =='0' ) { + base =8 ; + cp++; +if ((toupper (*cp) =='X' ) &&isxdigit (cp[1 ])) { + cp++; + base =16 ; + } + } + }else if (base ==16 ) { +if (cp[0 ] =='0' &&toupper (cp[1 ]) =='X' ) + cp +=2 ; + } +while (isxdigit (*cp) && + (value =isdigit (*cp) ? *cp-'0' :toupper (*cp)-'A' +10 ) < base) { + result = result*base + value; + cp++; + } +if (endp) + *endp = cp; +return result; +}
Signature · 1 line
2.30.2
Re: [PATCH 1/5] xen/lib: Move simple_strtoul from common/vsprintf.c to lib
Quoted 6 lines · Shawn Anastasio
Move the
simple_strtoulroutine which is used throughout the codebase fromvsprintf.cto its own file in xen/lib.This allows libfdt to be built on ppc64 even though xen/common doesn't build yet.
Quoted 7 lines
Signed-off-by Shawn Anastasio <[email protected]>--- xen/common/vsprintf.c | 37 ------------------------------------- xen/lib/Makefile | 1 + xen/lib/simple_strtoul.c | 40 ++++++++++++++++++++++++++++++++++++++++ 3 files changed, 41 insertions(+), 37 deletions(-) create mode 100644 xen/lib/simple_strtoul.c
What about its siblings? It'll be irritating to find one here and the other there.
Also please no underscores in (new) filenames unless there's a reason for this. In the case here, though, I question the need for "simple" in the file name in the first place.
Quoted 33 lines
xen/lib/simple_strtoul.c new file +30
-0@@ -0,0 +1,40 @@ +/* +* Copyright (C) 1991, 1992 Linus Torvalds +*/ + +#include <xen/ctype.h> + +/** +* simple_strtoul - convert a string to an unsigned long +* @cp: The start of the string +* @endp: A pointer to the end of the parsed string will be placed here +* @base: The number base to use +*/ +unsigned long simple_strtoul ( +const char *cp,const char **endp,unsigned int base) +{ +unsigned long result =0 ,value; + +if (!base) { + base =10 ; +if (*cp =='0' ) { + base =8 ; + cp++; +if ((toupper (*cp) =='X' ) &&isxdigit (cp[1 ])) { + cp++; + base =16 ; + } + } + }else if (base ==16 ) { +if (cp[0 ] =='0' &&toupper (cp[1 ]) =='X' ) + cp +=2 ;
xen/lib/simple_strtoul.c line 40
Quoted 10 lines
xen/lib/simple_strtoul.c new file +10
-0+ } +while (isxdigit (*cp) && + (value =isdigit (*cp) ? *cp-'0' :toupper (*cp)-'A' +10 ) < base) { + result = result*base + value; + cp++; + } +if (endp) + *endp = cp; +return result; +}
While moving, I think it would be nice if this stopped using neither Xen nor Linux style. I'm not going to insist, but doing such style adjustments right here would be quite nice.
Jan
Re: [PATCH 1/5] xen/lib: Move simple_strtoul from common/vsprintf.c to lib
Quoted 15 lines · Jan Beulich
Quoted 6 lines · Shawn Anastasio
Move the
simple_strtoulroutine which is used throughout the codebase fromvsprintf.cto its own file in xen/lib.This allows libfdt to be built on ppc64 even though xen/common doesn't build yet.
Quoted 7 lines
Signed-off-by Shawn Anastasio <[email protected]>--- xen/common/vsprintf.c | 37 ------------------------------------- xen/lib/Makefile | 1 + xen/lib/simple_strtoul.c | 40 ++++++++++++++++++++++++++++++++++++++++ 3 files changed, 41 insertions(+), 37 deletions(-) create mode 100644 xen/lib/simple_strtoul.c
Quoted 2 lines
What about its siblings? It'll be irritating to find one here and the other there.
I was debating whether to do this or not and ultimately decided to only make the minimum changes that were required right now. I can go ahead and make the change for its siblings as well.
Quoted 3 lines
Also please no underscores in (new) filenames unless there's a reason for this. In the case here, though, I question the need for "simple" in the file name in the first place.
From a look at the other files in xen/lib there seemed to be a convention of naming files after the exact function they implement. Would you rather I rename it to just strtoul.c? Or simple-strotoul.c?
Quoted 39 lines
Quoted 39 lines
xen/lib/simple_strtoul.c new file +36
-0@@ -0,0 +1,40 @@ +/* +* Copyright (C) 1991, 1992 Linus Torvalds +*/ + +#include <xen/ctype.h> + +/** +* simple_strtoul - convert a string to an unsigned long +* @cp: The start of the string +* @endp: A pointer to the end of the parsed string will be placed here +* @base: The number base to use +*/ +unsigned long simple_strtoul ( +const char *cp,const char **endp,unsigned int base) +{ +unsigned long result =0 ,value; + +if (!base) { + base =10 ; +if (*cp =='0' ) { + base =8 ; + cp++; +if ((toupper (*cp) =='X' ) &&isxdigit (cp[1 ])) { + cp++; + base =16 ; + } + } + }else if (base ==16 ) { +if (cp[0 ] =='0' &&toupper (cp[1 ]) =='X' ) + cp +=2 ; + } +while (isxdigit (*cp) && + (value =isdigit (*cp) ? *cp-'0' :toupper (*cp)-'A' +10 ) < base) { + result = result*base + value; + cp++; + }
Quoted 8 lines
xen/lib/simple_strtoul.c line 40
Quoted 4 lines
xen/lib/simple_strtoul.c new file +4
-0+if (endp) + *endp = cp; +return result; +}While moving, I think it would be nice if this stopped using neither Xen nor Linux style. I'm not going to insist, but doing such style adjustments right here would be quite nice.
Especially if I'm going to be moving its siblings, I'd rather just copy the functions verbatim for this patch, if that's acceptable.
Quoted 1 line
Jan
Thanks,
Shawn
Re: [PATCH 1/5] xen/lib: Move simple_strtoul from common/vsprintf.c to lib
Quoted 23 lines · Shawn Anastasio
Quoted 15 lines · Jan Beulich
Quoted 6 lines · Shawn Anastasio
Move the
simple_strtoulroutine which is used throughout the codebase fromvsprintf.cto its own file in xen/lib.This allows libfdt to be built on ppc64 even though xen/common doesn't build yet.
Quoted 7 lines
Signed-off-by Shawn Anastasio <[email protected]>--- xen/common/vsprintf.c | 37 ------------------------------------- xen/lib/Makefile | 1 + xen/lib/simple_strtoul.c | 40 ++++++++++++++++++++++++++++++++++++++++ 3 files changed, 41 insertions(+), 37 deletions(-) create mode 100644 xen/lib/simple_strtoul.cQuoted 2 lines
What about its siblings? It'll be irritating to find one here and the other there.
I was debating whether to do this or not and ultimately decided to only make the minimum changes that were required right now. I can go ahead and make the change for its siblings as well.
Quoted 7 lines
Quoted 3 lines
Also please no underscores in (new) filenames unless there's a reason for this. In the case here, though, I question the need for "simple" in the file name in the first place.
From a look at the other files in xen/lib there seemed to be a convention of naming files after the exact function they implement. Would you rather I rename it to just
strtoul.c? Orsimple-strotoul.c?
I'd prefer the former over the latter. While your observation of convention has been true so far, I think the shorter names are to be preferred here. They're not going to cause issues, as I don't see us gaining non-simple_* functions.
Quoted 48 lines
Quoted 39 lines
Quoted 39 lines
xen/lib/simple_strtoul.c new file +36
-0@@ -0,0 +1,40 @@ +/* +* Copyright (C) 1991, 1992 Linus Torvalds +*/ + +#include <xen/ctype.h> + +/** +* simple_strtoul - convert a string to an unsigned long +* @cp: The start of the string +* @endp: A pointer to the end of the parsed string will be placed here +* @base: The number base to use +*/ +unsigned long simple_strtoul ( +const char *cp,const char **endp,unsigned int base) +{ +unsigned long result =0 ,value; + +if (!base) { + base =10 ; +if (*cp =='0' ) { + base =8 ; + cp++; +if ((toupper (*cp) =='X' ) &&isxdigit (cp[1 ])) { + cp++; + base =16 ; + } + } + }else if (base ==16 ) { +if (cp[0 ] =='0' &&toupper (cp[1 ]) =='X' ) + cp +=2 ; + } +while (isxdigit (*cp) && + (value =isdigit (*cp) ? *cp-'0' :toupper (*cp)-'A' +10 ) < base) { + result = result*base + value; + cp++; + }Quoted 8 lines
xen/lib/simple_strtoul.c line 40
Quoted 4 lines
xen/lib/simple_strtoul.c new file +4
-0+if (endp) + *endp = cp; +return result; +}While moving, I think it would be nice if this stopped using neither Xen nor Linux style. I'm not going to insist, but doing such style adjustments right here would be quite nice.
Quoted 2 lines
Especially if I'm going to be moving its siblings, I'd rather just copy the functions verbatim for this patch, if that's acceptable.
As said - I wouldn't insist, but in this case maybe I take the time and make the slightly more "complete" change.
Jan
PATCH 2/5 xen/ppc: Switch to medium PIC code model
In reply to Shawn AnastasioSwitch Xen to the medium PIC code model on Power. Among other things, this allows us to be load address agnostic and will open the door to booting on bare metal PowerNV systems that don't use OpenFirmware.
Also update XEN_VIRT_START to 0xc000000000000000, which is equivalent to address 0x0 when the MMU is off. This prevents Open Firmware from loading Xen at an offset from its base load address, so the DECL_SECTION hack in xen.lds.S is no longer required.
--- xen/arch/ppc/arch.mk | 2 +- xen/arch/ppc/include/asm/asm-defns.h | 7 +++++ xen/arch/ppc/include/asm/config.h | 2 +- xen/arch/ppc/ppc64/head.S | 13 +++++--- xen/arch/ppc/xen.lds.S | 44 ++++++++++------------------ 5 files changed, 34 insertions(+), 34 deletions(-)
xen/arch/ppc/arch.mk +1 -1
@@ -5,7 +5,7 @@ ppc-march-$(CONFIG_POWER_ISA_2_07B) := power8 ppc-march-$(CONFIG_POWER_ISA_3_00) := power9 CFLAGS += -m64 -mlittle-endian -mcpu=$(ppc-march-y) -CFLAGS += -mstrict-align -mcmodel=large -mabi=elfv2 -mno-altivec -mno-vsx +CFLAGS += -mstrict-align -mcmodel=medium -mabi=elfv2 -fPIC -mno-altivec -mno-vsx -msoft-float LDFLAGS += -m elf64lppc
xen/arch/ppc/include/asm/asm-defns.h +7 -0
@@ -16,6 +16,13 @@ lis reg, (val) @h; \ ori reg, reg, (val) @l; \ +/* +* Load the address of a symbol from the TOC into the specified GPR. +*/ +#define LOAD_REG_ADDR (reg,name) \ + addis reg,%r2,name@toc@ha; \ + addi reg,reg,name@toc@l +/* * Depending on how we were booted, the CPU could be running in either * Little Endian or Big Endian mode. The following trampoline from Linux
xen/arch/ppc/include/asm/config.h +1 -1
@@ -39,7 +39,7 @@ name:#endif -#define XEN_VIRT_START _AT(UL, 0x400000) +#define XEN_VIRT_START _AT(UL, 0xc000000000000000)#define SMP_CACHE_BYTES (1 << 6)
xen/arch/ppc/ppc64/head.S +9 -4
@@ -1,9 +1,11 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ #include <asm/asm-defns.h> +#include <asm/asm-offsets.h> .section .text.header, "ax", %progbits + ENTRY(start) /* * NOTE: argument registers (r3-r9) must be preserved until the C entrypoint
@@ -11,16 +13,19 @@ ENTRY(start) FIXUP_ENDIAN /* set up the TOC pointer */ - LOAD_IMM32(%r2, .TOC.) + bcl 20, 31, .+4 +1: mflr %r12 + addis %r2, %r12, .TOC.-1b@ha + addi %r2, %r2, .TOC.-1b@l /* set up the initial stack */ - LOAD_IMM32(%r1, cpu0_boot_stack) + LOAD_REG_ADDR(%r1, cpu0_boot_stack) li %r11, 0 stdu %r11, -STACK_FRAME_OVERHEAD(%r1) /* clear .bss */ - LOAD_IMM32(%r14, __bss_start) - LOAD_IMM32(%r15, __bss_end) + LOAD_REG_ADDR(%r14, __bss_start) + LOAD_REG_ADDR(%r15, __bss_end) 1: std %r11, 0(%r14) addi %r14, %r14, 8
xen/arch/ppc/xen.lds.S +16 -28
116 lines not on this page · raw message
Signature · 1 line
2.30.2
Re: [PATCH 2/5] xen/ppc: Switch to medium PIC code model
xen/arch/ppc/ppc64/head.S line 9
Quoted 12 lines · Shawn Anastasio
xen/arch/ppc/ppc64/head.S +2
-0@@ -1,9 +1,11 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ #include <asm/asm-defns.h> +#include <asm/asm-offsets.h> .section .text.header, "ax", %progbits + ENTRY(start)
Nit: Stray change?
xen/arch/ppc/ppc64/head.S ENTRY(start) · line 16
Quoted 6 lines
xen/arch/ppc/ppc64/head.S +1
-1@@ -11,16 +13,19 @@ ENTRY(start) FIXUP_ENDIAN /* set up the TOC pointer */ - LOAD_IMM32(%r2, .TOC.) + bcl 20, 31, .+4
Could you use a label name instead of .+4? Aiui you really mean
xen/arch/ppc/ppc64/head.S ENTRY(start) · line 17
Quoted 1 line
xen/arch/ppc/ppc64/head.S +1
-0+1: mflr %r12
... "1f" there?
Jan
Quoted 17 lines
xen/arch/ppc/ppc64/head.S +5
-3+ addis %r2, %r12, .TOC.-1b@ha + addi %r2, %r2, .TOC.-1b@l /* set up the initial stack */ - LOAD_IMM32(%r1, cpu0_boot_stack) + LOAD_REG_ADDR(%r1, cpu0_boot_stack) li %r11, 0 stdu %r11, -STACK_FRAME_OVERHEAD(%r1) /* clear .bss */ - LOAD_IMM32(%r14, __bss_start) - LOAD_IMM32(%r15, __bss_end) + LOAD_REG_ADDR(%r14, __bss_start) + LOAD_REG_ADDR(%r15, __bss_end) 1: std %r11, 0(%r14) addi %r14, %r14, 8
Re: [PATCH 2/5] xen/ppc: Switch to medium PIC code model
Quoted 25 lines · Jan Beulich
xen/arch/ppc/ppc64/head.S line 9
Quoted 12 lines · Shawn Anastasio
xen/arch/ppc/ppc64/head.S +2
-0@@ -1,9 +1,11 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ #include <asm/asm-defns.h> +#include <asm/asm-offsets.h> .section .text.header, "ax", %progbits + ENTRY(start)Nit: Stray change?
xen/arch/ppc/ppc64/head.S ENTRY(start) · line 16
Quoted 6 lines
xen/arch/ppc/ppc64/head.S +1
-1@@ -11,16 +13,19 @@ ENTRY(start) FIXUP_ENDIAN /* set up the TOC pointer */ - LOAD_IMM32(%r2, .TOC.) + bcl 20, 31, .+4Could you use a label name instead of .+4? Aiui you really mean
Quoted 3 lines
xen/arch/ppc/ppc64/head.S ENTRY(start) · line 17
Quoted 1 line
xen/arch/ppc/ppc64/head.S +1
-0+1: mflr %r12... "1f" there?
Yes, good point. I'll point out that this form of the bcl instruction is specifically defined in the ISA specification as the recommended way to obtain the address of the next instruction, and hardware implementations presumably optimize it. Using a label instead of +4 would of course be fine as long as the label immediately follows the bcl, but if the label was elsewhere then the optimization that the ISA allows for this specific instruction might not be hit. Just something that should be kept in mind in case this code is ever refactored.
I'll change it to 1f in v2.
Quoted 2 lines
Jan
Thanks,
Shawn
Re: [PATCH 2/5] xen/ppc: Switch to medium PIC code model
Quoted 30 lines · Shawn Anastasio
Quoted 25 lines · Jan Beulich
xen/arch/ppc/ppc64/head.S line 9
Quoted 12 lines · Shawn Anastasio
xen/arch/ppc/ppc64/head.S +2
-0@@ -1,9 +1,11 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ #include <asm/asm-defns.h> +#include <asm/asm-offsets.h> .section .text.header, "ax", %progbits + ENTRY(start)Nit: Stray change?
xen/arch/ppc/ppc64/head.S ENTRY(start) · line 16
Quoted 6 lines
xen/arch/ppc/ppc64/head.S +1
-1@@ -11,16 +13,19 @@ ENTRY(start) FIXUP_ENDIAN /* set up the TOC pointer */ - LOAD_IMM32(%r2, .TOC.) + bcl 20, 31, .+4Could you use a label name instead of .+4? Aiui you really mean
Quoted 3 lines
xen/arch/ppc/ppc64/head.S ENTRY(start) · line 17
Quoted 1 line
xen/arch/ppc/ppc64/head.S +1
-0+1: mflr %r12... "1f" there?
Quoted 8 lines
Yes, good point. I'll point out that this form of the
bclinstruction is specifically defined in the ISA specification as the recommended way to obtain the address of the next instruction, and hardware implementations presumably optimize it. Using a label instead of +4 would of course be fine as long as the label immediately follows the bcl, but if the label was elsewhere then the optimization that the ISA allows for this specific instruction might not be hit. Just something that should be kept in mind in case this code is ever refactored.
Hmm, not really. If there was refactoring, the calculations using 1b would also need adjusting. That's why it's relevant that all "sides" agree on using one and the same label. (A similar "optimization" exists in x86 as well, just fyi, so we have precedent of that.)
Quoted 1 line
I'll change it to 1f in v2.
Thanks.
Jan
Re: [PATCH 2/5] xen/ppc: Switch to medium PIC code model
In reply to Shawn Anastasioxen/arch/ppc/ppc64/head.S ENTRY(start) · line 22
Quoted 13 lines · Shawn Anastasio
xen/arch/ppc/ppc64/head.S +5
-2@@ -11,16 +13,19 @@ ENTRY(start) FIXUP_ENDIAN /* set up the TOC pointer */ - LOAD_IMM32(%r2, .TOC.) + bcl 20, 31, .+4 +1: mflr %r12 + addis %r2, %r12, .TOC.-1b@ha + addi %r2, %r2, .TOC.-1b@l /* set up the initial stack */ - LOAD_IMM32(%r1, cpu0_boot_stack) + LOAD_REG_ADDR(%r1, cpu0_boot_stack)
Question: Would perhaps make sense to use %sp and %rtoc in place of %r1 and %r2 (not just here of course)?
Jan
Re: [PATCH 2/5] xen/ppc: Switch to medium PIC code model
Quoted 11 lines · Jan Beulich
Quoted 10 lines · Shawn Anastasio
xen/arch/ppc/ppc64/head.S +4
-1@@ -11,16 +13,19 @@ ENTRY(start) FIXUP_ENDIAN /* set up the TOC pointer */ - LOAD_IMM32(%r2, .TOC.) + bcl 20, 31, .+4 +1: mflr %r12 + addis %r2, %r12, .TOC.-1b@ha + addi %r2, %r2, .TOC.-1b@l
Quoted 6 lines
xen/arch/ppc/ppc64/head.S ENTRY(start) · line 22
Quoted 3 lines
xen/arch/ppc/ppc64/head.S +1
-1/* set up the initial stack */ - LOAD_IMM32(%r1, cpu0_boot_stack) + LOAD_REG_ADDR(%r1, cpu0_boot_stack)Question: Would perhaps make sense to use %sp and %rtoc in place of %r1 and %r2 (not just here of course)?
In my opinion, usage of the aliased register names ends up making the code less clear.
PATCH 3/5 xen/ppc: Add OPAL API definition header file
In reply to Shawn AnastasioOPAL (OpenPower Abstraction Layer) is the interface exposed by firmware on PowerNV (bare metal) systems. Import Linux's header definining the API and related information.
--- xen/arch/ppc/include/asm/opal-api.h | 1190 +++++++++++++++++++++++++++ 1 file changed, 1190 insertions(+) create mode 100644 xen/arch/ppc/include/asm/opal-api.h
xen/arch/ppc/include/asm/opal-api.h new file +1190 -0
@@ -0,0 +1,1190 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* +* OPAL API definitions. +* +* Copyright 2011-2015 IBM Corp. +*/ + +#ifndef __OPAL_API_H +#define __OPAL_API_H + +/****** OPAL APIs ******/ + +/* Return codes */ +#define OPAL_SUCCESS 0 +#define OPAL_PARAMETER -1 +#define OPAL_BUSY -2 +#define OPAL_PARTIAL -3 +#define OPAL_CONSTRAINED -4 +#define OPAL_CLOSED -5 +#define OPAL_HARDWARE -6 +#define OPAL_UNSUPPORTED -7 +#define OPAL_PERMISSION -8 +#define OPAL_NO_MEM -9 +#define OPAL_RESOURCE -10 +#define OPAL_INTERNAL_ERROR -11 +#define OPAL_BUSY_EVENT -12 +#define OPAL_HARDWARE_FROZEN -13 +#define OPAL_WRONG_STATE -14 +#define OPAL_ASYNC_COMPLETION -15 +#define OPAL_EMPTY -16 +#define OPAL_I2C_TIMEOUT -17 +#define OPAL_I2C_INVALID_CMD -18 +#define OPAL_I2C_LBUS_PARITY -19 +#define OPAL_I2C_BKEND_OVERRUN -20 +#define OPAL_I2C_BKEND_ACCESS -21 +#define OPAL_I2C_ARBT_LOST -22 +#define OPAL_I2C_NACK_RCVD -23 +#define OPAL_I2C_STOP_ERR -24 +#define OPAL_XIVE_PROVISIONING -31 +#define OPAL_XIVE_FREE_ACTIVE -32 +#define OPAL_TIMEOUT -33 + +/* API Tokens (in r0) */ +#define OPAL_INVALID_CALL -1 +#define OPAL_TEST 0 +#define OPAL_CONSOLE_WRITE 1 +#define OPAL_CONSOLE_READ 2 +#define OPAL_RTC_READ 3 +#define OPAL_RTC_WRITE 4 +#define OPAL_CEC_POWER_DOWN 5 +#define OPAL_CEC_REBOOT 6 +#define OPAL_READ_NVRAM 7 +#define OPAL_WRITE_NVRAM 8 +#define OPAL_HANDLE_INTERRUPT 9 +#define OPAL_POLL_EVENTS 10 +#define OPAL_PCI_SET_HUB_TCE_MEMORY 11 +#define OPAL_PCI_SET_PHB_TCE_MEMORY 12 +#define OPAL_PCI_CONFIG_READ_BYTE 13 +#define OPAL_PCI_CONFIG_READ_HALF_WORD 14 +#define OPAL_PCI_CONFIG_READ_WORD 15 +#define OPAL_PCI_CONFIG_WRITE_BYTE 16 +#define OPAL_PCI_CONFIG_WRITE_HALF_WORD 17 +#define OPAL_PCI_CONFIG_WRITE_WORD 18 +#define OPAL_SET_XIVE 19 +#define OPAL_GET_XIVE 20 +#define OPAL_GET_COMPLETION_TOKEN_STATUS 21/* obsolete */ +#define OPAL_REGISTER_OPAL_EXCEPTION_HANDLER 22 +#define OPAL_PCI_EEH_FREEZE_STATUS 23 +#define OPAL_PCI_SHPC 24 +#define OPAL_CONSOLE_WRITE_BUFFER_SPACE 25 +#define OPAL_PCI_EEH_FREEZE_CLEAR 26 +#define OPAL_PCI_PHB_MMIO_ENABLE 27 +#define OPAL_PCI_SET_PHB_MEM_WINDOW 28 +#define OPAL_PCI_MAP_PE_MMIO_WINDOW 29 +#define OPAL_PCI_SET_PHB_TABLE_MEMORY 30 +#define OPAL_PCI_SET_PE 31 +#define OPAL_PCI_SET_PELTV 32 +#define OPAL_PCI_SET_MVE 33 +#define OPAL_PCI_SET_MVE_ENABLE 34 +#define OPAL_PCI_GET_XIVE_REISSUE 35 +#define OPAL_PCI_SET_XIVE_REISSUE 36 +#define OPAL_PCI_SET_XIVE_PE 37 +#define OPAL_GET_XIVE_SOURCE 38 +#define OPAL_GET_MSI_32 39 +#define OPAL_GET_MSI_64 40 +#define OPAL_START_CPU 41 +#define OPAL_QUERY_CPU_STATUS 42 +#define OPAL_WRITE_OPPANEL 43/* unimplemented */ +#define OPAL_PCI_MAP_PE_DMA_WINDOW 44 +#define OPAL_PCI_MAP_PE_DMA_WINDOW_REAL 45 +#define OPAL_PCI_RESET 49 +#define OPAL_PCI_GET_HUB_DIAG_DATA 50 +#define OPAL_PCI_GET_PHB_DIAG_DATA 51 +#define OPAL_PCI_FENCE_PHB 52 +#define OPAL_PCI_REINIT 53 +#define OPAL_PCI_MASK_PE_ERROR 54 +#define OPAL_SET_SLOT_LED_STATUS 55 +#define OPAL_GET_EPOW_STATUS 56 +#define OPAL_SET_SYSTEM_ATTENTION_LED 57 +#define OPAL_RESERVED1 58 +#define OPAL_RESERVED2 59 +#define OPAL_PCI_NEXT_ERROR 60 +#define OPAL_PCI_EEH_FREEZE_STATUS2 61 +#define OPAL_PCI_POLL 62 +#define OPAL_PCI_MSI_EOI 63 +#define OPAL_PCI_GET_PHB_DIAG_DATA2 64 +#define OPAL_XSCOM_READ 65 +#define OPAL_XSCOM_WRITE 66 +#define OPAL_LPC_READ 67 +#define OPAL_LPC_WRITE 68 +#define OPAL_RETURN_CPU 69 +#define OPAL_REINIT_CPUS 70 +#define OPAL_ELOG_READ 71 +#define OPAL_ELOG_WRITE 72 +#define OPAL_ELOG_ACK 73 +#define OPAL_ELOG_RESEND 74 +#define OPAL_ELOG_SIZE 75 +#define OPAL_FLASH_VALIDATE 76 +#define OPAL_FLASH_MANAGE 77 +#define OPAL_FLASH_UPDATE 78 +#define OPAL_RESYNC_TIMEBASE 79 +#define OPAL_CHECK_TOKEN 80 +#define OPAL_DUMP_INIT 81 +#define OPAL_DUMP_INFO 82 +#define OPAL_DUMP_READ 83 +#define OPAL_DUMP_ACK 84 +#define OPAL_GET_MSG 85 +#define OPAL_CHECK_ASYNC_COMPLETION 86 +#define OPAL_SYNC_HOST_REBOOT 87 +#define OPAL_SENSOR_READ 88 +#define OPAL_GET_PARAM 89 +#define OPAL_SET_PARAM 90 +#define OPAL_DUMP_RESEND 91 +#define OPAL_ELOG_SEND 92/* Deprecated */ +#define OPAL_PCI_SET_PHB_CAPI_MODE 93 +#define OPAL_DUMP_INFO2 94 +#define OPAL_WRITE_OPPANEL_ASYNC 95 +#define OPAL_PCI_ERR_INJECT 96 +#define OPAL_PCI_EEH_FREEZE_SET 97 +#define OPAL_HANDLE_HMI 98 +#define OPAL_CONFIG_CPU_IDLE_STATE 99 +#define OPAL_SLW_SET_REG 100 +#define OPAL_REGISTER_DUMP_REGION 101 +#define OPAL_UNREGISTER_DUMP_REGION 102 +#define OPAL_WRITE_TPO 103 +#define OPAL_READ_TPO 104 +#define OPAL_GET_DPO_STATUS 105 +#define OPAL_OLD_I2C_REQUEST 106/* Deprecated */ +#define OPAL_IPMI_SEND 107 +#define OPAL_IPMI_RECV 108 +#define OPAL_I2C_REQUEST 109 +#define OPAL_FLASH_READ 110 +#define OPAL_FLASH_WRITE 111 +#define OPAL_FLASH_ERASE 112 +#define OPAL_PRD_MSG 113 +#define OPAL_LEDS_GET_INDICATOR 114 +#define OPAL_LEDS_SET_INDICATOR 115 +#define OPAL_CEC_REBOOT2 116 +#define OPAL_CONSOLE_FLUSH 117 +#define OPAL_GET_DEVICE_TREE 118 +#define OPAL_PCI_GET_PRESENCE_STATE 119 +#define OPAL_PCI_GET_POWER_STATE 120 +#define OPAL_PCI_SET_POWER_STATE 121 +#define OPAL_INT_GET_XIRR 122 +#define OPAL_INT_SET_CPPR 123 +#define OPAL_INT_EOI 124 +#define OPAL_INT_SET_MFRR 125 +#define OPAL_PCI_TCE_KILL 126 +#define OPAL_NMMU_SET_PTCR 127 +#define OPAL_XIVE_RESET 128 +#define OPAL_XIVE_GET_IRQ_INFO 129 +#define OPAL_XIVE_GET_IRQ_CONFIG 130 +#define OPAL_XIVE_SET_IRQ_CONFIG 131 +#define OPAL_XIVE_GET_QUEUE_INFO 132 +#define OPAL_XIVE_SET_QUEUE_INFO 133 +#define OPAL_XIVE_DONATE_PAGE 134 +#define OPAL_XIVE_ALLOCATE_VP_BLOCK 135 +#define OPAL_XIVE_FREE_VP_BLOCK 136 +#define OPAL_XIVE_GET_VP_INFO 137 +#define OPAL_XIVE_SET_VP_INFO 138 +#define OPAL_XIVE_ALLOCATE_IRQ 139 +#define OPAL_XIVE_FREE_IRQ 140 +#define OPAL_XIVE_SYNC 141 +#define OPAL_XIVE_DUMP 142 +#define OPAL_XIVE_GET_QUEUE_STATE 143 +#define OPAL_XIVE_SET_QUEUE_STATE 144 +#define OPAL_SIGNAL_SYSTEM_RESET 145 +#define OPAL_NPU_INIT_CONTEXT 146 +#define OPAL_NPU_DESTROY_CONTEXT 147 +#define OPAL_NPU_MAP_LPAR 148 +#define OPAL_IMC_COUNTERS_INIT 149 +#define OPAL_IMC_COUNTERS_START 150 +#define OPAL_IMC_COUNTERS_STOP 151 +#define OPAL_GET_POWERCAP 152 +#define OPAL_SET_POWERCAP 153 +#define OPAL_GET_POWER_SHIFT_RATIO 154 +#define OPAL_SET_POWER_SHIFT_RATIO 155 +#define OPAL_SENSOR_GROUP_CLEAR 156 +#define OPAL_PCI_SET_P2P 157 +#define OPAL_QUIESCE 158 +#define OPAL_NPU_SPA_SETUP 159 +#define OPAL_NPU_SPA_CLEAR_CACHE 160 +#define OPAL_NPU_TL_SET 161 +#define OPAL_SENSOR_READ_U64 162 +#define OPAL_SENSOR_GROUP_ENABLE 163 +#define OPAL_PCI_GET_PBCQ_TUNNEL_BAR 164 +#define OPAL_PCI_SET_PBCQ_TUNNEL_BAR 165 +#define OPAL_HANDLE_HMI2 166 +#define OPAL_NX_COPROC_INIT 167 +#define OPAL_XIVE_GET_VP_STATE 170 +#define OPAL_MPIPL_UPDATE 173 +#define OPAL_MPIPL_REGISTER_TAG 174 +#define OPAL_MPIPL_QUERY_TAG 175 +#define OPAL_SECVAR_GET 176 +#define OPAL_SECVAR_GET_NEXT 177 +#define OPAL_SECVAR_ENQUEUE_UPDATE 178 +#define OPAL_LAST 178 + +#define QUIESCE_HOLD 1/* Spin all calls at entry */ +#define QUIESCE_REJECT 2/* Fail all calls with OPAL_BUSY */ +#define QUIESCE_LOCK_BREAK 3/* Set to ignore locks. */ +#define QUIESCE_RESUME 4/* Un-quiesce */ +#define QUIESCE_RESUME_FAST_REBOOT 5/* Un-quiesce, fast reboot */ + +/* Device tree flags */ + +/* +* Flags set in power-mgmt nodes in device tree describing +* idle states that are supported in the platform. +*/ + +#define OPAL_PM_TIMEBASE_STOP 0x00000002 +#define OPAL_PM_LOSE_HYP_CONTEXT 0x00002000 +#define OPAL_PM_LOSE_FULL_CONTEXT 0x00004000 +#define OPAL_PM_NAP_ENABLED 0x00010000 +#define OPAL_PM_SLEEP_ENABLED 0x00020000 +#define OPAL_PM_WINKLE_ENABLED 0x00040000 +#define OPAL_PM_SLEEP_ENABLED_ER1 0x00080000/* with workaround */ +#define OPAL_PM_STOP_INST_FAST 0x00100000 +#define OPAL_PM_STOP_INST_DEEP 0x00200000 + +/* +* OPAL_CONFIG_CPU_IDLE_STATE parameters +*/ +#define OPAL_CONFIG_IDLE_FASTSLEEP 1 +#define OPAL_CONFIG_IDLE_UNDO 0 +#define OPAL_CONFIG_IDLE_APPLY 1 + +#ifndef __ASSEMBLY__ + +#include <xen/types.h> + +/* Other enums */ +enum OpalFreezeState { +OPAL_EEH_STOPPED_NOT_FROZEN =0 , +OPAL_EEH_STOPPED_MMIO_FREEZE =1 , +OPAL_EEH_STOPPED_DMA_FREEZE =2 , +OPAL_EEH_STOPPED_MMIO_DMA_FREEZE =3 , +OPAL_EEH_STOPPED_RESET =4 , +OPAL_EEH_STOPPED_TEMP_UNAVAIL =5 , +OPAL_EEH_STOPPED_PERM_UNAVAIL =6 +}; + +enum OpalEehFreezeActionToken { +OPAL_EEH_ACTION_CLEAR_FREEZE_MMIO =1 , +OPAL_EEH_ACTION_CLEAR_FREEZE_DMA =2 , +OPAL_EEH_ACTION_CLEAR_FREEZE_ALL =3 , + +OPAL_EEH_ACTION_SET_FREEZE_MMIO =1 , +OPAL_EEH_ACTION_SET_FREEZE_DMA =2 , +OPAL_EEH_ACTION_SET_FREEZE_ALL =3 +}; + +enum OpalPciStatusToken { +OPAL_EEH_NO_ERROR =0 , +OPAL_EEH_IOC_ERROR =1 , +OPAL_EEH_PHB_ERROR =2 , +OPAL_EEH_PE_ERROR =3 , +OPAL_EEH_PE_MMIO_ERROR =4 , +OPAL_EEH_PE_DMA_ERROR =5 +}; + +enum OpalPciErrorSeverity { +OPAL_EEH_SEV_NO_ERROR =0 , +OPAL_EEH_SEV_IOC_DEAD =1 , +OPAL_EEH_SEV_PHB_DEAD =2 , +OPAL_EEH_SEV_PHB_FENCED =3 , +OPAL_EEH_SEV_PE_ER =4 , +OPAL_EEH_SEV_INF =5 +}; + +enum OpalErrinjectType { +OPAL_ERR_INJECT_TYPE_IOA_BUS_ERR =0 , +OPAL_ERR_INJECT_TYPE_IOA_BUS_ERR64 =1 , +}; + +enum OpalErrinjectFunc { +/* IOA bus specific errors */ +OPAL_ERR_INJECT_FUNC_IOA_LD_MEM_ADDR =0 , +OPAL_ERR_INJECT_FUNC_IOA_LD_MEM_DATA =1 , +OPAL_ERR_INJECT_FUNC_IOA_LD_IO_ADDR =2 , +OPAL_ERR_INJECT_FUNC_IOA_LD_IO_DATA =3 , +OPAL_ERR_INJECT_FUNC_IOA_LD_CFG_ADDR =4 , +OPAL_ERR_INJECT_FUNC_IOA_LD_CFG_DATA =5 , +OPAL_ERR_INJECT_FUNC_IOA_ST_MEM_ADDR =6 , +OPAL_ERR_INJECT_FUNC_IOA_ST_MEM_DATA =7 , +OPAL_ERR_INJECT_FUNC_IOA_ST_IO_ADDR =8 , +OPAL_ERR_INJECT_FUNC_IOA_ST_IO_DATA =9 , +OPAL_ERR_INJECT_FUNC_IOA_ST_CFG_ADDR =10 , +OPAL_ERR_INJECT_FUNC_IOA_ST_CFG_DATA =11 , +OPAL_ERR_INJECT_FUNC_IOA_DMA_RD_ADDR =12 , +OPAL_ERR_INJECT_FUNC_IOA_DMA_RD_DATA =13 , +OPAL_ERR_INJECT_FUNC_IOA_DMA_RD_MASTER =14 , +OPAL_ERR_INJECT_FUNC_IOA_DMA_RD_TARGET =15 , +OPAL_ERR_INJECT_FUNC_IOA_DMA_WR_ADDR =16 , +OPAL_ERR_INJECT_FUNC_IOA_DMA_WR_DATA =17 , +OPAL_ERR_INJECT_FUNC_IOA_DMA_WR_MASTER =18 , +OPAL_ERR_INJECT_FUNC_IOA_DMA_WR_TARGET =19 , +}; + +enum OpalMmioWindowType { +OPAL_M32_WINDOW_TYPE =1 , +OPAL_M64_WINDOW_TYPE =2 , +OPAL_IO_WINDOW_TYPE =3 +}; + +enum OpalExceptionHandler { +OPAL_MACHINE_CHECK_HANDLER =1 , +OPAL_HYPERVISOR_MAINTENANCE_HANDLER =2 , +OPAL_SOFTPATCH_HANDLER =3 +}; + +enum OpalPendingState { +OPAL_EVENT_OPAL_INTERNAL =0x1 , +OPAL_EVENT_NVRAM =0x2 , +OPAL_EVENT_RTC =0x4 , +OPAL_EVENT_CONSOLE_OUTPUT =0x8 , +OPAL_EVENT_CONSOLE_INPUT =0x10 , +OPAL_EVENT_ERROR_LOG_AVAIL =0x20 , +OPAL_EVENT_ERROR_LOG =0x40 , +OPAL_EVENT_EPOW =0x80 , +OPAL_EVENT_LED_STATUS =0x100 , +OPAL_EVENT_PCI_ERROR =0x200 , +OPAL_EVENT_DUMP_AVAIL =0x400 , +OPAL_EVENT_MSG_PENDING =0x800 , +}; + +enum OpalThreadStatus { +OPAL_THREAD_INACTIVE =0x0 , +OPAL_THREAD_STARTED =0x1 , +OPAL_THREAD_UNAVAILABLE =0x2 /* opal-v3 */ +}; + +enum OpalPciBusCompare { + OpalPciBusAny =0 ,/* Any bus number match */ + OpalPciBus3Bits =2 ,/* Match top 3 bits of bus number */ + OpalPciBus4Bits =3 ,/* Match top 4 bits of bus number */ + OpalPciBus5Bits =4 ,/* Match top 5 bits of bus number */ + OpalPciBus6Bits =5 ,/* Match top 6 bits of bus number */ + OpalPciBus7Bits =6 ,/* Match top 7 bits of bus number */ + OpalPciBusAll =7 ,/* Match bus number exactly */ +}; + +enum OpalDeviceCompare { +OPAL_IGNORE_RID_DEVICE_NUMBER =0 , +OPAL_COMPARE_RID_DEVICE_NUMBER =1 +}; + +enum OpalFuncCompare { +OPAL_IGNORE_RID_FUNCTION_NUMBER =0 , +OPAL_COMPARE_RID_FUNCTION_NUMBER =1 +}; + +enum OpalPeAction { +OPAL_UNMAP_PE =0 , +OPAL_MAP_PE =1 +}; + +enum OpalPeltvAction { +OPAL_REMOVE_PE_FROM_DOMAIN =0 , +OPAL_ADD_PE_TO_DOMAIN =1 +}; + +enum OpalMveEnableAction { +OPAL_DISABLE_MVE =0 , +OPAL_ENABLE_MVE =1 +}; + +enum OpalM64Action { +OPAL_DISABLE_M64 =0 , +OPAL_ENABLE_M64_SPLIT =1 , +OPAL_ENABLE_M64_NON_SPLIT =2 +}; + +enum OpalPciResetScope { +OPAL_RESET_PHB_COMPLETE =1 , +OPAL_RESET_PCI_LINK =2 , +OPAL_RESET_PHB_ERROR =3 , +OPAL_RESET_PCI_HOT =4 , +OPAL_RESET_PCI_FUNDAMENTAL =5 , +OPAL_RESET_PCI_IODA_TABLE =6 +}; + +enum OpalPciReinitScope { +/* +* Note: we chose values that do not overlap +* OpalPciResetScope as OPAL v2 used the same +* enum for both +*/ +OPAL_REINIT_PCI_DEV =1000 +}; + +enum OpalPciResetState { +OPAL_DEASSERT_RESET =0 , +OPAL_ASSERT_RESET =1 +}; + +enum OpalPciSlotPresence { +OPAL_PCI_SLOT_EMPTY =0 , +OPAL_PCI_SLOT_PRESENT =1 +}; + +enum OpalPciSlotPower { +OPAL_PCI_SLOT_POWER_OFF =0 , +OPAL_PCI_SLOT_POWER_ON =1 , +OPAL_PCI_SLOT_OFFLINE =2 , +OPAL_PCI_SLOT_ONLINE =3 +}; + +enum OpalSlotLedType { +OPAL_SLOT_LED_TYPE_ID =0 ,/* IDENTIFY LED */ +OPAL_SLOT_LED_TYPE_FAULT =1 ,/* FAULT LED */ +OPAL_SLOT_LED_TYPE_ATTN =2 ,/* System Attention LED */ +OPAL_SLOT_LED_TYPE_MAX =3 +}; + +enum OpalSlotLedState { +OPAL_SLOT_LED_STATE_OFF =0 ,/* LED is OFF */ +OPAL_SLOT_LED_STATE_ON =1 /* LED is ON */ +}; + +/* +* Address cycle types for LPC accesses. These also correspond +* to the content of the first cell of the "reg" property for +* device nodes on the LPC bus +*/ +enum OpalLPCAddressType { +OPAL_LPC_MEM =0 , +OPAL_LPC_IO =1 , +OPAL_LPC_FW =2 , +}; + +enum opal_msg_type { +OPAL_MSG_ASYNC_COMP =0 ,/* params[0] = token, params[1] = rc, +* additional params function-specific +*/ +OPAL_MSG_MEM_ERR =1 , +OPAL_MSG_EPOW =2 , +OPAL_MSG_SHUTDOWN =3 ,/* params[0] = 1 reboot, 0 shutdown */ +OPAL_MSG_HMI_EVT =4 , +OPAL_MSG_DPO =5 , +OPAL_MSG_PRD =6 , +OPAL_MSG_OCC =7 , +OPAL_MSG_PRD2 =8 , +OPAL_MSG_TYPE_MAX , +}; + +struct opal_msg { +__be32 msg_type; +__be32 reserved; +__be64 params[8 ]; +}; + +/* System parameter permission */ +enum OpalSysparamPerm { +OPAL_SYSPARAM_READ =0x1 , +OPAL_SYSPARAM_WRITE =0x2 , +OPAL_SYSPARAM_RW = (OPAL_SYSPARAM_READ |OPAL_SYSPARAM_WRITE ), +}; + +enum { +OPAL_IPMI_MSG_FORMAT_VERSION_1 =1 , +}; + +struct opal_ipmi_msg { +uint8_t version; +uint8_t netfn; +uint8_t cmd; +uint8_t data[]; +}; + +/* FSP memory errors handling */ +enum OpalMemErr_Version { + OpalMemErr_V1 =1 , +}; + +enum OpalMemErrType { +OPAL_MEM_ERR_TYPE_RESILIENCE =0 , +OPAL_MEM_ERR_TYPE_DYN_DALLOC , +}; + +/* Memory Reilience error type */ +enum OpalMemErr_ResilErrType { +OPAL_MEM_RESILIENCE_CE =0 , +OPAL_MEM_RESILIENCE_UE , +OPAL_MEM_RESILIENCE_UE_SCRUB , +}; + +/* Dynamic Memory Deallocation type */ +enum OpalMemErr_DynErrType { +OPAL_MEM_DYNAMIC_DEALLOC =0 , +}; + +struct OpalMemoryErrorData { +enum OpalMemErr_Version version:8 ;/* 0x00 */ +enum OpalMemErrType type:8 ;/* 0x01 */ +__be16 flags;/* 0x02 */ +uint8_t reserved_1[4 ];/* 0x04 */ + +union { +/* Memory Resilience corrected/uncorrected error info */ +struct { +enum OpalMemErr_ResilErrType resil_err_type:8 ; +uint8_t reserved_1[7 ]; +__be64 physical_address_start; +__be64 physical_address_end; + } resilience; +/* Dynamic memory deallocation error info */ +struct { +enum OpalMemErr_DynErrType dyn_err_type:8 ; +uint8_t reserved_1[7 ]; +__be64 physical_address_start; +__be64 physical_address_end; + } dyn_dealloc; + } u; +}; + +/* HMI interrupt event */ +enum OpalHMI_Version { + OpalHMIEvt_V1 =1 , + OpalHMIEvt_V2 =2 , +}; + +enum OpalHMI_Severity { + OpalHMI_SEV_NO_ERROR =0 , + OpalHMI_SEV_WARNING =1 , + OpalHMI_SEV_ERROR_SYNC =2 , + OpalHMI_SEV_FATAL =3 , +}; + +enum OpalHMI_Disposition { + OpalHMI_DISPOSITION_RECOVERED =0 , + OpalHMI_DISPOSITION_NOT_RECOVERED =1 , +}; + +enum OpalHMI_ErrType { + OpalHMI_ERROR_MALFUNC_ALERT =0 , + OpalHMI_ERROR_PROC_RECOV_DONE, + OpalHMI_ERROR_PROC_RECOV_DONE_AGAIN, + OpalHMI_ERROR_PROC_RECOV_MASKED, + OpalHMI_ERROR_TFAC, + OpalHMI_ERROR_TFMR_PARITY, + OpalHMI_ERROR_HA_OVERFLOW_WARN, + OpalHMI_ERROR_XSCOM_FAIL, + OpalHMI_ERROR_XSCOM_DONE, + OpalHMI_ERROR_SCOM_FIR, + OpalHMI_ERROR_DEBUG_TRIG_FIR, + OpalHMI_ERROR_HYP_RESOURCE, + OpalHMI_ERROR_CAPP_RECOVERY, +}; + +enum OpalHMI_XstopType { +CHECKSTOP_TYPE_UNKNOWN =0 , +CHECKSTOP_TYPE_CORE =1 , +CHECKSTOP_TYPE_NX =2 , +CHECKSTOP_TYPE_NPU =3 +}; + +enum OpalHMI_CoreXstopReason { +CORE_CHECKSTOP_IFU_REGFILE =0x00000001 , +CORE_CHECKSTOP_IFU_LOGIC =0x00000002 , +CORE_CHECKSTOP_PC_DURING_RECOV =0x00000004 , +CORE_CHECKSTOP_ISU_REGFILE =0x00000008 , +CORE_CHECKSTOP_ISU_LOGIC =0x00000010 , +CORE_CHECKSTOP_FXU_LOGIC =0x00000020 , +CORE_CHECKSTOP_VSU_LOGIC =0x00000040 , +CORE_CHECKSTOP_PC_RECOV_IN_MAINT_MODE =0x00000080 , +CORE_CHECKSTOP_LSU_REGFILE =0x00000100 , +CORE_CHECKSTOP_PC_FWD_PROGRESS =0x00000200 , +CORE_CHECKSTOP_LSU_LOGIC =0x00000400 , +CORE_CHECKSTOP_PC_LOGIC =0x00000800 , +CORE_CHECKSTOP_PC_HYP_RESOURCE =0x00001000 , +CORE_CHECKSTOP_PC_HANG_RECOV_FAILED =0x00002000 , +CORE_CHECKSTOP_PC_AMBI_HANG_DETECTED =0x00004000 , +CORE_CHECKSTOP_PC_DEBUG_TRIG_ERR_INJ =0x00008000 , +CORE_CHECKSTOP_PC_SPRD_HYP_ERR_INJ =0x00010000 , +}; + +enum OpalHMI_NestAccelXstopReason { +NX_CHECKSTOP_SHM_INVAL_STATE_ERR =0x00000001 , +NX_CHECKSTOP_DMA_INVAL_STATE_ERR_1 =0x00000002 , +NX_CHECKSTOP_DMA_INVAL_STATE_ERR_2 =0x00000004 , +NX_CHECKSTOP_DMA_CH0_INVAL_STATE_ERR =0x00000008 , +NX_CHECKSTOP_DMA_CH1_INVAL_STATE_ERR =0x00000010 , +NX_CHECKSTOP_DMA_CH2_INVAL_STATE_ERR =0x00000020 , +NX_CHECKSTOP_DMA_CH3_INVAL_STATE_ERR =0x00000040 , +NX_CHECKSTOP_DMA_CH4_INVAL_STATE_ERR =0x00000080 , +NX_CHECKSTOP_DMA_CH5_INVAL_STATE_ERR =0x00000100 , +NX_CHECKSTOP_DMA_CH6_INVAL_STATE_ERR =0x00000200 , +NX_CHECKSTOP_DMA_CH7_INVAL_STATE_ERR =0x00000400 , +NX_CHECKSTOP_DMA_CRB_UE =0x00000800 , +NX_CHECKSTOP_DMA_CRB_SUE =0x00001000 , +NX_CHECKSTOP_PBI_ISN_UE =0x00002000 , +}; + +struct OpalHMIEvent { +uint8_t version;/* 0x00 */ +uint8_t severity;/* 0x01 */ +uint8_t type;/* 0x02 */ +uint8_t disposition;/* 0x03 */ +uint8_t reserved_1[4 ];/* 0x04 */ + +__be64 hmer; +/* TFMR register. Valid only for TFAC and TFMR_PARITY error type. */ +__be64 tfmr; + +/* version 2 and later */ +union { +/* +* checkstop info (Core/NX). +* Valid for OpalHMI_ERROR_MALFUNC_ALERT. +*/ +struct { +uint8_t xstop_type;/* enum OpalHMI_XstopType */ +uint8_t reserved_1[3 ]; +__be32 xstop_reason; +union { +__be32 pir;/* for CHECKSTOP_TYPE_CORE */ +__be32 chip_id;/* for CHECKSTOP_TYPE_NX */ + } u; + } xstop_error; + } u; +}; + +/* OPAL_HANDLE_HMI2 out_flags */ +enum { +OPAL_HMI_FLAGS_TB_RESYNC = (1ull <<0 ),/* Timebase has been resynced */ +OPAL_HMI_FLAGS_DEC_LOST = (1ull <<1 ),/* DEC lost, needs to be reprogrammed */ +OPAL_HMI_FLAGS_HDEC_LOST = (1ull <<2 ),/* HDEC lost, needs to be reprogrammed */ +OPAL_HMI_FLAGS_TOD_TB_FAIL = (1ull <<3 ),/* TOD/TB recovery failed. */ +OPAL_HMI_FLAGS_NEW_EVENT = (1ull <<63 ),/* An event has been created */ +}; + +enum { +OPAL_P7IOC_DIAG_TYPE_NONE =0 , +OPAL_P7IOC_DIAG_TYPE_RGC =1 , +OPAL_P7IOC_DIAG_TYPE_BI =2 , +OPAL_P7IOC_DIAG_TYPE_CI =3 , +OPAL_P7IOC_DIAG_TYPE_MISC =4 , +OPAL_P7IOC_DIAG_TYPE_I2C =5 , +OPAL_P7IOC_DIAG_TYPE_LAST =6 +}; + +struct OpalIoP7IOCErrorData { +__be16 type; + +/* GEM */ +__be64 gemXfir; +__be64 gemRfir; +__be64 gemRirqfir; +__be64 gemMask; +__be64 gemRwof; + +/* LEM */ +__be64 lemFir; +__be64 lemErrMask; +__be64 lemAction0; +__be64 lemAction1; +__be64 lemWof; + +union { +struct OpalIoP7IOCRgcErrorData { +__be64 rgcStatus;/* 3E1C10 */ +__be64 rgcLdcp;/* 3E1C18 */ + }rgc; +struct OpalIoP7IOCBiErrorData { +__be64 biLdcp0;/* 3C0100, 3C0118 */ +__be64 biLdcp1;/* 3C0108, 3C0120 */ +__be64 biLdcp2;/* 3C0110, 3C0128 */ +__be64 biFenceStatus;/* 3C0130, 3C0130 */ + +uint8_t biDownbound;/* BI Downbound or Upbound */ + }bi; +struct OpalIoP7IOCCiErrorData { +__be64 ciPortStatus;/* 3Dn008 */ +__be64 ciPortLdcp;/* 3Dn010 */ + +uint8_t ciPort;/* Index of CI port: 0/1 */ + }ci; + }; +}; + +/** +* This structure defines the overlay which will be used to store PHB error +* data upon request. +*/ +enum { +OPAL_PHB_ERROR_DATA_VERSION_1 =1 , +}; + +enum { +OPAL_PHB_ERROR_DATA_TYPE_P7IOC =1 , +OPAL_PHB_ERROR_DATA_TYPE_PHB3 =2 , +OPAL_PHB_ERROR_DATA_TYPE_PHB4 =3 +}; + +enum { +OPAL_P7IOC_NUM_PEST_REGS =128 , +OPAL_PHB3_NUM_PEST_REGS =256 , +OPAL_PHB4_NUM_PEST_REGS =512 +}; + +struct OpalIoPhbErrorCommon { +__be32 version; +__be32 ioType; +__be32 len; +}; + +struct OpalIoP7IOCPhbErrorData { +struct OpalIoPhbErrorCommon common; + +__be32 brdgCtl; + +// P7IOC utl regs +__be32 portStatusReg; +__be32 rootCmplxStatus; +__be32 busAgentStatus; + +// P7IOC cfg regs +__be32 deviceStatus; +__be32 slotStatus; +__be32 linkStatus; +__be32 devCmdStatus; +__be32 devSecStatus; + +// cfg AER regs +__be32 rootErrorStatus; +__be32 uncorrErrorStatus; +__be32 corrErrorStatus; +__be32 tlpHdr1; +__be32 tlpHdr2; +__be32 tlpHdr3; +__be32 tlpHdr4; +__be32 sourceId; + +__be32 rsv3; + +// Record data about the call to allocate a buffer. +__be64 errorClass; +__be64 correlator; + +//P7IOC MMIO Error Regs +__be64 p7iocPlssr;// n120 +__be64 p7iocCsr;// n110 +__be64 lemFir;// nC00 +__be64 lemErrorMask;// nC18 +__be64 lemWOF;// nC40 +__be64 phbErrorStatus;// nC80 +__be64 phbFirstErrorStatus;// nC88 +__be64 phbErrorLog0;// nCC0 +__be64 phbErrorLog1;// nCC8 +__be64 mmioErrorStatus;// nD00 +__be64 mmioFirstErrorStatus;// nD08 +__be64 mmioErrorLog0;// nD40 +__be64 mmioErrorLog1;// nD48 +__be64 dma0ErrorStatus;// nD80 +__be64 dma0FirstErrorStatus;// nD88 +__be64 dma0ErrorLog0;// nDC0 +__be64 dma0ErrorLog1;// nDC8 +__be64 dma1ErrorStatus;// nE00 +__be64 dma1FirstErrorStatus;// nE08 +__be64 dma1ErrorLog0;// nE40 +__be64 dma1ErrorLog1;// nE48 +__be64 pestA[OPAL_P7IOC_NUM_PEST_REGS ]; +__be64 pestB[OPAL_P7IOC_NUM_PEST_REGS ]; +}; + +struct OpalIoPhb3ErrorData { +struct OpalIoPhbErrorCommon common; + +__be32 brdgCtl; + +/* PHB3 UTL regs */ +__be32 portStatusReg; +__be32 rootCmplxStatus; +__be32 busAgentStatus; + +/* PHB3 cfg regs */ +__be32 deviceStatus; +__be32 slotStatus; +__be32 linkStatus; +__be32 devCmdStatus; +__be32 devSecStatus; + +/* cfg AER regs */ +__be32 rootErrorStatus; +__be32 uncorrErrorStatus; +__be32 corrErrorStatus; +__be32 tlpHdr1; +__be32 tlpHdr2; +__be32 tlpHdr3; +__be32 tlpHdr4; +__be32 sourceId; + +__be32 rsv3; + +/* Record data about the call to allocate a buffer */ +__be64 errorClass; +__be64 correlator; + +/* PHB3 MMIO Error Regs */ +__be64 nFir;/* 000 */ +__be64 nFirMask;/* 003 */ +__be64 nFirWOF;/* 008 */ +__be64 phbPlssr;/* 120 */ +__be64 phbCsr;/* 110 */ +__be64 lemFir;/* C00 */ +__be64 lemErrorMask;/* C18 */ +__be64 lemWOF;/* C40 */ +__be64 phbErrorStatus;/* C80 */ +__be64 phbFirstErrorStatus;/* C88 */ +__be64 phbErrorLog0;/* CC0 */ +__be64 phbErrorLog1;/* CC8 */ +__be64 mmioErrorStatus;/* D00 */ +__be64 mmioFirstErrorStatus;/* D08 */ +__be64 mmioErrorLog0;/* D40 */ +__be64 mmioErrorLog1;/* D48 */ +__be64 dma0ErrorStatus;/* D80 */ +__be64 dma0FirstErrorStatus;/* D88 */ +__be64 dma0ErrorLog0;/* DC0 */ +__be64 dma0ErrorLog1;/* DC8 */ +__be64 dma1ErrorStatus;/* E00 */ +__be64 dma1FirstErrorStatus;/* E08 */ +__be64 dma1ErrorLog0;/* E40 */ +__be64 dma1ErrorLog1;/* E48 */ +__be64 pestA[OPAL_PHB3_NUM_PEST_REGS ]; +__be64 pestB[OPAL_PHB3_NUM_PEST_REGS ]; +}; + +struct OpalIoPhb4ErrorData { +struct OpalIoPhbErrorCommon common; + +__be32 brdgCtl; + +/* PHB4 cfg regs */ +__be32 deviceStatus; +__be32 slotStatus; +__be32 linkStatus; +__be32 devCmdStatus; +__be32 devSecStatus; + +/* cfg AER regs */ +__be32 rootErrorStatus; +__be32 uncorrErrorStatus; +__be32 corrErrorStatus; +__be32 tlpHdr1; +__be32 tlpHdr2; +__be32 tlpHdr3; +__be32 tlpHdr4; +__be32 sourceId; + +/* PHB4 ETU Error Regs */ +__be64 nFir;/* 000 */ +__be64 nFirMask;/* 003 */ +__be64 nFirWOF;/* 008 */ +__be64 phbPlssr;/* 120 */ +__be64 phbCsr;/* 110 */ +__be64 lemFir;/* C00 */ +__be64 lemErrorMask;/* C18 */ +__be64 lemWOF;/* C40 */ +__be64 phbErrorStatus;/* C80 */ +__be64 phbFirstErrorStatus;/* C88 */ +__be64 phbErrorLog0;/* CC0 */ +__be64 phbErrorLog1;/* CC8 */ +__be64 phbTxeErrorStatus;/* D00 */ +__be64 phbTxeFirstErrorStatus;/* D08 */ +__be64 phbTxeErrorLog0;/* D40 */ +__be64 phbTxeErrorLog1;/* D48 */ +__be64 phbRxeArbErrorStatus;/* D80 */ +__be64 phbRxeArbFirstErrorStatus;/* D88 */ +__be64 phbRxeArbErrorLog0;/* DC0 */ +__be64 phbRxeArbErrorLog1;/* DC8 */ +__be64 phbRxeMrgErrorStatus;/* E00 */ +__be64 phbRxeMrgFirstErrorStatus;/* E08 */ +__be64 phbRxeMrgErrorLog0;/* E40 */ +__be64 phbRxeMrgErrorLog1;/* E48 */ +__be64 phbRxeTceErrorStatus;/* E80 */ +__be64 phbRxeTceFirstErrorStatus;/* E88 */ +__be64 phbRxeTceErrorLog0;/* EC0 */ +__be64 phbRxeTceErrorLog1;/* EC8 */ + +/* PHB4 REGB Error Regs */ +__be64 phbPblErrorStatus;/* 1900 */ +__be64 phbPblFirstErrorStatus;/* 1908 */ +__be64 phbPblErrorLog0;/* 1940 */ +__be64 phbPblErrorLog1;/* 1948 */ +__be64 phbPcieDlpErrorLog1;/* 1AA0 */ +__be64 phbPcieDlpErrorLog2;/* 1AA8 */ +__be64 phbPcieDlpErrorStatus;/* 1AB0 */ +__be64 phbRegbErrorStatus;/* 1C00 */ +__be64 phbRegbFirstErrorStatus;/* 1C08 */ +__be64 phbRegbErrorLog0;/* 1C40 */ +__be64 phbRegbErrorLog1;/* 1C48 */ + +__be64 pestA[OPAL_PHB4_NUM_PEST_REGS ]; +__be64 pestB[OPAL_PHB4_NUM_PEST_REGS ]; +}; + +enum { +OPAL_REINIT_CPUS_HILE_BE = (1 <<0 ), +OPAL_REINIT_CPUS_HILE_LE = (1 <<1 ), + +/* These two define the base MMU mode of the host on P9 +* +* On P9 Nimbus DD2.0 and Cumlus (and later), KVM can still +* create hash guests in "radix" mode with care (full core +* switch only). +*/ +OPAL_REINIT_CPUS_MMU_HASH = (1 <<2 ), +OPAL_REINIT_CPUS_MMU_RADIX = (1 <<3 ), + +OPAL_REINIT_CPUS_TM_SUSPEND_DISABLED = (1 <<4 ), +}; + +typedef struct oppanel_line { +__be64 line; +__be64 line_len; +}oppanel_line_t ; + +enum opal_prd_msg_type { +OPAL_PRD_MSG_TYPE_INIT =0 ,/* HBRT --> OPAL */ +OPAL_PRD_MSG_TYPE_FINI ,/* HBRT/kernel --> OPAL */ +OPAL_PRD_MSG_TYPE_ATTN ,/* HBRT <-- OPAL */ +OPAL_PRD_MSG_TYPE_ATTN_ACK ,/* HBRT --> OPAL */ +OPAL_PRD_MSG_TYPE_OCC_ERROR ,/* HBRT <-- OPAL */ +OPAL_PRD_MSG_TYPE_OCC_RESET ,/* HBRT <-- OPAL */ +}; + +struct opal_prd_msg_header { +uint8_t type; +uint8_t pad[1 ]; +__be16 size; +}; + +struct opal_prd_msg ; + +#define OCC_RESET 0 +#define OCC_LOAD 1 +#define OCC_THROTTLE 2 +#define OCC_MAX_THROTTLE_STATUS 5 + +struct opal_occ_msg { +__be64 type; +__be64 chip; +__be64 throttle_status; +}; + +/* +* SG entries +* +* WARNING: The current implementation requires each entry +* to represent a block that is 4k aligned *and* each block +* size except the last one in the list to be as well. +*/ +struct opal_sg_entry { +__be64 data; +__be64 length; +}; + +/* +* Candidate image SG list. +* +* length = VER | length +*/ +struct opal_sg_list { +__be64 length; +__be64 next; +struct opal_sg_entry entry[]; +}; + +/* +* Dump region ID range usable by the OS +*/ +#define OPAL_DUMP_REGION_HOST_START 0x80 +#define OPAL_DUMP_REGION_LOG_BUF 0x80 +#define OPAL_DUMP_REGION_HOST_END 0xFF + +/* CAPI modes for PHB */ +enum { +OPAL_PHB_CAPI_MODE_PCIE =0 , +OPAL_PHB_CAPI_MODE_CAPI =1 , +OPAL_PHB_CAPI_MODE_SNOOP_OFF =2 , +OPAL_PHB_CAPI_MODE_SNOOP_ON =3 , +OPAL_PHB_CAPI_MODE_DMA =4 , +OPAL_PHB_CAPI_MODE_DMA_TVT1 =5 , +}; + +/* OPAL I2C request */ +struct opal_i2c_request { +uint8_t type; +#define OPAL_I2C_RAW_READ 0 +#define OPAL_I2C_RAW_WRITE 1 +#define OPAL_I2C_SM_READ 2 +#define OPAL_I2C_SM_WRITE 3 +uint8_t flags; +#define OPAL_I2C_ADDR_10 0x01/* Not supported yet */ +uint8_t subaddr_sz;/* Max 4 */ +uint8_t reserved; +__be16 addr;/* 7 or 10 bit address */ +__be16 reserved2; +__be32 subaddr;/* Sub-address if any */ +__be32 size;/* Data size */ +__be64 buffer_ra;/* Buffer real address */ +}; + +/* +* EPOW status sharing (OPAL and the host) +* +* The host will pass on OPAL, a buffer of length OPAL_SYSEPOW_MAX +* with individual elements being 16 bits wide to fetch the system +* wide EPOW status. Each element in the buffer will contain the +* EPOW status in it's bit representation for a particular EPOW sub +* class as defined here. So multiple detailed EPOW status bits +* specific for any sub class can be represented in a single buffer +* element as it's bit representation. +*/ + +/* System EPOW type */ +enum OpalSysEpow { +OPAL_SYSEPOW_POWER =0 ,/* Power EPOW */ +OPAL_SYSEPOW_TEMP =1 ,/* Temperature EPOW */ +OPAL_SYSEPOW_COOLING =2 ,/* Cooling EPOW */ +OPAL_SYSEPOW_MAX =3 ,/* Max EPOW categories */ +}; + +/* Power EPOW */ +enum OpalSysPower { +OPAL_SYSPOWER_UPS =0x0001 ,/* System on UPS power */ +OPAL_SYSPOWER_CHNG =0x0002 ,/* System power config change */ +OPAL_SYSPOWER_FAIL =0x0004 ,/* System impending power failure */ +OPAL_SYSPOWER_INCL =0x0008 ,/* System incomplete power */ +}; + +/* Temperature EPOW */ +enum OpalSysTemp { +OPAL_SYSTEMP_AMB =0x0001 ,/* System over ambient temperature */ +OPAL_SYSTEMP_INT =0x0002 ,/* System over internal temperature */ +OPAL_SYSTEMP_HMD =0x0004 ,/* System over ambient humidity */ +}; + +/* Cooling EPOW */ +enum OpalSysCooling { +OPAL_SYSCOOL_INSF =0x0001 ,/* System insufficient cooling */ +}; + +/* Argument to OPAL_CEC_REBOOT2() */ +enum { +OPAL_REBOOT_NORMAL =0 , +OPAL_REBOOT_PLATFORM_ERROR =1 , +OPAL_REBOOT_FULL_IPL =2 , +OPAL_REBOOT_MPIPL =3 , +OPAL_REBOOT_FAST =4 , +}; + +/* Argument to OPAL_PCI_TCE_KILL */ +enum { +OPAL_PCI_TCE_KILL_PAGES , +OPAL_PCI_TCE_KILL_PE , +OPAL_PCI_TCE_KILL_ALL , +}; + +/* The xive operation mode indicates the active "API" and +* corresponds to the "mode" parameter of the opal_xive_reset() +* call +*/ +enum { +OPAL_XIVE_MODE_EMU =0 , +OPAL_XIVE_MODE_EXPL =1 , +}; + +/* Flags for OPAL_XIVE_GET_IRQ_INFO */ +enum { +OPAL_XIVE_IRQ_TRIGGER_PAGE =0x00000001 , +OPAL_XIVE_IRQ_STORE_EOI =0x00000002 , +OPAL_XIVE_IRQ_LSI =0x00000004 , +OPAL_XIVE_IRQ_SHIFT_BUG =0x00000008 ,/* P9 DD1.0 workaround */ +OPAL_XIVE_IRQ_MASK_VIA_FW =0x00000010 ,/* P9 DD1.0 workaround */ +OPAL_XIVE_IRQ_EOI_VIA_FW =0x00000020 ,/* P9 DD1.0 workaround */ +OPAL_XIVE_IRQ_STORE_EOI2 =0x00000040 , +}; + +/* Flags for OPAL_XIVE_GET/SET_QUEUE_INFO */ +enum { +OPAL_XIVE_EQ_ENABLED =0x00000001 , +OPAL_XIVE_EQ_ALWAYS_NOTIFY =0x00000002 , +OPAL_XIVE_EQ_ESCALATE =0x00000004 , +}; + +/* Flags for OPAL_XIVE_GET/SET_VP_INFO */ +enum { +OPAL_XIVE_VP_ENABLED =0x00000001 , +OPAL_XIVE_VP_SINGLE_ESCALATION =0x00000002 , +}; + +/* "Any chip" replacement for chip ID for allocation functions */ +enum { +OPAL_XIVE_ANY_CHIP =0xffffffff , +}; + +/* Xive sync options */ +enum { +/* This bits are cumulative, arg is a girq */ +XIVE_SYNC_EAS =0x00000001 ,/* Sync irq source */ +XIVE_SYNC_QUEUE =0x00000002 ,/* Sync irq target */ +}; + +/* Dump options */ +enum { +XIVE_DUMP_TM_HYP =0 , +XIVE_DUMP_TM_POOL =1 , +XIVE_DUMP_TM_OS =2 , +XIVE_DUMP_TM_USER =3 , +XIVE_DUMP_VP =4 , +XIVE_DUMP_EMU_STATE =5 , +}; + +/* "type" argument options for OPAL_IMC_COUNTERS_* calls */ +enum { +OPAL_IMC_COUNTERS_NEST =1 , +OPAL_IMC_COUNTERS_CORE =2 , +OPAL_IMC_COUNTERS_TRACE =3 , +}; + + +/* PCI p2p descriptor */ +#define OPAL_PCI_P2P_ENABLE 0x1 +#define OPAL_PCI_P2P_LOAD 0x2 +#define OPAL_PCI_P2P_STORE 0x4 + +/* MPIPL update operations */ +enum opal_mpipl_ops { +OPAL_MPIPL_ADD_RANGE =0 , +OPAL_MPIPL_REMOVE_RANGE =1 , +OPAL_MPIPL_REMOVE_ALL =2 , +OPAL_MPIPL_FREE_PRESERVED_MEMORY =3 , +}; + +/* Tag will point to various metadata area. Kernel will +* use tag to get metadata value. +*/ +enum opal_mpipl_tags { +OPAL_MPIPL_TAG_CPU =0 , +OPAL_MPIPL_TAG_OPAL =1 , +OPAL_MPIPL_TAG_KERNEL =2 , +OPAL_MPIPL_TAG_BOOT_MEM =3 , +}; + +/* Preserved memory details */ +struct opal_mpipl_region { +__be64 src; +__be64 dest; +__be64 size; +}; + +/* Structure version */ +#define OPAL_MPIPL_VERSION 0x01 + +struct opal_mpipl_fadump { +u8 version; +u8 reserved[7 ]; +__be32 crashing_pir;/* OPAL crashing CPU PIR */ +__be32 cpu_data_version; +__be32 cpu_data_size; +__be32 region_cnt; +struct opal_mpipl_region region[]; +} __packed; + +#endif /* __ASSEMBLY__ */ + +#endif /* __OPAL_API_H */
Signature · 1 line
2.30.2
Re: [PATCH 3/5] xen/ppc: Add OPAL API definition header file
Quoted 3 lines · Shawn Anastasio
OPAL (OpenPower Abstraction Layer) is the interface exposed by firmware on PowerNV (bare metal) systems. Import Linux's header definining the API and related information.
To help future updating, mentioning version (or commit) at which this snapshot was taken would be helpful.
Jan
Re: [PATCH 3/5] xen/ppc: Add OPAL API definition header file
Quoted 7 lines · Jan Beulich
Quoted 3 lines · Shawn Anastasio
OPAL (OpenPower Abstraction Layer) is the interface exposed by firmware on PowerNV (bare metal) systems. Import Linux's header definining the API and related information.
To help future updating, mentioning version (or commit) at which this snapshot was taken would be helpful.
Sounds reasonable. I'll reference the Linux commit that this was pulled from in the commit message.
Quoted 1 line
Jan
Thanks,
Shawn
PATCH 4/5 xen/ppc: Parse device tree for OPAL node on PowerNV
In reply to Shawn AnastasioCommunication with firmware boot services on PowerNV requires parsing the fdt blob passed by the bootloader in order to obtain the firmware entrypoint. Use Xen's libfdt to do this and store the information required for firmware calls, to be implemented in a future patch.
The full xen/common build doesn't yet work, but libfdt and its xen/lib dependency can be made to build by defining a few stub headers.
--- xen/arch/ppc/Kconfig | 1 + xen/arch/ppc/Makefile | 1 + xen/arch/ppc/arch.mk | 4 +-- xen/arch/ppc/include/asm/boot.h | 16 +++++++++- xen/arch/ppc/include/asm/bug.h | 18 +++++++++++ xen/arch/ppc/include/asm/cache.h | 6 ++++ xen/arch/ppc/include/asm/processor.h | 13 +++++++- xen/arch/ppc/include/asm/string.h | 6 ++++ xen/arch/ppc/include/asm/system.h | 6 ++++ xen/arch/ppc/opal.c | 48 ++++++++++++++++++++++++++++ xen/arch/ppc/setup.c | 9 ++++-- 11 files changed, 122 insertions(+), 6 deletions(-) create mode 100644 xen/arch/ppc/include/asm/bug.h create mode 100644 xen/arch/ppc/include/asm/cache.h create mode 100644 xen/arch/ppc/include/asm/string.h create mode 100644 xen/arch/ppc/include/asm/system.h create mode 100644 xen/arch/ppc/opal.c
xen/arch/ppc/Kconfig +1 -0
@@ -1,5 +1,6 @@ config PPC def_bool y + select HAS_DEVICE_TREE config PPC64 def_bool y
xen/arch/ppc/Makefile +1 -0
@@ -2,6 +2,7 @@ obj-$(CONFIG_PPC64) += ppc64/ obj-y += boot-of.init.o obj-$(CONFIG_EARLY_PRINTK) += early_printk.init.o +obj-y += opal.o obj-y += setup.o $(TARGET): $(TARGET)-syms
xen/arch/ppc/arch.mk +2 -2
@@ -10,5 +10,5 @@ CFLAGS += -mstrict-align -mcmodel=medium -mabi=elfv2 -fPIC -mno-altivec -mno-vsx LDFLAGS += -m elf64lppc # TODO: Drop override when more of the build is working -override ALL_OBJS-y = arch/$(SRCARCH)/built_in.o -override ALL_LIBS-y = +override ALL_OBJS-y = arch/$(SRCARCH)/built_in.o common/libfdt/built_in.o lib/built_in.o +override ALL_LIBS-y = lib/lib.a
xen/arch/ppc/include/asm/boot.h +15 -1
@@ -4,7 +4,10 @@#include <xen/types.h> -/* a collection of interfaces used during boot. */ +/* +* OpenFirmware boot interfaces +*/ +enum {OF_FAILURE =-1 ,OF_SUCCESS =0 ,
@@ -20,4 +23,15 @@ struct of_service {int enter_of (struct of_service *args,unsigned long entry);void boot_of_init (unsigned long vec); +/* +* OPAL boot interfaces +*/ + +struct opal { +uint64_t base; +uint64_t entry; +}; + +void boot_opal_init (const void *fdt); +#endif /* _ASM_PPC_BOOT_H */
xen/arch/ppc/include/asm/bug.h new file +18 -0
@@ -0,0 +1,18 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#ifndef _ASM_PPC_BUG_H +#define _ASM_PPC_BUG_H + +#include <xen/stringify.h> + +/* +* Power ISA guarantees that an instruction consisting of all zeroes is +* illegal. +*/ +#define BUG_OPCODE 0x00000000 + +#define BUG_INSTR ".long " __stringify(BUG_OPCODE) + +#define BUG_FN_REG r0 + +#endif /* _ASM_PPC_BUG_H */
xen/arch/ppc/include/asm/cache.h new file +6 -0
@@ -0,0 +1,6 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#ifndef _ASM_PPC_CACHE_H +#define _ASM_PPC_CACHE_H + +#endif /* _ASM_PPC_CACHE_H */
xen/arch/ppc/include/asm/processor.h +12 -1
@@ -133,6 +133,17 @@ struct cpu_user_regsuint32_t entry_vector; }; -#endif +/* +* panic() isn't available at the moment so an infinite loop will be +* used temporarily. +* TODO: change it to panic() +*/ +static inline void noreturndie (void ) +{ +for ( ; ; ) +HMT_very_low (); +} + +#endif /* __ASSEMBLY__ */ #endif /* _ASM_PPC_PROCESSOR_H */
xen/arch/ppc/include/asm/string.h new file +6 -0
@@ -0,0 +1,6 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#ifndef _ASM_PPC_STRING_H +#define _ASM_PPC_STRING_H + +#endif /* _ASM_PPC_STRING_H */
xen/arch/ppc/include/asm/system.h new file +6 -0
@@ -0,0 +1,6 @@ +#ifndef _ASM_SYSTEM_H_ +#define _ASM_SYSTEM_H_ + +#define smp_wmb () __asm__ __volatile__ ( "lwsync" : : : "memory" ) + +#endif /* _ASM_SYSTEM_H */
xen/arch/ppc/opal.c new file +48 -0
48 lines not on this page · raw message
xen/arch/ppc/setup.c +7 -2
@@ -18,8 +18,13 @@ void __init noreturn start_xen(unsigned long r3, unsigned long r4, }else { -/* kexec boot: Unimplemented */ -__builtin_trap (); +/* +* kexec boot protocol +* +* TODO: This currently assumes an OPAL/PowerNV system, but it's also +* possible to be kexec'd on an OF system. +*/ +boot_opal_init ((void *) r3); }early_printk ("Hello, ppc64le!\n" );
Signature · 1 line
2.30.2
Re: [PATCH 4/5] xen/ppc: Parse device tree for OPAL node on PowerNV
xen/arch/ppc/arch.mk CFLAGS += -mstrict-align -mcmodel=medium -mabi=elfv2 -fPIC -mno-altivec -mno-vsx · line 14
Quoted 10 lines · Shawn Anastasio
xen/arch/ppc/arch.mk +2
-2@@ -10,5 +10,5 @@ CFLAGS += -mstrict-align -mcmodel=medium -mabi=elfv2 -fPIC -mno-altivec -mno-vsx LDFLAGS += -m elf64lppc # TODO: Drop override when more of the build is working -override ALL_OBJS-y = arch/$(SRCARCH)/built_in.o -override ALL_LIBS-y = +override ALL_OBJS-y = arch/$(SRCARCH)/built_in.o common/libfdt/built_in.o lib/built_in.o +override ALL_LIBS-y = lib/lib.a
Can't you drop the ALL_LIBS-y override right here?
Jan
Re: [PATCH 4/5] xen/ppc: Parse device tree for OPAL node on PowerNV
Quoted 6 lines · Jan Beulich
Quoted 5 lines · Shawn Anastasio
xen/arch/ppc/arch.mk +0
-0@@ -10,5 +10,5 @@ CFLAGS += -mstrict-align -mcmodel=medium -mabi=elfv2 -fPIC -mno-altivec -mno-vsx LDFLAGS += -m elf64lppc
Quoted 7 lines
xen/arch/ppc/arch.mk CFLAGS += -mstrict-align -mcmodel=medium -mabi=elfv2 -fPIC -mno-altivec -mno-vsx · line 14
Quoted 5 lines
xen/arch/ppc/arch.mk +2
-2# TODO: Drop override when more of the build is working -override ALL_OBJS-y = arch/$(SRCARCH)/built_in.o -override ALL_LIBS-y = +override ALL_OBJS-y = arch/$(SRCARCH)/built_in.o common/libfdt/built_in.o lib/built_in.o +override ALL_LIBS-y = lib/lib.aCan't you drop the ALL_LIBS-y override right here?
Just tested this and it does indeed work. I'll drop the override in v2.
Quoted 1 line
Jan
Thanks,
Shawn
PATCH 5/5 xen/ppc: Implement early serial console on PowerNV
In reply to Shawn AnastasioImplement the OPAL firmware calls required to write to the serial console on PowerNV systems. Unlike pseries/Open Firmware, the OPAL firmware interface can be used past early boot and as such the relevant functions are not marked as __init.
--- xen/arch/ppc/include/asm/asm-defns.h | 12 ++++ xen/arch/ppc/opal.c | 27 ++++++++- xen/arch/ppc/ppc64/Makefile | 1 + xen/arch/ppc/ppc64/asm-offsets.c | 4 ++ xen/arch/ppc/ppc64/opal-calls.S | 82 ++++++++++++++++++++++++++++ 5 files changed, 125 insertions(+), 1 deletion(-) create mode 100644 xen/arch/ppc/ppc64/opal-calls.S
xen/arch/ppc/include/asm/asm-defns.h +12 -0
@@ -23,6 +23,18 @@ addis reg,%r2,name@toc@ha; \ addi reg,reg,name@toc@l +/* + * Declare a global assembly function with a proper TOC setup prologue + */ +#define _GLOBAL_TOC(name) \ + .balign 4; \ + .type name,@function; \ + .globl name; \ +name: \ +0: addis %r2,%r12,(.TOC.-0b)@ha; \ + addi %r2,%r2,(.TOC.-0b)@l; \ + .localentry name,.-name +/* * Depending on how we were booted, the CPU could be running in either * Little Endian or Big Endian mode. The following trampoline from Linux
xen/arch/ppc/opal.c +26 -1
@@ -8,9 +8,28 @@#include <xen/init.h> #include <xen/lib.h> -/* Global OPAL struct containing entrypoint and base */ +/* Global OPAL struct containing entrypoint and base used by opal-calls.S */ struct opal opal; +int64_t opal_console_write (int64_t term_number,uint64_t *length, +uint8_t *buffer); +int64_t opal_console_flush (int64_t term_number); +int64_t opal_reinit_cpus (uint64_t flags); + +static void opal_putchar (char c) +{ +uint64_t len; +if (c =='\n' ) + { +char buf ='\r' ; + len =cpu_to_be64 (1 ); +opal_console_write (0 , &len, (uint8_t *) &buf); + } + len =cpu_to_be64 (1 ); +opal_console_write (0 , &len, (uint8_t *) &c); +opal_console_flush (0 ); +} +void __init boot_opal_init (const void *fdt) {int opal_node;
@@ -45,4 +64,10 @@ void __init boot_opal_init(const void *fdt) opal.base =be64_to_cpu (*opal_base); opal.entry =be64_to_cpu (*opal_entry); + +early_printk_init (opal_putchar); + +/* Ask OPAL to set HID0 for Little Endian interrupts + Radix TLB support */ +opal_reinit_cpus (OPAL_REINIT_CPUS_HILE_LE |OPAL_REINIT_CPUS_MMU_RADIX + |OPAL_REINIT_CPUS_MMU_HASH ); }
xen/arch/ppc/ppc64/Makefile +1 -0
@@ -1,2 +1,3 @@ obj-y += head.o obj-y += of-call.o +obj-y += opal-calls.o
xen/arch/ppc/ppc64/asm-offsets.c +4 -0
@@ -6,6 +6,7 @@#include <xen/macros.h> #include <asm/processor.h> +#include <asm/boot.h> #define DEFINE(_sym, _val) \ asm volatile ( "\n.ascii\"==>#define " #_sym " %0 /* " #_val " */<==\"" \
@@ -46,6 +47,9 @@ void __dummy__(void) OFFSET(UREGS_cr, struct cpu_user_regs, cr); OFFSET(UREGS_fpscr, struct cpu_user_regs, fpscr);DEFINE (UREGS_sizeof,sizeof (struct cpu_user_regs )); + + OFFSET(OPAL_base, struct opal, base); + OFFSET(OPAL_entry, struct opal, entry); }/*
xen/arch/ppc/ppc64/opal-calls.S new file +82 -0
82 lines not on this page · raw message
Signature · 1 line
2.30.2
Re: [PATCH 5/5] xen/ppc: Implement early serial console on PowerNV
xen/arch/ppc/include/asm/asm-defns.h line 24
Quoted 5 lines · Shawn Anastasio
xen/arch/ppc/include/asm/asm-defns.h +0
-0@@ -23,6 +23,18 @@ addis reg,%r2,name@toc@ha; \ addi reg,reg,name@toc@l
Noticing only now, because of the issue ...
xen/arch/ppc/include/asm/asm-defns.h line 36
Quoted 11 lines
xen/arch/ppc/include/asm/asm-defns.h +11
-0+/* +* Declare a global assembly function with a proper TOC setup prologue +*/ +#define _GLOBAL_TOC (name) \ + .balign 4; \ + .type name,@function; \ + .globl name; \ +name: \ +0: addis %r2,%r12,(.TOC.-0b)@ha; \ + addi %r2,%r2,(.TOC.-0b)@l; \ + .localentry name,.-name
... being widened - could we gain blanks after the commas? Down here (to match the code in context) another padding blank after "addi" would also be nice.
xen/arch/ppc/opal.c line 15
Quoted 12 lines
xen/arch/ppc/opal.c +3
-1@@ -8,9 +8,28 @@#include <xen/init.h> #include <xen/lib.h> -/* Global OPAL struct containing entrypoint and base */ +/* Global OPAL struct containing entrypoint and base used by opal-calls.S */ struct opal opal; +int64_t opal_console_write (int64_t term_number,uint64_t *length, +uint8_t *buffer);
Would this perhaps better be void *, eliminating the need for casting in calls of this function?
xen/arch/ppc/opal.c line 19
Quoted 4 lines
xen/arch/ppc/opal.c +4
-0+int64_t opal_console_flush (int64_t term_number); +int64_t opal_reinit_cpus (uint64_t flags); + +static void opal_putchar (char c)
Can't this be __init?
xen/arch/ppc/opal.c line 22
Quoted 3 lines
xen/arch/ppc/opal.c +3
-0+{ +uint64_t len; +if (c =='\n' )
Nit: Blank line please between declaration(s) and statement(s). (At least one more instance below.)
Also please add the missing blanks in the if(), seeing that otherwise the file is aiming at being Xen style.
Quoted 14 lines
xen/arch/ppc/opal.c +10
-0+ { +char buf ='\r' ; + len =cpu_to_be64 (1 ); +opal_console_write (0 , &len, (uint8_t *) &buf); + } + len =cpu_to_be64 (1 ); +opal_console_write (0 , &len, (uint8_t *) &c); +opal_console_flush (0 ); +} +void __init boot_opal_init (const void *fdt) {int opal_node;
xen/arch/ppc/opal.c void __init boot_opal_init(const void *fdt) · line 72
Quoted 9 lines
xen/arch/ppc/opal.c +6
-0@@ -45,4 +64,10 @@ void __init boot_opal_init(const void *fdt) opal.base =be64_to_cpu (*opal_base); opal.entry =be64_to_cpu (*opal_entry); + +early_printk_init (opal_putchar); + +/* Ask OPAL to set HID0 for Little Endian interrupts + Radix TLB support */ +opal_reinit_cpus (OPAL_REINIT_CPUS_HILE_LE |OPAL_REINIT_CPUS_MMU_RADIX + |OPAL_REINIT_CPUS_MMU_HASH );
Nit: operators on continued lines go at the end of the earlier line.
xen/arch/ppc/ppc64/opal-calls.S line 10
Quoted 13 lines
xen/arch/ppc/ppc64/opal-calls.S new file +10
-0@@ -0,0 +1,82 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * Adapted from Linux's arch/powerpc/boot/opal-calls.S + * + * Copyright (c) 2016 IBM Corporation. + * Copyright Raptor Engineering, LLC + */ + +#include <asm/asm-defns.h> +#include <asm/asm-offsets.h>
Would it make sense to have asm-defns.h include asm-offsets.h, like x86 and Arm do?
xen/arch/ppc/ppc64/opal-calls.S line 14
Quoted 4 lines
xen/arch/ppc/ppc64/opal-calls.S new file +4
-0+#include <asm/opal-api.h> +#include <asm/msr.h> + + .text
Is any of this code still needed post-init?
xen/arch/ppc/ppc64/opal-calls.S line 20
Quoted 5 lines
xen/arch/ppc/ppc64/opal-calls.S new file +5
-0+#define OPAL_CALL(name, token) \ + .globl name; \ +name: \ + li %r0, token; \ + b opal_call;
I think the trailing semicolon wants omitting.
Jan
Re: [PATCH 5/5] xen/ppc: Implement early serial console on PowerNV
Quoted 9 lines · Jan Beulich
xen/arch/ppc/include/asm/asm-defns.h line 24
Quoted 5 lines · Shawn Anastasio
xen/arch/ppc/include/asm/asm-defns.h +0
-0@@ -23,6 +23,18 @@ addis reg,%r2,name@toc@ha; \ addi reg,reg,name@toc@lNoticing only now, because of the issue ...
Quoted 15 lines
xen/arch/ppc/include/asm/asm-defns.h line 36
Quoted 11 lines
xen/arch/ppc/include/asm/asm-defns.h +11
-0+/* +* Declare a global assembly function with a proper TOC setup prologue +*/ +#define _GLOBAL_TOC (name) \ + .balign 4; \ + .type name,@function; \ + .globl name; \ +name: \ +0: addis %r2,%r12,(.TOC.-0b)@ha; \ + addi %r2,%r2,(.TOC.-0b)@l; \ + .localentry name,.-name... being widened - could we gain blanks after the commas? Down here (to match the code in context) another padding blank after "addi" would also be nice.
Sure, will do in v2.
Quoted 10 lines
Quoted 10 lines
xen/arch/ppc/opal.c +1
-1@@ -8,9 +8,28 @@#include <xen/init.h> #include <xen/lib.h> -/* Global OPAL struct containing entrypoint and base */ +/* Global OPAL struct containing entrypoint and base used by opal-calls.S */ struct opal opal;
Quoted 5 lines
xen/arch/ppc/opal.c line 15
Quoted 2 lines
xen/arch/ppc/opal.c +2
-0+int64_t opal_console_write (int64_t term_number,uint64_t *length, +uint8_t *buffer);Would this perhaps better be void *, eliminating the need for casting in calls of this function?
I made it uint8_t to match the official OPAL API documentation (though I now see I missed a const):
https://open-power.github.io/skiboot/doc/opal-api/opal-console-read-write-1-2.html#opal-console-write
In this case though, the type information of this parameter might not be that important and changing it to void* to avoid the cast is fine with me.
Quoted 6 lines
xen/arch/ppc/opal.c line 19
Quoted 4 lines
xen/arch/ppc/opal.c +4
-0+int64_t opal_console_flush (int64_t term_number); +int64_t opal_reinit_cpus (uint64_t flags); + +static void opal_putchar (char c)Can't this be
__init?
Unlike OpenFirmware, OPAL calls are expected to be used by the OS during its entire lifecycle, not just during early boot, so the full (non-early) serial console driver would likely want to use these functions as well.
Quoted 7 lines
xen/arch/ppc/opal.c line 22
Quoted 4 lines
xen/arch/ppc/opal.c +3
-0+{ +uint64_t len; +if (c =='\n' )Nit: Blank line please between declaration(s) and statement(s). (At least one more instance below.)
Will fix.
Quoted 2 lines
Also please add the missing blanks in the
if(), seeing that otherwise the file is aiming at being Xen style.
Ditto.
Quoted 15 lines
Quoted 15 lines
xen/arch/ppc/opal.c +10
-0+ { +char buf ='\r' ; + len =cpu_to_be64 (1 ); +opal_console_write (0 , &len, (uint8_t *) &buf); + } + len =cpu_to_be64 (1 ); +opal_console_write (0 , &len, (uint8_t *) &c); +opal_console_flush (0 ); +} +void __init boot_opal_init (const void *fdt) {int opal_node;@@ -45,4 +64,10 @@ void __init boot_opal_init(const void *fdt)
Quoted 10 lines
xen/arch/ppc/opal.c void __init boot_opal_init(const void *fdt) · line 72
Quoted 8 lines
xen/arch/ppc/opal.c +6
-0opal.base =be64_to_cpu (*opal_base); opal.entry =be64_to_cpu (*opal_entry); + +early_printk_init (opal_putchar); + +/* Ask OPAL to set HID0 for Little Endian interrupts + Radix TLB support */ +opal_reinit_cpus (OPAL_REINIT_CPUS_HILE_LE |OPAL_REINIT_CPUS_MMU_RADIX + |OPAL_REINIT_CPUS_MMU_HASH );Nit: operators on continued lines go at the end of the earlier line.
Will fix.
Quoted 8 lines
Quoted 8 lines
xen/arch/ppc/ppc64/opal-calls.S new file +5
-0@@ -0,0 +1,82 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * Adapted from Linux's arch/powerpc/boot/opal-calls.S + * + * Copyright (c) 2016 IBM Corporation.
Quoted 8 lines
xen/arch/ppc/ppc64/opal-calls.S line 10
Quoted 5 lines
xen/arch/ppc/ppc64/opal-calls.S new file +5
-0+ * Copyright Raptor Engineering, LLC + */ + +#include <asm/asm-defns.h> +#include <asm/asm-offsets.h>Would it make sense to have
asm-defns.hincludeasm-offsets.h, like x86 and Arm do?
Sure, I'll make this change along with the formatting updates in asm-defns.h
Quoted 6 lines
xen/arch/ppc/ppc64/opal-calls.S line 14
Quoted 4 lines
xen/arch/ppc/ppc64/opal-calls.S new file +4
-0+#include <asm/opal-api.h> +#include <asm/msr.h> + + .textIs any of this code still needed post-init?
Yes, see above.
Quoted 7 lines
xen/arch/ppc/ppc64/opal-calls.S line 20
Quoted 5 lines
xen/arch/ppc/ppc64/opal-calls.S new file +5
-0+#define OPAL_CALL(name, token) \ + .globl name; \ +name: \ + li %r0, token; \ + b opal_call;I think the trailing semicolon wants omitting.
Will fix.
Quoted 1 line
Jan
Thanks,
Shawn
Re: [PATCH 5/5] xen/ppc: Implement early serial console on PowerNV
Quoted 10 lines · Shawn Anastasio
Quoted 4 lines · Jan Beulich
Quoted 1 line · Shawn Anastasio
+static void
opal_putchar(char c)Can't this be
__init?Unlike OpenFirmware, OPAL calls are expected to be used by the OS during its entire lifecycle, not just during early boot, so the full (non-early) serial console driver would likely want to use these functions as well.
Well, in the present usage it's unneeded post-init afaict. Hence if you don't want to add __init until another use appears, please add a respective remark in the description.
Jan