Skip to contentSkip to conversation

scsi: arcmsr: support Areca ARC-1688 Raid controller

PATCH Superseded ching Huang 2 participants 2 messages Sep 22, 2023 – Sep 24, 2023 SCSI

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/3 scsi: arcmsr: support Areca ARC-1688 Raid controller

From: ching Huang <[email protected]>

This patch supports Areca new Raid controller ARC-1688

---

drivers/scsi/arcmsr/arcmsr.h +23 -0
index ed8d931..8f20d9c 100644
@@ -818,6 +818,23 @@ typedef struct deliver_completeQ {
 	uint16_t	cmdLMID;        // reserved (0)
 	uint16_t	cmdFlag2;       // reserved (0)
 } DeliverQ, CompletionQ, *pDeliver_Q, *pCompletion_Q;
+
+#define ARCMSR_XOR_SEG_SIZE	(1024 * 1024)
+struct HostRamBuf {
+	uint32_t	hrbSignature;	// must be "HRBS"
+	uint32_t	hrbSize;	// total sg size, be multiples of MB
+	uint32_t	hrbRes[2];	// reserved, must be set to 0
+};
+struct	Xor_sg {
+	dma_addr_t	xorPhys;
+	uint64_t	xorBufLen;
+};
+struct	XorHandle {
+	dma_addr_t	xorPhys;
+	uint64_t	xorBufLen;
+	void		*xorVirt;
+};
+
 /*
 *******************************************************************************
 **                 Adapter Control Block
@@ -929,6 +946,7 @@ struct AdapterControlBlock
 	char			firm_model[12];
 	char			firm_version[20];
 	char			device_map[20];			/*21,84-99*/
+	uint32_t		firm_PicStatus;
 	struct work_struct 	arcmsr_do_message_isr_bh;
 	struct timer_list	eternal_timer;
 	unsigned short		fw_flag;
@@ -937,6 +955,7 @@ struct AdapterControlBlock
 #define	FW_DEADLOCK			0x0010
 	uint32_t		maxOutstanding;
 	int			vector_count;
+	int			xor_mega;
 	uint32_t		maxFreeCCB;
 	struct timer_list	refresh_timer;
 	uint32_t		doneq_index;
@@ -946,6 +965,10 @@ struct AdapterControlBlock
 	uint32_t		completionQ_entry;
 	pCompletion_Q		pCompletionQ;
 	uint32_t		completeQ_size;
+	void			*xorVirt;
+	dma_addr_t		xorPhys;
+	unsigned int		init2cfg_size;
+	unsigned int		xorVirtOffset;
 };/* HW_DEVICE_EXTENSION */
 /*
 *******************************************************************************
drivers/scsi/arcmsr/arcmsr_hba.c +89 -1

120 lines not on this page · raw message

#1 lore raw
kernel test robot noticed the following build warnings:

Hi ching,

kernel test robot noticed the following build warnings:

[auto build test WARNING on mkp-scsi/for-next]
[also build test WARNING on jejb-scsi/for-next linus/master v6.6-rc2 next-20230921] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/ching-Huang/scsi-arcmsr-support-Areca-ARC-1688-Raid-controller/20230922-170045
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
patch link:    https://lore.kernel.org/r/bc855b702c8a2fbb7d3ffff69f65b6ce89c9042c.camel%40areca.com.tw
patch subject: [PATCH V2 1/3] scsi: arcmsr: support Areca ARC-1688 Raid controller
config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20230924/[email protected]/config)
compiler: arceb-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230924/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All warnings (new ones prefixed by >>):

drivers/scsi/arcmsr/arcmsr_hba.c: In function 'arcmsr_free_ccb_pool':

>> drivers/scsi/arcmsr/arcmsr_hba.c:2094:53: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
    2094 |                                 pXorPhys->xorPhys = (dma_addr_t)NULL;
         |                                                     ^

vim +2094 drivers/scsi/arcmsr/arcmsr_hba.c

2077
2078 static void arcmsr_free_ccb_pool(struct AdapterControlBlock *acb)
2079 {
2080 if (acb->xor_mega) {
2081 struct Xor_sg *pXorPhys;
2082 void **pXorVirt;
2083 int i;
2084
2085 pXorPhys = (struct Xor_sg *)(acb->xorVirt +
2086 sizeof(struct HostRamBuf));
2087 pXorVirt = (void **)((unsigned long)acb->xorVirt +
2088 (unsigned long)acb->xorVirtOffset);
2089 for (i = 0; i < acb->xor_mega; i++) {
2090 if (pXorPhys->xorPhys) {
2091 dma_free_coherent(&acb->pdev->dev,
2092 ARCMSR_XOR_SEG_SIZE,
2093 *pXorVirt, pXorPhys->xorPhys);

> 2094					pXorPhys->xorPhys = (dma_addr_t)NULL;

2095 *pXorVirt = NULL;
2096 }
2097 pXorPhys++;
2098 pXorVirt++;
2099 }
2100 dma_free_coherent(&acb->pdev->dev, acb->init2cfg_size,
2101 acb->xorVirt, acb->xorPhys);
2102 }
2103 dma_free_coherent(&acb->pdev->dev, acb->uncache_size, acb->dma_coherent, acb->dma_coherent_handle);
2104 }
2105

Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki