Skip to contentSkip to conversation

linux: Manage the kernel patches using the BSP system

PATCH Superseded Ryan Eatmon 3 participants 5 messages Jul 18, 2024 – Jul 20, 2024 1 message not in the archive

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 linux: Manage the kernel patches using the BSP system

Applying the patches to all kernels is not going to work. Each kernel might need different patches to address reproducibility issues.

---
 meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)
meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc +8 -4
index f24fbe51..8bb30d40 100644
@@ -13,8 +13,12 @@ EXTRA_DTC_ARGS += "${@get_extra_dtc_args(d)}"
 KERNEL_DTBDEST = "${KERNEL_IMAGEDEST}/dtb"
 KERNEL_DTBVENDORED = "1"
 
-SRC_URI:append = " \
-file://0001-lib-build_OID_registry-fix-reproducibility-issues.patch \
-file://0001-vt-conmakehash-improve-reproducibility.patch \
-file://0001-pnmtologo-use-relocatable-file-name.patch \
+KERNEL_PATCHES = ""
+
+KERNEL_PATCHES:bsp-ti-6.6 = " \
+    file://0001-lib-build_OID_registry-fix-reproducibility-issues.patch \
+    file://0001-vt-conmakehash-improve-reproducibility.patch \
+    file://0001-pnmtologo-use-relocatable-file-name.patch \
 "
+
+SRC_URI:append = " ${KERNEL_PATCHES} "
Signature · 1 line
2.17.1
#1 lore raw

Hi Ryan,

Quoted 22 lines · Ryan Eatmon via lists.yoctoproject.org

Applying the patches to all kernels is not going to work. Each kernel might need different patches to address reproducibility issues. Signed-off-by: Ryan Eatmon <reatmon@ ti. com> --- meta-ti-bsp/recipes-kernel/linux/ti-kernel. inc | 12 ZjQcmQRYFpfptBannerStart
This message was sent from outside of Texas Instruments.
Do not click links or open attachments unless you recognize the source of this email and know the content is safe. If you wish to report this message to IT Security, please forward the message as an attachment to [email protected] ZjQcmQRYFpfptBannerEnd
Applying the patches to all kernels is not going to work. Each kernel
might need different patches to address reproducibility issues.

---
  meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc | 12 ++++++++----
  1 file changed, 8 insertions(+), 4 deletions(-)
meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc +0 -1
index f24fbe51..8bb30d40 100644
@@ -13,8 +13,12 @@ EXTRA_DTC_ARGS += "${@get_extra_dtc_args(d)}"
  KERNEL_DTBDEST = "${KERNEL_IMAGEDEST}/dtb"
  KERNEL_DTBVENDORED = "1"
 
-SRC_URI:append = " \

meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc EXTRA_DTC_ARGS += "${@get_extra_dtc_args(d)}" · line 22

Quoted 10 lines
meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc +6 -3
-file://0001-lib-build_OID_registry-fix-reproducibility-issues.patch \
-file://0001-vt-conmakehash-improve-reproducibility.patch \
-file://0001-pnmtologo-use-relocatable-file-name.patch \
+KERNEL_PATCHES = ""
+
+KERNEL_PATCHES:bsp-ti-6.6 = " \
+    file://0001-lib-build_OID_registry-fix-reproducibility-issues.patch \
+    file://0001-vt-conmakehash-improve-reproducibility.patch \
+    file://0001-pnmtologo-use-relocatable-file-name.patch \
  "

The patch title says [master/scarthgap] but I don't see these patches in scarthgap getting applied [1] Additionally the patches itself are missing in scarthgap branch [2]
Are they applicable to scarthgap?

[1]: https://git.ti.com/cgit/arago-project/meta-ti/tree/meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc?h=scarthgap

[2]: https://git.ti.com/cgit/arago-project/meta-ti/tree/meta-ti-bsp/recipes-kernel/linux/files?h=scarthgap

Quoted 14 lines
meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc +2 -0
+
+SRC_URI:append = " ${KERNEL_PATCHES} "
Signature · 10 lines
2.17.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#17888): https://urldefense.com/v3/__https://lists.yoctoproject.org/g/meta-ti/message/17888__;!!G3vK!T7Z2BA-Nk4Deu1oupZmJqJKhIHqoFGbruxASymNM3q5ISnIEShmzH_rXiNv1sd9t5IPUFAeq1MVZGvxkGY-um1_ZJzYlEx9Q0w$
Mute This Topic: https://urldefense.com/v3/__https://lists.yoctoproject.org/mt/107421992/7030289__;!!G3vK!T7Z2BA-Nk4Deu1oupZmJqJKhIHqoFGbruxASymNM3q5ISnIEShmzH_rXiNv1sd9t5IPUFAeq1MVZGvxkGY-um1_ZJzYHEViZow$
Group Owner: [email protected]
Unsubscribe: https://urldefense.com/v3/__https://lists.yoctoproject.org/g/meta-ti/unsub__;!!G3vK!T7Z2BA-Nk4Deu1oupZmJqJKhIHqoFGbruxASymNM3q5ISnIEShmzH_rXiNv1sd9t5IPUFAeq1MVZGvxkGY-um1_ZJzb2hPAKdA$  [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
#2 lore raw
Quoted 30 lines · Chirag Shilwant

Hi Ryan,

Quoted 28 lines · Ryan Eatmon via lists.yoctoproject.org

Applying the patches to all kernels is not going to work. Each kernel might need different patches to address reproducibility issues. Signed-off-by: Ryan Eatmon <reatmon@ ti. com> --- meta-ti-bsp/recipes-kernel/linux/ti-kernel. inc | 12 ZjQcmQRYFpfptBannerStart
This message was sent from outside of Texas Instruments.
Do not click links or open attachments unless you recognize the source of this email and know the content is safe. If you wish to report this message to IT Security, please forward the message as an attachment to [email protected] ZjQcmQRYFpfptBannerEnd
Applying the patches to all kernels is not going to work.  Each kernel
might need different patches to address reproducibility issues.

---
  meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc | 12 ++++++++----

  1 file changed, 8 insertions(+), 4 deletions(-)
meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc +0 -0
index f24fbe51..8bb30d40 100644
@@ -13,8 +13,12 @@ EXTRA_DTC_ARGS += "${@get_extra_dtc_args(d)}"

  KERNEL_DTBDEST = "${KERNEL_IMAGEDEST}/dtb"
  KERNEL_DTBVENDORED = "1"

meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc +4 -4
-SRC_URI:append = " \
-file://0001-lib-build_OID_registry-fix-reproducibility-issues.patch \
-file://0001-vt-conmakehash-improve-reproducibility.patch \
-file://0001-pnmtologo-use-relocatable-file-name.patch \
+KERNEL_PATCHES = ""
+
+KERNEL_PATCHES:bsp-ti-6.6 = " \
+    
Quoted 8 lines
Quoted 4 lines

file://0001-lib-build_OID_registry-fix-reproducibility-issues.patch \
+    file://0001-vt-conmakehash-improve-reproducibility.patch \
+    file://0001-pnmtologo-use-relocatable-file-name.patch \
  "

The patch title says [master/scarthgap] but I don't see these patches in scarthgap getting applied

I'll look into it. I've been a little preoccupied with master this week, but I'll take a look today.

[1]

Quoted 2 lines

Additionally the patches itself are missing in scarthgap branch [2] Are they applicable to scarthgap?

Yes, they are.

Quoted 20 lines

[1]: https://git.ti.com/cgit/arago-project/meta-ti/tree/meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc?h=scarthgap

[2]: https://git.ti.com/cgit/arago-project/meta-ti/tree/meta-ti-bsp/recipes-kernel/linux/files?h=scarthgap

Quoted 14 lines
meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc +2 -0
+
+SRC_URI:append = " ${KERNEL_PATCHES} "
Signature · 10 lines
2.17.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#17888): https://urldefense.com/v3/__https://lists.yoctoproject.org/g/meta-ti/message/17888__;!!G3vK!T7Z2BA-Nk4Deu1oupZmJqJKhIHqoFGbruxASymNM3q5ISnIEShmzH_rXiNv1sd9t5IPUFAeq1MVZGvxkGY-um1_ZJzYlEx9Q0w$
Mute This Topic: https://urldefense.com/v3/__https://lists.yoctoproject.org/mt/107421992/7030289__;!!G3vK!T7Z2BA-Nk4Deu1oupZmJqJKhIHqoFGbruxASymNM3q5ISnIEShmzH_rXiNv1sd9t5IPUFAeq1MVZGvxkGY-um1_ZJzYHEViZow$
Group Owner: [email protected]
Unsubscribe: https://urldefense.com/v3/__https://lists.yoctoproject.org/g/meta-ti/unsub__;!!G3vK!T7Z2BA-Nk4Deu1oupZmJqJKhIHqoFGbruxASymNM3q5ISnIEShmzH_rXiNv1sd9t5IPUFAeq1MVZGvxkGY-um1_ZJzb2hPAKdA$  [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
Signature · 3 lines
Ryan Eatmon                [email protected]
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS

A message that is not in the archive (sent off-list or not yet received): [email protected]

#4 lore raw
Quoted 18 lines · Ryan Eatmon via lists.yoctoproject.org
Quoted 15 lines · Chirag Shilwant

Hi Ryan,

Quoted 13 lines · Ryan Eatmon via lists.yoctoproject.org

Applying the patches to all kernels is not going to work. Each kernel might need different patches to address reproducibility issues. Signed-off-by: Ryan Eatmon <reatmon@ ti. com> --- meta-ti-bsp/recipes-kernel/linux/ti-kernel. inc | 12 ZjQcmQRYFpfptBannerStart
This message was sent from outside of Texas Instruments.
Do not click links or open attachments unless you recognize the source of this email and know the content is safe. If you wish to report this message to IT Security, please forward the message as an attachment to [email protected] ZjQcmQRYFpfptBannerEnd
Applying the patches to all kernels is not going to work.  Each kernel
might need different patches to address reproducibility issues.

---
  meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc | 12 ++++++++----

  1 file changed, 8 insertions(+), 4 deletions(-)
Quoted 14 lines
Quoted 6 lines
Quoted 6 lines
meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc +0 -0
index f24fbe51..8bb30d40 100644
@@ -13,8 +13,12 @@ EXTRA_DTC_ARGS += "${@get_extra_dtc_args(d)}"

  KERNEL_DTBDEST = "${KERNEL_IMAGEDEST}/dtb"

Quoted 8 lines

meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc EXTRA_DTC_ARGS += "${@get_extra_dtc_args(d)}" · line 18

Quoted 8 lines

  KERNEL_DTBVENDORED = "1"

meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc +3 -4
-SRC_URI:append = " \
-file://0001-lib-build_OID_registry-fix-reproducibility-issues.patch \
-file://0001-vt-conmakehash-improve-reproducibility.patch \
-file://0001-pnmtologo-use-relocatable-file-name.patch \
+KERNEL_PATCHES = ""
+
+KERNEL_PATCHES:bsp-ti-6.6 = " \

This is wrong. Should be bsp-ti-6_6. Still not used to the name scheme for this. I'll send a v2.

Quoted 44 lines
Quoted 8 lines
Quoted 4 lines

+ file://0001-lib-build_OID_registry-fix-reproducibility-issues.patch \
+    file://0001-vt-conmakehash-improve-reproducibility.patch \
+    file://0001-pnmtologo-use-relocatable-file-name.patch \
  "

The patch title says [master/scarthgap] but I don't see these patches in scarthgap getting applied

I'll look into it.  I've been a little preoccupied with master this week, but I'll take a look today.

 [1]

Quoted 2 lines

Additionally the patches itself are missing in scarthgap branch [2] Are they applicable to scarthgap?

Yes, they are.

Quoted 6 lines

[1]: https://git.ti.com/cgit/arago-project/meta-ti/tree/meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc?h=scarthgap

[2]: https://git.ti.com/cgit/arago-project/meta-ti/tree/meta-ti-bsp/recipes-kernel/linux/files?h=scarthgap

Quoted 8 lines
Quoted 8 lines
meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc +2 -0
+
+SRC_URI:append = " ${KERNEL_PATCHES} "
Signature · 1 line
2.17.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#17890): https://lists.yoctoproject.org/g/meta-ti/message/17890
Mute This Topic: https://lists.yoctoproject.org/mt/107421992/6551054
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 3 lines
Ryan Eatmon                [email protected]
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS
#5 lore raw
Quoted 37 lines · Ryan Eatmon via lists.yoctoproject.org
Quoted 34 lines · Ryan Eatmon via lists.yoctoproject.org
Quoted 31 lines · Chirag Shilwant

Hi Ryan,

Quoted 29 lines · Ryan Eatmon via lists.yoctoproject.org

Applying the patches to all kernels is not going to work. Each kernel might need different patches to address reproducibility issues. Signed-off-by: Ryan Eatmon <reatmon@ ti. com> --- meta-ti-bsp/recipes-kernel/linux/ti-kernel. inc | 12 ZjQcmQRYFpfptBannerStart
This message was sent from outside of Texas Instruments.
Do not click links or open attachments unless you recognize the source of this email and know the content is safe. If you wish to report this message to IT Security, please forward the message as an attachment to [email protected] ZjQcmQRYFpfptBannerEnd
Applying the patches to all kernels is not going to work.  Each kernel might need different patches to address reproducibility issues.

---
  meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc | 12 ++++++++----

  1 file changed, 8 insertions(+), 4 deletions(-)
meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc +0 -0
index f24fbe51..8bb30d40 100644
@@ -13,8 +13,12 @@ EXTRA_DTC_ARGS += "${@get_extra_dtc_args(d)}"

  KERNEL_DTBDEST = "${KERNEL_IMAGEDEST}/dtb"
  KERNEL_DTBVENDORED = "1"

meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc +0 -2
-SRC_URI:append = " \
-file://0001-lib-build_OID_registry-fix-reproducibility-issues.patch \
Quoted 8 lines
Quoted 5 lines
Quoted 5 lines

meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc EXTRA_DTC_ARGS += "${@get_extra_dtc_args(d)}" · line 18

Quoted 5 lines
meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc +3 -2
-file://0001-vt-conmakehash-improve-reproducibility.patch \
-file://0001-pnmtologo-use-relocatable-file-name.patch \
+KERNEL_PATCHES = ""
+
+KERNEL_PATCHES:bsp-ti-6.6 = " \

This is wrong. Should be bsp-ti-6_6. Still not used to the name scheme for this. I'll send a v2.

Yeah, this is an override, hence the number of special characters is limited - had to replace dot with underscore...

Quoted 31 lines
Quoted 31 lines
Quoted 9 lines
Quoted 4 lines

+ file://0001-lib-build_OID_registry-fix-reproducibility-issues.patch \
+    file://0001-vt-conmakehash-improve-reproducibility.patch \
+    file://0001-pnmtologo-use-relocatable-file-name.patch \
  "

The patch title says [master/scarthgap] but I don't see these patches in scarthgap getting applied

I'll look into it.  I've been a little preoccupied with master this week, but I'll take a look today.

 [1]

Quoted 2 lines

Additionally the patches itself are missing in scarthgap branch [2] Are they applicable to scarthgap?

Yes, they are.

Quoted 10 lines

[1]: https://git.ti.com/cgit/arago-project/meta-ti/tree/meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc?h=scarthgap

[2]: https://git.ti.com/cgit/arago-project/meta-ti/tree/meta-ti-bsp/recipes-kernel/linux/files?h=scarthgap

Quoted 4 lines
meta-ti-bsp/recipes-kernel/linux/ti-kernel.inc +2 -0
+
+SRC_URI:append = " ${KERNEL_PATCHES} "
Signature · 1 line
2.17.1