Skip to contentSkip to conversation

drm/nouveau/volt/gk104: Move assignment outside if condition

PATCH New [email protected] 1 participant 1 message Jul 11, 2023 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 drm/nouveau/volt/gk104: Move assignment outside if condition

Fixes the following checkpatch errors:

ERROR: do not use assignment in if condition

---
 drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk104.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk104.c +2 -1
index d1ce4309cfb8..35ab4fa5d18e 100644
@@ -113,7 +113,8 @@ gk104_volt_new(struct nvkm_device *device, enum nvkm_subdev_type type, int inst,
         volt_func = &gk104_volt_pwm;
     }
 
-    if (!(volt = kzalloc(sizeof(*volt), GFP_KERNEL)))
+    volt = kzalloc(sizeof(*volt), GFP_KERNEL);
+    if (!volt)
         return -ENOMEM;
     nvkm_volt_ctor(volt_func, device, type, inst, &volt->base);
     *pvolt = &volt->base;