mm: swap: Use memset to fill the swap_map with SWAP_HAS_CACHE
Friendly ping.
Quoted 32 lines
We could use helper memset to fill the
swap_mapwithSWAP_HAS_CACHEinstead of a direct loop here to simplify the code. Also we can remove the local variable i and map this way.Signed-off-by Miaohe Lin <[email protected]>--- mm/swapfile.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)mm/swapfile.c +1
-2@@ -975,8 +975,7 @@ static int swap_alloc_cluster(struct swap_info_struct *si, swp_entry_t *slot) {unsigned long idx;struct swap_cluster_info *ci; -unsigned long offset, i; -unsigned char *map; +unsigned long offset;/* * Should not even be attempting cluster allocations when huge @@ -996,9 +995,7 @@ static int swap_alloc_cluster(struct swap_info_struct *si, swp_entry_t *slot) alloc_cluster(si, idx); mm/swapfile.c +1
-4cluster_set_count_flag (ci,SWAPFILE_CLUSTER ,CLUSTER_FLAG_HUGE ); - map = si->swap_map + offset; -for (i =0 ; i <SWAPFILE_CLUSTER ; i++) - map[i] =SWAP_HAS_CACHE ; +memset (si->swap_map + offset,SWAP_HAS_CACHE ,SWAPFILE_CLUSTER );unlock_cluster (ci);swap_range_alloc (si, offset,SWAPFILE_CLUSTER ); *slot =swp_entry (si->type, offset); --2.19.1