mm/page_alloc: simplify lowmem_reserve max calculation
Subsystems (2)
PATCH v2 1/1 mm/page_alloc: simplify lowmem_reserve max calculation
From: Ye Liu <[email protected]>
Use max() to find the maximum lowmem_reserve value and min_t() to cap it to managed_pages in calculate_totalreserve_pages(), instead of open-coding the comparisons. No functional change.
Changes in v2:
- Drop unnecessary braces
- Replace "if (max > managed_pages)" with min_t()
- Link to v1:https://lore.kernel.org/all/[email protected]/
--- mm/page_alloc.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)
mm/page_alloc.c +3 -6
@@ -6235,16 +6235,13 @@ static void calculate_totalreserve_pages(void)unsigned long managed_pages =zone_managed_pages (zone);/* Find valid and maximum lowmem_reserve in the zone */ -for (j = i; j <MAX_NR_ZONES ; j++) { -if (zone->lowmem_reserve[j] > max) - max = zone->lowmem_reserve[j]; - } +for (j = i; j <MAX_NR_ZONES ; j++) + max =max (max, zone->lowmem_reserve[j]);/* we treat the high watermark as reserved pages. */ max +=high_wmark_pages (zone); -if (max > managed_pages) - max = managed_pages; + min_t(unsigned long, max, managed_pages); pgdat->totalreserve_pages += max;
Signature · 1 line
2.43.0
Zi Yan
reviewerQuoted 29 lines · Ye Liu
From: Ye Liu <[email protected]>
Use
max()to find the maximumlowmem_reservevalue andmin_t()to cap it tomanaged_pagesincalculate_totalreserve_pages(), instead of open-coding the comparisons. No functional change.Signed-off-by Ye Liu <[email protected]>Acked-by Johannes Weiner <[email protected]>Acked-by Zi Yan <[email protected]>Changes in v2:
- Drop unnecessary braces
- Replace "if (max >managed_pages)" withmin_t()
- Link to v1:https://lore.kernel.org/all/[email protected]/--- mm/page_alloc.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)mm/page_alloc.c +0
-3@@ -6235,16 +6235,13 @@ static void calculate_totalreserve_pages(void)unsigned long managed_pages =zone_managed_pages (zone);/* Find valid and maximum lowmem_reserve in the zone */ -for (j = i; j <MAX_NR_ZONES ; j++) { -if (zone->lowmem_reserve[j] > max) - max = zone->lowmem_reserve[j];
mm/page_alloc.c static void calculate_totalreserve_pages(void) · line 6244
Quoted 10 lines
mm/page_alloc.c +3
-3- } +for (j = i; j <MAX_NR_ZONES ; j++) + max =max (max, zone->lowmem_reserve[j]);/* we treat the high watermark as reserved pages. */ max +=high_wmark_pages (zone); -if (max > managed_pages) - max = managed_pages; + min_t(unsigned long, max, managed_pages);
Should be
max = min_t(unsigned long, max, managed_pages);
;)
Quoted 5 lines
mm/page_alloc.c +0
-0pgdat->totalreserve_pages += max;Signature · 1 line
2.43.0
Best Regards,
Yan, Zi
Quoted 44 lines · Zi Yan
Quoted 29 lines · Ye Liu
From: Ye Liu <[email protected]>
Use
max()to find the maximumlowmem_reservevalue andmin_t()to cap it tomanaged_pagesincalculate_totalreserve_pages(), instead of open-coding the comparisons. No functional change.Signed-off-by Ye Liu <[email protected]>Acked-by Johannes Weiner <[email protected]>Acked-by Zi Yan <[email protected]>Changes in v2:
- Drop unnecessary braces
- Replace "if (max >managed_pages)" withmin_t()
- Link to v1:https://lore.kernel.org/all/[email protected]/--- mm/page_alloc.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)mm/page_alloc.c +0
-3@@ -6235,16 +6235,13 @@ static void calculate_totalreserve_pages(void)unsigned long managed_pages =zone_managed_pages (zone);/* Find valid and maximum lowmem_reserve in the zone */ -for (j = i; j <MAX_NR_ZONES ; j++) { -if (zone->lowmem_reserve[j] > max) - max = zone->lowmem_reserve[j];mm/page_alloc.c static void calculate_totalreserve_pages(void) · line 6244
Quoted 10 lines
mm/page_alloc.c +3
-3- } +for (j = i; j <MAX_NR_ZONES ; j++) + max =max (max, zone->lowmem_reserve[j]);/* we treat the high watermark as reserved pages. */ max +=high_wmark_pages (zone); -if (max > managed_pages) - max = managed_pages; + min_t(unsigned long, max, managed_pages);Should be
Quoted 3 lines
max =
min_t(unsigned long, max, managed_pages);;)
Haha I forgot to git add after I modified it ;)
Quoted 10 lines
Quoted 6 lines
mm/page_alloc.c +0
-0pgdat->totalreserve_pages += max;Signature · 1 line
2.43.0Best Regards,
Yan, Zi
Signature · 2 lines
Thanks, Ye Liu