Skip to contentSkip to conversation

xl: do not return to caller from monitoring daemon

PATCH In review Ian Campbell 2 participants 2 messages Sep 3, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xl: do not return to caller from monitoring daemon

# HG changeset patch
# User Ian Campbell <[email protected]> # Date 1283529150 -3600
# Node ID be28cc7f45bbe2a592b2405e3130c8e537859ba8 # Parent f2c0e187de98560ed6c7104cf6b2d4f9291b4704
xl: do not return to caller from monitoring daemon

The parent process will have returned to the caller and done whatever is necessary. The daemon should not return otherwise it will repeat this work. In the case of the migration receiver this causes it to try and take part in the migration protocol long after the sender+parent process have completed it, leading to confusing error messages (although strangely not much actual damange).

tools/libxl/xl_cmdimpl.c +6 -0
diff -r f2c0e187de98 -r be28cc7f45bb tools/libxl/xl_cmdimpl.c
@@ -1635,6 +1635,12 @@ out:
 
     free(config_data);
 
+    /*
+     * If we have daemonized then do not return to the caller -- this
+     * has already happened in the parent.
+     */
+    if ( !need_daemon )
+        exit(ret);
     return ret;
 }
#1 lore raw

Ian Campbell writes ("[Xen-devel] [PATCH] xl: do not return to caller from monitoring daemon"):

Quoted 8 lines

xl: do not return to caller from monitoring daemon

The parent process will have returned to the caller and done whatever is necessary. The daemon should not return otherwise it will repeat this work. In the case of the migration receiver this causes it to try and take part in the migration protocol long after the sender+parent process have completed it, leading to confusing error messages (although strangely not much actual damange).

How exciting.

Unfortunately your patch doesn't apply any more because of fde833c66948.

Ian.