gpio: mb86s7x: Enable ACPI support
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 5 lines · tip-bot for Ard Biesheuvel
Committer: Marc Zyngier <[email protected]> CommitDate: Wed, 29 May 2019 10:42:19 +0100gpio: mb86s7x: Enable ACPI support
Quoted 8 lines
Make the mb86s7x GPIO block discoverable via ACPI. In addition, add support for ACPI GPIO interrupts routed via platform interrupts, by wiring the two together via the
to_irq()gpiochip callback.Reviewed-by Linus Walleij <[email protected]>Reviewed-by Mika Westerberg <[email protected]>Signed-off-by Ard Biesheuvel <[email protected]>Signed-off-by Marc Zyngier <[email protected]>
OK!
Review
Quoted 2 lines
(quoted diff) +2
-0+#include "gpiolib.h" +
But this isn't needed anymore, is it?
I can try to remember to remove it later though.
Yours,
Linus Walleij
Quoted 17 lines · Linus Walleij
Quoted 5 lines · tip-bot for Ard Biesheuvel
Committer: Marc Zyngier <[email protected]> CommitDate: Wed, 29 May 2019 10:42:19 +0100gpio: mb86s7x: Enable ACPI support
Quoted 8 lines
Make the mb86s7x GPIO block discoverable via ACPI. In addition, add support for ACPI GPIO interrupts routed via platform interrupts, by wiring the two together via the
to_irq()gpiochip callback.Reviewed-by Linus Walleij <[email protected]>Reviewed-by Mika Westerberg <[email protected]>Signed-off-by Ard Biesheuvel <[email protected]>Signed-off-by Marc Zyngier <[email protected]>
Quoted 6 lines
OK!
Review
Quoted 2 lines
(quoted diff) +2
-0+#include "gpiolib.h" +But this isn't needed anymore, is it?
You tell me! ;-)
Quoted 1 line
I can try to remember to remove it later though.
Yeah, please send a separate patch. tip is stable, and we can't roll this back.
Thanks,
M.
Signature · 1 line
Jazz is not dead. It just smells funny...
Quoted 25 lines · Marc Zyngier
Quoted 17 lines · Linus Walleij
Quoted 5 lines · tip-bot for Ard Biesheuvel
Committer: Marc Zyngier <[email protected]> CommitDate: Wed, 29 May 2019 10:42:19 +0100gpio: mb86s7x: Enable ACPI support
Quoted 8 lines
Make the mb86s7x GPIO block discoverable via ACPI. In addition, add support for ACPI GPIO interrupts routed via platform interrupts, by wiring the two together via the
to_irq()gpiochip callback.Reviewed-by Linus Walleij <[email protected]>Reviewed-by Mika Westerberg <[email protected]>Signed-off-by Ard Biesheuvel <[email protected]>Signed-off-by Marc Zyngier <[email protected]>Quoted 6 lines
OK!
Review
Quoted 2 lines
(quoted diff) +2
-0+#include "gpiolib.h" +But this isn't needed anymore, is it?
Quoted 6 lines
You tell me! ;-)
Quoted 1 line
I can try to remember to remove it later though.
Yeah, please send a separate patch. tip is stable, and we can't roll this back.
I'll just fix it in the GPIO tree after -rc1.
Made a personal TODO note!
Yours,
Linus Walleij
Quoted 29 lines · Linus Walleij
Quoted 27 lines · Marc Zyngier
Quoted 17 lines · Linus Walleij
Quoted 5 lines · tip-bot for Ard Biesheuvel
Committer: Marc Zyngier <[email protected]> CommitDate: Wed, 29 May 2019 10:42:19 +0100gpio: mb86s7x: Enable ACPI support
Quoted 8 lines
Make the mb86s7x GPIO block discoverable via ACPI. In addition, add support for ACPI GPIO interrupts routed via platform interrupts, by wiring the two together via the
to_irq()gpiochip callback.Reviewed-by Linus Walleij <[email protected]>Reviewed-by Mika Westerberg <[email protected]>Signed-off-by Ard Biesheuvel <[email protected]>Signed-off-by Marc Zyngier <[email protected]>Quoted 6 lines
OK!
Review
Quoted 2 lines
(quoted diff) +2
-0+#include "gpiolib.h" +But this isn't needed anymore, is it?
You tell me! ;-)
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
I can try to remember to remove it later though.
Yeah, please send a separate patch. tip is stable, and we can't roll this back.
I'll just fix it in the GPIO tree after -rc1.
Made a personal TODO note!
Why wouldn't it be needed anymore?
Quoted 32 lines · Ard Biesheuvel
Quoted 31 lines · Linus Walleij
Quoted 29 lines · Marc Zyngier
Quoted 17 lines · Linus Walleij
Quoted 5 lines · tip-bot for Ard Biesheuvel
Committer: Marc Zyngier <[email protected]> CommitDate: Wed, 29 May 2019 10:42:19 +0100gpio: mb86s7x: Enable ACPI support
Quoted 8 lines
Make the mb86s7x GPIO block discoverable via ACPI. In addition, add support for ACPI GPIO interrupts routed via platform interrupts, by wiring the two together via the
to_irq()gpiochip callback.Reviewed-by Linus Walleij <[email protected]>Reviewed-by Mika Westerberg <[email protected]>Signed-off-by Ard Biesheuvel <[email protected]>Signed-off-by Marc Zyngier <[email protected]>Quoted 6 lines
OK!
Review
Quoted 2 lines
(quoted diff) +2
-0+#include "gpiolib.h" +But this isn't needed anymore, is it?
You tell me! ;-)
Quoted 1 line
I can try to remember to remove it later though.
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
Yeah, please send a separate patch. tip is stable, and we can't roll this back.
I'll just fix it in the GPIO tree after -rc1.
Made a personal TODO note!Why wouldn't it be needed anymore?
I looked over the code like 5 times and I can't see it touching any gpiolib internals anymore, but maybe I'm still wrong?
Normally GPIO drivers should get all symbols it needs from <linux/gpio/driver.h> and "gpiolib.h" is not something drivers should include.
Anyways I will get to know from compile tests if I'm wrong.
Yours,
Linus Walleij
Quoted 42 lines · Linus Walleij
Quoted 32 lines · Ard Biesheuvel
Quoted 31 lines · Linus Walleij
Quoted 29 lines · Marc Zyngier
Quoted 17 lines · Linus Walleij
Quoted 5 lines · tip-bot for Ard Biesheuvel
Committer: Marc Zyngier <[email protected]> CommitDate: Wed, 29 May 2019 10:42:19 +0100gpio: mb86s7x: Enable ACPI support
Quoted 8 lines
Make the mb86s7x GPIO block discoverable via ACPI. In addition, add support for ACPI GPIO interrupts routed via platform interrupts, by wiring the two together via the
to_irq()gpiochip callback.Reviewed-by Linus Walleij <[email protected]>Reviewed-by Mika Westerberg <[email protected]>Signed-off-by Ard Biesheuvel <[email protected]>Signed-off-by Marc Zyngier <[email protected]>Quoted 6 lines
OK!
Review
Quoted 2 lines
(quoted diff) +2
-0+#include "gpiolib.h" +But this isn't needed anymore, is it?
You tell me! ;-)
Quoted 1 line
I can try to remember to remove it later though.
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
Yeah, please send a separate patch. tip is stable, and we can't roll this back.
I'll just fix it in the GPIO tree after -rc1.
Made a personal TODO note!Why wouldn't it be needed anymore?
Quoted 9 lines
I looked over the code like 5 times and I can't see it touching any gpiolib internals anymore, but maybe I'm still wrong?
Normally GPIO drivers should get all symbols it needs from <
linux/gpio/driver.h> and "gpiolib.h" is not something drivers should include.Anyways I will get to know from compile tests if I'm wrong.
IIRC it had something to do with the ACPI helpers that this driver calls directly.