Skip to contentSkip to conversation

MAINTAINERS: Update DW 8250 UART maintainership

PATCH In review Ilpo Järvinen 7 participants 8 messages Jun 17, 2022 – Jun 20, 2022 TTY layer and serial drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MAINTAINERS: Update DW 8250 UART maintainership

Add myself as maintainer for DW 8250 UART and up it to Supported.

---
 MAINTAINERS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
MAINTAINERS +2 -1
index a6d3bd9d2a8d..6c90484f395b 100644
@@ -19230,8 +19230,9 @@ F:	Documentation/devicetree/bindings/gpio/snps,creg-gpio.txt
 F:	drivers/gpio/gpio-creg-snps.c
 
 SYNOPSYS DESIGNWARE 8250 UART DRIVER
+M:	Ilpo Järvinen <[email protected]>
 R:	Andy Shevchenko <[email protected]>
-S:	Maintained
+S:	Supported
 F:	drivers/tty/serial/8250/8250_dw.c
 F:	drivers/tty/serial/8250/8250_dwlib.*
 F:	drivers/tty/serial/8250/8250_lpss.c
Signature · 1 line
tg: (f2906aa86338..) dw/maintainer (depends on: tty-next)
#1 lore raw
Quoted 3 lines · Ilpo Järvinen

Add myself as maintainer for DW 8250 UART and up it to Supported.

Obviously I need an ack from Andy too. And thanks for doing this and all the work you have already done so far, it's appreciated.

greg k-h

#2 lore raw
Quoted 6 lines · Greg Kroah-Hartman
Quoted 3 lines · Ilpo Järvinen

Add myself as maintainer for DW 8250 UART and up it to Supported.

Obviously I need an ack from Andy too.

I just gave my Rb, but just in case

Quoted 2 lines

And thanks for doing this and
all the work you have already done so far, it's appreciated.

+1 and many, thanks, Ilpo!

Signature · 2 lines
With Best Regards,
Andy Shevchenko
Reviewed-by on v1 1/1
#3 lore raw
In reply to Ilpo Järvinen
Quoted 2 lines · Ilpo Järvinen

Add myself as maintainer for DW 8250 UART and up it to Supported.

Thanks!

Quoted 24 lines
---
 MAINTAINERS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
MAINTAINERS +2 -2
index a6d3bd9d2a8d..6c90484f395b 100644
@@ -19230,8 +19230,9 @@ F:      Documentation/devicetree/bindings/gpio/snps,creg-gpio.txt
 F:     drivers/gpio/gpio-creg-snps.c
 
 SYNOPSYS DESIGNWARE 8250 UART DRIVER
+M:     Ilpo Järvinen <[email protected]>
 R:     Andy Shevchenko <[email protected]>
-S:     Maintained
+S:     Supported
 F:     drivers/tty/serial/8250/8250_dw.c
 F:     drivers/tty/serial/8250/8250_dwlib.*
 F:     drivers/tty/serial/8250/8250_lpss.c
 
--

tg: (f2906aa86338..) dw/maintainer (depends on: tty-next)

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#4 lore raw
In reply to Ilpo Järvinen
Thank you for the patch! Yet something to improve:

Hi "Ilpo,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.19-rc2 next-20220617]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Ilpo-J-rvinen/MAINTAINERS-Update-DW-8250-UART-maintainership/20220617-174145
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 47700948a4abb4a5ae13ef943ff682a7f327547a
reproduce: make htmldocs

If you fix the issue, kindly add following tag where applicable

All errors (new ones prefixed by >>):

>> 'utf-8' codec can't decode byte 0xe4 in position 1396: invalid continuation byte
Signature · 2 lines
0-DAY CI Kernel Test Service
https://01.org/lkp
#5 lore raw
Quoted 10 lines · kernel test robot

Hi "Ilpo,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.19-rc2 next-20220617]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

Quoted 10 lines
url:    https://github.com/intel-lab-lkp/linux/commits/Ilpo-J-rvinen/MAINTAINERS-Update-DW-8250-UART-maintainership/20220617-174145
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 47700948a4abb4a5ae13ef943ff682a7f327547a
reproduce: make htmldocs

If you fix the issue, kindly add following tag where applicable

All errors (new ones prefixed by >>):

Quoted 1 line
Quoted 1 line

'utf-8' codec can't decode byte 0xe4 in position 1396: invalid continuation byte

?

false positive?

#6 lore raw
Quoted 18 lines · Joe Perches
Quoted 17 lines · kernel test robot

Hi "Ilpo,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.19-rc2 next-20220617]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Ilpo-J-rvinen/MAINTAINERS-Update-DW-8250-UART-maintainership/20220617-174145
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 47700948a4abb4a5ae13ef943ff682a7f327547a
reproduce: make htmldocs

If you fix the issue, kindly add following tag where applicable

Quoted 7 lines
Quoted 3 lines

All errors (new ones prefixed by >>):

Quoted 1 line
Quoted 1 line

'utf-8' codec can't decode byte 0xe4 in position 1396: invalid continuation byte

?

false positive?

Hi,

I tried to apply the patch, and I can reproduce the error by 'make htmldocs':

$ wget -q -O - https://lore.kernel.org/lkml/[email protected]/raw | git apply -v
$ git --no-pager diff
MAINTAINERS +2 -1
index f52543aedd61e..3d64756814f09 100644
@@ -19247,8 +19247,9 @@ F: Documentation/devicetree/bindings/gpio/snps,creg-gpio.txt
 F:     drivers/gpio/gpio-creg-snps.c
 
 SYNOPSYS DESIGNWARE 8250 UART DRIVER
+M:     Ilpo Jrvinen <[email protected]>
 R:     Andy Shevchenko <[email protected]>
-S:     Maintained
+S:     Supported
 F:     drivers/tty/serial/8250/8250_dw.c
 F:     drivers/tty/serial/8250/8250_dwlib.*
 F:     drivers/tty/serial/8250/8250_lpss.c

It seems the special character 'ä' in name 'Ilpo Järvinen' was parsed wrongly.

Best Regards,
Rong Chen

#7 lore raw
Quoted 21 lines · Rong A
Quoted 20 lines · Joe Perches
Quoted 19 lines · kernel test robot

Hi "Ilpo,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.19-rc2 next-20220617]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:
https://github.com/intel-lab-lkp/linux/commits/Ilpo-J-rvinen/MAINTAINERS-Update-DW-8250-UART-maintainership/20220617-174145
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
47700948a4abb4a5ae13ef943ff682a7f327547a
reproduce: make htmldocs

If you fix the issue, kindly add following tag where applicable

Quoted 8 lines
Quoted 8 lines
Quoted 4 lines

All errors (new ones prefixed by >>):

Quoted 2 lines
Quoted 2 lines

'utf-8' codec can't decode byte 0xe4 in position 1396: invalid continuation byte

?

false positive?

This is correctly identified problem, however, the problem is lkp's end. It seemingly fails to handle non-UTF8 encoded emails correctly and just goes to assume the input is UTF8 encoded (w/o checking the Content-Type header).

Quoted 23 lines

I tried to apply the patch, and I can reproduce the error by 'make htmldocs':

$ wget -q -O -
https://lore.kernel.org/lkml/[email protected]/raw
| git apply -v
$ git --no-pager diff
MAINTAINERS +0 -0
index f52543aedd61e..3d64756814f09 100644
@@ -19247,8 +19247,9 @@ F:

Documentation/devicetree/bindings/gpio/snps,creg-gpio.txt
F: drivers/gpio/gpio-creg-snps.c

SYNOPSYS DESIGNWARE 8250 UART DRIVER

MAINTAINERS +2 -1
+M:     Ilpo Jrvinen <[email protected]>
 R:     Andy Shevchenko <[email protected]>
-S:     Maintained
+S:     Supported
 F:     drivers/tty/serial/8250/8250_dw.c
 F:     drivers/tty/serial/8250/8250_dwlib.*
 F:     drivers/tty/serial/8250/8250_lpss.c
Quoted 1 line

It seems the special character 'ä' in name 'Ilpo Järvinen' was parsed wrongly.

The original file was UTF-8 (0xc3 0xa4). The email is correctly encoded ISO 8859-15 as can be see e.g. by downloading this (with a single 0xe4 char):
https://marc.info/?l=linux-kernel&m=165545870203513&q=raw

When saving patch/exporting email, MUA/exporter should do ISO 8859-15 -> UTF-8 conversion. If I export email I sent, I get it back to UTF-8 just fine (as per the locale I've in use).

Just in case, I've attached the original patch file.

I thought git's toolchain these days handles these things fine but it seems not.

Signature · 1 line
 i.

From: Ilpo Järvinen <[email protected]>
Subject: [PATCH] MAINTAINERS: Update DW 8250 UART maintainership

Add myself as maintainer for DW 8250 UART and up it to Supported.

---
 MAINTAINERS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
MAINTAINERS +2 -1
index a6d3bd9d2a8d..6c90484f395b 100644
@@ -19230,8 +19230,9 @@ F:	Documentation/devicetree/bindings/gpio/snps,creg-gpio.txt
 F:	drivers/gpio/gpio-creg-snps.c
 
 SYNOPSYS DESIGNWARE 8250 UART DRIVER
+M:	Ilpo Järvinen <[email protected]>
 R:	Andy Shevchenko <[email protected]>
-S:	Maintained
+S:	Supported
 F:	drivers/tty/serial/8250/8250_dw.c
 F:	drivers/tty/serial/8250/8250_dwlib.*
 F:	drivers/tty/serial/8250/8250_lpss.c
Signature · 1 line
tg: (65534736d9a5..) dw/maintainer (depends on: tty-next)