app/testpmd: fix the sample RSS issue
PATCH 1/1 app/testpmd: fix the sample RSS issue
When the RSS with null key was set in sample actions list, it caused the segmentation fault since the RSS key pointer was NULL while did the memory copy.
This patch adds the RSS key NULL pointer checking before copying to fix the segmentation fault issue.
Fixes 11b1b0eddade ("app/testpmd: support RSS in sample action")
Signed-off-by Jiawei Wang <[email protected]>
--- app/test-pmd/cmdline_flow.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
app/test-pmd/cmdline_flow.c +2 -2
@@ -7885,7 +7885,7 @@ static int comp_set_modify_field_id(struct context *, const struct token *, rss = action->conf;rte_memcpy (&sample_rss_data[idx].conf, (const void *)rss, size); -if (rss->key_len) { +if (rss->key_len && rss->key) { sample_rss_data[idx].conf.key = sample_rss_data[idx].key; rte_memcpy((void *)((uintptr_t)
@@ -7893,7 +7893,7 @@ static int comp_set_modify_field_id(struct context *, const struct token *, (const void *)rss->key, sizeof(uint8_t) * rss->key_len); } -if (rss->queue_num) { +if (rss->queue_num && rss->queue) { sample_rss_data[idx].conf.queue = sample_rss_data[idx].queue; rte_memcpy((void *)((uintptr_t)
Signature · 1 line
1.8.3.1
Quoted 11 lines · Jiawei Wang
When the RSS with null key was set in sample actions list, it caused the segmentation fault since the RSS key pointer was NULL while did the memory copy.
This patch adds the RSS key NULL pointer checking before copying to fix the segmentation fault issue.
Fixes 11b1b0eddade ("app/testpmd: support RSS in sample action")Signed-off-by Jiawei Wang <[email protected]>
Reviewed-by Ferruh Yigit <[email protected]>
Applied to dpdk-next-net/main, thanks.