soc: qcom: PDR_HELPERS, PDR_MSG are independent of QCOM_SOC
Subsystems (2)
PATCH 1/1 soc: qcom: PDR_HELPERS, PDR_MSG are independent of QCOM_SOC
Currently QCOM_PDR_MSG depends on QCOM_SOC (it's inside the "if QCOM_SOC" block). It appears to be independent of QCOM_SOC, as though it was entered in the wrong location in the Kconfig file.
Moving QCOM_PDR_MSG after the end of the QCOM_SOC block fixes the kconfig unmet dependencies warning and survives both randconfig and allmodconfig builds.
WARNING: unmet direct dependencies detected for QCOM_PDR_MSG
Depends on [n]: QCOM_SOC [=n]
Selected by [y]:
- QCOM_PDR_HELPERS [=y] && NET [=y]
Caused by SLIM_QCOM_NGD_CTRL selecting QCOM_PDR_HELPERS.
---
Cc: Bjorn Andersson <[email protected]>
Cc: Konrad Dybcio <[email protected]>
Cc: [email protected]
Cc: Dmitry Baryshkov <[email protected]>
Cc: Arnd Bergmann <[email protected]>
drivers/soc/qcom/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/soc/qcom/Kconfig +3 -3
@@ -90,9 +90,6 @@ config QCOM_PD_MAPPER implementation of the service. It is a simpler alternative to the userspace daemon. -config QCOM_PDR_MSG - tristate - config QCOM_PMIC_PDCHARGER_ULOG tristate "Qualcomm PMIC PDCharger ULOG driver" depends on RPMSG
@@ -297,6 +294,9 @@ endif # Options selected by other drivers from different subsystems must be outside # of the menuconfig if-block: +config QCOM_PDR_MSG + tristate + config QCOM_INLINE_CRYPTO_ENGINE tristate select QCOM_SCM
Quoted 40 lines · Randy Dunlap
Currently
QCOM_PDR_MSGdepends onQCOM_SOC(it's inside the "ifQCOM_SOC" block). It appears to be independent ofQCOM_SOC, as though it was entered in the wrong location in theKconfigfile.Moving
QCOM_PDR_MSGafter the end of theQCOM_SOCblock fixes the kconfig unmet dependencies warning and survives both randconfig and allmodconfig builds.WARNING: unmet direct dependencies detected for
QCOM_PDR_MSG
Depends on [n]:QCOM_SOC[=n]
Selected by [y]:
-QCOM_PDR_HELPERS[=y] && NET [=y]Caused by
SLIM_QCOM_NGD_CTRLselectingQCOM_PDR_HELPERS.Fixes 0ac5c7d933de ("soc: qcom: pdr: extract PDR message marshalling data")Signed-off-by Randy Dunlap <[email protected]>---
Cc: Bjorn Andersson <[email protected]>
Cc: Konrad Dybcio <[email protected]>
Cc: [email protected]
Cc: Dmitry Baryshkov <[email protected]>
Cc: Arnd Bergmann <[email protected]>drivers/soc/qcom/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/soc/qcom/Kconfig +0
-3@@ -90,9 +90,6 @@ config QCOM_PD_MAPPER implementation of the service. It is a simpler alternative to the userspace daemon. -config QCOM_PDR_MSG - tristate - config QCOM_PMIC_PDCHARGER_ULOG tristate "Qualcomm PMIC PDCharger ULOG driver" depends on RPMSG
drivers/soc/qcom/Kconfig endif · line 302
Quoted 9 lines
drivers/soc/qcom/Kconfig +3
-0@@ -297,6 +294,9 @@ endif # Options selected by other drivers from different subsystems must be outside # of the menuconfig if-block: +config QCOM_PDR_MSG + tristate + config QCOM_INLINE_CRYPTO_ENGINE tristate select QCOM_SCM
This is a better solution than my earlier attempt:
https://lore.kernel.org/all/[email protected]/
- Julian Braha