Skip to contentSkip to conversation

dts: arm: socfpga: fix socfpga_de10_nano console

PATCH New Simon Goldschmidt 2 participants 7 messages Apr 29, 2019 – Apr 30, 2019 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dts: arm: socfpga: fix socfpga_de10_nano console

Booting this board failed as the initial console isn't found since commit c402e8170245 ("dts: arm: socfpga: merge gen5 devicetrees from linux")

The uart0 devicetree entry was missing "clock-frequency = <100000000>:" since that commit

Fixes c402e8170245 ("dts: arm: socfpga: merge gen5 devicetrees from linux")

---

 arch/arm/dts/socfpga_cyclone5_de10_nano.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm/dts/socfpga_cyclone5_de10_nano.dts +1 -0
index b620dd8dda..4be4083941 100644
@@ -77,6 +77,7 @@
 };
 
 &uart0 {
+	clock-frequency = <100000000>;
 	u-boot,dm-pre-reloc;
 };
 
Signature · 1 line
2.20.1
Applied
#1 lore raw

PATCH 1/1 dts: arm: socfpga: fix socfpga_de10_nano console

Quoted 20 lines · Simon Goldschmidt

Booting this board failed as the initial console isn't found since commit c402e8170245 ("dts: arm: socfpga: merge gen5 devicetrees from linux")

The uart0 devicetree entry was missing "clock-frequency = <100000000>:" since that commit

Fixes c402e8170245 ("dts: arm: socfpga: merge gen5 devicetrees from linux")

---

 arch/arm/dts/socfpga_cyclone5_de10_nano.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm/dts/socfpga_cyclone5_de10_nano.dts +0 -0
index b620dd8dda..4be4083941 100644

arch/arm/dts/socfpga_cyclone5_de10_nano.dts line 83

Quoted 7 lines
arch/arm/dts/socfpga_cyclone5_de10_nano.dts +1 -0
@@ -77,6 +77,7 @@
 };
 
 &uart0 {
+	clock-frequency = <100000000>;
 	u-boot,dm-pre-reloc;
 };
 

Applied, thanks.

While at it, can we do something about Gen5 clock driver ?

Signature · 2 lines
Best regards,
Marek Vasut
#2 lore raw

PATCH 1/1 dts: arm: socfpga: fix socfpga_de10_nano console

Am 29.04.2019 um 20:33 schrieb Marek Vasut:

Quoted 22 lines · Simon Goldschmidt
Quoted 21 lines

Booting this board failed as the initial console isn't found since commit c402e8170245 ("dts: arm: socfpga: merge gen5 devicetrees from linux")

The uart0 devicetree entry was missing "clock-frequency = <100000000>:" since that commit

Fixes c402e8170245 ("dts: arm: socfpga: merge gen5 devicetrees from linux")

---

  arch/arm/dts/socfpga_cyclone5_de10_nano.dts | 1 +
  1 file changed, 1 insertion(+)
arch/arm/dts/socfpga_cyclone5_de10_nano.dts +0 -0
index b620dd8dda..4be4083941 100644
@@ -77,6 +77,7 @@
  };
 
Quoted 7 lines

arch/arm/dts/socfpga_cyclone5_de10_nano.dts line 83

Quoted 6 lines
arch/arm/dts/socfpga_cyclone5_de10_nano.dts +1 -0
  &uart0 {
+	clock-frequency = <100000000>;
  	u-boot,dm-pre-reloc;
  };
 

Applied, thanks.

Wow, that was fast!

Quoted 2 lines

While at it, can we do something about Gen5 clock driver ?

Which Gen5 clock driver, haha?

I might find the time. Would you think the A10 driver would be a good point to start?

Regards,
Simon

#3 lore raw

PATCH 1/1 dts: arm: socfpga: fix socfpga_de10_nano console

Quoted 35 lines · Simon Goldschmidt

Am 29.04.2019 um 20:33 schrieb Marek Vasut:

Quoted 17 lines · Simon Goldschmidt
Quoted 16 lines

Booting this board failed as the initial console isn't found since commit c402e8170245 ("dts: arm: socfpga: merge gen5 devicetrees from linux")

The uart0 devicetree entry was missing "clock-frequency = <100000000>:" since that commit

Fixes c402e8170245 ("dts: arm: socfpga: merge gen5 devicetrees from

linux")

---

  arch/arm/dts/socfpga_cyclone5_de10_nano.dts | 1 +

  1 file changed, 1 insertion(+)
Quoted 13 lines
Quoted 11 lines
arch/arm/dts/socfpga_cyclone5_de10_nano.dts +1 -0
index b620dd8dda..4be4083941 100644
@@ -77,6 +77,7 @@
   };
     &uart0 {
+    clock-frequency = <100000000>;
       u-boot,dm-pre-reloc;
   };
Quoted 1 line

Applied, thanks.

Wow, that was fast!

Quoted 1 line
Quoted 6 lines
Quoted 1 line

While at it, can we do something about Gen5 clock driver ?

Which Gen5 clock driver, haha?

I might find the time. Would you think the A10 driver would be a good point to start?

For a read-only clock driver, based off DT, yes.

Signature · 2 lines
Best regards,
Marek Vasut
#4 lore raw

PATCH 1/1 dts: arm: socfpga: fix socfpga_de10_nano console

Am 29.04.2019 um 21:23 schrieb Marek Vasut:

Quoted 36 lines · Simon Goldschmidt
Quoted 35 lines

Am 29.04.2019 um 20:33 schrieb Marek Vasut:

Quoted 17 lines · Simon Goldschmidt
Quoted 16 lines

Booting this board failed as the initial console isn't found since commit c402e8170245 ("dts: arm: socfpga: merge gen5 devicetrees from linux")

The uart0 devicetree entry was missing "clock-frequency = <100000000>:" since that commit

Fixes c402e8170245 ("dts: arm: socfpga: merge gen5 devicetrees from

linux")

---

   arch/arm/dts/socfpga_cyclone5_de10_nano.dts | 1 +
   1 file changed, 1 insertion(+)
Quoted 13 lines

arch/arm/dts/socfpga_cyclone5_de10_nano.dts line 82

Quoted 12 lines
arch/arm/dts/socfpga_cyclone5_de10_nano.dts +1 -0
index b620dd8dda..4be4083941 100644
@@ -77,6 +77,7 @@
   };
     &uart0 {
+    clock-frequency = <100000000>;
       u-boot,dm-pre-reloc;
   };
 

Applied, thanks.

Wow, that was fast!

Quoted 1 line
Quoted 8 lines
Quoted 6 lines
Quoted 1 line

While at it, can we do something about Gen5 clock driver ?

Which Gen5 clock driver, haha?

I might find the time. Would you think the A10 driver would be a good point to start?

For a read-only clock driver, based off DT, yes.

Well, that would be a start, using the handoff values from Quartus.

Would it make sense to convert the qts header output for gen5 to a dtsi format like A10? Not only the clock settings, but all information living in the qts directory would be better off in a devicetree.

And in addition, different FPGA configurations require different pinmux/iocsr configurations, which is a thing we haven't covered, yet. I don't want to update SPL just because an FPGA image decides to use loan-IO instead of a HPS GPIO...

However, the bindings from A10 handoff dtsi don't seem in a state to just copy them. (How does that handof dtsi get included anyway?)

Regards,
Simon

#5 lore raw

PATCH 1/1 dts: arm: socfpga: fix socfpga_de10_nano console

Quoted 45 lines · Simon Goldschmidt

Am 29.04.2019 um 21:23 schrieb Marek Vasut:

Quoted 44 lines · Simon Goldschmidt
Quoted 42 lines

Am 29.04.2019 um 20:33 schrieb Marek Vasut:

Quoted 18 lines · Simon Goldschmidt
Quoted 17 lines

Booting this board failed as the initial console isn't found since commit c402e8170245 ("dts: arm: socfpga: merge gen5 devicetrees from linux")

The uart0 devicetree entry was missing "clock-frequency = <100000000>:"
since that commit

Fixes c402e8170245 ("dts: arm: socfpga: merge gen5 devicetrees from

linux")

---

   arch/arm/dts/socfpga_cyclone5_de10_nano.dts | 1 +

   1 file changed, 1 insertion(+)
Quoted 13 lines
Quoted 11 lines
arch/arm/dts/socfpga_cyclone5_de10_nano.dts +1 -0
index b620dd8dda..4be4083941 100644
@@ -77,6 +77,7 @@
    };
      &uart0 {
+    clock-frequency = <100000000>;
        u-boot,dm-pre-reloc;
    };
Quoted 1 line

Applied, thanks.

Wow, that was fast!

Quoted 2 lines

While at it, can we do something about Gen5 clock driver ?

Which Gen5 clock driver, haha?

I might find the time. Would you think the A10 driver would be a good point to start?

Quoted 7 lines
Quoted 1 line

For a read-only clock driver, based off DT, yes.

Well, that would be a start, using the handoff values from Quartus.

Would it make sense to convert the qts header output for gen5 to a dtsi format like A10? Not only the clock settings, but all information living in the qts directory would be better off in a devicetree.

I think so too :)

Quoted 4 lines

And in addition, different FPGA configurations require different pinmux/iocsr configurations, which is a thing we haven't covered, yet. I don't want to update SPL just because an FPGA image decides to use loan-IO instead of a HPS GPIO...

Right ?

Quoted 2 lines

However, the bindings from A10 handoff dtsi don't seem in a state to just copy them. (How does that handof dtsi get included anyway?)

The A10 bindings are ad-hoc mess for sure :)

(What do you mean, how?)

Signature · 2 lines
Best regards,
Marek Vasut
#6 lore raw

PATCH 1/1 dts: arm: socfpga: fix socfpga_de10_nano console

Quoted 62 lines · Marek Vasut
Quoted 45 lines · Simon Goldschmidt

Am 29.04.2019 um 21:23 schrieb Marek Vasut:

Quoted 44 lines · Simon Goldschmidt
Quoted 42 lines

Am 29.04.2019 um 20:33 schrieb Marek Vasut:

Quoted 18 lines · Simon Goldschmidt
Quoted 17 lines

Booting this board failed as the initial console isn't found since commit c402e8170245 ("dts: arm: socfpga: merge gen5 devicetrees from linux")

The uart0 devicetree entry was missing "clock-frequency = <100000000>:"
since that commit

Fixes c402e8170245 ("dts: arm: socfpga: merge gen5 devicetrees from

linux")

---

   arch/arm/dts/socfpga_cyclone5_de10_nano.dts | 1 +
   1 file changed, 1 insertion(+)
Quoted 13 lines

arch/arm/dts/socfpga_cyclone5_de10_nano.dts line 82

Quoted 12 lines
arch/arm/dts/socfpga_cyclone5_de10_nano.dts +1 -0
index b620dd8dda..4be4083941 100644
@@ -77,6 +77,7 @@
   };
     &uart0 {
+    clock-frequency = <100000000>;
       u-boot,dm-pre-reloc;
   };
 

Applied, thanks.

Wow, that was fast!

Quoted 2 lines

While at it, can we do something about Gen5 clock driver ?

Which Gen5 clock driver, haha?

I might find the time. Would you think the A10 driver would be a good point to start?

Quoted 7 lines
Quoted 1 line

For a read-only clock driver, based off DT, yes.

Well, that would be a start, using the handoff values from Quartus.

Would it make sense to convert the qts header output for gen5 to a dtsi format like A10? Not only the clock settings, but all information living in the qts directory would be better off in a devicetree.

I think so too :)

Quoted 4 lines

And in addition, different FPGA configurations require different pinmux/iocsr configurations, which is a thing we haven't covered, yet. I don't want to update SPL just because an FPGA image decides to use loan-IO instead of a HPS GPIO...

Quoted 8 lines

Right ?

Quoted 2 lines

However, the bindings from A10 handoff dtsi don't seem in a state to just copy them. (How does that handof dtsi get included anyway?)

The A10 bindings are ad-hoc mess for sure :)

(What do you mean, how?)

Nevermind, I somehow missed the include line socfpga_arria10_socdk.dtsi.

Regards,
Simon