Skip to contentSkip to conversation

arm64: dts: qcom: sm8550: Add missing interconnect path to USB HC

PATCH Applied Abel Vesa 3 participants 5 messages Jun 1, 2023 – Jun 13, 2023

Subsystems (3)
lore
Share & tools
lore

Abel Vesa

author
#0 lore raw

PATCH 1/1 arm64: dts: qcom: sm8550: Add missing interconnect path to USB HC

The USB HC node is missing the interconnect paths, so add them.

Fixes 7f7e5c1b037f ("arm64: dts: qcom: sm8550: Add USB PHYs and controller nodes")
---
 arch/arm64/boot/dts/qcom/sm8550.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm64/boot/dts/qcom/sm8550.dtsi +4 -0
index 75cd374943eb..4991b2e962d1 100644
@@ -2793,6 +2793,10 @@ usb_1: usb@a6f8800 {
 
 			resets = <&gcc GCC_USB30_PRIM_BCR>;
 
+			interconnects = <&aggre1_noc MASTER_USB3_0 0 &mc_virt SLAVE_EBI1 0>,
+					<&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_USB3_0 0>;
+			interconnect-names = "usb-ddr", "apps-usb";
+
 			status = "disabled";
 
 			usb_1_dwc3: usb@a600000 {
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 3 lines · Abel Vesa

The USB HC node is missing the interconnect paths, so add them.

Fixes 7f7e5c1b037f ("arm64: dts: qcom: sm8550: Add USB PHYs and controller nodes")

For context, it's a fix in the context of "we should prooobably have this if we want to fix the icc driver to include sync state".

Quoted 2 lines

---

sidenote:

on recent SoCs there's also an USB-IPA path:

aggre1_noc MASTER_USB3_0 <-> &config_noc SLAVE_IPA_CFG

I don't think we really make use of that upstream today or whether it would make enabling IPA necessary (to enable the clocks and reach the IPA hardware), but it's something to think about.

Konrad

Quoted 18 lines
 arch/arm64/boot/dts/qcom/sm8550.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm64/boot/dts/qcom/sm8550.dtsi +4 -0
index 75cd374943eb..4991b2e962d1 100644
@@ -2793,6 +2793,10 @@ usb_1: usb@a6f8800 {
 
 			resets = <&gcc GCC_USB30_PRIM_BCR>;
 
+			interconnects = <&aggre1_noc MASTER_USB3_0 0 &mc_virt SLAVE_EBI1 0>,
+					<&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_USB3_0 0>;
+			interconnect-names = "usb-ddr", "apps-usb";
+
 			status = "disabled";
 
 			usb_1_dwc3: usb@a600000 {
author
#2 lore raw
Quoted 8 lines · Konrad Dybcio
Quoted 3 lines · Abel Vesa

The USB HC node is missing the interconnect paths, so add them.

Fixes 7f7e5c1b037f ("arm64: dts: qcom: sm8550: Add USB PHYs and controller nodes")

For context, it's a fix in the context of "we should prooobably have this if we want to fix the icc driver to include sync state".

Fair enough...

Quoted 11 lines
Quoted 2 lines

---

sidenote:

on recent SoCs there's also an USB-IPA path:

aggre1_noc MASTER_USB3_0 <-> &config_noc SLAVE_IPA_CFG

AFAIK, support for IPA on SM8550 is not added yet.

We can worry about this 3rd path when IPA support for this platform is upstreamed.

Quoted 24 lines

I don't think we really make use of that upstream today or whether it would make enabling IPA necessary (to enable the clocks and reach the IPA hardware), but it's something to think about.

Konrad

Quoted 18 lines
 arch/arm64/boot/dts/qcom/sm8550.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm64/boot/dts/qcom/sm8550.dtsi +4 -0
index 75cd374943eb..4991b2e962d1 100644
@@ -2793,6 +2793,10 @@ usb_1: usb@a6f8800 {
 
 			resets = <&gcc GCC_USB30_PRIM_BCR>;
 
+			interconnects = <&aggre1_noc MASTER_USB3_0 0 &mc_virt SLAVE_EBI1 0>,
+					<&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_USB3_0 0>;
+			interconnect-names = "usb-ddr", "apps-usb";
+
 			status = "disabled";
 
 			usb_1_dwc3: usb@a600000 {
#3 lore raw
Quoted 20 lines · Abel Vesa
Quoted 8 lines · Konrad Dybcio
Quoted 3 lines · Abel Vesa

The USB HC node is missing the interconnect paths, so add them.

Fixes 7f7e5c1b037f ("arm64: dts: qcom: sm8550: Add USB PHYs and controller nodes")

For context, it's a fix in the context of "we should prooobably have this if we want to fix the icc driver to include sync state".

Fair enough...

Quoted 8 lines
Quoted 2 lines

---

sidenote:

Quoted 8 lines
Quoted 3 lines

on recent SoCs there's also an USB-IPA path:

aggre1_noc MASTER_USB3_0 <-> &config_noc SLAVE_IPA_CFG

AFAIK, support for IPA on SM8550 is not added yet.

We can worry about this 3rd path when IPA support for this platform is upstreamed.

Right, that's what I'm saying. I'm not even sure we have tethering acceleration upstream (where IPA pushes data quickly for sharing mobile data via USB).

Konrad

Quoted 25 lines
Quoted 25 lines

I don't think we really make use of that upstream today or whether it would make enabling IPA necessary (to enable the clocks and reach the IPA hardware), but it's something to think about.

Konrad

Quoted 18 lines
 arch/arm64/boot/dts/qcom/sm8550.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm64/boot/dts/qcom/sm8550.dtsi +4 -0
index 75cd374943eb..4991b2e962d1 100644
@@ -2793,6 +2793,10 @@ usb_1: usb@a6f8800 {
 
 			resets = <&gcc GCC_USB30_PRIM_BCR>;
 
+			interconnects = <&aggre1_noc MASTER_USB3_0 0 &mc_virt SLAVE_EBI1 0>,
+					<&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_USB3_0 0>;
+			interconnect-names = "usb-ddr", "apps-usb";
+
 			status = "disabled";
 
 			usb_1_dwc3: usb@a600000 {
maintainer Applied
#4 lore raw
In reply to Abel Vesa
Quoted 3 lines · Abel Vesa

The USB HC node is missing the interconnect paths, so add them.

Applied, thanks!

[1/1] arm64: dts: qcom: sm8550: Add missing interconnect path to USB HC

      commit: 11a1397bbf69e408223bb691858a0fcd295a8f76

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>