perf/test: Test case 27 broken on s390 in linux-next
PATCH 1/1 perf/test: Test case 27 broken on s390 in linux-next
Commit 10269a2ca2b08c ("perf test sample-parsing: Add endian test for struct branch_flags") broke the test case 27 (Sample parsing) on s390 on linux-next tree:
# ./perf test -Fv 27 27: Sample parsing --- start --- parsing failed for sample_type 0x800 ---- end ---- Sample parsing: FAILED! #
The cause of the failure is a wrong #define BS_EXPECTED_BE statement in above commit. Correct this define and the test case runs fine.
Output After:
# ./perf test -Fv 27 27: Sample parsing : --- start --- ---- end ---- Sample parsing: Ok #
--- tools/perf/tests/sample-parsing.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/tests/sample-parsing.c +1 -1
@@ -36,7 +36,7 @@* These are based on the input value (213) specified * in branch_stack variable. */ -#define BS_EXPECTED_BE 0xa00d000000000000 +#define BS_EXPECTED_BE 0xa000d00000000000#define BS_EXPECTED_LE 0xd5000000#define FLAG (s) s->branch_stack->entries[i].flags
Signature · 1 line
2.25.1
Arnaldo Carvalho de Melo
maintainerEm Wed, Nov 03, 2021 at 04:52:15PM +0100, Thomas Richter escreveu:
Quoted 2 lines
Commit
10269a2ca2b08c("perf test sample-parsing: Add endian test for structbranch_flags") broke the test case 27 (Sample parsing) on s390 on linux-next tree:
Maddy,
Can you please ack this one?
- Arnaldo
Quoted 40 lines
# ./perf test -Fv 27 27: Sample parsing --- start --- parsing failed for sample_type 0x800 ---- end ---- Sample parsing: FAILED! #The cause of the failure is a wrong #define
BS_EXPECTED_BEstatement in above commit. Correct this define and the test case runs fine.Output After:
# ./perf test -Fv 27 27: Sample parsing : --- start --- ---- end ---- Sample parsing: Ok #Fixes 10269a2ca2b08c ("perf test sample-parsing: Add endian test for struct branch_flags")Signed-off-by Thomas Richter <[email protected]>--- tools/perf/tests/sample-parsing.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/perf/tests/sample-parsing.c +1
-1@@ -36,7 +36,7 @@* These are based on the input value (213) specified * in branch_stack variable. */ -#define BS_EXPECTED_BE 0xa00d000000000000 +#define BS_EXPECTED_BE 0xa000d00000000000#define BS_EXPECTED_LE 0xd5000000#define FLAG (s) s->branch_stack->entries[i].flagsSignature · 1 line
2.25.1
Signature · 1 line
- Arnaldo
Quoted 6 lines · Arnaldo Carvalho de Melo
Em Wed, Nov 03, 2021 at 04:52:15PM +0100, Thomas Richter escreveu:
Quoted 2 lines
Commit
10269a2ca2b08c("perf test sample-parsing: Add endian test for structbranch_flags") broke the test case 27 (Sample parsing) on s390 on linux-next tree:Maddy,
Can you please ack this one?
Sorry i missed this completely. My bad. Will check it and will reply.
Maddy
Quoted 43 lines
- Arnaldo
Quoted 40 lines
# ./perf test -Fv 27 27: Sample parsing --- start --- parsing failed for sample_type 0x800 ---- end ---- Sample parsing: FAILED! #The cause of the failure is a wrong #define
BS_EXPECTED_BEstatement in above commit. Correct this define and the test case runs fine.Output After:
# ./perf test -Fv 27 27: Sample parsing : --- start --- ---- end ---- Sample parsing: Ok #Fixes 10269a2ca2b08c ("perf test sample-parsing: Add endian test for struct branch_flags")Signed-off-by Thomas Richter <[email protected]>--- tools/perf/tests/sample-parsing.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/perf/tests/sample-parsing.c +1
-1@@ -36,7 +36,7 @@* These are based on the input value (213) specified * in branch_stack variable. */ -#define BS_EXPECTED_BE 0xa00d000000000000 +#define BS_EXPECTED_BE 0xa000d00000000000#define BS_EXPECTED_LE 0xd5000000#define FLAG (s) s->branch_stack->entries[i].flagsSignature · 1 line
2.25.1
PING [PATCH] perf/test: Test case 27 broken on s390 in linux-next
In reply to Thomas RichterHi Arnaldo,
since I have not received any ACK from Maddy and the issue still shows up on s390 in our daily test suite, can you go ahead and pick this patch.
Thanks
Thomas Richter, Dept 3303, IBM s390 Linux Development, Boeblingen, Germany --
Vorsitzender des Aufsichtsrats: Gregor Pillen
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294
-------- Forwarded Message --------
Subject: [PATCH] perf/test: Test case 27 broken on s390 in linux-next
Date: Wed, 3 Nov 2021 16:52:15 +0100
From: Thomas Richter <[email protected]>
To: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
CC: [email protected], [email protected], [email protected], Thomas Richter <[email protected]>
Commit 10269a2ca2b08c ("perf test sample-parsing: Add endian test for struct branch_flags") broke the test case 27 (Sample parsing) on s390 on linux-next tree:
# ./perf test -Fv 27 27: Sample parsing --- start --- parsing failed for sample_type 0x800 ---- end ---- Sample parsing: FAILED! #
The cause of the failure is a wrong #define BS_EXPECTED_BE statement in above commit. Correct this define and the test case runs fine.
Output After:
# ./perf test -Fv 27 27: Sample parsing : --- start --- ---- end ---- Sample parsing: Ok #
--- tools/perf/tests/sample-parsing.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/tests/sample-parsing.c +1 -1
@@ -36,7 +36,7 @@* These are based on the input value (213) specified * in branch_stack variable. */ -#define BS_EXPECTED_BE 0xa00d000000000000 +#define BS_EXPECTED_BE 0xa000d00000000000#define BS_EXPECTED_LE 0xd5000000#define FLAG (s) s->branch_stack->entries[i].flags
Signature · 9 lines
2.25.1 -- Thomas Richter, Dept 3303, IBM s390 Linux Development, Boeblingen, Germany -- Vorsitzender des Aufsichtsrats: Gregor Pillen Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294
Quoted 14 lines · Thomas Richter
Commit
10269a2ca2b08c("perf test sample-parsing: Add endian test for structbranch_flags") broke the test case 27 (Sample parsing) on s390 on linux-next tree:# ./perf test -Fv 27 27: Sample parsing --- start --- parsing failed for sample_type 0x800 ---- end ---- Sample parsing: FAILED! #The cause of the failure is a wrong #define
BS_EXPECTED_BEstatement in above commit. Correct this define and the test case runs fine.
Quoted 7 lines
Output After:
# ./perf test -Fv 27 27: Sample parsing : --- start --- ---- end ---- Sample parsing: Ok #
Hi Thomas,
Thanks for the fix. Not sure, I guess I messed up my big endian setup or test run I had before sending the patch. My bad. It fails for me too, but with your patch the issue fixed.
Quoted 20 lines
Fixes 10269a2ca2b08c ("perf test sample-parsing: Add endian test for struct branch_flags")Signed-off-by Thomas Richter <[email protected]>--- tools/perf/tests/sample-parsing.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/perf/tests/sample-parsing.c +1
-1@@ -36,7 +36,7 @@* These are based on the input value (213) specified * in branch_stack variable. */ -#define BS_EXPECTED_BE 0xa00d000000000000 +#define BS_EXPECTED_BE 0xa000d00000000000#define BS_EXPECTED_LE 0xd5000000#define FLAG (s) s->branch_stack->entries[i].flags
Em Wed, Nov 17, 2021 at 02:35:29PM +0530, Madhavan Srinivasan escreveu:
Quoted 25 lines · Thomas Richter
Quoted 14 lines
Commit
10269a2ca2b08c("perf test sample-parsing: Add endian test for structbranch_flags") broke the test case 27 (Sample parsing) on s390 on linux-next tree:# ./perf test -Fv 27 27: Sample parsing --- start --- parsing failed for sample_type 0x800 ---- end ---- Sample parsing: FAILED! #The cause of the failure is a wrong #define
BS_EXPECTED_BEstatement in above commit. Correct this define and the test case runs fine.Quoted 7 lines
Output After:
# ./perf test -Fv 27 27: Sample parsing : --- start --- ---- end ---- Sample parsing: Ok #
Quoted 6 lines
Hi Thomas,
Thanks for the fix. Not sure, I guess I messed up my big endian setup or test run I had before sending
the patch. My bad. It fails for me too, but with your patch the issue fixed.Acked-and-Tested-by Madhavan Srinivasan <[email protected]>
Thanks, applied.
- Arnaldo