virtio: update MemoryRegionCaches when guest set bad features
PATCH 1/1 virtio: update MemoryRegionCaches when guest set bad features
Current the 'virtio_set_features' only update the 'MemorRegionCaches' when the 'virtio_set_features_nocheck' return '0' which means it is not bad features. However the guest can still trigger the access of the used vring after set bad features. In this situation it will cause assert failure in 'ADDRESS_SPACE_ST_CACHED'.
--- hw/virtio/virtio.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-)
hw/virtio/virtio.c +8 -9
@@ -2963,17 +2963,16 @@ int virtio_set_features(VirtIODevice *vdev, uint64_t val)return -EINVAL ; } ret =virtio_set_features_nocheck (vdev, val); -if (!ret) { -if (virtio_vdev_has_feature (vdev,VIRTIO_RING_F_EVENT_IDX )) { -/* VIRTIO_RING_F_EVENT_IDX changes the size of the caches. */ -int i; -for (i =0 ; i <VIRTIO_QUEUE_MAX ; i++) { -if (vdev->vq[i].vring.num !=0 ) { -virtio_init_region_cache (vdev, i); - } +if (virtio_vdev_has_feature (vdev,VIRTIO_RING_F_EVENT_IDX )) { +/* VIRTIO_RING_F_EVENT_IDX changes the size of the caches. */ +int i; +for (i =0 ; i <VIRTIO_QUEUE_MAX ; i++) { +if (vdev->vq[i].vring.num !=0 ) { +virtio_init_region_cache (vdev, i); } } - + } +if (!ret) {if (!virtio_device_started (vdev, vdev->status) && !virtio_vdev_has_feature (vdev,VIRTIO_F_VERSION_1 )) { vdev->start_on_kick = true;
Signature · 1 line
2.17.1
Quoted 35 lines · Li Qiang
Current the '
virtio_set_features' only update the 'MemorRegionCaches' when the 'virtio_set_features_nocheck' return '0' which means it is not bad features. However the guest can still trigger the access of the used vring after set bad features. In this situation it will cause assert failure in 'ADDRESS_SPACE_ST_CACHED'.Fixes db812c4073c7 ("virtio: update MemoryRegionCaches when guest negotiates features")Reported-by Alexander Bulekov <[email protected]>Signed-off-by Li Qiang <[email protected]>--- hw/virtio/virtio.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-)hw/virtio/virtio.c +4
-8@@ -2963,17 +2963,16 @@ int virtio_set_features(VirtIODevice *vdev, uint64_t val)return -EINVAL ; } ret =virtio_set_features_nocheck (vdev, val); -if (!ret) { -if (virtio_vdev_has_feature (vdev,VIRTIO_RING_F_EVENT_IDX )) { -/* VIRTIO_RING_F_EVENT_IDX changes the size of the caches. */ -int i; -for (i =0 ; i <VIRTIO_QUEUE_MAX ; i++) { -if (vdev->vq[i].vring.num !=0 ) { -virtio_init_region_cache (vdev, i); - } +if (virtio_vdev_has_feature (vdev,VIRTIO_RING_F_EVENT_IDX )) { +/* VIRTIO_RING_F_EVENT_IDX changes the size of the caches. */ +int i; +for (i =0 ; i <VIRTIO_QUEUE_MAX ; i++) {
hw/virtio/virtio.c int virtio_set_features(VirtIODevice *vdev, uint64_t val) · line 2978
Quoted 10 lines
hw/virtio/virtio.c +4
-1+if (vdev->vq[i].vring.num !=0 ) { +virtio_init_region_cache (vdev, i); } } - + } +if (!ret) {if (!virtio_device_started (vdev, vdev->status) && !virtio_vdev_has_feature (vdev,VIRTIO_F_VERSION_1 )) { vdev->start_on_kick = true;