arm64/sme: Add ID_AA64SMFR0_EL1 to __read_sysreg_by_encoding()
PATCH 1/1 arm64/sme: Add ID_AA64SMFR0_EL1 to __read_sysreg_by_encoding()
We need to explicitly enumerate all the ID registers which we rely on for CPU capabilities in __read_sysreg_by_encoding(), ID_AA64SMFR0_EL1 was missed from this list so we trip a BUG() in paths which rely on that function such as CPU hotplug. Add the register.
--- arch/arm64/kernel/cpufeature.c | 1 + 1 file changed, 1 insertion(+)
arch/arm64/kernel/cpufeature.c +1 -0
@@ -1336,6 +1336,7 @@ u64 __read_sysreg_by_encoding(u32 sys_id)read_sysreg_case (SYS_ID_AA64PFR0_EL1 );read_sysreg_case (SYS_ID_AA64PFR1_EL1 );read_sysreg_case (SYS_ID_AA64ZFR0_EL1 ); +read_sysreg_case (SYS_ID_AA64SMFR0_EL1 );read_sysreg_case (SYS_ID_AA64DFR0_EL1 );read_sysreg_case (SYS_ID_AA64DFR1_EL1 );read_sysreg_case (SYS_ID_AA64MMFR0_EL1 );
Signature · 7 lines
2.30.2 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 7 lines · Mark Brown
We need to explicitly enumerate all the ID registers which we rely on for CPU capabilities in
__read_sysreg_by_encoding(),ID_AA64SMFR0_EL1was missed from this list so we trip aBUG()in paths which rely on that function such as CPU hotplug. Add the register.Reported-by Marek Szyprowski <[email protected]>Signed-off-by Mark Brown <[email protected]>
Quoted 9 lines
--- arch/arm64/kernel/cpufeature.c | 1 + 1 file changed, 1 insertion(+)arch/arm64/kernel/cpufeature.c +0
-0
arch/arm64/kernel/cpufeature.c u64 __read_sysreg_by_encoding(u32 sys_id) · line 1342
Quoted 7 lines
arch/arm64/kernel/cpufeature.c +1
-0@@ -1336,6 +1336,7 @@ u64 __read_sysreg_by_encoding(u32 sys_id)read_sysreg_case (SYS_ID_AA64PFR0_EL1 );read_sysreg_case (SYS_ID_AA64PFR1_EL1 );read_sysreg_case (SYS_ID_AA64ZFR0_EL1 ); +read_sysreg_case (SYS_ID_AA64SMFR0_EL1 );read_sysreg_case (SYS_ID_AA64DFR0_EL1 );read_sysreg_case (SYS_ID_AA64DFR1_EL1 );read_sysreg_case (SYS_ID_AA64MMFR0_EL1 );
Best regards
Signature · 8 lines
Marek Szyprowski, PhD Samsung R&D Institute Poland _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 6 lines · Mark Brown
We need to explicitly enumerate all the ID registers which we rely on for CPU capabilities in
__read_sysreg_by_encoding(),ID_AA64SMFR0_EL1was missed from this list so we trip aBUG()in paths which rely on that function such as CPU hotplug. Add the register.
Applied to arm64 (for-next/sme), thanks!
[1/1] arm64/sme: Add ID_AA64SMFR0_EL1 to __read_sysreg_by_encoding()
https://git.kernel.org/arm64/c/8a58bcd00e2e
Signature · 7 lines
Catalin _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel