netdevice.h: Add __cold to netdev_<level> logging functions
Subsystems (2)
PATCH 1/1 netdevice.h: Add __cold to netdev_<level> logging functions
Add __cold to the netdev_<level> logging functions similar to the use of __cold in the generic printk function.
Using __cold moves all the netdev_<level> logging functions out-of-line possibly improving code locality and runtime performance.
Signed-off-by Joe Perches <[email protected]>
--- include/linux/netdevice.h | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
include/linux/netdevice.h +8 -8
@@ -4671,22 +4671,22 @@ static inline const char *netdev_reg_state(const struct net_device *dev)return " (unknown)" ; } -__printf(3, 4) +__printf(3, 4) __coldvoid netdev_printk (const char *level,const struct net_device *dev,const char *format, ...); -__printf(2, 3) +__printf(2, 3) __coldvoid netdev_emerg (const struct net_device *dev,const char *format, ...); -__printf(2, 3) +__printf(2, 3) __coldvoid netdev_alert (const struct net_device *dev,const char *format, ...); -__printf(2, 3) +__printf(2, 3) __coldvoid netdev_crit (const struct net_device *dev,const char *format, ...); -__printf(2, 3) +__printf(2, 3) __coldvoid netdev_err (const struct net_device *dev,const char *format, ...); -__printf(2, 3) +__printf(2, 3) __coldvoid netdev_warn (const struct net_device *dev,const char *format, ...); -__printf(2, 3) +__printf(2, 3) __coldvoid netdev_notice (const struct net_device *dev,const char *format, ...); -__printf(2, 3) +__printf(2, 3) __coldvoid netdev_info (const struct net_device *dev,const char *format, ...);#define netdev_level_once (level, dev, fmt, ...) \
David Miller
maintainerFrom: Joe Perches <[email protected]>
Date: Sat, 02 Feb 2019 19:47:25 -0800
Quoted 8 lines
Add
__coldto the netdev_<level> logging functions similar to the use of__coldin the generic printk function.Using
__coldmoves all the netdev_<level> logging functions out-of-line possibly improving code locality and runtime performance.Signed-off-by Joe Perches <[email protected]>
Sure, let's give this a try.
I'll push this out to net-next when my build testing completes.
Thanks.