nvmet: pci-epf: Always configure BAR0 as 64-bit
Subsystems (2)
PATCH 1/1 nvmet: pci-epf: Always configure BAR0 as 64-bit
NVMe PCIe Transport Specification 1.1, section 2.1.10, claims that the BAR0 type is Implementation Specific.
However, in NVMe 1.1, the type is required to be 64-bit.
Thus, to make our PCI EPF work on as many host systems as possible, always configure the BAR0 type to be 64-bit.
In the rare case that the underlying PCI EPC does not support configuring BAR0 as 64-bit, the call to pci_epc_set_bar() will fail, and we will return a failure back to the user.
This should not be a problem, as most PCI EPCs support configuring a BAR as 64-bit (and those EPCs with .only_64bit set to true in epc_features only support configuring the BAR as 64-bit).
---
Hello Damien,
please test on your platforms as well.
I think this is the way to go, as most real NVMe drives in the wild have BAR0 as a 64-bit BAR.
drivers/nvme/target/pci-epf.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
drivers/nvme/target/pci-epf.c +9 -2
@@ -2096,8 +2096,15 @@ static int nvmet_pci_epf_configure_bar(struct nvmet_pci_epf *nvme_epf)return -ENODEV ; } -if (epc_features->bar[BAR_0 ].only_64bit) - epf->bar[BAR_0 ].flags |=PCI_BASE_ADDRESS_MEM_TYPE_64 ; +/* +* While NVMe PCIe Transport Specification 1.1, section 2.1.10, claims +* that the BAR0 type is Implementation Specific, in NVMe 1.1, the type +* is required to be 64-bit. Thus, for interoperability, always set the +* type to 64-bit. In the rare case that the PCI EPC does not support +* configuring BAR0 as 64-bit, the call to pci_epc_set_bar() will fail, +* and we will return failure back to the user. +*/ + epf->bar[BAR_0 ].flags |=PCI_BASE_ADDRESS_MEM_TYPE_64 ;/* * Calculate the size of the register bar: NVMe registers first with
Signature · 1 line
2.48.1
Quoted 16 lines · Niklas Cassel
NVMe PCIe Transport Specification 1.1, section 2.1.10, claims that the BAR0 type is Implementation Specific.
However, in NVMe 1.1, the type is required to be 64-bit.
Thus, to make our PCI EPF work on as many host systems as possible, always configure the BAR0 type to be 64-bit.
In the rare case that the underlying PCI EPC does not support configuring BAR0 as 64-bit, the call to
pci_epc_set_bar()will fail, and we will return a failure back to the user.This should not be a problem, as most PCI EPCs support configuring a BAR as 64-bit (and those EPCs with .only_64bit set to true in
epc_featuresonly support configuring the BAR as 64-bit).
Quoted 5 lines
Signed-off-by Niklas Cassel <[email protected]>---
Hello Damien,please test on your platforms as well.
Will test. But I think this needs a Fixes tag:
Quoted 29 lines
I think this is the way to go, as most real NVMe drives in the wild have BAR0 as a 64-bit BAR.
drivers/nvme/target/pci-epf.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)drivers/nvme/target/pci-epf.c +9
-2@@ -2096,8 +2096,15 @@ static int nvmet_pci_epf_configure_bar(struct nvmet_pci_epf *nvme_epf)return -ENODEV ; } -if (epc_features->bar[BAR_0 ].only_64bit) - epf->bar[BAR_0 ].flags |=PCI_BASE_ADDRESS_MEM_TYPE_64 ; +/* +* While NVMe PCIe Transport Specification 1.1, section 2.1.10, claims +* that the BAR0 type is Implementation Specific, in NVMe 1.1, the type +* is required to be 64-bit. Thus, for interoperability, always set the +* type to 64-bit. In the rare case that the PCI EPC does not support +* configuring BAR0 as 64-bit, the call to pci_epc_set_bar() will fail, +* and we will return failure back to the user. +*/ + epf->bar[BAR_0 ].flags |=PCI_BASE_ADDRESS_MEM_TYPE_64 ;/* * Calculate the size of the register bar: NVMe registers first with
Signature · 2 lines
Damien Le Moal Western Digital Research
Quoted 12 lines · Niklas Cassel
NVMe PCIe Transport Specification 1.1, section 2.1.10, claims that the BAR0 type is Implementation Specific.
However, in NVMe 1.1, the type is required to be 64-bit.
Thus, to make our PCI EPF work on as many host systems as possible, always configure the BAR0 type to be 64-bit.
In the rare case that the underlying PCI EPC does not support configuring BAR0 as 64-bit, the call to
pci_epc_set_bar()will fail, and we will return a failure back to the user.
Quoted 5 lines
This should not be a problem, as most PCI EPCs support configuring a BAR as 64-bit (and those EPCs with .only_64bit set to true in
epc_featuresonly support configuring the BAR as 64-bit).Signed-off-by Niklas Cassel <[email protected]>
(please add the fixes tag I suggested)
Signature · 2 lines
Damien Le Moal Western Digital Research