Skip to contentSkip to conversation

libtirpc: Simplify the installation of symlinks for legacy headers

PATCH In review Peter Kjellerstedt 2 participants 6 messages Dec 5, 2019 – Dec 6, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 libtirpc: Simplify the installation of symlinks for legacy headers

This also corrects the symbolic links installed in /usr/include/rpcsvc.

---
 .../libtirpc/libtirpc_1.1.4.bb                | 27 +++++++++----------
 1 file changed, 12 insertions(+), 15 deletions(-)
meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb +12 -15
index 633cececd4..91e0ce6fd2 100644
@@ -1,5 +1,5 @@
 SUMMARY = "Transport-Independent RPC library"
-DESCRIPTION = "Libtirpc is a port of Suns Transport-Independent RPC library to Linux"
+DESCRIPTION = "Libtirpc is a port of Sun's Transport-Independent RPC library to Linux"
 SECTION = "libs/network"
 HOMEPAGE = "http://sourceforge.net/projects/libtirpc/"
 BUGTRACKER = "http://sourceforge.net/tracker/?group_id=183075&atid=903784"
@@ -22,21 +22,18 @@ inherit autotools pkgconfig
 EXTRA_OECONF = "--disable-gssapi"
 
 do_install_append() {
-        chown root:root ${D}${sysconfdir}/netconfig
-        install -d ${D}${includedir}/rpc
-        install -d ${D}${includedir}/rpcsvc
-        for link_header in ${D}${includedir}/tirpc/rpc/*; do
-            if [ -f $link_header -a ! -e ${D}/${includedir}/rpc/$(basename $link_header) ]; then
-                ln -sf ../tirpc/rpc/$(basename $link_header) ${D}${includedir}/rpc/$(basename $link_header)
-            fi
-        done
-        for link_header in ${D}${includedir}/tirpc/rpcsvc/*; do
-            if [ -f $link_header -a ! -e ${D}/${includedir}/rpcsvc/$(basename $link_header) ]; then
-                ln -sf ../tirpc/rpc/$(basename $link_header) ${D}${includedir}/rpcsvc/$(basename $link_header)
-            fi
-        done
-        ln -sf  tirpc/netconfig.h ${D}/${includedir}/netconfig.h
+	chown root:root ${D}${sysconfdir}/netconfig
 
+	for dir in rpc rpcsvc; do
+		install -d ${D}${includedir}/$dir
+		for link_header in ${D}${includedir}/tirpc/$dir/*; do
+			if [ -f $link_header ] &&
+			   [ ! -e ${D}${includedir}/$dir/$(basename $link_header) ]; then
+				ln -sf ../tirpc/$dir/$(basename $link_header) ${D}${includedir}/$dir/$(basename $link_header)
+			fi
+		done
+	done
+	ln -sf tirpc/netconfig.h ${D}${includedir}/netconfig.h
 }
 
 BBCLASSEXTEND = "native nativesdk"
Signature · 1 line
2.21.0
#1 lore raw

PATCH 2/2 libtirpc: Make it easy to disable the installation of legacy headers

Providing symbolic links to the header files to replace the old corresponding glibc headers seems like a band aid for applications that have not been updated to cope with the lack of the RPC headers from glibc. Additionally they clash with glibc if an older version of glibc is used that still provides the header files. To remedy this, make it easy to disable the installation of the legacy headers by not setting the legacy-headers PACKAGECONFIG.

---
 .../libtirpc/libtirpc_1.1.4.bb                | 23 +++++++++++--------
 1 file changed, 14 insertions(+), 9 deletions(-)
meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb +14 -9
index 91e0ce6fd2..3c84694161 100644
@@ -17,6 +17,9 @@ UPSTREAM_CHECK_REGEX = "(?P<pver>\d+(\.\d+)+)/"
 SRC_URI[md5sum] = "f5d2a623e9dfbd818d2f3f3a4a878e3a"
 SRC_URI[sha256sum] = "2ca529f02292e10c158562295a1ffd95d2ce8af97820e3534fe1b0e3aec7561d"
 
+PACKAGECONFIG = "legacy-headers"
+PACKAGECONFIG[legacy-headers] = ""
+
 inherit autotools pkgconfig
 
 EXTRA_OECONF = "--disable-gssapi"
@@ -24,16 +27,18 @@ EXTRA_OECONF = "--disable-gssapi"
 do_install_append() {
 	chown root:root ${D}${sysconfdir}/netconfig
 
-	for dir in rpc rpcsvc; do
-		install -d ${D}${includedir}/$dir
-		for link_header in ${D}${includedir}/tirpc/$dir/*; do
-			if [ -f $link_header ] &&
-			   [ ! -e ${D}${includedir}/$dir/$(basename $link_header) ]; then
-				ln -sf ../tirpc/$dir/$(basename $link_header) ${D}${includedir}/$dir/$(basename $link_header)
-			fi
+	if [ "${@bb.utils.filter('PACKAGECONFIG', 'legacy-headers', d)}" ]; then
+		for dir in rpc rpcsvc; do
+			install -d ${D}${includedir}/$dir
+			for link_header in ${D}${includedir}/tirpc/$dir/*; do
+				if [ -f $link_header ] &&
+				   [ ! -e ${D}${includedir}/$dir/$(basename $link_header) ]; then
+					ln -sf ../tirpc/$dir/$(basename $link_header) ${D}${includedir}/$dir/$(basename $link_header)
+				fi
+			done
 		done
-	done
-	ln -sf tirpc/netconfig.h ${D}${includedir}/netconfig.h
+		ln -sf tirpc/netconfig.h ${D}${includedir}/netconfig.h
+	fi
 }
 
 BBCLASSEXTEND = "native nativesdk"
Signature · 1 line
2.21.0
#2 lore raw
In reply to Peter Kjellerstedt
Quoted 41 lines · Peter Kjellerstedt

This also corrects the symbolic links installed in /usr/include/rpcsvc.

---
  .../libtirpc/libtirpc_1.1.4.bb                | 27 +++++++++----------
  1 file changed, 12 insertions(+), 15 deletions(-)
meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb +4 -15
index 633cececd4..91e0ce6fd2 100644
@@ -1,5 +1,5 @@
  SUMMARY = "Transport-Independent RPC library"
-DESCRIPTION = "Libtirpc is a port of Suns Transport-Independent RPC library to Linux"
+DESCRIPTION = "Libtirpc is a port of Sun's Transport-Independent RPC library to Linux"
  SECTION = "libs/network"
  HOMEPAGE = "http://sourceforge.net/projects/libtirpc/"
  BUGTRACKER = "http://sourceforge.net/tracker/?group_id=183075&atid=903784"
@@ -22,21 +22,18 @@ inherit autotools pkgconfig
  EXTRA_OECONF = "--disable-gssapi"
 
  do_install_append() {
-        chown root:root ${D}${sysconfdir}/netconfig
-        install -d ${D}${includedir}/rpc
-        install -d ${D}${includedir}/rpcsvc
-        for link_header in ${D}${includedir}/tirpc/rpc/*; do
-            if [ -f $link_header -a ! -e ${D}/${includedir}/rpc/$(basename $link_header) ]; then
-                ln -sf ../tirpc/rpc/$(basename $link_header) ${D}${includedir}/rpc/$(basename $link_header)
-            fi
-        done
-        for link_header in ${D}${includedir}/tirpc/rpcsvc/*; do
-            if [ -f $link_header -a ! -e ${D}/${includedir}/rpcsvc/$(basename $link_header) ]; then
-                ln -sf ../tirpc/rpc/$(basename $link_header) ${D}${includedir}/rpcsvc/$(basename $link_header)
-            fi
-        done
-        ln -sf  tirpc/netconfig.h ${D}/${includedir}/netconfig.h
+	chown root:root ${D}${sysconfdir}/netconfig
 
+	for dir in rpc rpcsvc; do
+		install -d ${D}${includedir}/$dir

meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb inherit autotools pkgconfig · line 38

Quoted 10 lines
meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb +8 -0
+		for link_header in ${D}${includedir}/tirpc/$dir/*; do
+			if [ -f $link_header ] &&
+			   [ ! -e ${D}${includedir}/$dir/$(basename $link_header) ]; then
+				ln -sf ../tirpc/$dir/$(basename $link_header) ${D}${includedir}/$dir/$(basename $link_header)
+			fi
+		done
+	done
+	ln -sf tirpc/netconfig.h ${D}${includedir}/netconfig.h
  }
 

I know this patch is making the existing logic better. But I dont think we should be substituting, sunrpc headers like this, what problems does this fix is not clear. tirpc is not a drop in replacement for sun rpc. Applications have to use it consciously. Sneaking the headers like this can cause subtle errors.

Perhaps original patch should just be reverted.

Quoted 2 lines
meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb +0 -0
  BBCLASSEXTEND = "native nativesdk"
#3 lore raw
Quoted 78 lines

-----Original Message-----
From: [email protected] <openembedded-core- [email protected]> On Behalf Of Khem Raj
Sent: den 6 december 2019 05:56
To: [email protected]
Subject: Re: [OE-core] [master][zeus][PATCH 1/2] libtirpc: Simplify the installation of symlinks for legacy headers

Review

Quoted 9 lines · Peter Kjellerstedt

This also corrects the symbolic links installed in /usr/include/rpcsvc.

---
  .../libtirpc/libtirpc_1.1.4.bb                | 27 +++++++++----------
  1 file changed, 12 insertions(+), 15 deletions(-)
(quoted diff) +0 -0

b/meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb

meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb line 2

Quoted 6 lines

index 633cececd4..91e0ce6fd2 100644

meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb +0 -1
@@ -1,5 +1,5 @@
  SUMMARY = "Transport-Independent RPC library"
-DESCRIPTION = "Libtirpc is a port of Suns Transport-Independent RPC

library to Linux"

meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb line 2

Quoted 1 line
meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb +1 -0
+DESCRIPTION = "Libtirpc is a port of Sun's Transport-Independent RPC

library to Linux"

meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb

Quoted 3 lines
meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb +0 -0
  SECTION = "libs/network"
  HOMEPAGE = "http://sourceforge.net/projects/libtirpc/"
  BUGTRACKER =

"http://sourceforge.net/tracker/?group_id=183075&atid=903784"

meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb inherit autotools pkgconfig · line 29

Quoted 9 lines
meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb +0 -5
@@ -22,21 +22,18 @@ inherit autotools pkgconfig
  EXTRA_OECONF = "--disable-gssapi"
 
  do_install_append() {
-        chown root:root ${D}${sysconfdir}/netconfig
-        install -d ${D}${includedir}/rpc
-        install -d ${D}${includedir}/rpcsvc
-        for link_header in ${D}${includedir}/tirpc/rpc/*; do
-            if [ -f $link_header -a ! -e

${D}/${includedir}/rpc/$(basename $link_header) ]; then

meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb inherit autotools pkgconfig · line 30

Quoted 1 line
meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb +0 -1
-                ln -sf ../tirpc/rpc/$(basename $link_header)

${D}${includedir}/rpc/$(basename $link_header)

meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb inherit autotools pkgconfig

Quoted 4 lines
meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb +0 -4
-            fi
-        done
-        for link_header in ${D}${includedir}/tirpc/rpcsvc/*; do
-            if [ -f $link_header -a ! -e

${D}/${includedir}/rpcsvc/$(basename $link_header) ]; then

meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb inherit autotools pkgconfig · line 35

Quoted 1 line
meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb +0 -1
-                ln -sf ../tirpc/rpc/$(basename $link_header)

${D}${includedir}/rpcsvc/$(basename $link_header)

meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb inherit autotools pkgconfig

Quoted 8 lines
meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb +4 -3
-            fi
-        done
-        ln -sf  tirpc/netconfig.h ${D}/${includedir}/netconfig.h
+	chown root:root ${D}${sysconfdir}/netconfig
 
+	for dir in rpc rpcsvc; do
+		install -d ${D}${includedir}/$dir
+		for link_header in ${D}${includedir}/tirpc/$dir/*;

do

meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb inherit autotools pkgconfig · line 31

Quoted 2 lines
meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb +2 -0
+			if [ -f $link_header ] &&
+			   [ ! -e

${D}${includedir}/$dir/$(basename $link_header) ]; then

meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb inherit autotools pkgconfig · line 32

Quoted 1 line
meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb +1 -0
+				ln -sf ../tirpc/$dir/$(basename

$link_header) ${D}${includedir}/$dir/$(basename $link_header)

meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb inherit autotools pkgconfig · line 38

Quoted 6 lines
meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb +4 -0
+			fi
+		done
+	done
+	ln -sf tirpc/netconfig.h ${D}${includedir}/netconfig.h
  }
 

I know this patch is making the existing logic better. But I dont think we should be substituting, sunrpc headers like this, what problems does this fix is not clear. tirpc is not a drop in replacement for sun rpc. Applications have to use it consciously. Sneaking the headers like this can cause subtle errors.

Quoted 1 line

Perhaps original patch should just be reverted.

I'm perfectly fine with reverting the original patch instead as that will solve my problem.

Quoted 1 line

meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb inherit autotools pkgconfig · line 39

Quoted 1 line
meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb +0 -0
  BBCLASSEXTEND = "native nativesdk"

//Peter

#4 lore raw

perhaps send a revert request instead

Quoted 88 lines · Peter Kjellerstedt
Quoted 73 lines

-----Original Message-----
From: [email protected] <openembedded-core- [email protected]> On Behalf Of Khem Raj
Sent: den 6 december 2019 05:56
To: [email protected]
Subject: Re: [OE-core] [master][zeus][PATCH 1/2] libtirpc: Simplify the installation of symlinks for legacy headers

Review

Quoted 9 lines · Peter Kjellerstedt

This also corrects the symbolic links installed in /usr/include/rpcsvc.

---
  .../libtirpc/libtirpc_1.1.4.bb                | 27 +++++++++----------
  1 file changed, 12 insertions(+), 15 deletions(-)
(quoted diff) +0 -0

b/meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb

meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb line 2

Quoted 6 lines

index 633cececd4..91e0ce6fd2 100644

meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb +0 -1
@@ -1,5 +1,5 @@
  SUMMARY = "Transport-Independent RPC library"
-DESCRIPTION = "Libtirpc is a port of Suns Transport-Independent RPC

library to Linux"

meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb line 2

Quoted 1 line
meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb +1 -0
+DESCRIPTION = "Libtirpc is a port of Sun's Transport-Independent RPC

library to Linux"

meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb

Quoted 3 lines
meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb +0 -0
  SECTION = "libs/network"
  HOMEPAGE = "http://sourceforge.net/projects/libtirpc/"
  BUGTRACKER =

"http://sourceforge.net/tracker/?group_id=183075&atid=903784"

meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb inherit autotools pkgconfig · line 29

Quoted 9 lines
meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb +0 -5
@@ -22,21 +22,18 @@ inherit autotools pkgconfig
  EXTRA_OECONF = "--disable-gssapi"
 
  do_install_append() {
-        chown root:root ${D}${sysconfdir}/netconfig
-        install -d ${D}${includedir}/rpc
-        install -d ${D}${includedir}/rpcsvc
-        for link_header in ${D}${includedir}/tirpc/rpc/*; do
-            if [ -f $link_header -a ! -e

${D}/${includedir}/rpc/$(basename $link_header) ]; then

meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb inherit autotools pkgconfig · line 30

Quoted 1 line
meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb +0 -1
-                ln -sf ../tirpc/rpc/$(basename $link_header)

${D}${includedir}/rpc/$(basename $link_header)

meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb inherit autotools pkgconfig

Quoted 4 lines
meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb +0 -4
-            fi
-        done
-        for link_header in ${D}${includedir}/tirpc/rpcsvc/*; do
-            if [ -f $link_header -a ! -e

${D}/${includedir}/rpcsvc/$(basename $link_header) ]; then

meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb inherit autotools pkgconfig · line 35

Quoted 1 line
meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb +0 -1
-                ln -sf ../tirpc/rpc/$(basename $link_header)

${D}${includedir}/rpcsvc/$(basename $link_header)

meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb inherit autotools pkgconfig

Quoted 8 lines
meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb +4 -3
-            fi
-        done
-        ln -sf  tirpc/netconfig.h ${D}/${includedir}/netconfig.h
+   chown root:root ${D}${sysconfdir}/netconfig
 
+   for dir in rpc rpcsvc; do
+           install -d ${D}${includedir}/$dir
+           for link_header in ${D}${includedir}/tirpc/$dir/*;

do

meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb inherit autotools pkgconfig · line 31

Quoted 2 lines
meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb +2 -0
+                   if [ -f $link_header ] &&
+                      [ ! -e

${D}${includedir}/$dir/$(basename $link_header) ]; then

meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb inherit autotools pkgconfig · line 32

Quoted 1 line
meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb +1 -0
+                           ln -sf ../tirpc/$dir/$(basename

$link_header) ${D}${includedir}/$dir/$(basename $link_header)

meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb inherit autotools pkgconfig · line 38

Quoted 6 lines
meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb +4 -0
+                   fi
+           done
+   done
+   ln -sf tirpc/netconfig.h ${D}${includedir}/netconfig.h
  }
 
Quoted 7 lines

I know this patch is making the existing logic better. But I dont think we should be substituting, sunrpc headers like this, what problems does this fix is not clear. tirpc is not a drop in replacement for sun rpc. Applications have to use it consciously. Sneaking the headers like this can cause subtle errors.

Perhaps original patch should just be reverted.

I'm perfectly fine with reverting the original patch instead as that will solve my problem.

Quoted 1 line

meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb inherit autotools pkgconfig · line 39

Quoted 1 line
meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb +0 -0
  BBCLASSEXTEND = "native nativesdk"

//Peter

#5 lore raw

Will do.

//Peter

Quoted 108 lines

-----Original Message-----
From: Khem Raj <[email protected]>
Sent: den 6 december 2019 16:21
To: Peter Kjellerstedt <[email protected]>
Cc: [email protected]
Subject: Re: [OE-core] [master][zeus][PATCH 1/2] libtirpc: Simplify the installation of symlinks for legacy headers

perhaps send a revert request instead

Quoted 3 lines · Peter Kjellerstedt
Quoted 3 lines

-----Original Message-----
From: [email protected] <openembedded-

core-

Quoted 4 lines
Quoted 4 lines

[email protected]> On Behalf Of Khem Raj
Sent: den 6 december 2019 05:56
To: [email protected]
Subject: Re: [OE-core] [master][zeus][PATCH 1/2] libtirpc: Simplify

the

Quoted 9 lines
Quoted 9 lines

installation of symlinks for legacy headers

Quoted 6 lines · Peter Kjellerstedt

This also corrects the symbolic links installed in /usr/include/rpcsvc.

---
  .../libtirpc/libtirpc_1.1.4.bb                | 27 +++++++++------

----

Quoted 4 lines
Quoted 4 lines

Review

Quoted 3 lines
  1 file changed, 12 insertions(+), 15 deletions(-)
(quoted diff) +0 -0

b/meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb

Quoted 8 lines
Quoted 8 lines

meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb line 2

Quoted 6 lines

index 633cececd4..91e0ce6fd2 100644

meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb +0 -1
@@ -1,5 +1,5 @@
  SUMMARY = "Transport-Independent RPC library"
-DESCRIPTION = "Libtirpc is a port of Suns Transport-Independent RPC

library to Linux"

Quoted 1 line
meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb +1 -0
+DESCRIPTION = "Libtirpc is a port of Sun's Transport-Independent

RPC

Quoted 38 lines
Quoted 38 lines

library to Linux"

meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb

Quoted 3 lines
meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb +0 -0
  SECTION = "libs/network"
  HOMEPAGE = "http://sourceforge.net/projects/libtirpc/"
  BUGTRACKER =

"http://sourceforge.net/tracker/?group_id=183075&atid=903784"

meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb inherit autotools pkgconfig · line 29

Quoted 9 lines
meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb +0 -5
@@ -22,21 +22,18 @@ inherit autotools pkgconfig
  EXTRA_OECONF = "--disable-gssapi"
 
  do_install_append() {
-        chown root:root ${D}${sysconfdir}/netconfig
-        install -d ${D}${includedir}/rpc
-        install -d ${D}${includedir}/rpcsvc
-        for link_header in ${D}${includedir}/tirpc/rpc/*; do
-            if [ -f $link_header -a ! -e

${D}/${includedir}/rpc/$(basename $link_header) ]; then

meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb inherit autotools pkgconfig · line 30

Quoted 1 line
meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb +0 -1
-                ln -sf ../tirpc/rpc/$(basename $link_header)

${D}${includedir}/rpc/$(basename $link_header)

meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb inherit autotools pkgconfig

Quoted 4 lines
meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb +0 -4
-            fi
-        done
-        for link_header in ${D}${includedir}/tirpc/rpcsvc/*; do
-            if [ -f $link_header -a ! -e

${D}/${includedir}/rpcsvc/$(basename $link_header) ]; then

meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb inherit autotools pkgconfig · line 35

Quoted 1 line
meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb +0 -1
-                ln -sf ../tirpc/rpc/$(basename $link_header)

${D}${includedir}/rpcsvc/$(basename $link_header)

meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb inherit autotools pkgconfig

Quoted 8 lines
meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb +4 -3
-            fi
-        done
-        ln -sf  tirpc/netconfig.h ${D}/${includedir}/netconfig.h
+   chown root:root ${D}${sysconfdir}/netconfig
 
+   for dir in rpc rpcsvc; do
+           install -d ${D}${includedir}/$dir
+           for link_header in ${D}${includedir}/tirpc/$dir/*;

do

meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb inherit autotools pkgconfig · line 31

Quoted 2 lines
meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb +2 -0
+                   if [ -f $link_header ] &&
+                      [ ! -e

${D}${includedir}/$dir/$(basename $link_header) ]; then

meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb inherit autotools pkgconfig · line 32

Quoted 1 line
meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb +1 -0
+                           ln -sf ../tirpc/$dir/$(basename

$link_header) ${D}${includedir}/$dir/$(basename $link_header)

Quoted 8 lines
Quoted 8 lines

meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb inherit autotools pkgconfig · line 38

Quoted 6 lines
meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb +4 -0
+                   fi
+           done
+   done
+   ln -sf tirpc/netconfig.h ${D}${includedir}/netconfig.h
  }
 

I know this patch is making the existing logic better. But I dont

think

Quoted 1 line
Quoted 1 line

we should be substituting, sunrpc headers like this, what problems

does

Quoted 2 lines
Quoted 2 lines

this fix is not clear. tirpc is not a drop in replacement for sun rpc. Applications have to use it consciously. Sneaking the headers like

this

Quoted 5 lines
Quoted 3 lines

can cause subtle errors.

Perhaps original patch should just be reverted.

I'm perfectly fine with reverting the original patch instead as that

will

Quoted 6 lines

solve my problem.

Quoted 1 line

meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb inherit autotools pkgconfig · line 39

Quoted 1 line
meta/recipes-extended/libtirpc/libtirpc_1.1.4.bb +0 -0
  BBCLASSEXTEND = "native nativesdk"

//Peter