rust: Use libc++ runtime when using clang with llvm runtime
PATCH v2 1/1 rust: Use libc++ runtime when using clang with llvm runtime
meta-clang has options when it comes to C++ runtime, default is to use gnu runtime, other options are llvm runtime and android runtime. This patch helps when a distro is using llvm runtime for C/C++ runtime. It informs the rust build system about right C++ runtime to configure for when such a setting is used.
---
v2: Rebase now that 1.63 is in
meta/recipes-devtools/rust/rust.inc | 2 ++ 1 file changed, 2 insertions(+)
meta/recipes-devtools/rust/rust.inc +2 -0
@@ -107,6 +107,8 @@ python do_configure() { # [llvm] config.add_section("llvm") config.set("llvm", "static-libstdcpp", e(False)) + if "llvm" in (d.getVar('RUNTIME', True) or ""): + config.set("llvm", "use-libcxx", e(True)) # [rust] config.add_section("rust")
Signature · 1 line
2.37.3
Quoted 18 lines · Khem Raj
meta-clang has options when it comes to C++ runtime, default is to use gnu runtime, other options are llvm runtime and android runtime. This patch helps when a distro is using llvm runtime for C/C++ runtime. It informs the rust build system about right C++ runtime to configure for when such a setting is used.
Signed-off-by Khem Raj <[email protected]>---
v2: Rebase now that 1.63 is inmeta/recipes-devtools/rust/rust.inc | 2 ++ 1 file changed, 2 insertions(+)meta/recipes-devtools/rust/rust.inc +0
-0
meta/recipes-devtools/rust/rust.inc python do_configure() { · line 114
Quoted 8 lines
meta/recipes-devtools/rust/rust.inc +2
-0@@ -107,6 +107,8 @@ python do_configure() { # [llvm] config.add_section("llvm") config.set("llvm", "static-libstdcpp", e(False)) + if "llvm" in (d.getVar('RUNTIME', True) or ""): + config.set("llvm", "use-libcxx", e(True)) # [rust] config.add_section("rust")
My concerns about "RUNTIME" as a variable in OE-Core stand. We need to figure out the naming properly for this before it is used here.
Cheers,
Richard
Quoted 26 lines · Richard Purdie
Quoted 24 lines · Khem Raj
meta-clang has options when it comes to C++ runtime, default is to use gnu runtime, other options are llvm runtime and android runtime. This patch helps when a distro is using llvm runtime for C/C++ runtime. It informs the rust build system about right C++ runtime to configure for when such a setting is used.
Signed-off-by Khem Raj <[email protected]>---
v2: Rebase now that 1.63 is inmeta/recipes-devtools/rust/rust.inc | 2 ++ 1 file changed, 2 insertions(+)meta/recipes-devtools/rust/rust.inc +2
-0@@ -107,6 +107,8 @@ python do_configure() { # [llvm] config.add_section("llvm") config.set("llvm", "static-libstdcpp", e(False)) + if "llvm" in (d.getVar('RUNTIME', True) or ""): + config.set("llvm", "use-libcxx", e(True))
Quoted 6 lines
meta/recipes-devtools/rust/rust.inc python do_configure() { · line 114
Quoted 2 lines
meta/recipes-devtools/rust/rust.inc +0
-0# [rust] config.add_section("rust")My concerns about "RUNTIME" as a variable in OE-Core stand. We need to figure out the naming properly for this before it is used here.
Thats fine, do you see any other issue, I have addressed your other feedback. May be we should call itCL_RUNTIME which stands for compiler-language rumtime or we can call
<lang>_RUNTIME which in this case will be CXX_RUNTIME
Quoted 5 lines
Cheers,
Richard