drm/amd/pm: remove unneeded variable
Subsystems (3)
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 drm/amd/pm: remove unneeded variable
fix the following coccicheck warning:
drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c:1657:14-18: Unneeded variable: "size".
--- drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c +1 -1
@@ -1654,7 +1654,7 @@ static int navi10_force_clk_levels(struct smu_context *smu, enum smu_clk_type clk_type, uint32_t mask) { - int ret = 0, size = 0; + int ret = 0; uint32_t soft_min_level = 0, soft_max_level = 0, min_freq = 0,
max_freq = 0;
soft_min_level = mask ? (ffs(mask) - 1) : 0;
@@ -1675,15 +1675,15 @@ static int navi10_force_clk_levels(struct smu_context *smu,
ret = smu_v11_0_get_dpm_freq_by_index(smu, clk_type,
soft_min_level, &min_freq);
if (ret)
- return size;
+ return 0;
ret = smu_v11_0_get_dpm_freq_by_index(smu, clk_type,
soft_max_level, &max_freq);
if (ret)
- return size;
+ return 0;
ret = smu_v11_0_set_soft_freq_limited_range(smu, clk_type,
min_freq, max_freq);
if (ret)
- return size;
+ return 0;
break;
case SMU_DCEFCLK:
dev_info(smu->adev->dev,"Setting DCEFCLK min/max dpm level is
not supported!\n");
@@ -1693,7 +1693,7 @@ static int navi10_force_clk_levels(struct smu_context *smu,
break;
}- return size;
+ return 0;
}
static int navi10_populate_umd_state_clk(struct smu_context *smu)
Alex Deucher
AppliedApplied, but please check your mailer. I had to manually fix this up.
Alex
Quoted 61 lines · On Wed, Jun 14, 2023 at 3:21 AM <[email protected]> wrote:
fix the following coccicheck warning:
drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c:1657:14-18: Unneeded
variable: "size".Signed-off-by Mingtong Bao <[email protected]>--- drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c +1
-1@@ -1654,7 +1654,7 @@ static int navi10_force_clk_levels(structsmu_context *smu, enum smu_clk_type clk_type, uint32_t mask) { - int ret = 0, size = 0; + int ret = 0;uint32_t soft_min_level =0 , soft_max_level =0 , min_freq =0 , max_freq =0 ;soft_min_level = mask ? (ffs(mask) - 1) : 0;drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c +3
-3@@ -1675,15 +1675,15 @@ static int navi10_force_clk_levels(structsmu_context *smu, ret =smu_v11_0_get_dpm_freq_by_index (smu, clk_type, soft_min_level, &min_freq);if (ret) -return size; +return 0 ; ret =smu_v11_0_get_dpm_freq_by_index (smu, clk_type, soft_max_level, &max_freq);if (ret) -return size; +return 0 ; ret =smu_v11_0_set_soft_freq_limited_range (smu, clk_type, min_freq, max_freq);if (ret) -return size; +return 0 ;break ;case SMU_DCEFCLK : dev_info(smu->adev->dev,"Setting DCEFCLK min/max dpm level isnot supported!\n");
drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c +1
-1@@ -1693,7 +1693,7 @@ static int navi10_force_clk_levels(structsmu_context *smu, break; } -return size; +return 0 ; }static int
navi10_populate_umd_state_clk(struct smu_context *smu)