ubsan: disallow bounds checking with gcov on broken gcc
Subsystems (5)
RFC PATCH 1/1 ubsan: disallow bounds checking with gcov on broken gcc
From: Arnd Bergmann <[email protected]>
Combining UBSAN and GCOV in randconfig builds results in a number of stack frame size warnings, such as:
crypto/twofish_common.c:683:1: error: the frame size of 2040 bytes is larger than 1024 bytes [-Werror=frame-larger-than=] drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c:1589:1: error: the frame size of 1696 bytes is larger than 1400 bytes [-Werror=frame-larger-than=] drivers/media/platform/verisilicon/hantro_g2_vp9_dec.c:754:1: error: the frame size of 1260 bytes is larger than 1024 bytes [-Werror=frame-larger-than=] drivers/staging/media/ipu3/ipu3-css-params.c:1206:1: error: the frame size of 1080 bytes is larger than 1024 bytes [-Werror=frame-larger-than=] drivers/staging/media/rkvdec/rkvdec-vp9.c:1042:1: error: the frame size of 2176 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] drivers/staging/media/rkvdec/rkvdec-vp9.c:995:1: error: the frame size of 1656 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]
I managed to track this down to the -fsanitize=bounds option clashing with the -fprofile-arcs option, which leads a lot of spilled temporary variables in generated instrumentation code.
Hopefully this can be addressed in future gcc releases the same way that clang handles the combination, but for existing compiler releases, it seems best to disable one of the two flags. This can be done either globally by just not passing both at the same time, or locally using the no_sanitize or no_instrument_function attributes in the affected functions.
Try the simplest approach here, and turn off -fsanitize=bounds on gcc when GCOV is enabled, leaving the rest of UBSAN working. Doing this globally also helps avoid inefficient code from the same problem that did not push the build over the warning limit.
--- lib/Kconfig.ubsan | 2 ++ 1 file changed, 2 insertions(+)
lib/Kconfig.ubsan +2 -0
@@ -29,6 +29,8 @@ config UBSAN_TRAP config CC_HAS_UBSAN_BOUNDS_STRICT def_bool $(cc-option,-fsanitize=bounds-strict) + # work around https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110074 + depends on GCC_VERSION > 140000 || !GCOV_PROFILE_ALL help The -fsanitize=bounds-strict option is only available on GCC, but uses the more strict handling of arrays that includes knowledge
Signature · 1 line
2.39.2
Quoted 28 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
Combining UBSAN and GCOV in randconfig builds results in a number of stack frame size warnings, such as:
crypto/twofish_common.c:683:1: error: the frame size of 2040 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c:1589:1: error: the frame size of 1696 bytes is larger than 1400 bytes [-Werror=frame-larger-than=]drivers/media/platform/verisilicon/hantro_g2_vp9_dec.c:754:1: error: the frame size of 1260 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]drivers/staging/media/ipu3/ipu3-css-params.c:1206:1: error: the frame size of 1080 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]drivers/staging/media/rkvdec/rkvdec-vp9.c:1042:1: error: the frame size of 2176 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]drivers/staging/media/rkvdec/rkvdec-vp9.c:995:1: error: the frame size of 1656 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]I managed to track this down to the -fsanitize=bounds option clashing with the -fprofile-arcs option, which leads a lot of spilled temporary variables in generated instrumentation code.
Hopefully this can be addressed in future gcc releases the same way that clang handles the combination, but for existing compiler releases, it seems best to disable one of the two flags. This can be done either globally by just not passing both at the same time, or locally using the
no_sanitizeorno_instrument_functionattributes in the affected functions.Try the simplest approach here, and turn off -fsanitize=bounds on gcc when GCOV is enabled, leaving the rest of UBSAN working. Doing this globally also helps avoid inefficient code from the same problem that did not push the build over the warning limit.
Quoted 5 lines
I think more production systems will have CONFIG_UBSAN_BOUNDS enabled (e.g. Ubuntu has had it enabled for more than a year now) than GCOV, so I'd prefer we maintain all*config coverage for the more commonly used config.
Quoted 9 lines
--- lib/Kconfig.ubsan | 2 ++ 1 file changed, 2 insertions(+)lib/Kconfig.ubsan +0
-0
lib/Kconfig.ubsan config UBSAN_TRAP · line 36
Quoted 8 lines
lib/Kconfig.ubsan +2
-0@@ -29,6 +29,8 @@ config UBSAN_TRAP config CC_HAS_UBSAN_BOUNDS_STRICT def_bool $(cc-option,-fsanitize=bounds-strict) + # work around https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110074 + depends on GCC_VERSION > 140000 || !GCOV_PROFILE_ALL help The -fsanitize=bounds-strict option is only available on GCC, but uses the more strict handling of arrays that includes knowledge
Alternatively, how about falling back to -fsanitize=bounds instead, as that (which has less coverage) wasn't triggering the stack frame warnings?
i.e. fall back through these:
-fsanitize=array-bounds (Clang) -fsanitize=bounds-strict (!GCOV || bug fixed in GCC) -fsanitize=bounds
Signature · 1 line
Kees Cook
Quoted 6 lines · Kees Cook
On Thu, Jun 01, 2023 at 05:18:11PM +0200, Arnd Bergmann wrote:
I think more production systems will have
CONFIG_UBSAN_BOUNDSenabled (e.g. Ubuntu has had it enabled for more than a year now) than GCOV, so I'd prefer we maintain all*config coverage for the more commonly used config.
Fair enough, I can send that as v2, but let's see what the others think first.
Quoted 12 lines
lib/Kconfig.ubsan config UBSAN_TRAP · line 36
Quoted 7 lines
config
CC_HAS_UBSAN_BOUNDS_STRICTlib/Kconfig.ubsan +2
-0def_bool $(cc-option,-fsanitize=bounds-strict) + # work around https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110074 + depends on GCC_VERSION > 140000 || !GCOV_PROFILE_ALL help The -fsanitize=bounds-strict option is only available on GCC, but uses the more strict handling of arrays that includes knowledgeAlternatively, how about falling back to -fsanitize=bounds instead, as that (which has less coverage) wasn't triggering the stack frame warnings?
Quoted 4 lines
i.e. fall back through these:
-fsanitize=array-bounds (Clang) -fsanitize=bounds-strict (!GCOV || bug fixed in GCC) -fsanitize=bounds
From what I can tell, -fsanitize=bounds has the same problem as -fsanitize=bounds-strict, so that would not help.
Arnd
Quoted 23 lines · Arnd Bergmann
Quoted 6 lines · Kees Cook
On Thu, Jun 01, 2023 at 05:18:11PM +0200, Arnd Bergmann wrote:
I think more production systems will have
CONFIG_UBSAN_BOUNDSenabled (e.g. Ubuntu has had it enabled for more than a year now) than GCOV, so I'd prefer we maintain all*config coverage for the more commonly used config.Fair enough, I can send that as v2, but let's see what the others think first.
Quoted 12 lines
lib/Kconfig.ubsan config UBSAN_TRAP · line 36
Quoted 7 lines
config
CC_HAS_UBSAN_BOUNDS_STRICTlib/Kconfig.ubsan +2
-0def_bool $(cc-option,-fsanitize=bounds-strict) + # work around https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110074 + depends on GCC_VERSION > 140000 || !GCOV_PROFILE_ALL help The -fsanitize=bounds-strict option is only available on GCC, but uses the more strict handling of arrays that includes knowledgeAlternatively, how about falling back to -fsanitize=bounds instead, as that (which has less coverage) wasn't triggering the stack frame warnings?
Quoted 7 lines
Quoted 4 lines
i.e. fall back through these:
-fsanitize=array-bounds (Clang) -fsanitize=bounds-strict (!GCOV || bug fixed in GCC) -fsanitize=boundsFrom what I can tell, -fsanitize=bounds has the same problem as -fsanitize=bounds-strict, so that would not help.
Ah, did something change with GCOV? This (bounds vs bounds-strict) is the only recent change to CONFIG_UBSAN_BOUNDS...
Signature · 1 line
Kees Cook
Quoted 8 lines · Kees Cook
Quoted 7 lines · Arnd Bergmann
Quoted 5 lines · Kees Cook
i.e. fall back through these:
-fsanitize=array-bounds (Clang) -fsanitize=bounds-strict (!GCOV || bug fixed in GCC) -fsanitize=bounds
Quoted 5 lines
Quoted 2 lines
From what I can tell, -fsanitize=bounds has the same problem as -fsanitize=bounds-strict, so that would not help.
Ah, did something change with GCOV? This (bounds vs bounds-strict) is the only recent change to
CONFIG_UBSAN_BOUNDS...
I missed this problem in my usual randconfig builds because I was building with GCOV disabled due to disk size limitations until Dan Carpenter pointed out the specific issue.
I suspect it's been there for a longer time.
Arnd