staging: r8188eu: clean up spacing style issues in core dir
cover staging: r8188eu: clean up spacing style issues in core dir
This series cleans up coding style issues in the core directory reported by checkpatch --types SPACING.
Michael Straube (23):
staging: r8188eu: add spaces around operators in core/rtw_ap.c
staging: r8188eu: rewrite subtraction in core/rtw_cmd.c
staging: r8188eu: remove unnecessary parentheses in core/rtw_cmd.c
staging: r8188eu: clean up spacing style issues in core/rtw_cmd.c
staging: r8188eu: clean up spacing style issues in core/rtw_efuse.c
staging: r8188eu: clean up spacing style issues in
core/rtw_ieee80211.c
staging: r8188eu: simplify multiplication in core/rtw_ioctl_set.c
staging: r8188eu: clean up spacing style issues in
core/rtw_ioctl_set.c
staging: r8188eu: add spaces around operators in core/rtw_iol.c
staging: r8188eu: clean up spacing style issues in core/rtw_mlme.c
staging: r8188eu: clean up spacing style issues in core/rtw_mlme_ext.c
staging: r8188eu: clean up spacing style issues in core/rtw_mp.c
staging: r8188eu: clean up spacing style issues in core/rtw_mp_ioctl.c
staging: r8188eu: clean up spacing style issues in core/rtw_p2p.c
staging: r8188eu: clean up spacing style issues in core/rtw_pwrctrl.c
staging: r8188eu: clean up spacing style issues in core/rtw_recv.c
staging: r8188eu: clean up spacing style issues in core/rtw_security.c
staging: r8188eu: add spaces around operators in core/rtw_wlan_util.c
staging: r8188eu: clean up spacing style issues in core/rtw_xmit.c
staging: r8188eu: clean up spacing style issues in core/rtw_debug.c
staging: r8188eu: add space around operator in core/rtw_sreset.c
staging: r8188eu: clean up spacing style issues in core/rtw_sta_mgt.c
staging: r8188eu: add spaces around operators in core/rtw_br_ext.c
drivers/staging/r8188eu/core/rtw_ap.c | 88 +++---- drivers/staging/r8188eu/core/rtw_br_ext.c | 104 ++++---- drivers/staging/r8188eu/core/rtw_cmd.c | 22 +- drivers/staging/r8188eu/core/rtw_debug.c | 42 ++-- drivers/staging/r8188eu/core/rtw_efuse.c | 96 ++++---- drivers/staging/r8188eu/core/rtw_ieee80211.c | 124 +++++----- drivers/staging/r8188eu/core/rtw_ioctl_set.c | 20 +- drivers/staging/r8188eu/core/rtw_iol.c | 12 +- drivers/staging/r8188eu/core/rtw_mlme.c | 80 +++---- drivers/staging/r8188eu/core/rtw_mlme_ext.c | 236 +++++++++---------- drivers/staging/r8188eu/core/rtw_mp.c | 10 +- drivers/staging/r8188eu/core/rtw_mp_ioctl.c | 6 +- drivers/staging/r8188eu/core/rtw_p2p.c | 46 ++-- drivers/staging/r8188eu/core/rtw_pwrctrl.c | 16 +- drivers/staging/r8188eu/core/rtw_recv.c | 112 ++++----- drivers/staging/r8188eu/core/rtw_security.c | 188 +++++++-------- drivers/staging/r8188eu/core/rtw_sreset.c | 2 +- drivers/staging/r8188eu/core/rtw_sta_mgt.c | 6 +- drivers/staging/r8188eu/core/rtw_wlan_util.c | 60 ++--- drivers/staging/r8188eu/core/rtw_xmit.c | 122 +++++----- 20 files changed, 696 insertions(+), 696 deletions(-)
Signature · 1 line
2.32.0
PATCH 1/23 staging: r8188eu: add spaces around operators in core/rtw_ap.c
Add missing spaces around operators in core/rtw_ap.c reported by checkpatch.
--- drivers/staging/r8188eu/core/rtw_ap.c | 88 +++++++++++++-------------- 1 file changed, 44 insertions(+), 44 deletions(-)
drivers/staging/r8188eu/core/rtw_ap.c +44 -44
@@ -69,7 +69,7 @@ static void update_BCNTIM(struct adapter *padapter) p =rtw_get_ie (pie + _FIXED_IE_LENGTH_, _TIM_IE_, &tim_ielen, pnetwork_mlmeext->IELength - _FIXED_IE_LENGTH_);if (p && tim_ielen >0 ) { tim_ielen +=2 ; - premainder_ie = p+tim_ielen; + premainder_ie = p + tim_ielen; tim_ie_offset = (int )(p - pie); remainder_ielen = pnetwork_mlmeext->IELength - tim_ie_offset - tim_ielen;/* append TIM IE from dst_ie offset */
@@ -84,7 +84,7 @@ static void update_BCNTIM(struct adapter *padapter)/* get supported rates len */ p =rtw_get_ie (pie + _BEACON_IE_OFFSET_, _SUPPORTEDRATES_IE_, &tmp_len, (pnetwork_mlmeext->IELength - _BEACON_IE_OFFSET_));if (p) - offset += tmp_len+2 ; + offset += tmp_len +2 ;/* DS Parameter Set IE, len = 3 */ offset +=3 ;
@@ -104,7 +104,7 @@ static void update_BCNTIM(struct adapter *padapter) } *dst_ie++ = _TIM_IE_; -if ((pstapriv->tim_bitmap&0xff00 ) && (pstapriv->tim_bitmap&0x00fc )) +if ((pstapriv->tim_bitmap &0xff00 ) && (pstapriv->tim_bitmap &0x00fc )) tim_ielen =5 ;else tim_ielen =4 ;
@@ -114,7 +114,7 @@ static void update_BCNTIM(struct adapter *padapter) *dst_ie++ =0 ;/* DTIM count */ *dst_ie++ =1 ;/* DTIM period */ -if (pstapriv->tim_bitmap&BIT (0 ))/* for bc/mc frames */ +if (pstapriv->tim_bitmap &BIT (0 ))/* for bc/mc frames */ *dst_ie++ =BIT (0 );/* bitmap ctrl */ else *dst_ie++ =0 ;
@@ -167,7 +167,7 @@ void rtw_add_bcn_ie(struct adapter *padapter, struct wlan_bssid_ex *pnetwork, u8if (p && ielen >0 ) { ielen +=2 ; - premainder_ie = p+ielen; + premainder_ie = p + ielen; ie_offset = (int )(p - pie);
@@ -176,7 +176,7 @@ void rtw_add_bcn_ie(struct adapter *padapter, struct wlan_bssid_ex *pnetwork, u8if (bmatch) dst_ie = p;else - dst_ie = (p+ielen); + dst_ie = (p + ielen); }if (remainder_ielen >0 ) {
@@ -214,7 +214,7 @@ void rtw_remove_bcn_ie(struct adapter *padapter, struct wlan_bssid_ex *pnetwork,if (p && ielen >0 ) { ielen +=2 ; - premainder_ie = p+ielen; + premainder_ie = p + ielen; ie_offset = (int )(p - pie);
@@ -355,8 +355,8 @@ void expire_timeout_chk(struct adapter *padapter) updated =ap_free_sta (padapter, psta, true,WLAN_REASON_DEAUTH_LEAVING ); }else {/* TODO: Aging mechanism to digest frames in sleep_q to avoid running out of xmitframe */ -if (psta->sleepq_len > (NR_XMITFRAME /pstapriv->asoc_list_cnt) && - padapter->xmitpriv.free_xmitframe_cnt < (NR_XMITFRAME /pstapriv->asoc_list_cnt/2 )) { +if (psta->sleepq_len > (NR_XMITFRAME / pstapriv->asoc_list_cnt) && + padapter->xmitpriv.free_xmitframe_cnt < (NR_XMITFRAME / pstapriv->asoc_list_cnt /2 )) { DBG_88E("%s sta:%pM, sleepq_len:%u, free_xmitframe_cnt:%u, asoc_list_cnt:%u, clear sleep_q\n", __func__, (psta->hwaddr), psta->sleepq_len, padapter->xmitpriv.free_xmitframe_cnt,
@@ -440,7 +440,7 @@ void add_RATid(struct adapter *padapter, struct sta_info *psta, u8 rssi_level)/* b/g mode ra_bitmap */ for (i =0 ; i <sizeof (psta->bssrateset); i++) {if (psta->bssrateset[i]) - tx_ra_bitmap |=rtw_get_bit_value_from_ieee_value (psta->bssrateset[i]&0x7f ); + tx_ra_bitmap |=rtw_get_bit_value_from_ieee_value (psta->bssrateset[i] &0x7f ); }/* n mode ra_bitmap */ if (psta_ht->ht_option) {
@@ -451,8 +451,8 @@ void add_RATid(struct adapter *padapter, struct sta_info *psta, u8 rssi_level) limit =8 ;/* 1R */ for (i =0 ; i < limit; i++) { -if (psta_ht->ht_cap.mcs.rx_mask[i/8 ] &BIT (i%8 )) - tx_ra_bitmap |=BIT (i+12 ); +if (psta_ht->ht_cap.mcs.rx_mask[i /8 ] &BIT (i %8 )) + tx_ra_bitmap |=BIT (i +12 ); }/* max short GI rate */
@@ -473,19 +473,19 @@ void add_RATid(struct adapter *padapter, struct sta_info *psta, u8 rssi_level) psta->wireless_mode = sta_band; raid =networktype_to_raid (sta_band); - init_rate =get_highest_rate_idx (tx_ra_bitmap&0x0fffffff )&0x3f ; + init_rate =get_highest_rate_idx (tx_ra_bitmap &0x0fffffff ) &0x3f ;if (psta->aid <NUM_STA ) {u8 arg =0 ; - arg = psta->mac_id&0x1f ; + arg = psta->mac_id &0x1f ; arg |=BIT (7 );/* support entry 2~31 */ if (shortGIrate) arg |=BIT (5 ); - tx_ra_bitmap |= ((raid<<28 )&0xf0000000 ); + tx_ra_bitmap |= ((raid <<28 ) &0xf0000000 );DBG_88E ("%s => mac_id:%d , raid:%d , bitmap = 0x%x, arg = 0x%x\n" , __func__, psta->mac_id, raid, tx_ra_bitmap, arg);
@@ -539,7 +539,7 @@ void update_bmc_sta(struct adapter *padapter)/* b/g mode ra_bitmap */ for (i =0 ; i < supportRateNum; i++) {if (psta->bssrateset[i]) - tx_ra_bitmap |=rtw_get_bit_value_from_ieee_value (psta->bssrateset[i]&0x7f ); + tx_ra_bitmap |=rtw_get_bit_value_from_ieee_value (psta->bssrateset[i] &0x7f ); }if (pcur_network->Configuration.DSConfig >14 ) {
@@ -551,7 +551,7 @@ void update_bmc_sta(struct adapter *padapter) } raid =networktype_to_raid (network_type); - init_rate =get_highest_rate_idx (tx_ra_bitmap&0x0fffffff )&0x3f ; + init_rate =get_highest_rate_idx (tx_ra_bitmap &0x0fffffff ) &0x3f ;/* ap mode */ rtw_hal_set_odm_var (padapter,HAL_ODM_STA_INFO , psta, true);
@@ -559,9 +559,9 @@ void update_bmc_sta(struct adapter *padapter) {u8 arg =0 ; - arg = psta->mac_id&0x1f ; + arg = psta->mac_id &0x1f ; arg |=BIT (7 ); - tx_ra_bitmap |= ((raid<<28 )&0xf0000000 ); + tx_ra_bitmap |= ((raid <<28 ) &0xf0000000 );DBG_88E ("update_bmc_sta, mask = 0x%x, arg = 0x%x\n" , tx_ra_bitmap, arg);/* bitmap[0:27] = tx_rate_bitmap */
@@ -602,7 +602,7 @@ void update_sta_info_apmode(struct adapter *padapter, struct sta_info *psta)u16 sta_cap_info;u16 ap_cap_info; - psta->mac_id = psta->aid+1 ; + psta->mac_id = psta->aid +1 ;DBG_88E ("%s\n" , __func__);/* ap mode */
@@ -716,7 +716,7 @@ static void start_bss_network(struct adapter *padapter, u8 *pbuf)/* check if there is wps ie, */ /* if there is wpsie in beacon, the hostapd will update beacon twice when stating hostapd, */ /* and at first time the security ie (RSN/WPA IE) will not include in beacon. */ -if (!rtw_get_wps_ie (pnetwork->IEs+_FIXED_IE_LENGTH_, pnetwork->IELength-_FIXED_IE_LENGTH_,NULL ,NULL )) +if (!rtw_get_wps_ie (pnetwork->IEs + _FIXED_IE_LENGTH_, pnetwork->IELength - _FIXED_IE_LENGTH_,NULL ,NULL )) pmlmeext->bstart_bss = true;/* todo: update wmm, ht cap */
@@ -769,7 +769,7 @@ static void start_bss_network(struct adapter *padapter, u8 *pbuf)/* set channel, bwmode */ p =rtw_get_ie ((pnetwork->IEs +sizeof (struct ndis_802_11_fixed_ie )), _HT_ADD_INFO_IE_, &ie_len, (pnetwork->IELength -sizeof (struct ndis_802_11_fixed_ie )));if (p && ie_len) { - pht_info = (struct HT_info_element *)(p+2 ); + pht_info = (struct HT_info_element *)(p +2 );if ((pregpriv->cbw40_enable) && (pht_info->infos[0 ] &BIT (2 ))) {/* switch to the 40M Hz mode */
@@ -904,14 +904,14 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf, int len)/* get supported rates */ p =rtw_get_ie (ie + _BEACON_IE_OFFSET_, _SUPPORTEDRATES_IE_, &ie_len, (pbss_network->IELength - _BEACON_IE_OFFSET_));if (p) { -memcpy (supportRate, p+2 , ie_len); +memcpy (supportRate, p +2 , ie_len); supportRateNum = ie_len; }/* get ext_supported rates */ p =rtw_get_ie (ie + _BEACON_IE_OFFSET_, _EXT_SUPPORTEDRATES_IE_, &ie_len, pbss_network->IELength - _BEACON_IE_OFFSET_);if (p) { -memcpy (supportRate+supportRateNum, p+2 , ie_len); +memcpy (supportRate + supportRateNum, p +2 , ie_len); supportRateNum += ie_len; }
@@ -939,7 +939,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf, int len) psecuritypriv->wpa2_pairwise_cipher = _NO_PRIVACY_; p =rtw_get_ie (ie + _BEACON_IE_OFFSET_, _RSN_IE_2_, &ie_len, (pbss_network->IELength - _BEACON_IE_OFFSET_));if (p && ie_len >0 ) { -if (rtw_parse_wpa2_ie (p, ie_len+2 , &group_cipher, &pairwise_cipher,NULL ) == _SUCCESS) { +if (rtw_parse_wpa2_ie (p, ie_len +2 , &group_cipher, &pairwise_cipher,NULL ) == _SUCCESS) { psecuritypriv->dot11AuthAlgrthm = dot11AuthAlgrthm_8021X; psecuritypriv->dot8021xalg =1 ;/* psk, todo:802.1x */
@@ -958,8 +958,8 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf, int len)for (p = ie + _BEACON_IE_OFFSET_;; p += (ie_len +2 )) { p =rtw_get_ie (p, _SSN_IE_1_, &ie_len, (pbss_network->IELength - _BEACON_IE_OFFSET_ - (ie_len +2 ))); -if ((p) && (!memcmp (p+2 ,OUI1 ,4 ))) { -if (rtw_parse_wpa_ie (p, ie_len+2 , &group_cipher, +if ((p) && (!memcmp (p +2 ,OUI1 ,4 ))) { +if (rtw_parse_wpa_ie (p, ie_len +2 , &group_cipher, &pairwise_cipher,NULL ) == _SUCCESS) { psecuritypriv->dot11AuthAlgrthm = dot11AuthAlgrthm_8021X;
@@ -983,10 +983,10 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf, int len)for (p = ie + _BEACON_IE_OFFSET_;; p += (ie_len +2 )) { p =rtw_get_ie (p, _VENDOR_SPECIFIC_IE_, &ie_len, (pbss_network->IELength - _BEACON_IE_OFFSET_ - (ie_len +2 ))); -if ((p) && !memcmp (p+2 ,WMM_PARA_IE ,6 )) { +if ((p) && !memcmp (p +2 ,WMM_PARA_IE ,6 )) { pmlmepriv->qospriv.qos_option =1 ; - *(p+8 ) |=BIT (7 );/* QoS Info, support U-APSD */ + *(p +8 ) |=BIT (7 );/* QoS Info, support U-APSD */ /* disable all ACM bits since the WMM admission control is not supported */ *(p +10 ) &= ~BIT (4 );/* BE */
@@ -1005,7 +1005,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf, int len) (pbss_network->IELength - _BEACON_IE_OFFSET_));if (p && ie_len >0 ) {u8 rf_type; -struct ieee80211_ht_cap *pht_cap = (struct ieee80211_ht_cap *)(p+2 ); +struct ieee80211_ht_cap *pht_cap = (struct ieee80211_ht_cap *)(p +2 ); pHT_caps_ie = p; ht_cap = true;
@@ -1026,7 +1026,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf, int len) pht_cap->mcs.rx_mask[0 ] =0xff ; pht_cap->mcs.rx_mask[1 ] =0x0 ; } -memcpy (&pmlmepriv->htpriv.ht_cap, p+2 , ie_len); +memcpy (&pmlmepriv->htpriv.ht_cap, p +2 , ie_len); }/* parsing HT_INFO_IE */
@@ -1113,7 +1113,7 @@ int rtw_acl_add_sta(struct adapter *padapter, u8 *addr)DBG_88E ("%s(acl_num =%d) =%pM\n" , __func__, pacl_list->num, (addr)); -if ((NUM_ACL -1 ) < pacl_list->num) +if ((NUM_ACL -1 ) < pacl_list->num)return -1 ;spin_lock_bh (&pacl_node_q->lock);
@@ -1229,9 +1229,9 @@ static void update_bcn_erpinfo_ie(struct adapter *padapter)struct ndis_802_11_var_ie *pIE = (struct ndis_802_11_var_ie *)p;if (pmlmepriv->num_sta_non_erp ==1 ) - pIE->data[0 ] |=RTW_ERP_INFO_NON_ERP_PRESENT |RTW_ERP_INFO_USE_PROTECTION ; + pIE->data[0 ] |=RTW_ERP_INFO_NON_ERP_PRESENT |RTW_ERP_INFO_USE_PROTECTION ;else - pIE->data[0 ] &= ~(RTW_ERP_INFO_NON_ERP_PRESENT |RTW_ERP_INFO_USE_PROTECTION ); + pIE->data[0 ] &= ~(RTW_ERP_INFO_NON_ERP_PRESENT |RTW_ERP_INFO_USE_PROTECTION );if (pmlmepriv->num_sta_no_short_preamble >0 ) pIE->data[0 ] |=RTW_ERP_INFO_BARKER_PREAMBLE_MODE ;
@@ -1281,12 +1281,12 @@ static void update_bcn_wps_ie(struct adapter *padapter)DBG_88E ("%s\n" , __func__); - pwps_ie =rtw_get_wps_ie (ie+_FIXED_IE_LENGTH_, ielen-_FIXED_IE_LENGTH_,NULL , &wps_ielen); + pwps_ie =rtw_get_wps_ie (ie + _FIXED_IE_LENGTH_, ielen - _FIXED_IE_LENGTH_,NULL , &wps_ielen);if (!pwps_ie || wps_ielen ==0 )return ; - wps_offset = (uint)(pwps_ie-ie); + wps_offset = (uint)(pwps_ie - ie); premainder_ie = pwps_ie + wps_ielen;
@@ -1303,15 +1303,15 @@ static void update_bcn_wps_ie(struct adapter *padapter)return ; wps_ielen = (uint )pwps_ie_src[1 ];/* to get ie data len */ -if ((wps_offset+wps_ielen+2 +remainder_ielen) <=MAX_IE_SZ ) { -memcpy (pwps_ie, pwps_ie_src, wps_ielen+2 ); - pwps_ie += (wps_ielen+2 ); +if ((wps_offset + wps_ielen +2 + remainder_ielen) <=MAX_IE_SZ ) { +memcpy (pwps_ie, pwps_ie_src, wps_ielen +2 ); + pwps_ie += (wps_ielen +2 );if (pbackup_remainder_ie)memcpy (pwps_ie, pbackup_remainder_ie, remainder_ielen);/* update IELength */ - pnetwork->IELength = wps_offset + (wps_ielen+2 ) + remainder_ielen; + pnetwork->IELength = wps_offset + (wps_ielen +2 ) + remainder_ielen; }if (pbackup_remainder_ie)
@@ -1744,7 +1744,7 @@ int rtw_ap_inform_ch_switch(struct adapter *padapter, u8 new_ch, u8 ch_offset)struct mlme_ext_info *pmlmeinfo = &pmlmeext->mlmext_info;u8 bc_addr[ETH_ALEN ] = {0xff ,0xff ,0xff ,0xff ,0xff ,0xff }; -if ((pmlmeinfo->state&0x03 ) !=WIFI_FW_AP_STATE ) +if ((pmlmeinfo->state &0x03 ) !=WIFI_FW_AP_STATE )return ret; DBG_88E(FUNC_NDEV_FMT" with ch:%u, offset:%u\n",
@@ -1781,7 +1781,7 @@ int rtw_sta_flush(struct adapter *padapter)DBG_88E (FUNC_NDEV_FMT "\n" ,FUNC_NDEV_ARG (padapter->pnetdev)); -if ((pmlmeinfo->state&0x03 ) !=WIFI_FW_AP_STATE ) +if ((pmlmeinfo->state &0x03 ) !=WIFI_FW_AP_STATE )return ret;spin_lock_bh (&pstapriv->asoc_list_lock);
@@ -1815,7 +1815,7 @@ void sta_info_update(struct adapter *padapter, struct sta_info *psta)struct mlme_priv *pmlmepriv = &padapter->mlmepriv;/* update wmm cap. */ -if (WLAN_STA_WME &flags) +if (WLAN_STA_WME & flags) psta->qos_option =1 ;else psta->qos_option =0 ;
@@ -1824,7 +1824,7 @@ void sta_info_update(struct adapter *padapter, struct sta_info *psta) psta->qos_option =0 ;/* update 802.11n ht cap. */ -if (WLAN_STA_HT &flags) { +if (WLAN_STA_HT & flags) { psta->htpriv.ht_option = true; psta->qos_option =1 ; }else {
Signature · 1 line
2.32.0
PATCH 2/23 staging: r8188eu: rewrite subtraction in core/rtw_cmd.c
In reply to Michael StraubeRewrite subtraction in core/rtw_cmd.c to clear missing spaces around operator reported by checkpatch.
256-1 -> 255
--- drivers/staging/r8188eu/core/rtw_cmd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/r8188eu/core/rtw_cmd.c +2 -2
@@ -832,10 +832,10 @@ u8 rtw_joinbss_cmd(struct adapter *padapter, struct wlan_network *pnetwork) psecuritypriv->authenticator_ie[0 ] = (unsigned char )psecnetwork->IELength; -if ((psecnetwork->IELength-12 ) < (256 -1 )) { +if ((psecnetwork->IELength-12 ) <255 ) {memcpy (&psecuritypriv->authenticator_ie[1 ], &psecnetwork->IEs[12 ], psecnetwork->IELength-12 ); }else { -memcpy (&psecuritypriv->authenticator_ie[1 ], &psecnetwork->IEs[12 ], (256 -1 )); +memcpy (&psecuritypriv->authenticator_ie[1 ], &psecnetwork->IEs[12 ],255 ); } psecnetwork->IELength =0 ;
Signature · 1 line
2.32.0
PATCH 3/23 staging: r8188eu: remove unnecessary parentheses in core/rtw_cmd.c
In reply to Michael StraubeRemove unnecessary parentheses in core/rtw_cmd.c.
--- drivers/staging/r8188eu/core/rtw_cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/r8188eu/core/rtw_cmd.c +1 -1
@@ -832,7 +832,7 @@ u8 rtw_joinbss_cmd(struct adapter *padapter, struct wlan_network *pnetwork) psecuritypriv->authenticator_ie[0 ] = (unsigned char )psecnetwork->IELength; -if ((psecnetwork->IELength-12 ) <255 ) { +if (psecnetwork->IELength-12 <255 ) {memcpy (&psecuritypriv->authenticator_ie[1 ], &psecnetwork->IEs[12 ], psecnetwork->IELength-12 ); }else {memcpy (&psecuritypriv->authenticator_ie[1 ], &psecnetwork->IEs[12 ],255 );
Signature · 1 line
2.32.0
PATCH 4/23 staging: r8188eu: clean up spacing style issues in core/rtw_cmd.c
In reply to Michael StraubeClean up spacing style issues in core/rtw_cmd.c reported by checkpatch.
CHECK: spaces preferred around that ...
CHECK: No space is necessary after a cast
WARNING: space prohibited between function name and open parenthesis '('
--- drivers/staging/r8188eu/core/rtw_cmd.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-)
drivers/staging/r8188eu/core/rtw_cmd.c +10 -10
@@ -16,7 +16,7 @@ Caller and the rtw_cmd_thread can protect cmd_q by spin_lock.No irqsave is necessary. */ -int _rtw_init_cmd_priv (struct cmd_priv *pcmdpriv) +int _rtw_init_cmd_priv (struct cmd_priv *pcmdpriv) {int res = _SUCCESS;
@@ -38,7 +38,7 @@ int _rtw_init_cmd_priv (struct cmd_priv *pcmdpriv) goto exit; } - pcmdpriv->cmd_buf = pcmdpriv->cmd_allocated_buf +CMDBUFF_ALIGN_SZ - ((size_t )(pcmdpriv->cmd_allocated_buf) & (CMDBUFF_ALIGN_SZ -1 )); + pcmdpriv->cmd_buf = pcmdpriv->cmd_allocated_buf +CMDBUFF_ALIGN_SZ - ((size_t )(pcmdpriv->cmd_allocated_buf) & (CMDBUFF_ALIGN_SZ -1 )); pcmdpriv->rsp_allocated_buf =kzalloc (MAX_RSPSZ +4 ,GFP_KERNEL );
@@ -69,7 +69,7 @@ int _rtw_init_evt_priv(struct evt_priv *pevtpriv)_init_workitem (&pevtpriv->c2h_wk, c2h_wk_callback,NULL ); pevtpriv->c2h_wk_alive = false; - pevtpriv->c2h_queue =rtw_cbuf_alloc (C2H_QUEUE_MAX_LEN +1 ); + pevtpriv->c2h_queue =rtw_cbuf_alloc (C2H_QUEUE_MAX_LEN +1 );return res; }
@@ -87,7 +87,7 @@ void rtw_free_evt_priv(struct evt_priv *pevtpriv) } } -void _rtw_free_cmd_priv (struct cmd_priv *pcmdpriv) +void _rtw_free_cmd_priv (struct cmd_priv *pcmdpriv) {if (pcmdpriv) {
@@ -149,12 +149,12 @@ u32 rtw_init_cmd_priv(struct cmd_priv *pcmdpriv) {u32 res; - res =_rtw_init_cmd_priv (pcmdpriv); + res =_rtw_init_cmd_priv (pcmdpriv);return res; } -u32 rtw_init_evt_priv (struct evt_priv *pevtpriv) +u32 rtw_init_evt_priv (struct evt_priv *pevtpriv) {int res;
@@ -801,7 +801,7 @@ u8 rtw_joinbss_cmd(struct adapter *padapter, struct wlan_network *pnetwork) t_len =sizeof (struct wlan_bssid_ex );/* for hidden ap to set fw_state here */ -if (!check_fwstate (pmlmepriv,WIFI_STATION_STATE |WIFI_ADHOC_STATE )) { +if (!check_fwstate (pmlmepriv,WIFI_STATION_STATE |WIFI_ADHOC_STATE )) {switch (ndis_network_mode) {case Ndis802_11IBSS:set_fwstate (pmlmepriv,WIFI_ADHOC_STATE );
@@ -832,8 +832,8 @@ u8 rtw_joinbss_cmd(struct adapter *padapter, struct wlan_network *pnetwork) psecuritypriv->authenticator_ie[0 ] = (unsigned char )psecnetwork->IELength; -if (psecnetwork->IELength-12 <255 ) { -memcpy (&psecuritypriv->authenticator_ie[1 ], &psecnetwork->IEs[12 ], psecnetwork->IELength-12 ); +if (psecnetwork->IELength -12 <255 ) { +memcpy (&psecuritypriv->authenticator_ie[1 ], &psecnetwork->IEs[12 ], psecnetwork->IELength -12 ); }else {memcpy (&psecuritypriv->authenticator_ie[1 ], &psecnetwork->IEs[12 ],255 ); }
@@ -1010,7 +1010,7 @@ u8 rtw_setstakey_cmd(struct adapter *padapter, u8 *psta, u8 unicast_key)memcpy (psetstakey_para->addr, sta->hwaddr,ETH_ALEN );if (check_fwstate (pmlmepriv,WIFI_STATION_STATE )) - psetstakey_para->algorithm = (unsigned char ) psecuritypriv->dot11PrivacyAlgrthm; + psetstakey_para->algorithm = (unsigned char )psecuritypriv->dot11PrivacyAlgrthm;else GET_ENCRY_ALGO (psecuritypriv, sta, psetstakey_para->algorithm, false);
Signature · 1 line
2.32.0
PATCH 5/23 staging: r8188eu: clean up spacing style issues in core/rtw_efuse.c
In reply to Michael StraubeClean up spacing style issues in core/rtw_efuse.c reported by checkpatch.
CHECK: spaces preferred around that ...
WARNING: space prohibited before semicolon
--- drivers/staging/r8188eu/core/rtw_efuse.c | 96 ++++++++++++------------ 1 file changed, 48 insertions(+), 48 deletions(-)
drivers/staging/r8188eu/core/rtw_efuse.c +48 -48
@@ -46,7 +46,7 @@ Efuse_Read1ByteFromFakeContent(if (fakeEfuseBank ==0 ) *Value = fakeEfuseContent[Offset];else - *Value = fakeBTEfuseContent[fakeEfuseBank-1 ][Offset]; + *Value = fakeBTEfuseContent[fakeEfuseBank -1 ][Offset];return true; }
@@ -61,7 +61,7 @@ Efuse_Write1ByteToFakeContent(if (fakeEfuseBank ==0 ) { fakeEfuseContent[Offset] = Value; }else { - fakeBTEfuseContent[fakeEfuseBank-1 ][Offset] = Value; + fakeBTEfuseContent[fakeEfuseBank -1 ][Offset] = Value; }return true; }
@@ -166,13 +166,13 @@ ReadEFuseByte( }/* Write Address */ -rtw_write8 (Adapter,EFUSE_CTRL +1 , (_offset &0xff )); - readbyte =rtw_read8 (Adapter,EFUSE_CTRL +2 ); -rtw_write8 (Adapter,EFUSE_CTRL +2 , ((_offset >>8 ) &0x03 ) | (readbyte &0xfc )); +rtw_write8 (Adapter,EFUSE_CTRL +1 , (_offset &0xff )); + readbyte =rtw_read8 (Adapter,EFUSE_CTRL +2 ); +rtw_write8 (Adapter,EFUSE_CTRL +2 , ((_offset >>8 ) &0x03 ) | (readbyte &0xfc ));/* Write bit 32 0 */ - readbyte =rtw_read8 (Adapter,EFUSE_CTRL +3 ); -rtw_write8 (Adapter,EFUSE_CTRL +3 , (readbyte &0x7f )); + readbyte =rtw_read8 (Adapter,EFUSE_CTRL +3 ); +rtw_write8 (Adapter,EFUSE_CTRL +3 , (readbyte &0x7f ));/* Check bit 32 read-ready */ retry =0 ;
@@ -250,21 +250,21 @@ u8 EFUSE_Read1Byte(struct adapter *Adapter, u16 Address)if (Address < contentLen) {/* E-fuse 512Byte */ /* Write E-fuse Register address bit0~7 */ temp = Address &0xFF ; -rtw_write8 (Adapter,EFUSE_CTRL +1 , temp); - Bytetemp =rtw_read8 (Adapter,EFUSE_CTRL +2 ); +rtw_write8 (Adapter,EFUSE_CTRL +1 , temp); + Bytetemp =rtw_read8 (Adapter,EFUSE_CTRL +2 );/* Write E-fuse Register address bit8~9 */ temp = ((Address >>8 ) &0x03 ) | (Bytetemp &0xFC ); -rtw_write8 (Adapter,EFUSE_CTRL +2 , temp); +rtw_write8 (Adapter,EFUSE_CTRL +2 , temp);/* Write 0x30[31]= 0 */ - Bytetemp =rtw_read8 (Adapter,EFUSE_CTRL +3 ); + Bytetemp =rtw_read8 (Adapter,EFUSE_CTRL +3 ); temp = Bytetemp &0x7F ; -rtw_write8 (Adapter,EFUSE_CTRL +3 , temp); +rtw_write8 (Adapter,EFUSE_CTRL +3 , temp);/* Wait Write-ready (0x30[31]= 1) */ - Bytetemp =rtw_read8 (Adapter,EFUSE_CTRL +3 ); + Bytetemp =rtw_read8 (Adapter,EFUSE_CTRL +3 );while (!(Bytetemp &0x80 )) { - Bytetemp =rtw_read8 (Adapter,EFUSE_CTRL +3 ); + Bytetemp =rtw_read8 (Adapter,EFUSE_CTRL +3 ); k++;if (k ==1000 ) { k =0 ;
@@ -291,13 +291,13 @@ u8 efuse_OneByteRead(struct adapter *pAdapter, u16 addr, u8 *data, bool pseudo) }/* -----------------e-fuse reg ctrl --------------------------------- */ /* address */ -rtw_write8 (pAdapter,EFUSE_CTRL +1 , (u8)(addr &0xff )); -rtw_write8 (pAdapter,EFUSE_CTRL +2 , ((u8)((addr>>8 ) &0x03 )) | - (rtw_read8 (pAdapter,EFUSE_CTRL +2 ) &0xFC )); +rtw_write8 (pAdapter,EFUSE_CTRL +1 , (u8)(addr &0xff )); +rtw_write8 (pAdapter,EFUSE_CTRL +2 , ((u8)((addr >>8 ) &0x03 )) | + (rtw_read8 (pAdapter,EFUSE_CTRL +2 ) &0xFC )); -rtw_write8 (pAdapter,EFUSE_CTRL +3 ,0x72 );/* read cmd */ +rtw_write8 (pAdapter,EFUSE_CTRL +3 ,0x72 );/* read cmd */ -while (!(0x80 &rtw_read8 (pAdapter,EFUSE_CTRL +3 )) && (tmpidx <100 )) +while (!(0x80 &rtw_read8 (pAdapter,EFUSE_CTRL +3 )) && (tmpidx <100 )) tmpidx++;if (tmpidx <100 ) { *data =rtw_read8 (pAdapter,EFUSE_CTRL );
@@ -322,15 +322,15 @@ u8 efuse_OneByteWrite(struct adapter *pAdapter, u16 addr, u8 data, bool pseudo)/* -----------------e-fuse reg ctrl --------------------------------- */ /* address */ -rtw_write8 (pAdapter,EFUSE_CTRL +1 , (u8)(addr&0xff )); -rtw_write8 (pAdapter,EFUSE_CTRL +2 , - (rtw_read8 (pAdapter,EFUSE_CTRL +2 ) &0xFC ) | - (u8)((addr>>8 ) &0x03 )); +rtw_write8 (pAdapter,EFUSE_CTRL +1 , (u8)(addr &0xff )); +rtw_write8 (pAdapter,EFUSE_CTRL +2 , + (rtw_read8 (pAdapter,EFUSE_CTRL +2 ) &0xFC ) | + (u8)((addr >>8 ) &0x03 ));rtw_write8 (pAdapter,EFUSE_CTRL , data);/* data */ -rtw_write8 (pAdapter,EFUSE_CTRL +3 ,0xF2 );/* write cmd */ +rtw_write8 (pAdapter,EFUSE_CTRL +3 ,0xF2 );/* write cmd */ -while ((0x80 &rtw_read8 (pAdapter,EFUSE_CTRL +3 )) && (tmpidx <100 )) +while ((0x80 &rtw_read8 (pAdapter,EFUSE_CTRL +3 )) && (tmpidx <100 )) tmpidx++;if (tmpidx <100 )
@@ -387,19 +387,19 @@ static int Efuse_PgPacketWrite_BT(struct adapter *pAdapter, u8 offset, u8 word_e*---------------------------------------------------------------------------*/ void efuse_WordEnableDataRead (u8 word_en,u8 *sourdata,u8 *targetdata) { -if (!(word_en&BIT (0 ))) { +if (!(word_en &BIT (0 ))) { targetdata[0 ] = sourdata[0 ]; targetdata[1 ] = sourdata[1 ]; } -if (!(word_en&BIT (1 ))) { +if (!(word_en &BIT (1 ))) { targetdata[2 ] = sourdata[2 ]; targetdata[3 ] = sourdata[3 ]; } -if (!(word_en&BIT (2 ))) { +if (!(word_en &BIT (2 ))) { targetdata[4 ] = sourdata[4 ]; targetdata[5 ] = sourdata[5 ]; } -if (!(word_en&BIT (3 ))) { +if (!(word_en &BIT (3 ))) { targetdata[6 ] = sourdata[6 ]; targetdata[7 ] = sourdata[7 ]; }
@@ -431,7 +431,7 @@ u8 rtw_efuse_access(struct adapter *padapter, u8 write, u16 start_addr, u16 cnts {int i =0 ;u16 real_content_len =0 , max_available_size =0 ; -u8 res = _FAIL ; +u8 res = _FAIL;u8 (*rw8)(struct adapter *,u16 ,u8 *);EFUSE_GetEfuseDefinition (padapter,EFUSE_WIFI ,TYPE_EFUSE_REAL_CONTENT_LEN , (void *)&real_content_len, false);
@@ -551,9 +551,9 @@ u8 rtw_efuse_map_write(struct adapter *padapter, u16 addr, u16 cnts, u8 *data)if (i &0x1 ) {/* odd start */ -if (data[idx] != map[addr+idx]) { +if (data[idx] != map[addr + idx]) { word_en &= ~BIT (i >>1 ); - newdata[i-1 ] = map[addr+idx-1 ]; + newdata[i -1 ] = map[addr + idx -1 ]; newdata[i] = data[idx]; } i++;
@@ -564,19 +564,19 @@ u8 rtw_efuse_map_write(struct adapter *padapter, u16 addr, u16 cnts, u8 *data)if (cnts == idx)break ;if ((cnts - idx) ==1 ) { -if (data[idx] != map[addr+idx]) { +if (data[idx] != map[addr + idx]) { word_en &= ~BIT (i >>1 ); newdata[i] = data[idx]; - newdata[i+1 ] = map[addr+idx+1 ]; + newdata[i +1 ] = map[addr + idx +1 ]; } idx++;break ; }else { -if ((data[idx] != map[addr+idx]) || - (data[idx+1 ] != map[addr+idx+1 ])) { +if ((data[idx] != map[addr + idx]) || + (data[idx +1 ] != map[addr + idx +1 ])) { word_en &= ~BIT (i >>1 ); newdata[i] = data[idx]; - newdata[i+1 ] = data[idx +1 ]; + newdata[i +1 ] = data[idx +1 ]; } idx +=2 ; }
@@ -643,9 +643,9 @@ u8 rtw_BT_efuse_map_write(struct adapter *padapter, u16 addr, u16 cnts, u8 *dataif (i &0x1 ) {/* odd start */ -if (data[idx] != map[addr+idx]) { +if (data[idx] != map[addr + idx]) { word_en &= ~BIT (i >>1 ); - newdata[i-1 ] = map[addr+idx-1 ]; + newdata[i -1 ] = map[addr + idx -1 ]; newdata[i] = data[idx]; } i++;
@@ -656,19 +656,19 @@ u8 rtw_BT_efuse_map_write(struct adapter *padapter, u16 addr, u16 cnts, u8 *dataif (cnts == idx)break ;if ((cnts - idx) ==1 ) { -if (data[idx] != map[addr+idx]) { +if (data[idx] != map[addr + idx]) { word_en &= ~BIT (i >>1 ); newdata[i] = data[idx]; - newdata[i+1 ] = map[addr+idx+1 ]; + newdata[i +1 ] = map[addr + idx +1 ]; } idx++;break ; }else { -if ((data[idx] != map[addr+idx]) || - (data[idx+1 ] != map[addr+idx+1 ])) { +if ((data[idx] != map[addr + idx]) || + (data[idx +1 ] != map[addr + idx +1 ])) { word_en &= ~BIT (i >>1 ); newdata[i] = data[idx]; - newdata[i+1 ] = data[idx +1 ]; + newdata[i +1 ] = data[idx +1 ]; } idx +=2 ; }
@@ -747,7 +747,7 @@ efuse_ShadowRead2Byte(struct eeprom_priv *pEEPROM =GET_EEPROM_EFUSE_PRIV (pAdapter); *Value = pEEPROM->efuse_eeprom_data[Offset]; - *Value |= pEEPROM->efuse_eeprom_data[Offset+1 ]<<8 ; + *Value |= pEEPROM->efuse_eeprom_data[Offset +1 ] <<8 ; }/* EFUSE_ShadowRead2Byte */
@@ -761,9 +761,9 @@ efuse_ShadowRead4Byte(struct eeprom_priv *pEEPROM =GET_EEPROM_EFUSE_PRIV (pAdapter); *Value = pEEPROM->efuse_eeprom_data[Offset]; - *Value |= pEEPROM->efuse_eeprom_data[Offset+1 ]<<8 ; - *Value |= pEEPROM->efuse_eeprom_data[Offset+2 ]<<16 ; - *Value |= pEEPROM->efuse_eeprom_data[Offset+3 ]<<24 ; + *Value |= pEEPROM->efuse_eeprom_data[Offset +1 ] <<8 ; + *Value |= pEEPROM->efuse_eeprom_data[Offset +2 ] <<16 ; + *Value |= pEEPROM->efuse_eeprom_data[Offset +3 ] <<24 ; }/* efuse_ShadowRead4Byte */
Signature · 1 line
2.32.0
PATCH 6/23 staging: r8188eu: clean up spacing style issues in core/rtw_ieee80211.c
In reply to Michael StraubeClean up spacing style issues in core/rtw_ieee80211.c reported by checkpatch.
CHECK: spaces preferred around that ...
CHECK: No space is necessary after a cast
WARNING: space prohibited between function name and open parenthesis '('
--- drivers/staging/r8188eu/core/rtw_ieee80211.c | 124 +++++++++---------- 1 file changed, 62 insertions(+), 62 deletions(-)
drivers/staging/r8188eu/core/rtw_ieee80211.c +62 -62
@@ -140,7 +140,7 @@ u8 *rtw_set_iereturn pbuf + len +2 ; } -inline u8 *rtw_set_ie_ch_switch (u8 *buf,u32 *buf_len,u8 ch_switch_mode, +inline u8 *rtw_set_ie_ch_switch (u8 *buf,u32 *buf_len,u8 ch_switch_mode,u8 new_ch,u8 ch_switch_cnt) {u8 ie_data[3 ];
@@ -187,8 +187,8 @@ inline u8 *rtw_set_ie_mesh_ch_switch_parm(u8 *buf, u32 *buf_len, u8 ttl, ie_data[0 ] = ttl; ie_data[1 ] = flags; - *(u16 *)(ie_data+2 ) =cpu_to_le16 (reason); - *(u16 *)(ie_data+4 ) =cpu_to_le16 (precedence); + *(u16 *)(ie_data +2 ) =cpu_to_le16 (reason); + *(u16 *)(ie_data +4 ) =cpu_to_le16 (precedence);return rtw_set_ie (buf,0x118 ,6 , ie_data, buf_len); }
@@ -251,18 +251,18 @@ u8 *rtw_get_ie_ex(u8 *in_ie, uint in_len, u8 eid, u8 *oui, u8 oui_len, u8 *ie, u cnt =0 ;while (cnt < in_len) { -if (eid == in_ie[cnt] && (!oui || !memcmp (&in_ie[cnt+2 ], oui, oui_len))) { +if (eid == in_ie[cnt] && (!oui || !memcmp (&in_ie[cnt +2 ], oui, oui_len))) { target_ie = &in_ie[cnt];if (ie) -memcpy (ie, &in_ie[cnt], in_ie[cnt+1 ]+2 ); +memcpy (ie, &in_ie[cnt], in_ie[cnt +1 ] +2 );if (ielen) - *ielen = in_ie[cnt+1 ]+2 ; + *ielen = in_ie[cnt +1 ] +2 ;break ; }else { - cnt += in_ie[cnt+1 ]+2 ;/* goto next */ + cnt += in_ie[cnt +1 ] +2 ;/* goto next */ } }return target_ie;
@@ -427,7 +427,7 @@ unsigned char *rtw_get_wpa_ie(unsigned char *pie, int *wpa_ie_len, int limit)if (pbuf) {/* check if oui matches... */ -if (memcmp ((pbuf +2 ), wpa_oui_type,sizeof (wpa_oui_type))) +if (memcmp ((pbuf +2 ), wpa_oui_type,sizeof (wpa_oui_type))) goto check_next_ie;/* check version... */
@@ -503,8 +503,8 @@ int rtw_parse_wpa_ie(u8 *wpa_ie, int wpa_ie_len, int *group_cipher, int *pairwisreturn _FAIL; } -if ((*wpa_ie != _WPA_IE_ID_) || (*(wpa_ie+1 ) != (u8)(wpa_ie_len -2 )) || - (memcmp (wpa_ie+2 ,RTW_WPA_OUI_TYPE ,WPA_SELECTOR_LEN ))) +if ((*wpa_ie != _WPA_IE_ID_) || (*(wpa_ie +1 ) != (u8)(wpa_ie_len -2 )) || + (memcmp (wpa_ie +2 ,RTW_WPA_OUI_TYPE ,WPA_SELECTOR_LEN )))return _FAIL; pos = wpa_ie;
@@ -563,7 +563,7 @@ int rtw_parse_wpa2_ie(u8 *rsn_ie, int rsn_ie_len, int *group_cipher, int *pairwireturn _FAIL; } -if ((*rsn_ie != _WPA2_IE_ID_) || (*(rsn_ie+1 ) != (u8)(rsn_ie_len -2 ))) +if ((*rsn_ie != _WPA2_IE_ID_) || (*(rsn_ie +1 ) != (u8)(rsn_ie_len -2 )))return _FAIL; pos = rsn_ie;
@@ -624,21 +624,21 @@ int rtw_get_sec_ie(u8 *in_ie, uint in_len, u8 *rsn_ie, u16 *rsn_len, u8 *wpa_ie,while (cnt < in_len) { authmode = in_ie[cnt]; -if ((authmode == _WPA_IE_ID_) && (!memcmp (&in_ie[cnt+2 ], &wpa_oui[0 ],4 ))) { +if ((authmode == _WPA_IE_ID_) && (!memcmp (&in_ie[cnt +2 ], &wpa_oui[0 ],4 ))) {if (wpa_ie) -memcpy (wpa_ie, &in_ie[cnt], in_ie[cnt+1 ]+2 ); +memcpy (wpa_ie, &in_ie[cnt], in_ie[cnt +1 ] +2 ); - *wpa_len = in_ie[cnt+1 ]+2 ; - cnt += in_ie[cnt+1 ]+2 ;/* get next */ + *wpa_len = in_ie[cnt +1 ] +2 ; + cnt += in_ie[cnt +1 ] +2 ;/* get next */ }else {if (authmode == _WPA2_IE_ID_) {if (rsn_ie) -memcpy (rsn_ie, &in_ie[cnt], in_ie[cnt+1 ]+2 ); +memcpy (rsn_ie, &in_ie[cnt], in_ie[cnt +1 ] +2 ); - *rsn_len = in_ie[cnt+1 ]+2 ; - cnt += in_ie[cnt+1 ]+2 ;/* get next */ + *rsn_len = in_ie[cnt +1 ] +2 ; + cnt += in_ie[cnt +1 ] +2 ;/* get next */ }else { - cnt += in_ie[cnt+1 ]+2 ;/* get next */ + cnt += in_ie[cnt +1 ] +2 ;/* get next */ } } }
@@ -657,7 +657,7 @@ u8 rtw_is_wps_ie(u8 *ie_ptr, uint *wps_ielen) eid = ie_ptr[0 ];if ((eid == _WPA_IE_ID_) && (!memcmp (&ie_ptr[2 ], wps_oui,4 ))) { - *wps_ielen = ie_ptr[1 ]+2 ; + *wps_ielen = ie_ptr[1 ] +2 ; match = true; }return match;
@@ -689,20 +689,20 @@ u8 *rtw_get_wps_ie(u8 *in_ie, uint in_len, u8 *wps_ie, uint *wps_ielen)while (cnt < in_len) { eid = in_ie[cnt]; -if ((eid == _WPA_IE_ID_) && (!memcmp (&in_ie[cnt+2 ], wps_oui,4 ))) { +if ((eid == _WPA_IE_ID_) && (!memcmp (&in_ie[cnt +2 ], wps_oui,4 ))) { wpsie_ptr = &in_ie[cnt];if (wps_ie) -memcpy (wps_ie, &in_ie[cnt], in_ie[cnt+1 ]+2 ); +memcpy (wps_ie, &in_ie[cnt], in_ie[cnt +1 ] +2 );if (wps_ielen) - *wps_ielen = in_ie[cnt+1 ]+2 ; + *wps_ielen = in_ie[cnt +1 ] +2 ; - cnt += in_ie[cnt+1 ]+2 ; + cnt += in_ie[cnt +1 ] +2 ;break ; }else { - cnt += in_ie[cnt+1 ]+2 ;/* goto next */ + cnt += in_ie[cnt +1 ] +2 ;/* goto next */ } }return wpsie_ptr;
@@ -776,12 +776,12 @@ u8 *rtw_get_wps_attr_content(u8 *wps_ie, uint wps_ielen, u16 target_attr_id, u8if (attr_ptr && attr_len) {if (buf_content) -memcpy (buf_content, attr_ptr+4 , attr_len-4 ); +memcpy (buf_content, attr_ptr +4 , attr_len -4 );if (len_content) - *len_content = attr_len-4 ; + *len_content = attr_len -4 ; -return attr_ptr+4 ; +return attr_ptr +4 ; }return NULL ;
@@ -799,7 +799,7 @@ static int rtw_ieee802_11_parse_vendor_specific(u8 *pos, uint elen,if (elen <4 ) {if (show_errors) {DBG_88E ("short vendor specific information element ignored (len=%lu)\n" , - (unsigned long ) elen); + (unsigned long )elen); }return -1 ; }
@@ -819,7 +819,7 @@ static int rtw_ieee802_11_parse_vendor_specific(u8 *pos, uint elen,case WME_OUI_TYPE :/* this is a Wi-Fi WME info. element */ if (elen <5 ) {DBG_88E ("short WME information element ignored (len=%lu)\n" , - (unsigned long ) elen); + (unsigned long )elen);return -1 ; }switch (pos[4 ]) {
@@ -834,7 +834,7 @@ static int rtw_ieee802_11_parse_vendor_specific(u8 *pos, uint elen,break ;default :DBG_88E ("unknown WME information element ignored (subtype=%d len=%lu)\n" , - pos[4 ], (unsigned long ) elen); + pos[4 ], (unsigned long )elen);return -1 ; }break ;
@@ -845,7 +845,7 @@ static int rtw_ieee802_11_parse_vendor_specific(u8 *pos, uint elen,break ;default :DBG_88E ("Unknown Microsoft information element ignored (type=%d len=%lu)\n" , - pos[3 ], (unsigned long ) elen); + pos[3 ], (unsigned long )elen);return -1 ; }break ;
@@ -858,13 +858,13 @@ static int rtw_ieee802_11_parse_vendor_specific(u8 *pos, uint elen,break ;default :DBG_88E ("Unknown Broadcom information element ignored (type=%d len=%lu)\n" , - pos[3 ], (unsigned long ) elen); + pos[3 ], (unsigned long )elen);return -1 ; }break ;default :DBG_88E ("unknown vendor specific information element ignored (vendor OUI %02x:%02x:%02x len=%lu)\n" , - pos[0 ], pos[1 ], pos[2 ], (unsigned long ) elen); + pos[0 ], pos[1 ], pos[2 ], (unsigned long )elen);return -1 ; }return 0 ;
@@ -898,7 +898,7 @@ enum parse_res rtw_ieee802_11_parse_elems(u8 *start, uint len,if (elen > left) {if (show_errors) {DBG_88E ("IEEE 802.11 element parse failed (id=%d elen=%d left=%lu)\n" , - id, elen, (unsigned long ) left); + id, elen, (unsigned long )left); }return ParseFailed; }
@@ -1057,9 +1057,9 @@ void dump_ies(u8 *buf, u32 buf_len)u8 *pos = (u8 *)buf;u8 id, len; -while (pos-buf <= buf_len) { +while (pos - buf <= buf_len) { id = *pos; - len = *(pos+1 ); + len = *(pos +1 );DBG_88E ("%s ID:%u, LEN:%u\n" , __func__, id, len);#ifdef CONFIG_88EU_P2P
@@ -1084,11 +1084,11 @@ void dump_wps_ie(u8 *ie, u32 ie_len)return ; pos +=6 ; -while (pos-ie < ie_len) { +while (pos - ie < ie_len) { id =RTW_GET_BE16 (pos); len =RTW_GET_BE16 (pos +2 );DBG_88E ("%s ID:0x%04x, LEN:%u\n" , __func__, id, len); - pos += (4 +len); + pos += (4 + len); } }
@@ -1106,11 +1106,11 @@ void dump_p2p_ie(u8 *ie, u32 ie_len)return ; pos +=6 ; -while (pos-ie < ie_len) { +while (pos - ie < ie_len) { id = *pos; - len =get_unaligned_le16 (pos+1 ); + len =get_unaligned_le16 (pos +1 );DBG_88E ("%s ID:%u, LEN:%u\n" , __func__, id, len); - pos += (3 +len); + pos += (3 + len); } }
@@ -1138,7 +1138,7 @@ u8 *rtw_get_p2p_ie(u8 *in_ie, int in_len, u8 *p2p_ie, uint *p2p_ielen)dump_stack ();return NULL ; } -if ((eid == _VENDOR_SPECIFIC_IE_) && !memcmp (&in_ie[cnt+2 ], p2p_oui,4 )) { +if ((eid == _VENDOR_SPECIFIC_IE_) && !memcmp (&in_ie[cnt +2 ], p2p_oui,4 )) { p2p_ie_ptr = in_ie + cnt;if (p2p_ie)
@@ -1222,12 +1222,12 @@ u8 *rtw_get_p2p_attr_content(u8 *p2p_ie, uint p2p_ielen, u8 target_attr_id, u8 *if (attr_ptr && attr_len) {if (buf_content) -memcpy (buf_content, attr_ptr+3 , attr_len-3 ); +memcpy (buf_content, attr_ptr +3 , attr_len -3 );if (len_content) - *len_content = attr_len-3 ; + *len_content = attr_len -3 ; -return attr_ptr+3 ; +return attr_ptr +3 ; }return NULL ;
@@ -1259,13 +1259,13 @@ static uint rtw_p2p_attr_remove(u8 *ie, uint ielen_ori, u8 attr_id)while (1 ) { target_attr =rtw_get_p2p_attr (ie, ielen, attr_id,NULL , &target_attr_len);if (target_attr && target_attr_len) { -u8 *next_attr = target_attr+target_attr_len; -uint remain_len = ielen-(next_attr-ie); +u8 *next_attr = target_attr + target_attr_len; +uint remain_len = ielen - (next_attr - ie);memset (target_attr,0 , target_attr_len);memcpy (target_attr, next_attr, remain_len); -memset (target_attr+remain_len,0 , target_attr_len); - *(ie+1 ) -= target_attr_len; +memset (target_attr + remain_len,0 , target_attr_len); + *(ie +1 ) -= target_attr_len; ielen -= target_attr_len; }else {break ;
@@ -1279,17 +1279,17 @@ void rtw_wlan_bssid_ex_remove_p2p_attr(struct wlan_bssid_ex *bss_ex, u8 attr_id)u8 *p2p_ie;uint p2p_ielen, p2p_ielen_ori; - p2p_ie =rtw_get_p2p_ie (bss_ex->IEs+_FIXED_IE_LENGTH_, bss_ex->IELength-_FIXED_IE_LENGTH_,NULL , &p2p_ielen_ori); + p2p_ie =rtw_get_p2p_ie (bss_ex->IEs + _FIXED_IE_LENGTH_, bss_ex->IELength - _FIXED_IE_LENGTH_,NULL , &p2p_ielen_ori);if (p2p_ie) { p2p_ielen =rtw_p2p_attr_remove (p2p_ie, p2p_ielen_ori, attr_id);if (p2p_ielen != p2p_ielen_ori) { -u8 *next_ie_ori = p2p_ie+p2p_ielen_ori; -u8 *next_ie = p2p_ie+p2p_ielen; -uint remain_len = bss_ex->IELength-(next_ie_ori-bss_ex->IEs); +u8 *next_ie_ori = p2p_ie + p2p_ielen_ori; +u8 *next_ie = p2p_ie + p2p_ielen; +uint remain_len = bss_ex->IELength - (next_ie_ori - bss_ex->IEs);memcpy (next_ie, next_ie_ori, remain_len); -memset (next_ie+remain_len,0 , p2p_ielen_ori-p2p_ielen); - bss_ex->IELength -= p2p_ielen_ori-p2p_ielen; +memset (next_ie + remain_len,0 , p2p_ielen_ori - p2p_ielen); + bss_ex->IELength -= p2p_ielen_ori - p2p_ielen; } } }
@@ -1346,20 +1346,20 @@ static int rtw_get_cipher_info(struct wlan_network *pnetwork)unsigned char *pbuf;int group_cipher =0 , pairwise_cipher =0 , is8021x =0 ;int ret = _FAIL; - pbuf =rtw_get_wpa_ie (&pnetwork->network.IEs[12 ], &wpa_ielen, pnetwork->network.IELength-12 ); + pbuf =rtw_get_wpa_ie (&pnetwork->network.IEs[12 ], &wpa_ielen, pnetwork->network.IELength -12 );if (pbuf && (wpa_ielen >0 )) { -if (_SUCCESS ==rtw_parse_wpa_ie (pbuf, wpa_ielen+2 , &group_cipher, &pairwise_cipher, &is8021x)) { +if (_SUCCESS ==rtw_parse_wpa_ie (pbuf, wpa_ielen +2 , &group_cipher, &pairwise_cipher, &is8021x)) { pnetwork->BcnInfo.pairwise_cipher = pairwise_cipher; pnetwork->BcnInfo.group_cipher = group_cipher; pnetwork->BcnInfo.is_8021x = is8021x; ret = _SUCCESS; } }else { - pbuf =rtw_get_wpa2_ie (&pnetwork->network.IEs[12 ], &wpa_ielen, pnetwork->network.IELength-12 ); + pbuf =rtw_get_wpa2_ie (&pnetwork->network.IEs[12 ], &wpa_ielen, pnetwork->network.IELength -12 );if (pbuf && (wpa_ielen >0 )) { -if (_SUCCESS ==rtw_parse_wpa2_ie (pbuf, wpa_ielen+2 , &group_cipher, &pairwise_cipher, &is8021x)) { +if (_SUCCESS ==rtw_parse_wpa2_ie (pbuf, wpa_ielen +2 , &group_cipher, &pairwise_cipher, &is8021x)) { pnetwork->BcnInfo.pairwise_cipher = pairwise_cipher; pnetwork->BcnInfo.group_cipher = group_cipher; pnetwork->BcnInfo.is_8021x = is8021x;
@@ -1491,8 +1491,8 @@ int rtw_action_frame_parse(const u8 *frame, u32 frame_len, u8 *category, u8 *act fc =le16_to_cpu (((struct rtw_ieee80211_hdr_3addr *)frame)->frame_ctl); -if ((fc & (RTW_IEEE80211_FCTL_FTYPE |RTW_IEEE80211_FCTL_STYPE )) != - (RTW_IEEE80211_FTYPE_MGMT |RTW_IEEE80211_STYPE_ACTION )) +if ((fc & (RTW_IEEE80211_FCTL_FTYPE |RTW_IEEE80211_FCTL_STYPE )) != + (RTW_IEEE80211_FTYPE_MGMT |RTW_IEEE80211_STYPE_ACTION ))return false; c = frame_body[0 ];
Signature · 1 line
2.32.0
PATCH 7/23 staging: r8188eu: simplify multiplication in core/rtw_ioctl_set.c
In reply to Michael StraubeSimplify multiplication in core/rtw_ioctl_set.c. to improve readability and clear a checkpatch issue.
CHECK: spaces preferred around that '/' (ctx:VxV)
--- drivers/staging/r8188eu/core/rtw_ioctl_set.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/r8188eu/core/rtw_ioctl_set.c +1 -1
@@ -825,7 +825,7 @@ u16 rtw_get_cur_max_rate(struct adapter *adapter) i++; } - max_rate = max_rate*10 /2 ; + max_rate *=5 ; }return max_rate;
Signature · 1 line
2.32.0
PATCH 8/23 staging: r8188eu: clean up spacing style issues in core/rtw_ioctl_set.c
In reply to Michael StraubeClean up spacing style issues in core/rtw_ioctl_set.c reported by checkpatch.
CHECK: spaces preferred around that ...
WARNING: space prohibited before semicolon
--- drivers/staging/r8188eu/core/rtw_ioctl_set.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)
drivers/staging/r8188eu/core/rtw_ioctl_set.c +9 -9
@@ -154,7 +154,7 @@ u8 rtw_set_802_11_bssid(struct adapter *padapter, u8 *bssid)else if (check_fwstate (pmlmepriv, _FW_UNDER_LINKING)) goto release_mlme_lock; -if (check_fwstate (pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE )) { +if (check_fwstate (pmlmepriv, _FW_LINKED |WIFI_ADHOC_MASTER_STATE )) {if (!memcmp (&pmlmepriv->cur_network.network.MacAddress, bssid,ETH_ALEN )) {if (check_fwstate (pmlmepriv,WIFI_STATION_STATE ) == false) goto release_mlme_lock;/* it means driver is in WIFI_ADHOC_MASTER_STATE, we needn't create bss again. */
@@ -228,7 +228,7 @@ u8 rtw_set_802_11_ssid(struct adapter *padapter, struct ndis_802_11_ssid *ssid) goto release_mlme_lock; } -if (check_fwstate (pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE )) { +if (check_fwstate (pmlmepriv, _FW_LINKED |WIFI_ADHOC_MASTER_STATE )) {if ((pmlmepriv->assoc_ssid.SsidLength == ssid->SsidLength) && (!memcmp (&pmlmepriv->assoc_ssid.Ssid, ssid->Ssid, ssid->SsidLength))) {if (!check_fwstate (pmlmepriv,WIFI_STATION_STATE )) {
@@ -389,7 +389,7 @@ u8 rtw_set_802_11_bssid_list_scan(struct adapter *padapter, struct ndis_802_11_s goto exit; } -if ((check_fwstate (pmlmepriv, _FW_UNDER_SURVEY|_FW_UNDER_LINKING)) || +if ((check_fwstate (pmlmepriv, _FW_UNDER_SURVEY | _FW_UNDER_LINKING)) || (pmlmepriv->LinkDetectInfo.bBusyTraffic)) {/* Scan or linking is in progress, do nothing. */ res = true;
@@ -623,8 +623,8 @@ u8 rtw_set_802_11_add_key(struct adapter *padapter, struct ndis_802_11_key *key)struct ndis_802_11_wep *wep = &padapter->securitypriv.ndiswep; wep->Length = len; - keyindex = key->KeyIndex&0x7fffffff ; - wep->KeyIndex = keyindex ; + keyindex = key->KeyIndex &0x7fffffff ; + wep->KeyIndex = keyindex; wep->KeyLength = key->KeyLength;memcpy (wep->KeyMaterial, key->KeyMaterial, key->KeyLength);
@@ -654,7 +654,7 @@ u8 rtw_set_802_11_add_key(struct adapter *padapter, struct ndis_802_11_key *key)if (bgrouptkey) padapter->securitypriv.dot118021XGrpKeyid = (u8 )key->KeyIndex; -if ((key->KeyIndex&0x3 ) ==0 ) { +if ((key->KeyIndex &0x3 ) ==0 ) { ret = _FAIL; goto exit; }
@@ -796,9 +796,9 @@ u16 rtw_get_cur_max_rate(struct adapter *adapter)return 0 ;if (pmlmeext->cur_wireless_mode & (WIRELESS_11_24N )) { - p =rtw_get_ie (&pcur_bss->IEs[12 ], _HT_CAPABILITY_IE_, &ht_ielen, pcur_bss->IELength-12 ); + p =rtw_get_ie (&pcur_bss->IEs[12 ], _HT_CAPABILITY_IE_, &ht_ielen, pcur_bss->IELength -12 );if (p && ht_ielen >0 ) { - pht_capie = (struct ieee80211_ht_cap *)(p+2 ); + pht_capie = (struct ieee80211_ht_cap *)(p +2 );memcpy (&mcs_rate, pht_capie->mcs.rx_mask,2 );
@@ -819,7 +819,7 @@ u16 rtw_get_cur_max_rate(struct adapter *adapter) } }else {while ((pcur_bss->SupportedRates[i] !=0 ) && (pcur_bss->SupportedRates[i] !=0xFF )) { - rate = pcur_bss->SupportedRates[i]&0x7F ; + rate = pcur_bss->SupportedRates[i] &0x7F ;if (rate > max_rate) max_rate = rate; i++;
Signature · 1 line
2.32.0
PATCH 9/23 staging: r8188eu: add spaces around operators in core/rtw_iol.c
In reply to Michael StraubeAdd missing spaces around operators in core/rtw_iol.c reported by checkpatch.
--- drivers/staging/r8188eu/core/rtw_iol.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/staging/r8188eu/core/rtw_iol.c +6 -6
@@ -46,7 +46,7 @@ int rtw_IOL_append_cmds(struct xmit_frame *xmit_frame, u8 *IOL_cmds, u32 cmd_lenu32 ori_len; buf_offset =TXDESC_OFFSET ; - ori_len = buf_offset+pattrib->pktlen; + ori_len = buf_offset + pattrib->pktlen;/* check if the io_buf can accommodate new cmds */ if (ori_len + cmd_len +8 >MAX_XMITBUF_SZ ) {
@@ -128,7 +128,7 @@ int _rtw_IOL_append_WRF_cmd(struct xmit_frame *xmit_frame, u8 rf_path, u16 addr, {struct ioreg_cfg cmd = {8 ,IOREG_CMD_W_RF ,0x0 ,0x0 ,0x0 }; - cmd.address =cpu_to_le16 ((rf_path<<8 ) | ((addr) &0xFF )); + cmd.address =cpu_to_le16 ((rf_path <<8 ) | ((addr) &0xFF )); cmd.data =cpu_to_le32 (value);if (mask !=0x000FFFFF ) {
@@ -164,9 +164,9 @@ int rtw_IOL_append_END_cmd(struct xmit_frame *xmit_frame)u8 rtw_IOL_cmd_boundary_handle (struct xmit_frame *pxmit_frame) {u8 is_cmd_bndy = false; -if (((pxmit_frame->attrib.pktlen+32 )%256 ) +8 >=256 ) { +if (((pxmit_frame->attrib.pktlen +32 ) %256 ) +8 >=256 ) {rtw_IOL_append_END_cmd (pxmit_frame); - pxmit_frame->attrib.pktlen = ((((pxmit_frame->attrib.pktlen+32 )/256 )+1 )*256 ); + pxmit_frame->attrib.pktlen = ((((pxmit_frame->attrib.pktlen +32 ) /256 ) +1 ) *256 ); pxmit_frame->attrib.last_txcmdsz = pxmit_frame->attrib.pktlen; is_cmd_bndy = true;
@@ -181,9 +181,9 @@ void rtw_IOL_cmd_buf_dump(struct adapter *Adapter, int buf_len, u8 *pbuf)pr_info ("###### %s ######\n" , __func__);for (i =0 ; i < buf_len; i++) { -printk ("%02x-" , *(pbuf+i)); +printk ("%02x-" , *(pbuf + i)); -if (j%32 ==0 ) +if (j %32 ==0 )printk ("\n" ); j++; }
Signature · 1 line
2.32.0
PATCH 10/23 staging: r8188eu: clean up spacing style issues in core/rtw_mlme.c
In reply to Michael StraubeClean up spacing style issues in core/rtw_mlme.c reported by checkpatch.
CHECK: spaces preferred around that ...
CHECK: No space is necessary after a cast
WARNING: space prohibited between function name and open parenthesis '('
--- drivers/staging/r8188eu/core/rtw_mlme.c | 80 ++++++++++++------------- 1 file changed, 40 insertions(+), 40 deletions(-)
drivers/staging/r8188eu/core/rtw_mlme.c +40 -40
@@ -31,7 +31,7 @@ u8 rtw_to_roaming(struct adapter *adapter)return adapter->mlmepriv.to_roaming; } -int _rtw_init_mlme_priv (struct adapter *padapter) +int _rtw_init_mlme_priv (struct adapter *padapter) {int i;u8 *pbuf;
@@ -85,11 +85,11 @@ int _rtw_init_mlme_priv (struct adapter *padapter)return res; } -static void rtw_mfree_mlme_priv_lock (struct mlme_priv *pmlmepriv) +static void rtw_mfree_mlme_priv_lock (struct mlme_priv *pmlmepriv) { } -#if defined (CONFIG_88EU_AP_MODE ) +#if defined(CONFIG_88EU_AP_MODE )static void rtw_free_mlme_ie_data (u8 **ppie,u32 *plen) {kfree (*ppie);
@@ -118,13 +118,13 @@ void rtw_free_mlme_priv_ie_data(struct mlme_priv *pmlmepriv) }#endif -void _rtw_free_mlme_priv (struct mlme_priv *pmlmepriv) +void _rtw_free_mlme_priv (struct mlme_priv *pmlmepriv) {rtw_free_mlme_priv_ie_data (pmlmepriv);if (pmlmepriv) { -rtw_mfree_mlme_priv_lock (pmlmepriv); +rtw_mfree_mlme_priv_lock (pmlmepriv);vfree (pmlmepriv->free_bss_buf); }
@@ -215,7 +215,7 @@ void _rtw_free_network(struct mlme_priv *pmlmepriv, struct wlan_network *pnetwor (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE))) lifetime =1 ;if (!isfreeall) { - delta_time = (curr_time - pnetwork->last_scanned)/HZ ; + delta_time = (curr_time - pnetwork->last_scanned) /HZ ;if (delta_time < lifetime)/* unit:sec */ return ; }
@@ -314,8 +314,8 @@ void rtw_generate_random_ibss(u8 *pibss) pibss[1 ] =0x11 ; pibss[2 ] =0x87 ; pibss[3 ] = (u8)(curtime &0xff );/* p[0]; */ - pibss[4 ] = (u8)((curtime>>8 ) &0xff );/* p[1]; */ - pibss[5 ] = (u8)((curtime>>16 ) &0xff );/* p[2]; */ + pibss[4 ] = (u8)((curtime >>8 ) &0xff );/* p[1]; */ + pibss[5 ] = (u8)((curtime >>16 ) &0xff );/* p[2]; */ }u8 *rtw_get_capability_from_ie (u8 *ie)
@@ -342,7 +342,7 @@ u8 *rtw_get_beacon_interval_from_ie(u8 *ie)return ie +8 ; } -int rtw_init_mlme_priv (struct adapter *padapter)/* struct mlme_priv *pmlmepriv) */ +int rtw_init_mlme_priv (struct adapter *padapter)/* struct mlme_priv *pmlmepriv) */ {int res;
@@ -351,9 +351,9 @@ int rtw_init_mlme_priv (struct adapter *padapter)/* struct mlme_priv *pmlmepriv)return res; } -void rtw_free_mlme_priv (struct mlme_priv *pmlmepriv) +void rtw_free_mlme_priv (struct mlme_priv *pmlmepriv) { -_rtw_free_mlme_priv (pmlmepriv); +_rtw_free_mlme_priv (pmlmepriv); }static struct wlan_network *rtw_alloc_network (struct mlme_priv *pmlmepriv)
@@ -642,7 +642,7 @@ static int rtw_is_desired_network(struct adapter *adapter, struct wlan_network * privacy = pnetwork->network.Privacy;if (check_fwstate (pmlmepriv,WIFI_UNDER_WPS )) { -if (rtw_get_wps_ie (pnetwork->network.IEs+_FIXED_IE_LENGTH_, pnetwork->network.IELength-_FIXED_IE_LENGTH_,NULL , &wps_ielen)) +if (rtw_get_wps_ie (pnetwork->network.IEs + _FIXED_IE_LENGTH_, pnetwork->network.IELength - _FIXED_IE_LENGTH_,NULL , &wps_ielen))return true;else return false;
@@ -1061,8 +1061,8 @@ static void rtw_joinbss_update_network(struct adapter *padapter, struct wlan_net/* update fw_state will clr _FW_UNDER_LINKING here indirectly */ switch (pnetwork->network.InfrastructureMode) {case Ndis802_11Infrastructure: -if (pmlmepriv->fw_state&WIFI_UNDER_WPS ) - pmlmepriv->fw_state =WIFI_STATION_STATE |WIFI_UNDER_WPS ; +if (pmlmepriv->fw_state &WIFI_UNDER_WPS ) + pmlmepriv->fw_state =WIFI_STATION_STATE |WIFI_UNDER_WPS ;else pmlmepriv->fw_state =WIFI_STATION_STATE ;break ;
@@ -1201,7 +1201,7 @@ void rtw_joinbss_event_callback(struct adapter *adapter, u8 *pbuf)static u8 search_max_mac_id (struct adapter *padapter) {u8 mac_id; -#if defined (CONFIG_88EU_AP_MODE ) +#if defined(CONFIG_88EU_AP_MODE )u8 aid;struct mlme_priv *pmlmepriv = &padapter->mlmepriv;struct sta_priv *pstapriv = &padapter->stapriv;
@@ -1209,17 +1209,17 @@ static u8 search_max_mac_id(struct adapter *padapter)struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;struct mlme_ext_info *pmlmeinfo = &pmlmeext->mlmext_info; -#if defined (CONFIG_88EU_AP_MODE ) +#if defined(CONFIG_88EU_AP_MODE )if (check_fwstate (pmlmepriv,WIFI_AP_STATE )) {for (aid = (pstapriv->max_num_sta); aid >0 ; aid--) { -if (pstapriv->sta_aid[aid-1 ]) +if (pstapriv->sta_aid[aid -1 ])break ; } mac_id = aid +1 ; } else#endif {/* adhoc id = 31~2 */ -for (mac_id = (NUM_STA -1 ); mac_id >=IBSS_START_MAC_ID ; mac_id--) { +for (mac_id = (NUM_STA -1 ); mac_id >=IBSS_START_MAC_ID ; mac_id--) {if (pmlmeinfo->FW_sta_info[mac_id].status ==1 )break ; }
@@ -1240,7 +1240,7 @@ void rtw_sta_media_status_rpt(struct adapter *adapter, struct sta_info *psta, macid =search_max_mac_id (adapter);rtw_hal_set_hwreg (adapter,HW_VAR_TX_RPT_MAX_MACID , (u8 *)&macid);/* MACID|OPMODE:1 connect */ - media_status_rpt = (u16)((psta->mac_id<<8 ) | mstatus); + media_status_rpt = (u16)((psta->mac_id <<8 ) | mstatus);rtw_hal_set_hwreg (adapter,HW_VAR_H2C_MEDIA_STATUS_RPT , (u8 *)&media_status_rpt); }
@@ -1256,7 +1256,7 @@ void rtw_stassoc_event_callback(struct adapter *adapter, u8 *pbuf)if (rtw_access_ctrl (adapter, pstassoc->macaddr) == false)return ; -#if defined (CONFIG_88EU_AP_MODE ) +#if defined(CONFIG_88EU_AP_MODE )if (check_fwstate (pmlmepriv,WIFI_AP_STATE )) { psta =rtw_get_stainfo (&adapter->stapriv, pstassoc->macaddr);if (psta)
@@ -1322,7 +1322,7 @@ void rtw_stadel_event_callback(struct adapter *adapter, u8 *pbuf)if (mac_id >=0 ) {u16 media_status; - media_status = (mac_id<<8 )|0 ;/* MACID|OPMODE:0 means disconnect */ + media_status = (mac_id <<8 ) |0 ;/* MACID|OPMODE:0 means disconnect */ /* for STA, AP, ADHOC mode, report disconnect stauts to FW */ rtw_hal_set_hwreg (adapter,HW_VAR_H2C_MEDIA_STATUS_RPT , (u8 *)&media_status); }
@@ -1500,7 +1500,7 @@ void rtw_dynamic_check_timer_handlder(struct adapter *adapter)rcu_read_lock ();if (rcu_dereference (adapter->pnetdev->rx_handler_data) && - (check_fwstate (pmlmepriv,WIFI_STATION_STATE |WIFI_ADHOC_STATE ) == true)) { + (check_fwstate (pmlmepriv,WIFI_STATION_STATE |WIFI_ADHOC_STATE ) == true)) {/* expire NAT2.5 entry */ nat25_db_expire (adapter);
@@ -1747,7 +1747,7 @@ int rtw_restruct_wmm_ie(struct adapter *adapter, u8 *in_ie, u8 *out_ie, uint in_while (i < in_len) { ielength = initial_out_len; -if (in_ie[i] ==0xDD && in_ie[i+2 ] ==0x00 && in_ie[i+3 ] ==0x50 && in_ie[i+4 ] ==0xF2 && in_ie[i+5 ] ==0x02 && i+5 < in_len) { +if (in_ie[i] ==0xDD && in_ie[i +2 ] ==0x00 && in_ie[i +3 ] ==0x50 && in_ie[i +4 ] ==0xF2 && in_ie[i +5 ] ==0x02 && i +5 < in_len) {/* WMM element ID and OUI */ /* Append WMM IE to the last index of out_ie */
@@ -1760,7 +1760,7 @@ int rtw_restruct_wmm_ie(struct adapter *adapter, u8 *in_ie, u8 *out_ie, uint in_ out_ie[initial_out_len +8 ] =0x00 ;break ; } - i += (in_ie[i+1 ]+2 );/* to the next IE element */ + i += (in_ie[i +1 ] +2 );/* to the next IE element */ }return ielength; }
@@ -1846,13 +1846,13 @@ int rtw_restruct_sec_ie(struct adapter *adapter, u8 *in_ie, u8 *out_ie, uint in_ authmode = _WPA2_IE_ID_;if (check_fwstate (pmlmepriv,WIFI_UNDER_WPS )) { -memcpy (out_ie+ielength, psecuritypriv->wps_ie, psecuritypriv->wps_ie_len); +memcpy (out_ie + ielength, psecuritypriv->wps_ie, psecuritypriv->wps_ie_len); ielength += psecuritypriv->wps_ie_len; }else if ((authmode == _WPA_IE_ID_) || (authmode == _WPA2_IE_ID_)) {/* copy RSN or SSN */ -memcpy (&out_ie[ielength], &psecuritypriv->supplicant_ie[0 ], psecuritypriv->supplicant_ie[1 ]+2 ); - ielength += psecuritypriv->supplicant_ie[1 ]+2 ; +memcpy (&out_ie[ielength], &psecuritypriv->supplicant_ie[0 ], psecuritypriv->supplicant_ie[1 ] +2 ); + ielength += psecuritypriv->supplicant_ie[1 ] +2 ;rtw_report_sec_ie (adapter, authmode, psecuritypriv->supplicant_ie); }
@@ -1982,12 +1982,12 @@ unsigned int rtw_restructure_ht_ie(struct adapter *padapter, u8 *in_ie, u8 *out_ phtpriv->ht_option = false; - p =rtw_get_ie (in_ie+12 , _HT_CAPABILITY_IE_, &ielen, in_len-12 ); + p =rtw_get_ie (in_ie +12 , _HT_CAPABILITY_IE_, &ielen, in_len -12 );if (p && ielen >0 ) {if (pqospriv->qos_option ==0 ) { out_len = *pout_len; -rtw_set_ie (out_ie+out_len, _VENDOR_SPECIFIC_IE_, +rtw_set_ie (out_ie + out_len, _VENDOR_SPECIFIC_IE_, _WMM_IE_Length_,WMM_IE , pout_len); pqospriv->qos_option =1 ;
@@ -2012,22 +2012,22 @@ unsigned int rtw_restructure_ht_ie(struct adapter *padapter, u8 *in_ie, u8 *out_*/ rtw_hal_get_def_var (padapter,HW_VAR_MAX_RX_AMPDU_FACTOR , &max_rx_ampdu_factor); - ht_capie.ampdu_params_info = (max_rx_ampdu_factor&0x03 ); + ht_capie.ampdu_params_info = (max_rx_ampdu_factor &0x03 );if (padapter->securitypriv.dot11PrivacyAlgrthm == _AES_) ht_capie.ampdu_params_info |= (IEEE80211_HT_AMPDU_PARM_DENSITY & (0x07 <<2 ));else ht_capie.ampdu_params_info |= (IEEE80211_HT_AMPDU_PARM_DENSITY &0x00 ); -rtw_set_ie (out_ie+out_len, _HT_CAPABILITY_IE_, +rtw_set_ie (out_ie + out_len, _HT_CAPABILITY_IE_,sizeof (struct ieee80211_ht_cap ), (unsigned char *)&ht_capie, pout_len); phtpriv->ht_option = true; - p =rtw_get_ie (in_ie+12 , _HT_ADD_INFO_IE_, &ielen, in_len-12 ); + p =rtw_get_ie (in_ie +12 , _HT_ADD_INFO_IE_, &ielen, in_len -12 );if (p && (ielen ==sizeof (struct ieee80211_ht_addt_info ))) { out_len = *pout_len; -rtw_set_ie (out_ie+out_len, _HT_ADD_INFO_IE_, ielen, p+2 , pout_len); +rtw_set_ie (out_ie + out_len, _HT_ADD_INFO_IE_, ielen, p +2 , pout_len); } }return phtpriv->ht_option;
@@ -2065,15 +2065,15 @@ void rtw_update_ht_cap(struct adapter *padapter, u8 *pie, uint ie_len)/* check Max Rx A-MPDU Size */ len =0 ; - p =rtw_get_ie (pie+sizeof (struct ndis_802_11_fixed_ie ), _HT_CAPABILITY_IE_, &len, ie_len-sizeof (struct ndis_802_11_fixed_ie )); + p =rtw_get_ie (pie +sizeof (struct ndis_802_11_fixed_ie ), _HT_CAPABILITY_IE_, &len, ie_len -sizeof (struct ndis_802_11_fixed_ie ));if (p && len >0 ) { - pht_capie = (struct ieee80211_ht_cap *)(p+2 ); + pht_capie = (struct ieee80211_ht_cap *)(p +2 ); max_ampdu_sz = (pht_capie->ampdu_params_info &IEEE80211_HT_AMPDU_PARM_FACTOR ); - max_ampdu_sz =1 << (max_ampdu_sz+3 );/* max_ampdu_sz (kbytes); */ + max_ampdu_sz =1 << (max_ampdu_sz +3 );/* max_ampdu_sz (kbytes); */ phtpriv->rx_ampdu_maxlen = max_ampdu_sz; } len =0 ; - p =rtw_get_ie (pie+sizeof (struct ndis_802_11_fixed_ie ), _HT_ADD_INFO_IE_, &len, ie_len-sizeof (struct ndis_802_11_fixed_ie )); + p =rtw_get_ie (pie +sizeof (struct ndis_802_11_fixed_ie ), _HT_ADD_INFO_IE_, &len, ie_len -sizeof (struct ndis_802_11_fixed_ie ));/* update cur_bwmode & cur_ch_offset */ if ((pregistrypriv->cbw40_enable) &&
@@ -2140,13 +2140,13 @@ void rtw_issue_addbareq_cmd(struct adapter *padapter, struct xmit_frame *pxmitfr phtpriv = &psta->htpriv;if ((phtpriv->ht_option) && (phtpriv->ampdu_enable)) { - issued = (phtpriv->agg_enable_bitmap>>priority)&0x1 ; - issued |= (phtpriv->candidate_tid_bitmap>>priority)&0x1 ; + issued = (phtpriv->agg_enable_bitmap >> priority) &0x1 ; + issued |= (phtpriv->candidate_tid_bitmap >> priority) &0x1 ;if (0 == issued) {DBG_88E ("rtw_issue_addbareq_cmd, p=%d\n" , priority); psta->htpriv.candidate_tid_bitmap |=BIT ((u8 )priority); -rtw_addbareq_cmd (padapter, (u8 ) priority, pattrib->ra); +rtw_addbareq_cmd (padapter, (u8 )priority, pattrib->ra); } } }
Signature · 1 line
2.32.0
PATCH 11/23 staging: r8188eu: clean up spacing style issues in core/rtw_mlme_ext.c
In reply to Michael StraubeClean up spacing style issues in core/rtw_mlme_ext.c reported by checkpatch.
CHECK: spaces preferred around that ...
WARNING: space prohibited between function name and open parenthesis '('
--- drivers/staging/r8188eu/core/rtw_mlme_ext.c | 236 ++++++++++---------- 1 file changed, 118 insertions(+), 118 deletions(-)
drivers/staging/r8188eu/core/rtw_mlme_ext.c +118 -118
@@ -553,7 +553,7 @@ unsigned int OnProbeReq(struct adapter *padapter, struct recv_frame *precv_framereturn _SUCCESS;if (!check_fwstate (pmlmepriv, _FW_LINKED) && - !check_fwstate (pmlmepriv,WIFI_ADHOC_MASTER_STATE |WIFI_AP_STATE )) + !check_fwstate (pmlmepriv,WIFI_ADHOC_MASTER_STATE |WIFI_AP_STATE ))return _SUCCESS; p = rtw_get_ie(pframe + WLAN_HDR_A3_LEN + _PROBEREQ_IE_OFFSET_, _SSID_IE_, (int *)&ielen,
@@ -564,7 +564,7 @@ unsigned int OnProbeReq(struct adapter *padapter, struct recv_frame *precv_frameif (is_valid_p2p_probereq) goto _issue_probersp; -if ((ielen !=0 &&memcmp ((void *)(p+2 ), (void *)cur->Ssid.Ssid, cur->Ssid.SsidLength)) || +if ((ielen !=0 &&memcmp ((void *)(p +2 ), (void *)cur->Ssid.Ssid, cur->Ssid.SsidLength)) || (ielen ==0 && pmlmeinfo->hidden_ssid_mode))return _SUCCESS;
@@ -662,7 +662,7 @@ unsigned int OnBeacon(struct adapter *padapter, struct recv_frame *precv_frame) }/* check the vendor of the assoc AP */ - pmlmeinfo->assoc_AP_vendor =check_assoc_AP (pframe+sizeof (struct rtw_ieee80211_hdr_3addr ), len-sizeof (struct rtw_ieee80211_hdr_3addr )); + pmlmeinfo->assoc_AP_vendor =check_assoc_AP (pframe +sizeof (struct rtw_ieee80211_hdr_3addr ), len -sizeof (struct rtw_ieee80211_hdr_3addr ));/* update TSF Value */ update_TSF (pmlmeext, pframe, len);
@@ -673,7 +673,7 @@ unsigned int OnBeacon(struct adapter *padapter, struct recv_frame *precv_frame)return _SUCCESS; } -if (((pmlmeinfo->state&0x03 ) ==WIFI_FW_STATION_STATE ) && (pmlmeinfo->state &WIFI_FW_ASSOC_SUCCESS )) { +if (((pmlmeinfo->state &0x03 ) ==WIFI_FW_STATION_STATE ) && (pmlmeinfo->state &WIFI_FW_ASSOC_SUCCESS )) { psta =rtw_get_stainfo (pstapriv,GetAddr2Ptr (pframe));if (psta) { ret =rtw_check_bcn_info (padapter, pframe, len);
@@ -688,7 +688,7 @@ unsigned int OnBeacon(struct adapter *padapter, struct recv_frame *precv_frame)update_beacon_info (padapter, pframe, len, psta);process_p2p_ps_ie (padapter, (pframe +WLAN_HDR_A3_LEN ), (len -WLAN_HDR_A3_LEN )); } - }else if ((pmlmeinfo->state&0x03 ) ==WIFI_FW_ADHOC_STATE ) { + }else if ((pmlmeinfo->state &0x03 ) ==WIFI_FW_ADHOC_STATE ) { psta =rtw_get_stainfo (pstapriv,GetAddr2Ptr (pframe));if (psta) {/* update WMM, ERP in the beacon */
@@ -738,7 +738,7 @@ unsigned int OnAuth(struct adapter *padapter, struct recv_frame *precv_frame)u8 *pframe = precv_frame->rx_data;uint len = precv_frame->len; -if ((pmlmeinfo->state&0x03 ) !=WIFI_FW_AP_STATE ) +if ((pmlmeinfo->state &0x03 ) !=WIFI_FW_AP_STATE )return _FAIL;DBG_88E ("+OnAuth\n" );
@@ -808,7 +808,7 @@ unsigned int OnAuth(struct adapter *padapter, struct recv_frame *precv_frame)if ((pstat->auth_seq +1 ) != seq) {DBG_88E ("(1)auth rejected because out of seq [rx_seq=%d, exp_seq=%d]!\n" , - seq, pstat->auth_seq+1 ); + seq, pstat->auth_seq +1 ); status = _STATS_OUT_OF_AUTH_SEQ_; goto auth_fail; }
@@ -821,7 +821,7 @@ unsigned int OnAuth(struct adapter *padapter, struct recv_frame *precv_frame) pstat->authalg = algorithm; }else {DBG_88E ("(2)auth rejected because out of seq [rx_seq=%d, exp_seq=%d]!\n" , - seq, pstat->auth_seq+1 ); + seq, pstat->auth_seq +1 ); status = _STATS_OUT_OF_AUTH_SEQ_; goto auth_fail; }
@@ -858,7 +858,7 @@ unsigned int OnAuth(struct adapter *padapter, struct recv_frame *precv_frame) } }else {DBG_88E ("(3)auth rejected because out of seq [rx_seq=%d, exp_seq=%d]!\n" , - seq, pstat->auth_seq+1 ); + seq, pstat->auth_seq +1 ); status = _STATS_OUT_OF_AUTH_SEQ_; goto auth_fail; }
@@ -997,7 +997,7 @@ unsigned int OnAssocReq(struct adapter *padapter, struct recv_frame *precv_frameu32 p2pielen =0 ;#endif /* CONFIG_88EU_P2P */ -if ((pmlmeinfo->state&0x03 ) !=WIFI_FW_AP_STATE ) +if ((pmlmeinfo->state &0x03 ) !=WIFI_FW_AP_STATE )return _FAIL; frame_type =GetFrameSubType (pframe);
@@ -1062,7 +1062,7 @@ unsigned int OnAssocReq(struct adapter *padapter, struct recv_frame *precv_frame status = _STATS_FAILURE_; }else {/* check if ssid match */ -if (memcmp ((void *)(p+2 ), cur->Ssid.Ssid, cur->Ssid.SsidLength)) +if (memcmp ((void *)(p +2 ), cur->Ssid.Ssid, cur->Ssid.SsidLength)) status = _STATS_FAILURE_;if (ie_len != cur->Ssid.SsidLength)
@@ -1083,14 +1083,14 @@ unsigned int OnAssocReq(struct adapter *padapter, struct recv_frame *precv_frame status = _STATS_FAILURE_; goto OnAssocReqFail; }else { -memcpy (supportRate, p+2 , ie_len); +memcpy (supportRate, p +2 , ie_len); supportRateNum = ie_len; p =rtw_get_ie (pframe +WLAN_HDR_A3_LEN + ie_offset, _EXT_SUPPORTEDRATES_IE_, &ie_len, pkt_len -WLAN_HDR_A3_LEN - ie_offset);if (p) {if (supportRateNum <=sizeof (supportRate)) { -memcpy (supportRate+supportRateNum, p+2 , ie_len); +memcpy (supportRate + supportRateNum, p +2 , ie_len); supportRateNum += ie_len; } }
@@ -1118,12 +1118,12 @@ unsigned int OnAssocReq(struct adapter *padapter, struct recv_frame *precv_frame wpa_ie = elems.rsn_ie; wpa_ie_len = elems.rsn_ie_len; -if (rtw_parse_wpa2_ie (wpa_ie-2 , wpa_ie_len+2 , &group_cipher, &pairwise_cipher,NULL ) == _SUCCESS) { +if (rtw_parse_wpa2_ie (wpa_ie -2 , wpa_ie_len +2 , &group_cipher, &pairwise_cipher,NULL ) == _SUCCESS) { pstat->dot8021xalg =1 ;/* psk, todo:802.1x */ pstat->wpa_psk |=BIT (1 ); - pstat->wpa2_group_cipher = group_cipher&psecuritypriv->wpa2_group_cipher; - pstat->wpa2_pairwise_cipher = pairwise_cipher&psecuritypriv->wpa2_pairwise_cipher; + pstat->wpa2_group_cipher = group_cipher & psecuritypriv->wpa2_group_cipher; + pstat->wpa2_pairwise_cipher = pairwise_cipher & psecuritypriv->wpa2_pairwise_cipher;if (!pstat->wpa2_group_cipher) status =WLAN_STATUS_GROUP_CIPHER_NOT_VALID ;
@@ -1139,12 +1139,12 @@ unsigned int OnAssocReq(struct adapter *padapter, struct recv_frame *precv_frame wpa_ie = elems.wpa_ie; wpa_ie_len = elems.wpa_ie_len; -if (rtw_parse_wpa_ie (wpa_ie-2 , wpa_ie_len+2 , &group_cipher, &pairwise_cipher,NULL ) == _SUCCESS) { +if (rtw_parse_wpa_ie (wpa_ie -2 , wpa_ie_len +2 , &group_cipher, &pairwise_cipher,NULL ) == _SUCCESS) { pstat->dot8021xalg =1 ;/* psk, todo:802.1x */ pstat->wpa_psk |=BIT (0 ); - pstat->wpa_group_cipher = group_cipher&psecuritypriv->wpa_group_cipher; - pstat->wpa_pairwise_cipher = pairwise_cipher&psecuritypriv->wpa_pairwise_cipher; + pstat->wpa_group_cipher = group_cipher & psecuritypriv->wpa_group_cipher; + pstat->wpa_pairwise_cipher = pairwise_cipher & psecuritypriv->wpa_pairwise_cipher;if (!pstat->wpa_group_cipher) status =WLAN_STATUS_GROUP_CIPHER_NOT_VALID ;
@@ -1181,7 +1181,7 @@ unsigned int OnAssocReq(struct adapter *padapter, struct recv_frame *precv_frame/* AP support WPA/RSN, and sta is going to do WPS, but AP is not ready */ /* that the selected registrar of AP is _FLASE */ -if ((psecuritypriv->wpa_psk >0 ) && (pstat->flags & (WLAN_STA_WPS |WLAN_STA_MAYBE_WPS ))) { +if ((psecuritypriv->wpa_psk >0 ) && (pstat->flags & (WLAN_STA_WPS |WLAN_STA_MAYBE_WPS ))) {if (pmlmepriv->wps_beacon_ie) {u8 selected_registrar =0 ;
@@ -1215,10 +1215,10 @@ unsigned int OnAssocReq(struct adapter *padapter, struct recv_frame *precv_frame pstat->flags |=WLAN_STA_WPS ; copy_len =0 ; }else { - copy_len = ((wpa_ie_len+2 ) >sizeof (pstat->wpa_ie)) ? (sizeof (pstat->wpa_ie)) : (wpa_ie_len+2 ); + copy_len = ((wpa_ie_len +2 ) >sizeof (pstat->wpa_ie)) ? (sizeof (pstat->wpa_ie)) : (wpa_ie_len +2 ); }if (copy_len >0 ) -memcpy (pstat->wpa_ie, wpa_ie-2 , copy_len); +memcpy (pstat->wpa_ie, wpa_ie -2 , copy_len); }/* check if there is WMM IE & support WWM-PS */ pstat->flags &= ~WLAN_STA_WME ;
@@ -1234,37 +1234,37 @@ unsigned int OnAssocReq(struct adapter *padapter, struct recv_frame *precv_framefor (;;) { p =rtw_get_ie (p, _VENDOR_SPECIFIC_IE_, &ie_len, pkt_len -WLAN_HDR_A3_LEN - ie_offset);if (p) { -if (!memcmp (p+2 ,WMM_IE ,6 )) { +if (!memcmp (p +2 ,WMM_IE ,6 )) { pstat->flags |=WLAN_STA_WME ; pstat->qos_option =1 ; - pstat->qos_info = *(p+8 ); + pstat->qos_info = *(p +8 ); - pstat->max_sp_len = (pstat->qos_info>>5 )&0x3 ; + pstat->max_sp_len = (pstat->qos_info >>5 ) &0x3 ; -if ((pstat->qos_info&0xf ) !=0xf ) +if ((pstat->qos_info &0xf ) !=0xf ) pstat->has_legacy_ac = true;else pstat->has_legacy_ac = false; -if (pstat->qos_info&0xf ) { -if (pstat->qos_info&BIT (0 )) - pstat->uapsd_vo =BIT (0 )|BIT (1 ); +if (pstat->qos_info &0xf ) { +if (pstat->qos_info &BIT (0 )) + pstat->uapsd_vo =BIT (0 ) |BIT (1 );else pstat->uapsd_vo =0 ; -if (pstat->qos_info&BIT (1 )) - pstat->uapsd_vi =BIT (0 )|BIT (1 ); +if (pstat->qos_info &BIT (1 )) + pstat->uapsd_vi =BIT (0 ) |BIT (1 );else pstat->uapsd_vi =0 ; -if (pstat->qos_info&BIT (2 )) - pstat->uapsd_bk =BIT (0 )|BIT (1 ); +if (pstat->qos_info &BIT (2 )) + pstat->uapsd_bk =BIT (0 ) |BIT (1 );else pstat->uapsd_bk =0 ; -if (pstat->qos_info&BIT (3 )) - pstat->uapsd_be =BIT (0 )|BIT (1 ); +if (pstat->qos_info &BIT (3 )) + pstat->uapsd_be =BIT (0 ) |BIT (1 );else pstat->uapsd_be =0 ; }
@@ -1288,14 +1288,14 @@ unsigned int OnAssocReq(struct adapter *padapter, struct recv_frame *precv_frame }else { pstat->flags &= ~WLAN_STA_HT ; } -if ((!pmlmepriv->htpriv.ht_option) && (pstat->flags&WLAN_STA_HT )) { +if ((!pmlmepriv->htpriv.ht_option) && (pstat->flags &WLAN_STA_HT )) { status = _STATS_FAILURE_; goto OnAssocReqFail; }if ((pstat->flags &WLAN_STA_HT ) && - ((pstat->wpa2_pairwise_cipher&WPA_CIPHER_TKIP ) || - (pstat->wpa_pairwise_cipher&WPA_CIPHER_TKIP ))) { + ((pstat->wpa2_pairwise_cipher &WPA_CIPHER_TKIP ) || + (pstat->wpa_pairwise_cipher &WPA_CIPHER_TKIP ))) {DBG_88E ("HT: %pM tried to " "use TKIP with HT association\n" , pstat->hwaddr);
@@ -1473,7 +1473,7 @@ unsigned int OnAssocRsp(struct adapter *padapter, struct recv_frame *precv_frame pmlmeinfo->slotTime = (pmlmeinfo->capability &BIT (10 )) ?9 :20 ;/* AID */ - pmlmeinfo->aid = (int )(le16_to_cpu (*(__le16 *)(pframe +WLAN_HDR_A3_LEN +4 ))&0x3fff ); + pmlmeinfo->aid = (int )(le16_to_cpu (*(__le16 *)(pframe +WLAN_HDR_A3_LEN +4 )) &0x3fff ); res = pmlmeinfo->aid;/* following are moved to join event callback function */
@@ -1733,7 +1733,7 @@ unsigned int OnAction_back(struct adapter *padapter, struct recv_frame *precv_frDBG_88E ("%s\n" , __func__); -if ((pmlmeinfo->state&0x03 ) !=WIFI_FW_AP_STATE ) +if ((pmlmeinfo->state &0x03 ) !=WIFI_FW_AP_STATE )if (!(pmlmeinfo->state &WIFI_FW_ASSOC_SUCCESS ))return _SUCCESS;
@@ -3515,8 +3515,8 @@ static int _issue_probereq_p2p(struct adapter *padapter, u8 *da, int wait_ack) pmlmeext->mgnt_seq++;SetFrameSubType (pframe,WIFI_PROBEREQ ); - pframe +=sizeof (struct rtw_ieee80211_hdr_3addr ); - pattrib->pktlen =sizeof (struct rtw_ieee80211_hdr_3addr ); + pframe +=sizeof (struct rtw_ieee80211_hdr_3addr ); + pattrib->pktlen =sizeof (struct rtw_ieee80211_hdr_3addr );if (rtw_p2p_chk_state (pwdinfo,P2P_STATE_TX_PROVISION_DIS_REQ )) pframe =rtw_set_ie (pframe, _SSID_IE_, pwdinfo->tx_prov_disc_info.ssid.SsidLength, pwdinfo->tx_prov_disc_info.ssid.Ssid, &pattrib->pktlen);
@@ -3794,7 +3794,7 @@ static s32 rtw_action_public_decache(struct recv_frame *recv_frame, s32 token)struct adapter *adapter = recv_frame->adapter;struct mlme_ext_priv *mlmeext = &adapter->mlmeextpriv;u8 *frame = recv_frame->rx_data; -u16 seq_ctrl = ((recv_frame->attrib.seq_num&0xffff ) <<4 ) | +u16 seq_ctrl = ((recv_frame->attrib.seq_num &0xffff ) <<4 ) | (recv_frame->attrib.frag_num &0xf );if (GetRetry (frame)) {
@@ -4237,7 +4237,7 @@ unsigned int OnAction(struct adapter *padapter, struct recv_frame *precv_frame) category = frame_body[0 ]; -for (i =0 ; i <sizeof (OnAction_tbl)/sizeof (struct action_handler ); i++) { +for (i =0 ; i <sizeof (OnAction_tbl) /sizeof (struct action_handler ); i++) { ptable = &OnAction_tbl[i];if (category == ptable->num) ptable->func (padapter, precv_frame);
@@ -4389,7 +4389,7 @@ static int update_hidden_ssid(u8 *ies, u32 ies_len, u8 hidden_ssid_mode) remain_len = ies_len - (next_ie - ies); ssid_ie[1 ] =0 ; -memcpy (ssid_ie+2 , next_ie, remain_len); +memcpy (ssid_ie +2 , next_ie, remain_len); len_diff -= ssid_len_ori;break ;
@@ -4428,7 +4428,7 @@ void issue_beacon(struct adapter *padapter, int timeout_ms)DBG_88E ("%s, alloc mgnt frame fail\n" , __func__);return ; } -#if defined (CONFIG_88EU_AP_MODE ) +#if defined(CONFIG_88EU_AP_MODE )spin_lock_bh (&pmlmepriv->bcn_update_lock);#endif /* if defined (CONFIG_88EU_AP_MODE) */
@@ -4454,14 +4454,14 @@ void issue_beacon(struct adapter *padapter, int timeout_ms)SetFrameSubType (pframe,WIFI_BEACON ); pframe +=sizeof (struct rtw_ieee80211_hdr_3addr ); - pattrib->pktlen =sizeof (struct rtw_ieee80211_hdr_3addr ); + pattrib->pktlen =sizeof (struct rtw_ieee80211_hdr_3addr ); -if ((pmlmeinfo->state&0x03 ) ==WIFI_FW_AP_STATE ) { +if ((pmlmeinfo->state &0x03 ) ==WIFI_FW_AP_STATE ) {#ifdef CONFIG_88EU_P2P /* for P2P : Primary Device Type & Device Name */ u32 wpsielen =0 , insert_len =0 ;u8 *wpsie =NULL ; - wpsie =rtw_get_wps_ie (cur_network->IEs+_FIXED_IE_LENGTH_, cur_network->IELength-_FIXED_IE_LENGTH_,NULL , &wpsielen); + wpsie =rtw_get_wps_ie (cur_network->IEs + _FIXED_IE_LENGTH_, cur_network->IELength - _FIXED_IE_LENGTH_,NULL , &wpsielen);if (rtw_p2p_chk_role (pwdinfo,P2P_ROLE_GO ) && wpsie && wpsielen >0 ) {uint wps_offset, remainder_ielen;
@@ -4471,7 +4471,7 @@ void issue_beacon(struct adapter *padapter, int timeout_ms) premainder_ie = wpsie + wpsielen; remainder_ielen = cur_network->IELength - wps_offset - wpsielen; pframe_wscie = pframe + wps_offset; -memcpy (pframe, cur_network->IEs, wps_offset+wpsielen); +memcpy (pframe, cur_network->IEs, wps_offset + wpsielen); pframe += (wps_offset + wpsielen); pattrib->pktlen += (wps_offset + wpsielen);
@@ -4512,7 +4512,7 @@ void issue_beacon(struct adapter *padapter, int timeout_ms) insert_len += pwdinfo->device_name_len;/* update wsc ie length */ - *(pframe_wscie+1 ) = (wpsielen-2 ) + insert_len; + *(pframe_wscie +1 ) = (wpsielen -2 ) + insert_len;/* pframe move to end */ pframe += insert_len;
@@ -4528,20 +4528,20 @@ void issue_beacon(struct adapter *padapter, int timeout_ms)int len_diff;memcpy (pframe, cur_network->IEs, cur_network->IELength); len_diff =update_hidden_ssid ( - pframe+_BEACON_IE_OFFSET_ - , cur_network->IELength-_BEACON_IE_OFFSET_ + pframe + _BEACON_IE_OFFSET_ + , cur_network->IELength - _BEACON_IE_OFFSET_ , pmlmeinfo->hidden_ssid_mode ); - pframe += (cur_network->IELength+len_diff); - pattrib->pktlen += (cur_network->IELength+len_diff); + pframe += (cur_network->IELength + len_diff); + pattrib->pktlen += (cur_network->IELength + len_diff); } {u8 *wps_ie;uint wps_ielen;u8 sr =0 ; - wps_ie =rtw_get_wps_ie (pmgntframe->buf_addr+TXDESC_OFFSET +sizeof (struct rtw_ieee80211_hdr_3addr )+_BEACON_IE_OFFSET_, - pattrib->pktlen-sizeof (struct rtw_ieee80211_hdr_3addr )-_BEACON_IE_OFFSET_,NULL , &wps_ielen); + wps_ie =rtw_get_wps_ie (pmgntframe->buf_addr +TXDESC_OFFSET +sizeof (struct rtw_ieee80211_hdr_3addr ) + _BEACON_IE_OFFSET_, + pattrib->pktlen -sizeof (struct rtw_ieee80211_hdr_3addr ) - _BEACON_IE_OFFSET_,NULL , &wps_ielen);if (wps_ie && wps_ielen >0 )rtw_get_wps_attr_content (wps_ie, wps_ielen,WPS_ATTR_SELECTED_REGISTRAR , (u8 *)(&sr),NULL );if (sr !=0 )
@@ -4610,7 +4610,7 @@ void issue_beacon(struct adapter *padapter, int timeout_ms)/* todo:HT for adhoc */ _issue_bcn: -#if defined (CONFIG_88EU_AP_MODE ) +#if defined(CONFIG_88EU_AP_MODE ) pmlmepriv->update_bcn = false;spin_unlock_bh (&pmlmepriv->bcn_update_lock);
@@ -4639,7 +4639,7 @@ void issue_probersp(struct adapter *padapter, unsigned char *da, u8 is_valid_p2p__le16 *fctrl;unsigned char *mac, *bssid;struct xmit_priv *pxmitpriv = &padapter->xmitpriv; -#if defined (CONFIG_88EU_AP_MODE ) +#if defined(CONFIG_88EU_AP_MODE )u8 *pwps_ie;uint wps_ielen;struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
@@ -4688,8 +4688,8 @@ void issue_probersp(struct adapter *padapter, unsigned char *da, u8 is_valid_p2preturn ;#if defined(CONFIG_88EU_AP_MODE ) -if ((pmlmeinfo->state&0x03 ) ==WIFI_FW_AP_STATE ) { - pwps_ie =rtw_get_wps_ie (cur_network->IEs+_FIXED_IE_LENGTH_, cur_network->IELength-_FIXED_IE_LENGTH_,NULL , &wps_ielen); +if ((pmlmeinfo->state &0x03 ) ==WIFI_FW_AP_STATE ) { + pwps_ie =rtw_get_wps_ie (cur_network->IEs + _FIXED_IE_LENGTH_, cur_network->IELength - _FIXED_IE_LENGTH_,NULL , &wps_ielen);/* inerset & update wps_probe_resp_ie */ if (pmlmepriv->wps_probe_resp_ie && pwps_ie && wps_ielen >0 ) {
@@ -4707,13 +4707,13 @@ void issue_probersp(struct adapter *padapter, unsigned char *da, u8 is_valid_p2p pattrib->pktlen += wps_offset; wps_ielen = (uint )pmlmepriv->wps_probe_resp_ie[1 ];/* to get ie data len */ -if ((wps_offset+wps_ielen+2 ) <=MAX_IE_SZ ) { -memcpy (pframe, pmlmepriv->wps_probe_resp_ie, wps_ielen+2 ); - pframe += wps_ielen+2 ; - pattrib->pktlen += wps_ielen+2 ; +if ((wps_offset + wps_ielen +2 ) <=MAX_IE_SZ ) { +memcpy (pframe, pmlmepriv->wps_probe_resp_ie, wps_ielen +2 ); + pframe += wps_ielen +2 ; + pattrib->pktlen += wps_ielen +2 ; } -if ((wps_offset+wps_ielen+2 +remainder_ielen) <=MAX_IE_SZ ) { +if ((wps_offset + wps_ielen +2 + remainder_ielen) <=MAX_IE_SZ ) {memcpy (pframe, premainder_ie, remainder_ielen); pframe += remainder_ielen; pattrib->pktlen += remainder_ielen;
@@ -4756,7 +4756,7 @@ void issue_probersp(struct adapter *padapter, unsigned char *da, u8 is_valid_p2p/* DS parameter set */ pframe =rtw_set_ie (pframe, _DSSET_IE_,1 , (unsigned char *)&cur_network->Configuration.DSConfig, &pattrib->pktlen); -if ((pmlmeinfo->state&0x03 ) ==WIFI_FW_ADHOC_STATE ) { +if ((pmlmeinfo->state &0x03 ) ==WIFI_FW_ADHOC_STATE ) {u8 erpinfo =0 ;u32 ATIMWindow;/* IBSS Parameter Set... */
@@ -4839,8 +4839,8 @@ static int _issue_probereq(struct adapter *padapter, struct ndis_802_11_ssid *ps pmlmeext->mgnt_seq++;SetFrameSubType (pframe,WIFI_PROBEREQ ); - pframe +=sizeof (struct rtw_ieee80211_hdr_3addr ); - pattrib->pktlen =sizeof (struct rtw_ieee80211_hdr_3addr ); + pframe +=sizeof (struct rtw_ieee80211_hdr_3addr ); + pattrib->pktlen =sizeof (struct rtw_ieee80211_hdr_3addr );if (pssid) pframe =rtw_set_ie (pframe, _SSID_IE_, pssid->SsidLength, pssid->Ssid, &pattrib->pktlen);
@@ -5121,7 +5121,7 @@ void issue_asocrsp(struct adapter *padapter, unsigned short status, struct sta_i pframe =rtw_set_ie (pframe, _SUPPORTEDRATES_IE_, pstat->bssratelen, pstat->bssrateset, &pattrib->pktlen); }else { pframe =rtw_set_ie (pframe, _SUPPORTEDRATES_IE_,8 , pstat->bssrateset, &pattrib->pktlen); - pframe =rtw_set_ie (pframe, _EXT_SUPPORTEDRATES_IE_, pstat->bssratelen-8 , pstat->bssrateset+8 , &pattrib->pktlen); + pframe =rtw_set_ie (pframe, _EXT_SUPPORTEDRATES_IE_, pstat->bssratelen -8 , pstat->bssrateset +8 , &pattrib->pktlen); }if ((pstat->flags &WLAN_STA_HT ) && (pmlmepriv->htpriv.ht_option)) {
@@ -5130,17 +5130,17 @@ void issue_asocrsp(struct adapter *padapter, unsigned short status, struct sta_i/* FILL HT CAP INFO IE */ pbuf =rtw_get_ie (ie + _BEACON_IE_OFFSET_, _HT_CAPABILITY_IE_, &ie_len, (pnetwork->IELength - _BEACON_IE_OFFSET_));if (pbuf && ie_len >0 ) { -memcpy (pframe, pbuf, ie_len+2 ); - pframe += (ie_len+2 ); - pattrib->pktlen += (ie_len+2 ); +memcpy (pframe, pbuf, ie_len +2 ); + pframe += (ie_len +2 ); + pattrib->pktlen += (ie_len +2 ); }/* FILL HT ADD INFO IE */ pbuf =rtw_get_ie (ie + _BEACON_IE_OFFSET_, _HT_ADD_INFO_IE_, &ie_len, (pnetwork->IELength - _BEACON_IE_OFFSET_));if (pbuf && ie_len >0 ) { -memcpy (pframe, pbuf, ie_len+2 ); - pframe += (ie_len+2 ); - pattrib->pktlen += (ie_len+2 ); +memcpy (pframe, pbuf, ie_len +2 ); + pframe += (ie_len +2 ); + pattrib->pktlen += (ie_len +2 ); } }
@@ -5151,10 +5151,10 @@ void issue_asocrsp(struct adapter *padapter, unsigned short status, struct sta_ifor (pbuf = ie + _BEACON_IE_OFFSET_;; pbuf += (ie_len +2 )) { pbuf =rtw_get_ie (pbuf, _VENDOR_SPECIFIC_IE_, &ie_len, (pnetwork->IELength - _BEACON_IE_OFFSET_ - (ie_len +2 ))); -if (pbuf && !memcmp (pbuf+2 ,WMM_PARA_IE ,6 )) { -memcpy (pframe, pbuf, ie_len+2 ); - pframe += (ie_len+2 ); - pattrib->pktlen += (ie_len+2 ); +if (pbuf && !memcmp (pbuf +2 ,WMM_PARA_IE ,6 )) { +memcpy (pframe, pbuf, ie_len +2 ); + pframe += (ie_len +2 ); + pattrib->pktlen += (ie_len +2 );break ; }
@@ -5276,8 +5276,8 @@ void issue_assocreq(struct adapter *padapter)/* Check if the AP's supported rates are also supported by STA. */ for (j =0 ; j < sta_bssrate_len; j++) {/* Avoid the proprietary data rate (22Mbps) of Handlink WSG-4000 AP */ -if ((pmlmeinfo->network.SupportedRates[i]|IEEE80211_BASIC_RATE_MASK ) - == (sta_bssrate[j]|IEEE80211_BASIC_RATE_MASK )) +if ((pmlmeinfo->network.SupportedRates[i] |IEEE80211_BASIC_RATE_MASK ) + == (sta_bssrate[j] |IEEE80211_BASIC_RATE_MASK ))break ; }
@@ -5557,9 +5557,9 @@ static int _issue_nulldata(struct adapter *padapter, unsigned char *da, unsigned fctrl = &pwlanhdr->frame_ctl; *(fctrl) =0 ; -if ((pmlmeinfo->state&0x03 ) ==WIFI_FW_AP_STATE ) +if ((pmlmeinfo->state &0x03 ) ==WIFI_FW_AP_STATE )SetFrDs (fctrl); -else if ((pmlmeinfo->state&0x03 ) ==WIFI_FW_STATION_STATE ) +else if ((pmlmeinfo->state &0x03 ) ==WIFI_FW_STATION_STATE )SetToDs (fctrl);if (power_mode)
@@ -5672,9 +5672,9 @@ static int _issue_qos_nulldata(struct adapter *padapter, unsigned char *da, u16 fctrl = &pwlanhdr->frame_ctl; *(fctrl) =0 ; -if ((pmlmeinfo->state&0x03 ) ==WIFI_FW_AP_STATE ) +if ((pmlmeinfo->state &0x03 ) ==WIFI_FW_AP_STATE )SetFrDs (fctrl); -else if ((pmlmeinfo->state&0x03 ) ==WIFI_FW_STATION_STATE ) +else if ((pmlmeinfo->state &0x03 ) ==WIFI_FW_STATION_STATE )SetToDs (fctrl);if (pattrib->mdata)
@@ -5868,7 +5868,7 @@ int issue_deauth_ex(struct adapter *padapter, u8 *da, unsigned short reason, intreturn ret; } -void issue_action_spct_ch_switch (struct adapter *padapter,u8 *ra,u8 new_ch,u8 ch_offset) +void issue_action_spct_ch_switch (struct adapter *padapter,u8 *ra,u8 new_ch,u8 ch_offset) {struct xmit_frame *pmgntframe;struct pkt_attrib *pattrib;
@@ -5918,7 +5918,7 @@ void issue_action_spct_ch_switch (struct adapter *padapter, u8 *ra, u8 new_ch, u pframe =rtw_set_fixed_ie (pframe,1 , &action, &pattrib->pktlen); } - pframe =rtw_set_ie_ch_switch (pframe, &pattrib->pktlen,0 , new_ch,0 ); + pframe =rtw_set_ie_ch_switch (pframe, &pattrib->pktlen,0 , new_ch,0 ); pframe =rtw_set_ie_secondary_ch_offset (pframe, &pattrib->pktlen,hal_ch_offset_to_secondary_ch_offset (ch_offset));
@@ -6000,7 +6000,7 @@ void issue_action_BA(struct adapter *padapter, unsigned char *raddr, unsigned ch psta =rtw_get_stainfo (pstapriv, raddr);if (psta) { - start_seq = (psta->sta_xmitpriv.txseq_tid[status &0x07 ]&0xfff ) +1 ; + start_seq = (psta->sta_xmitpriv.txseq_tid[status &0x07 ] &0xfff ) +1 ;DBG_88E ("BA_starting_seqctrl=%d for TID=%d\n" , start_seq, status &0x07 );
@@ -6200,7 +6200,7 @@ unsigned int send_delba(struct adapter *padapter, u8 initiator, u8 *addr)struct mlme_ext_info *pmlmeinfo = &pmlmeext->mlmext_info;u16 tid; -if ((pmlmeinfo->state&0x03 ) !=WIFI_FW_AP_STATE ) +if ((pmlmeinfo->state &0x03 ) !=WIFI_FW_AP_STATE )if (!(pmlmeinfo->state &WIFI_FW_ASSOC_SUCCESS ))return _SUCCESS;
@@ -6212,7 +6212,7 @@ unsigned int send_delba(struct adapter *padapter, u8 initiator, u8 *addr)for (tid =0 ; tid <MAXTID ; tid++) {if (psta->recvreorder_ctrl[tid].enable) {DBG_88E ("rx agg disable tid(%d)\n" , tid); -issue_action_BA (padapter, addr,RTW_WLAN_ACTION_DELBA , (((tid <<1 ) | initiator)&0x1F )); +issue_action_BA (padapter, addr,RTW_WLAN_ACTION_DELBA , (((tid <<1 ) | initiator) &0x1F )); psta->recvreorder_ctrl[tid].enable = false; psta->recvreorder_ctrl[tid].indicate_seq =0xffff ; }
@@ -6221,7 +6221,7 @@ unsigned int send_delba(struct adapter *padapter, u8 initiator, u8 *addr)for (tid =0 ; tid <MAXTID ; tid++) {if (psta->htpriv.agg_enable_bitmap &BIT (tid)) {DBG_88E ("tx agg disable tid(%d)\n" , tid); -issue_action_BA (padapter, addr,RTW_WLAN_ACTION_DELBA , (((tid <<1 ) | initiator)&0x1F )); +issue_action_BA (padapter, addr,RTW_WLAN_ACTION_DELBA , (((tid <<1 ) | initiator) &0x1F )); psta->htpriv.agg_enable_bitmap &= ~BIT (tid); psta->htpriv.candidate_tid_bitmap &= ~BIT (tid); }
@@ -6247,7 +6247,7 @@ unsigned int send_beacon(struct adapter *padapter)yield ();rtw_hal_get_hwreg (padapter,HW_VAR_BCN_VALID , (u8 *)(&bxmitok)); poll++; - }while ((poll%10 ) !=0 && !bxmitok && !padapter->bSurpriseRemoved && !padapter->bDriverStopped); + }while ((poll %10 ) !=0 && !bxmitok && !padapter->bSurpriseRemoved && !padapter->bDriverStopped); }while (!bxmitok && issue <100 && !padapter->bSurpriseRemoved && !padapter->bDriverStopped);if (padapter->bSurpriseRemoved || padapter->bDriverStopped)
@@ -6522,7 +6522,7 @@ u8 collect_bss_info(struct adapter *padapter, struct recv_frame *precv_frame, st p =rtw_get_ie (bssid->IEs + ie_offset, _EXT_SUPPORTEDRATES_IE_, &len, bssid->IELength - ie_offset);if (p) { -if (len > (NDIS_802_11_LENGTH_RATES_EX -i)) { +if (len > (NDIS_802_11_LENGTH_RATES_EX - i)) {DBG_88E ("%s()-%d: IE too long (%d) for survey event\n" , __func__, __LINE__, len);return _FAIL; }
@@ -6582,7 +6582,7 @@ u8 collect_bss_info(struct adapter *padapter, struct recv_frame *precv_frame, ststruct HT_caps_element *pHT_caps; pHT_caps = (struct HT_caps_element *)(p +2 ); -if (le16_to_cpu (pHT_caps->u.HT_cap_element.HT_caps_info)&BIT (14 )) +if (le16_to_cpu (pHT_caps->u.HT_cap_element.HT_caps_info) &BIT (14 )) pmlmepriv->num_FortyMHzIntolerant++; }else { pmlmepriv->num_sta_no_ht++;
@@ -6612,7 +6612,7 @@ void start_create_ibss(struct adapter *padapter)/* udpate capability */ caps =rtw_get_capability ((struct wlan_bssid_ex *)pnetwork);update_capinfo (padapter, caps); -if (caps&cap_IBSS) {/* adhoc master */ +if (caps & cap_IBSS) {/* adhoc master */ val8 =0xcf ;rtw_hal_set_hwreg (padapter,HW_VAR_SEC_CFG , (u8 *)(&val8));
@@ -6665,7 +6665,7 @@ void start_clnt_join(struct adapter *padapter)/* udpate capability */ caps =rtw_get_capability ((struct wlan_bssid_ex *)pnetwork);update_capinfo (padapter, caps); -if (caps&cap_ESS) { +if (caps & cap_ESS) {Set_MSR (padapter,WIFI_FW_STATION_STATE ); val8 = (pmlmeinfo->auth_algo == dot11AuthAlgrthm_8021X) ?0xcc :0xcf ;
@@ -6680,10 +6680,10 @@ void start_clnt_join(struct adapter *padapter) beacon_timeout =decide_wait_for_beacon_timeout (pmlmeinfo->bcn_interval);set_link_timer (pmlmeext, beacon_timeout);_set_timer (&padapter->mlmepriv.assoc_timer, - (REAUTH_TO *REAUTH_LIMIT ) + (REASSOC_TO *REASSOC_LIMIT ) + beacon_timeout); + (REAUTH_TO *REAUTH_LIMIT ) + (REASSOC_TO *REASSOC_LIMIT ) + beacon_timeout); pmlmeinfo->state =WIFI_FW_AUTH_NULL |WIFI_FW_STATION_STATE ; - }else if (caps&cap_IBSS) {/* adhoc client */ + }else if (caps & cap_IBSS) {/* adhoc client */ Set_MSR (padapter,WIFI_FW_ADHOC_STATE ); val8 =0xcf ;
@@ -6757,7 +6757,7 @@ unsigned int receive_disconnect(struct adapter *padapter, unsigned char *MacAddrDBG_88E ("%s\n" , __func__); -if ((pmlmeinfo->state&0x03 ) ==WIFI_FW_STATION_STATE ) { +if ((pmlmeinfo->state &0x03 ) ==WIFI_FW_STATION_STATE ) {if (pmlmeinfo->state &WIFI_FW_ASSOC_SUCCESS ) { pmlmeinfo->state =WIFI_FW_NULL_STATE ;report_del_sta_event (padapter, MacAddr, reason);
@@ -7233,7 +7233,7 @@ void mlmeext_joinbss_event_callback(struct adapter *padapter, int join_res) goto exit_mlmeext_joinbss_event_callback; } -if ((pmlmeinfo->state&0x03 ) ==WIFI_FW_ADHOC_STATE ) { +if ((pmlmeinfo->state &0x03 ) ==WIFI_FW_ADHOC_STATE ) {/* for bc/mc */ psta_bmc =rtw_get_bcmc_stainfo (padapter);if (psta_bmc) {
@@ -7274,14 +7274,14 @@ void mlmeext_joinbss_event_callback(struct adapter *padapter, int join_res)/* set per sta rate after updating HT cap. */ set_sta_rate (padapter, psta);rtw_hal_set_hwreg (padapter,HW_VAR_TX_RPT_MAX_MACID , (u8 *)&psta->mac_id); - media_status = (psta->mac_id<<8 )|1 ;/* MACID|OPMODE: 1 means connect */ + media_status = (psta->mac_id <<8 ) |1 ;/* MACID|OPMODE: 1 means connect */ rtw_hal_set_hwreg (padapter,HW_VAR_H2C_MEDIA_STATUS_RPT , (u8 *)&media_status); } join_type =2 ;rtw_hal_set_hwreg (padapter,HW_VAR_MLME_JOIN , (u8 *)(&join_type)); -if ((pmlmeinfo->state&0x03 ) ==WIFI_FW_STATION_STATE ) { +if ((pmlmeinfo->state &0x03 ) ==WIFI_FW_STATION_STATE ) {/* correcting TSF */ correct_TSF (padapter, pmlmeext); }
@@ -7300,7 +7300,7 @@ void mlmeext_sta_add_event_callback(struct adapter *padapter, struct sta_info *pDBG_88E ("%s\n" , __func__); -if ((pmlmeinfo->state&0x03 ) ==WIFI_FW_ADHOC_STATE ) { +if ((pmlmeinfo->state &0x03 ) ==WIFI_FW_ADHOC_STATE ) {if (pmlmeinfo->state &WIFI_FW_ASSOC_SUCCESS ) {/* adhoc master or sta_count>1 */ /* nothing to do */ }else {/* adhoc client */
@@ -7372,9 +7372,9 @@ void _linked_rx_signal_strehgth_display(struct adapter *padapter)u8 mac_id;int UndecoratedSmoothedPWDB; -if ((pmlmeinfo->state&0x03 ) ==WIFI_FW_STATION_STATE ) +if ((pmlmeinfo->state &0x03 ) ==WIFI_FW_STATION_STATE ) mac_id =0 ; -else if ((pmlmeinfo->state&0x03 ) == _HW_STATE_AP_) +else if ((pmlmeinfo->state &0x03 ) == _HW_STATE_AP_) mac_id =2 ;rtw_hal_get_def_var (padapter,HW_DEF_RA_INFO_DUMP , &mac_id);
@@ -7637,7 +7637,7 @@ u8 setopmode_hdl(struct adapter *padapter, u8 *pbuf) pmlmeinfo->state =WIFI_FW_AP_STATE ; type = _HW_STATE_AP_; }else if (psetop->mode == Ndis802_11Infrastructure) { - pmlmeinfo->state &= ~(BIT (0 )|BIT (1 ));/* clear state */ + pmlmeinfo->state &= ~(BIT (0 ) |BIT (1 ));/* clear state */ pmlmeinfo->state |=WIFI_FW_STATION_STATE ;/* set to STATION_STATE */ type = _HW_STATE_STATION_; }else if (psetop->mode == Ndis802_11IBSS) {
@@ -7834,7 +7834,7 @@ u8 disconnect_hdl(struct adapter *padapter, unsigned char *pbuf)u8 val8;if (is_client_associated_to_ap (padapter)) -issue_deauth_ex (padapter, pnetwork->MacAddress,WLAN_REASON_DEAUTH_LEAVING , param->deauth_timeout_ms/100 ,100 ); +issue_deauth_ex (padapter, pnetwork->MacAddress,WLAN_REASON_DEAUTH_LEAVING , param->deauth_timeout_ms /100 ,100 );rtw_hal_set_hwreg (padapter,HW_VAR_MLME_DISCONNECT ,NULL );rtw_hal_set_hwreg (padapter,HW_VAR_BSSID , null_addr);
@@ -7842,7 +7842,7 @@ u8 disconnect_hdl(struct adapter *padapter, unsigned char *pbuf)/* restore to initial setting. */ update_tx_basic_rate (padapter, padapter->registrypriv.wireless_mode); -if (((pmlmeinfo->state&0x03 ) ==WIFI_FW_ADHOC_STATE ) || ((pmlmeinfo->state&0x03 ) ==WIFI_FW_AP_STATE )) { +if (((pmlmeinfo->state &0x03 ) ==WIFI_FW_ADHOC_STATE ) || ((pmlmeinfo->state &0x03 ) ==WIFI_FW_AP_STATE )) {/* Stop BCN */ val8 =0 ;rtw_hal_set_hwreg (padapter,HW_VAR_BCN_FUNC , (u8 *)(&val8));
@@ -7876,7 +7876,7 @@ static int rtw_scan_ch_decision(struct adapter *padapter, struct rtw_ieee80211_cstruct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;/* clear out first */ -memset (out,0 ,sizeof (struct rtw_ieee80211_channel )*out_num); +memset (out,0 ,sizeof (struct rtw_ieee80211_channel ) * out_num);/* acquire channels from in */ j =0 ;
@@ -8051,7 +8051,7 @@ u8 set_stakey_hdl(struct adapter *padapter, u8 *pbuf)DBG_88E_LEVEL (_drv_info_,"set pairwise key to hw: alg:%d(WEP40-1 WEP104-5 TKIP-2 AES-4) camid:%d\n" , pparm->algorithm, cam_id); -if ((pmlmeinfo->state&0x03 ) ==WIFI_FW_AP_STATE ) { +if ((pmlmeinfo->state &0x03 ) ==WIFI_FW_AP_STATE ) {struct sta_info *psta;struct sta_priv *pstapriv = &padapter->stapriv;
@@ -8066,7 +8066,7 @@ u8 set_stakey_hdl(struct adapter *padapter, u8 *pbuf)DBG_88E ("r871x_set_stakey_hdl(): enc_algorithm=%d\n" , pparm->algorithm); -if ((psta->mac_id <1 ) || (psta->mac_id > (NUM_STA -4 ))) { +if ((psta->mac_id <1 ) || (psta->mac_id > (NUM_STA -4 ))) {DBG_88E ("r871x_set_stakey_hdl():set_stakey failed, mac_id(aid)=%d\n" , psta->mac_id);return H2C_REJECTED ; }
@@ -8110,7 +8110,7 @@ u8 add_ba_hdl(struct adapter *padapter, unsigned char *pbuf)return H2C_SUCCESS ;if (((pmlmeinfo->state &WIFI_FW_ASSOC_SUCCESS ) && (pmlmeinfo->HT_enable)) || - ((pmlmeinfo->state&0x03 ) ==WIFI_FW_AP_STATE )) { + ((pmlmeinfo->state &0x03 ) ==WIFI_FW_AP_STATE )) {issue_action_BA (padapter, pparm->addr,RTW_WLAN_ACTION_ADDBA_REQ , (u16 )pparm->tid);_set_timer (&psta->addba_retry_timer,ADDBA_TO ); }else {
@@ -8144,8 +8144,8 @@ u8 set_tx_beacon_cmd(struct adapter *padapter)memcpy (&ptxBeacon_parm->network, &pmlmeinfo->network,sizeof (struct wlan_bssid_ex )); - len_diff =update_hidden_ssid (ptxBeacon_parm->network.IEs+_BEACON_IE_OFFSET_, - ptxBeacon_parm->network.IELength-_BEACON_IE_OFFSET_, + len_diff =update_hidden_ssid (ptxBeacon_parm->network.IEs + _BEACON_IE_OFFSET_, + ptxBeacon_parm->network.IELength - _BEACON_IE_OFFSET_, pmlmeinfo->hidden_ssid_mode); ptxBeacon_parm->network.IELength += len_diff;
@@ -8167,8 +8167,8 @@ u8 mlme_evt_hdl(struct adapter *padapter, unsigned char *pbuf)struct evt_priv *pevt_priv = &padapter->evtpriv; peventbuf = (uint *)pbuf; - evt_sz = (u16)(*peventbuf&0xffff ); - evt_code = (u8)((*peventbuf>>16 )&0xff ); + evt_sz = (u16)(*peventbuf &0xffff ); + evt_code = (u8)((*peventbuf >>16 ) &0xff );/* checking if event code is valid */ if (evt_code >=MAX_C2HEVT )
@@ -8220,7 +8220,7 @@ u8 tx_beacon_hdl(struct adapter *padapter, unsigned char *pbuf)if (!psta_bmc)return H2C_SUCCESS ; -if ((pstapriv->tim_bitmap&BIT (0 )) && (psta_bmc->sleepq_len >0 )) { +if ((pstapriv->tim_bitmap &BIT (0 )) && (psta_bmc->sleepq_len >0 )) {msleep (10 );/* 10ms, ATIM(HIQ) Windows */ spin_lock_bh (&psta_bmc->sleep_q.lock);
Signature · 1 line
2.32.0
PATCH 12/23 staging: r8188eu: clean up spacing style issues in core/rtw_mp.c
In reply to Michael StraubeClean up spacing style issues in core/rtw_mp.c reported by checkpatch.
CHECK: spaces preferred around that ...
WARNING: space prohibited between function name and open parenthesis '('
--- drivers/staging/r8188eu/core/rtw_mp.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/staging/r8188eu/core/rtw_mp.c +5 -5
@@ -595,7 +595,7 @@ static int mp_xmit_packet_thread(void *context) } } -memcpy ((u8 *)(pxmitframe->buf_addr+TXDESC_OFFSET ), pmptx->buf, pmptx->write_size); +memcpy ((u8 *)(pxmitframe->buf_addr +TXDESC_OFFSET ), pmptx->buf, pmptx->write_size);memcpy (&pxmitframe->attrib, &pmptx->attrib,sizeof (struct pkt_attrib ));dump_mpframe (padapter, pxmitframe);
@@ -698,7 +698,7 @@ void SetPacketTx(struct adapter *padapter)/* offset 8 */ /* offset 12 */ - desc->txdw3 |=cpu_to_le32 ((pattrib->seqnum<<16 )&0x0fff0000 ); + desc->txdw3 |=cpu_to_le32 ((pattrib->seqnum <<16 ) &0x0fff0000 );/* offset 16 */ desc->txdw4 |=cpu_to_le32 (HW_SSN );
@@ -882,7 +882,7 @@ u32 mp_query_psd(struct adapter *pAdapter, u8 *data) i = psd_start;while (i < psd_stop) {if (i >= psd_pts) { - psd_data =rtw_GetPSDData (pAdapter, i-psd_pts); + psd_data =rtw_GetPSDData (pAdapter, i - psd_pts); }else { psd_data =rtw_GetPSDData (pAdapter, i); }
@@ -891,7 +891,7 @@ u32 mp_query_psd(struct adapter *pAdapter, u8 *data) }msleep (100 ); -return strlen (data)+1 ; +return strlen (data) +1 ; }void _rtw_mp_xmit_priv (struct xmit_priv *pxmitpriv)
@@ -964,7 +964,7 @@ void _rtw_mp_xmit_priv(struct xmit_priv *pxmitpriv) ; } -void Hal_ProSetCrystalCap (struct adapter *pAdapter,u32 CrystalCapVal) +void Hal_ProSetCrystalCap (struct adapter *pAdapter,u32 CrystalCapVal) { CrystalCapVal = CrystalCapVal &0x3F ;
Signature · 1 line
2.32.0
PATCH 13/23 staging: r8188eu: clean up spacing style issues in core/rtw_mp_ioctl.c
In reply to Michael StraubeClean up spacing style issues in core/rtw_mp_ioctl.c reported by checkpatch.
CHECK: spaces preferred around that '|' (ctx:VxV)
WARNING: space prohibited between function name and open parenthesis '('
--- drivers/staging/r8188eu/core/rtw_mp_ioctl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/r8188eu/core/rtw_mp_ioctl.c +3 -3
@@ -309,7 +309,7 @@ int rtl8188eu_oid_rt_pro_set_antenna_bb_hdl(struct oid_par_priv *poid_par_priv)SetAntenna (Adapter);_irqlevel_changed_ (&oldirql,RAISE ); }else { - antenna = (Adapter->mppriv.antenna_tx <<16 )|Adapter->mppriv.antenna_rx; + antenna = (Adapter->mppriv.antenna_tx <<16 ) | Adapter->mppriv.antenna_rx; *(u32 *)poid_par_priv->information_buf = antenna; }
@@ -734,7 +734,7 @@ int rtl8188eu_oid_rt_pro_read16_eeprom_hdl(struct oid_par_priv *poid_par_priv) }/* */ -int rtl8188eu_oid_rt_pro_write16_eeprom_hdl (struct oid_par_priv *poid_par_priv) +int rtl8188eu_oid_rt_pro_write16_eeprom_hdl (struct oid_par_priv *poid_par_priv) {return 0 ; }
@@ -754,7 +754,7 @@ int rtl8188eu_oid_rt_rd_attrib_mem_hdl(struct oid_par_priv *poid_par_priv)return 0 ; }/* */ -int rtl8188eu_oid_rt_wr_attrib_mem_hdl (struct oid_par_priv *poid_par_priv) +int rtl8188eu_oid_rt_wr_attrib_mem_hdl (struct oid_par_priv *poid_par_priv) {return 0 ; }
Signature · 1 line
2.32.0
PATCH 14/23 staging: r8188eu: clean up spacing style issues in core/rtw_p2p.c
In reply to Michael StraubeClean up spacing style issues in core/rtw_p2p.c reported by checkpatch.
CHECK: spaces preferred around that ...
CHECK: No space is necessary after a cast
WARNING: space prohibited before semicolon
WARNING: space prohibited between function name and open parenthesis '('
--- drivers/staging/r8188eu/core/rtw_p2p.c | 46 +++++++++++++------------- 1 file changed, 23 insertions(+), 23 deletions(-)
drivers/staging/r8188eu/core/rtw_p2p.c +23 -23
@@ -75,8 +75,8 @@ static u32 go_add_group_info_attr(struct wifidirect_info *pwdinfo, u8 *pbuf) *pcur = psta->num_of_secdev_type; pcur++; -memcpy (pcur, psta->secdev_types_list, psta->num_of_secdev_type*8 ); - pcur += psta->num_of_secdev_type*8 ; +memcpy (pcur, psta->secdev_types_list, psta->num_of_secdev_type *8 ); + pcur += psta->num_of_secdev_type *8 ;if (psta->dev_name_len >0 ) {/* u16*)(pcur) = cpu_to_be16(WPS_ATTR_DEVICE_NAME); */
@@ -91,9 +91,9 @@ static u32 go_add_group_info_attr(struct wifidirect_info *pwdinfo, u8 *pbuf) pcur += psta->dev_name_len; } - tmplen = (u8)(pcur-pstart); + tmplen = (u8)(pcur - pstart); - *pstart = (tmplen-1 ); + *pstart = (tmplen -1 ); attr_len += tmplen;
@@ -419,10 +419,10 @@ u32 build_beacon_p2p_ie(struct wifidirect_info *pwdinfo, u8 *pbuf)/* Be able to participate in additional P2P Groups and */ /* support the P2P Invitation Procedure */ /* Group Capability Bitmap, 1 byte */ - capability =P2P_DEVCAP_INVITATION_PROC |P2P_DEVCAP_CLIENT_DISCOVERABILITY ; + capability =P2P_DEVCAP_INVITATION_PROC |P2P_DEVCAP_CLIENT_DISCOVERABILITY ; capability |= ((P2P_GRPCAP_GO |P2P_GRPCAP_INTRABSS ) <<8 );if (rtw_p2p_chk_state (pwdinfo,P2P_STATE_PROVISIONING_ING )) - capability |= (P2P_GRPCAP_GROUP_FORMATION <<8 ); + capability |= (P2P_GRPCAP_GROUP_FORMATION <<8 ); le_tmp =cpu_to_le16 (capability); p2pielen +=rtw_set_p2p_attr_content (&p2pie[p2pielen],P2P_ATTR_CAPABILITY ,2 , (u8 *)&le_tmp);
@@ -790,7 +790,7 @@ u32 process_probe_req_p2p_ie(struct wifidirect_info *pwdinfo, u8 *pframe, uint lif (rtw_p2p_chk_role (pwdinfo,P2P_ROLE_DEVICE ) ||rtw_p2p_chk_role (pwdinfo,P2P_ROLE_GO )) { p2pie =rtw_get_p2p_ie (pframe +WLAN_HDR_A3_LEN + _PROBEREQ_IE_OFFSET_, len -WLAN_HDR_A3_LEN - _PROBEREQ_IE_OFFSET_,NULL , &p2pielen);if (p2pie) { -if (p && !memcmp ((void *)(p+2 ), (void *)pwdinfo->p2p_wildcard_ssid,7 )) { +if (p && !memcmp ((void *)(p +2 ), (void *)pwdinfo->p2p_wildcard_ssid,7 )) {/* todo: */ /* Check Requested Device Type attributes in WSC IE. */ /* Check Device ID attribute in P2P IE */
@@ -847,7 +847,7 @@ u32 process_assoc_req_p2p_ie(struct wifidirect_info *pwdinfo, u8 *pframe, uint lif (rtw_get_p2p_attr_content (p2p_ie, p2p_ielen,P2P_ATTR_CAPABILITY , (u8 *)&le_tmp, (uint *)&attr_contentlen)) {DBG_88E ("[%s] Got P2P Capability Attr!!\n" , __func__); cap_attr =le16_to_cpu (le_tmp); - psta->dev_cap = cap_attr&0xff ; + psta->dev_cap = cap_attr &0xff ; }/* Check Extended Listen Timing ATTR */
@@ -886,28 +886,28 @@ u32 process_assoc_req_p2p_ie(struct wifidirect_info *pwdinfo, u8 *pframe, uint l psta->num_of_secdev_type = num_of_secdev_type; - len = (sizeof (psta->secdev_types_list) < (num_of_secdev_type*8 )) ? - (sizeof (psta->secdev_types_list)) : (num_of_secdev_type*8 ); + len = (sizeof (psta->secdev_types_list) < (num_of_secdev_type *8 )) ? + (sizeof (psta->secdev_types_list)) : (num_of_secdev_type *8 );memcpy (psta->secdev_types_list, pattr_content, len); - pattr_content += (num_of_secdev_type*8 ); + pattr_content += (num_of_secdev_type *8 ); } psta->dev_name_len =0 ;if (WPS_ATTR_DEVICE_NAME ==be16_to_cpu (*(__be16 *)pattr_content)) { - dev_name_len =be16_to_cpu (*(__be16 *)(pattr_content+2 )); + dev_name_len =be16_to_cpu (*(__be16 *)(pattr_content +2 )); psta->dev_name_len = (sizeof (psta->dev_name) < dev_name_len) ?sizeof (psta->dev_name) : dev_name_len; -memcpy (psta->dev_name, pattr_content+4 , psta->dev_name_len); +memcpy (psta->dev_name, pattr_content +4 , psta->dev_name_len); }kfree (pbuf); } }/* Get the next P2P IE */ - p2p_ie =rtw_get_p2p_ie (p2p_ie+p2p_ielen, ies_len - (p2p_ie - ies + p2p_ielen),NULL , &p2p_ielen); + p2p_ie =rtw_get_p2p_ie (p2p_ie + p2p_ielen, ies_len - (p2p_ie - ies + p2p_ielen),NULL , &p2p_ielen); }return status_code;
@@ -936,7 +936,7 @@ u32 process_p2p_devdisc_req(struct wifidirect_info *pwdinfo, u8 *pframe, uint leif (rtw_get_p2p_attr_content (p2p_ie, p2p_ielen,P2P_ATTR_GROUP_ID , groupid, &attr_contentlen)) {if (!memcmp (pwdinfo->device_addr, groupid,ETH_ALEN ) && - !memcmp (pwdinfo->p2p_group_ssid, groupid+ETH_ALEN , pwdinfo->p2p_group_ssid_len)) { + !memcmp (pwdinfo->p2p_group_ssid, groupid +ETH_ALEN , pwdinfo->p2p_group_ssid_len)) { attr_contentlen =0 ;if (rtw_get_p2p_attr_content (p2p_ie, p2p_ielen,P2P_ATTR_DEVICE_ID , dev_addr, &attr_contentlen)) {struct list_head *phead, *plist;
@@ -951,7 +951,7 @@ u32 process_p2p_devdisc_req(struct wifidirect_info *pwdinfo, u8 *pframe, uint le plist = plist->next; -if (psta->is_p2p_device && (psta->dev_cap&P2P_DEVCAP_CLIENT_DISCOVERABILITY ) && +if (psta->is_p2p_device && (psta->dev_cap &P2P_DEVCAP_CLIENT_DISCOVERABILITY ) && !memcmp (psta->dev_addr, dev_addr,ETH_ALEN )) {/* issue GO Discoverability Request */ issue_group_disc_req (pwdinfo, psta->hwaddr);
@@ -1038,7 +1038,7 @@ static u8 rtw_p2p_get_peer_ch_list(struct wifidirect_info *pwdinfo, u8 *ch_conte peer_ch_list[j] = *(ch_content +1 + i); ch_content += (temp +1 ); ch_cnt -= (temp +1 ); - ch_no += temp ; + ch_no += temp; }return ch_no;
@@ -1198,7 +1198,7 @@ u8 process_p2p_group_negotation_req(struct wifidirect_info *pwdinfo, u8 *pframe, }/* Get the next P2P IE */ - p2p_ie =rtw_get_p2p_ie (p2p_ie+p2p_ielen, ies_len - (p2p_ie - ies + p2p_ielen),NULL , &p2p_ielen); + p2p_ie =rtw_get_p2p_ie (p2p_ie + p2p_ielen, ies_len - (p2p_ie - ies + p2p_ielen),NULL , &p2p_ielen); }return result; }
@@ -1360,7 +1360,7 @@ u8 process_p2p_group_negotation_resp(struct wifidirect_info *pwdinfo, u8 *pframe }/* Get the next P2P IE */ - p2p_ie =rtw_get_p2p_ie (p2p_ie+p2p_ielen, ies_len - (p2p_ie - ies + p2p_ielen),NULL , &p2p_ielen); + p2p_ie =rtw_get_p2p_ie (p2p_ie + p2p_ielen, ies_len - (p2p_ie - ies + p2p_ielen),NULL , &p2p_ielen); } }return result;
@@ -1431,7 +1431,7 @@ u8 process_p2p_group_negotation_confirm(struct wifidirect_info *pwdinfo, u8 *pfr }/* Get the next P2P IE */ - p2p_ie =rtw_get_p2p_ie (p2p_ie+p2p_ielen, ies_len - (p2p_ie - ies + p2p_ielen),NULL , &p2p_ielen); + p2p_ie =rtw_get_p2p_ie (p2p_ie + p2p_ielen, ies_len - (p2p_ie - ies + p2p_ielen),NULL , &p2p_ielen); }return result; }
@@ -1623,7 +1623,7 @@ void process_p2p_ps_ie(struct adapter *padapter, u8 *IEs, u32 IELength) }/* Get the next P2P IE */ - p2p_ie =rtw_get_p2p_ie (p2p_ie+p2p_ielen, ies_len - (p2p_ie - ies + p2p_ielen),NULL , &p2p_ielen); + p2p_ie =rtw_get_p2p_ie (p2p_ie + p2p_ielen, ies_len - (p2p_ie - ies + p2p_ielen),NULL , &p2p_ielen); }if (find_p2p) {
@@ -1740,7 +1740,7 @@ static void reset_ch_sitesurvey_timer_process(struct timer_list *t) pwdinfo->rx_invitereq_info.scan_op_ch_only =0 ; } -static void reset_ch_sitesurvey_timer_process2 (struct timer_list *t) +static void reset_ch_sitesurvey_timer_process2 (struct timer_list *t) {struct adapter *adapter =from_timer (adapter, t, pwrctrlpriv.pwr_state_check_timer);struct wifidirect_info *pwdinfo = &adapter->wdinfo;
@@ -1902,7 +1902,7 @@ void init_wifidirect_info(struct adapter *padapter, enum P2P_ROLE role)rtw_p2p_findphase_ex_set (pwdinfo,P2P_FINDPHASE_EX_NONE ); - pwdinfo->listen_dwell = (u8) ((jiffies %3 ) +1 ); + pwdinfo->listen_dwell = (u8)((jiffies %3 ) +1 );memset (&pwdinfo->tx_prov_disc_info,0x00 ,sizeof (struct tx_provdisc_req_info )); pwdinfo->tx_prov_disc_info.wps_config_method_request =WPS_CM_NONE ;
Signature · 1 line
2.32.0
PATCH 15/23 staging: r8188eu: clean up spacing style issues in core/rtw_pwrctrl.c
In reply to Michael StraubeClean up spacing style issues in core/rtw_pwrctrl.c reported by checkpatch.
CHECK: spaces preferred around that ...
WARNING: space prohibited before semicolon
--- drivers/staging/r8188eu/core/rtw_pwrctrl.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
drivers/staging/r8188eu/core/rtw_pwrctrl.c +8 -8
@@ -108,11 +108,11 @@ static bool rtw_pwr_unassociated_idle(struct adapter *adapter)if (adapter->pwrctrlpriv.ips_deny_time >= jiffies) goto exit; -if (check_fwstate (pmlmepriv,WIFI_ASOC_STATE |WIFI_SITE_MONITOR ) || -check_fwstate (pmlmepriv,WIFI_UNDER_LINKING |WIFI_UNDER_WPS ) || +if (check_fwstate (pmlmepriv,WIFI_ASOC_STATE |WIFI_SITE_MONITOR ) || +check_fwstate (pmlmepriv,WIFI_UNDER_LINKING |WIFI_UNDER_WPS ) ||check_fwstate (pmlmepriv,WIFI_UNDER_WPS ) ||check_fwstate (pmlmepriv,WIFI_AP_STATE ) || -check_fwstate (pmlmepriv,WIFI_ADHOC_MASTER_STATE |WIFI_ADHOC_STATE ) || +check_fwstate (pmlmepriv,WIFI_ADHOC_MASTER_STATE |WIFI_ADHOC_STATE ) || #if defined(CONFIG_88EU_P2P) !rtw_p2p_chk_state(pwdinfo, P2P_STATE_NONE)) #else
@@ -127,10 +127,10 @@ static bool rtw_pwr_unassociated_idle(struct adapter *adapter)struct wifidirect_info *b_pwdinfo = &buddy->wdinfo;#endif -if (check_fwstate (b_pmlmepriv,WIFI_ASOC_STATE |WIFI_SITE_MONITOR ) || -check_fwstate (b_pmlmepriv,WIFI_UNDER_LINKING |WIFI_UNDER_WPS ) || +if (check_fwstate (b_pmlmepriv,WIFI_ASOC_STATE |WIFI_SITE_MONITOR ) || +check_fwstate (b_pmlmepriv,WIFI_UNDER_LINKING |WIFI_UNDER_WPS ) ||check_fwstate (b_pmlmepriv,WIFI_AP_STATE ) || -check_fwstate (b_pmlmepriv,WIFI_ADHOC_MASTER_STATE |WIFI_ADHOC_STATE ) || +check_fwstate (b_pmlmepriv,WIFI_ADHOC_MASTER_STATE |WIFI_ADHOC_STATE ) || #if defined(CONFIG_88EU_P2P) !rtw_p2p_chk_state(b_pwdinfo, P2P_STATE_NONE)) #else
@@ -180,7 +180,7 @@ void rtw_ps_processor(struct adapter *padapter)if (!rtw_pwr_unassociated_idle (padapter)) goto exit; -if ((pwrpriv->rf_pwrstate == rf_on) && ((pwrpriv->pwr_state_check_cnts%4 ) ==0 )) { +if ((pwrpriv->rf_pwrstate == rf_on) && ((pwrpriv->pwr_state_check_cnts %4 ) ==0 )) {DBG_88E ("==>%s .fw_state(%x)\n" , __func__,get_fwstate (pmlmepriv)); pwrpriv->change_rfpwrstate = rf_off;
@@ -444,7 +444,7 @@ void rtw_init_pwrctrl_priv(struct adapter *padapter) pwrctrlpriv->LpsIdleCount =0 ;if (padapter->registrypriv.mp_mode ==1 ) - pwrctrlpriv->power_mgnt =PS_MODE_ACTIVE ; + pwrctrlpriv->power_mgnt =PS_MODE_ACTIVE ;else pwrctrlpriv->power_mgnt = padapter->registrypriv.power_mgnt;/* PS_MODE_MIN; */ pwrctrlpriv->bLeisurePs = (PS_MODE_ACTIVE != pwrctrlpriv->power_mgnt) ? true : false;
Signature · 1 line
2.32.0
PATCH 16/23 staging: r8188eu: clean up spacing style issues in core/rtw_recv.c
In reply to Michael StraubeClean up spacing style issues in core/rtw_recv.c reported by checkpatch.
CHECK: spaces preferred around that ...
CHECK: No space is necessary after a cast
WARNING: space prohibited between function name and open parenthesis '('
--- drivers/staging/r8188eu/core/rtw_recv.c | 112 ++++++++++++------------ 1 file changed, 56 insertions(+), 56 deletions(-)
drivers/staging/r8188eu/core/rtw_recv.c +56 -56
@@ -30,7 +30,7 @@ void rtw_signal_stat_timer_hdl(struct timer_list *);void _rtw_init_sta_recv_priv (struct sta_recv_priv *psta_recvpriv) { -memset ((u8 *)psta_recvpriv,0 ,sizeof (struct sta_recv_priv )); +memset ((u8 *)psta_recvpriv,0 ,sizeof (struct sta_recv_priv ));spin_lock_init (&psta_recvpriv->lock);
@@ -96,7 +96,7 @@ int _rtw_init_recv_priv(struct recv_priv *precvpriv, struct adapter *padapter)return res; } -void _rtw_free_recv_priv (struct recv_priv *precvpriv) +void _rtw_free_recv_priv (struct recv_priv *precvpriv) {struct adapter *padapter = precvpriv->adapter;
@@ -109,7 +109,7 @@ void _rtw_free_recv_priv (struct recv_priv *precvpriv)rtw_hal_free_recv_priv (padapter); } -struct recv_frame *_rtw_alloc_recvframe (struct __queue *pfree_recv_queue) +struct recv_frame *_rtw_alloc_recvframe (struct __queue *pfree_recv_queue) {struct recv_frame *hdr;struct list_head *plist, *phead;
@@ -137,7 +137,7 @@ struct recv_frame *_rtw_alloc_recvframe (struct __queue *pfree_recv_queue)return (struct recv_frame *)hdr; } -struct recv_frame *rtw_alloc_recvframe (struct __queue *pfree_recv_queue) +struct recv_frame *rtw_alloc_recvframe (struct __queue *pfree_recv_queue) {struct recv_frame *precvframe;
@@ -285,7 +285,7 @@ int rtw_enqueue_recvbuf(struct recv_buf *precvbuf, struct __queue *queue)return _SUCCESS; } -struct recv_buf *rtw_dequeue_recvbuf (struct __queue *queue) +struct recv_buf *rtw_dequeue_recvbuf (struct __queue *queue) {struct recv_buf *precvbuf;struct list_head *plist, *phead;
@@ -342,19 +342,19 @@ static int recvframe_chkmic(struct adapter *adapter, struct recv_frame *precvfr mickey = &stainfo->dot11tkiprxmickey.skey[0 ]; } - datalen = precvframe->len-prxattrib->hdrlen-prxattrib->iv_len-prxattrib->icv_len-8 ;/* icv_len included the mic code */ + datalen = precvframe->len - prxattrib->hdrlen - prxattrib->iv_len - prxattrib->icv_len -8 ;/* icv_len included the mic code */ pframe = precvframe->rx_data; - payload = pframe+prxattrib->hdrlen+prxattrib->iv_len; + payload = pframe + prxattrib->hdrlen + prxattrib->iv_len;rtw_seccalctkipmic (mickey, pframe, payload, datalen, &miccode[0 ], (unsigned char )prxattrib->priority);/* care the length of the data */ - pframemic = payload+datalen; + pframemic = payload + datalen; bmic_err = false;for (i =0 ; i <8 ; i++) { -if (miccode[i] != *(pframemic+i)) +if (miccode[i] != *(pframemic + i)) bmic_err = true; }
@@ -395,8 +395,8 @@ static struct recv_frame *decryptor(struct adapter *padapter, struct recv_frameu32 res = _SUCCESS;if (prxattrib->encrypt >0 ) { -u8 *iv = precv_frame->rx_data+prxattrib->hdrlen; - prxattrib->key_index = (((iv[3 ])>>6 )&0x3 ); +u8 *iv = precv_frame->rx_data + prxattrib->hdrlen; + prxattrib->key_index = (((iv[3 ]) >>6 ) &0x3 );if (prxattrib->key_index >WEP_KEYS ) {DBG_88E ("prxattrib->key_index(%d)>WEP_KEYS\n" , prxattrib->key_index);
@@ -480,7 +480,7 @@ static struct recv_frame *portctrl(struct adapter *adapter, struct recv_frame *p prtnframe = precv_frame;/* get ether_type */ - ptr = ptr+pfhdr->attrib.hdrlen+pfhdr->attrib.iv_len+LLC_HEADER_SIZE ; + ptr = ptr + pfhdr->attrib.hdrlen + pfhdr->attrib.iv_len +LLC_HEADER_SIZE ;memcpy (&be_tmp, ptr,2 ); ether_type =ntohs (be_tmp);
@@ -507,7 +507,7 @@ static int recv_decache(struct recv_frame *precv_frame, u8 bretry, struct stainf {int tid = precv_frame->attrib.priority; -u16 seq_ctrl = ((precv_frame->attrib.seq_num&0xffff ) <<4 ) | +u16 seq_ctrl = ((precv_frame->attrib.seq_num &0xffff ) <<4 ) | (precv_frame->attrib.frag_num &0xf );if (tid >15 )
@@ -565,29 +565,29 @@ static void process_wmmps_data(struct adapter *padapter, struct recv_frame *precif (!psta->qos_option)return ; -if (!(psta->qos_info&0xf )) +if (!(psta->qos_info &0xf ))return ; -if (psta->state&WIFI_SLEEP_STATE ) { +if (psta->state &WIFI_SLEEP_STATE ) {u8 wmmps_ac =0 ;switch (pattrib->priority) {case 1 :case 2 : - wmmps_ac = psta->uapsd_bk&BIT (1 ); + wmmps_ac = psta->uapsd_bk &BIT (1 );break ;case 4 :case 5 : - wmmps_ac = psta->uapsd_vi&BIT (1 ); + wmmps_ac = psta->uapsd_vi &BIT (1 );break ;case 6 :case 7 : - wmmps_ac = psta->uapsd_vo&BIT (1 ); + wmmps_ac = psta->uapsd_vo &BIT (1 );break ;case 0 :case 3 :default : - wmmps_ac = psta->uapsd_be&BIT (1 ); + wmmps_ac = psta->uapsd_be &BIT (1 );break ; }
@@ -727,7 +727,7 @@ int sta2sta_data_frame(struct adapter *adapter, struct recv_frame *precv_frame,return ret; } -static int ap2sta_data_frame ( +static int ap2sta_data_frame (struct adapter *adapter,struct recv_frame *precv_frame,struct sta_info **psta)
@@ -917,20 +917,20 @@ static int validate_recv_ctrl_frame(struct adapter *padapter,switch (pattrib->priority) {case 1 :case 2 : - wmmps_ac = psta->uapsd_bk&BIT (0 ); + wmmps_ac = psta->uapsd_bk &BIT (0 );break ;case 4 :case 5 : - wmmps_ac = psta->uapsd_vi&BIT (0 ); + wmmps_ac = psta->uapsd_vi &BIT (0 );break ;case 6 :case 7 : - wmmps_ac = psta->uapsd_vo&BIT (0 ); + wmmps_ac = psta->uapsd_vo &BIT (0 );break ;case 0 :case 3 :default : - wmmps_ac = psta->uapsd_be&BIT (0 ); + wmmps_ac = psta->uapsd_be &BIT (0 );break ; }
@@ -943,7 +943,7 @@ static int validate_recv_ctrl_frame(struct adapter *padapter, psta->state ^=WIFI_STA_ALIVE_CHK_STATE ; } -if ((psta->state&WIFI_SLEEP_STATE ) && (pstapriv->sta_dz_bitmap&BIT (psta->aid))) { +if ((psta->state &WIFI_SLEEP_STATE ) && (pstapriv->sta_dz_bitmap &BIT (psta->aid))) {struct list_head *xmitframe_plist, *xmitframe_phead;struct xmit_frame *pxmitframe =NULL ;struct xmit_priv *pxmitpriv = &padapter->xmitpriv;
@@ -979,7 +979,7 @@ static int validate_recv_ctrl_frame(struct adapter *padapter,update_beacon (padapter, _TIM_IE_,NULL , false); } }else { -if (pstapriv->tim_bitmap&BIT (psta->aid)) { +if (pstapriv->tim_bitmap &BIT (psta->aid)) {if (psta->sleepq_len ==0 ) {DBG_88E ("no buffered packets to xmit\n" );
@@ -1162,7 +1162,7 @@ static int validate_recv_frame(struct adapter *adapter, struct recv_frame *precvu8 bDumpRxPkt;struct rx_pkt_attrib *pattrib = &precv_frame->attrib;u8 *ptr = precv_frame->rx_data; -u8 ver = (unsigned char ) (*ptr)&0x3 ; +u8 ver = (unsigned char )(*ptr) &0x3 ;struct mlme_ext_priv *pmlmeext = &adapter->mlmeextpriv;if (pmlmeext->sitesurvey_res.state ==SCAN_PROCESS ) {
@@ -1197,18 +1197,18 @@ static int validate_recv_frame(struct adapter *adapter, struct recv_frame *precvint i;DBG_88E ("#############################\n" ); -for (i =0 ; i <64 ; i = i+8 ) -DBG_88E ("%02X:%02X:%02X:%02X:%02X:%02X:%02X:%02X:\n" , *(ptr+i), - *(ptr+i+1 ), *(ptr+i+2 ), *(ptr+i+3 ), *(ptr+i+4 ), *(ptr+i+5 ), *(ptr+i+6 ), *(ptr+i+7 )); +for (i =0 ; i <64 ; i = i +8 ) +DBG_88E ("%02X:%02X:%02X:%02X:%02X:%02X:%02X:%02X:\n" , *(ptr + i), + *(ptr + i +1 ), *(ptr + i +2 ), *(ptr + i +3 ), *(ptr + i +4 ), *(ptr + i +5 ), *(ptr + i +6 ), *(ptr + i +7 ));DBG_88E ("#############################\n" ); }else if (bDumpRxPkt ==2 ) {if (type ==WIFI_MGT_TYPE ) {int i;DBG_88E ("#############################\n" ); -for (i =0 ; i <64 ; i = i+8 ) -DBG_88E ("%02X:%02X:%02X:%02X:%02X:%02X:%02X:%02X:\n" , *(ptr+i), - *(ptr+i+1 ), *(ptr+i+2 ), *(ptr+i+3 ), *(ptr+i+4 ), *(ptr+i+5 ), *(ptr+i+6 ), *(ptr+i+7 )); +for (i =0 ; i <64 ; i = i +8 ) +DBG_88E ("%02X:%02X:%02X:%02X:%02X:%02X:%02X:%02X:\n" , *(ptr + i), + *(ptr + i +1 ), *(ptr + i +2 ), *(ptr + i +3 ), *(ptr + i +4 ), *(ptr + i +5 ), *(ptr + i +6 ), *(ptr + i +7 ));DBG_88E ("#############################\n" ); } }else if (bDumpRxPkt ==3 ) {
@@ -1216,9 +1216,9 @@ static int validate_recv_frame(struct adapter *adapter, struct recv_frame *precvint i;DBG_88E ("#############################\n" ); -for (i =0 ; i <64 ; i = i+8 ) -DBG_88E ("%02X:%02X:%02X:%02X:%02X:%02X:%02X:%02X:\n" , *(ptr+i), - *(ptr+i+1 ), *(ptr+i+2 ), *(ptr+i+3 ), *(ptr+i+4 ), *(ptr+i+5 ), *(ptr+i+6 ), *(ptr+i+7 )); +for (i =0 ; i <64 ; i = i +8 ) +DBG_88E ("%02X:%02X:%02X:%02X:%02X:%02X:%02X:%02X:\n" , *(ptr + i), + *(ptr + i +1 ), *(ptr + i +2 ), *(ptr + i +3 ), *(ptr + i +4 ), *(ptr + i +5 ), *(ptr + i +6 ), *(ptr + i +7 ));DBG_88E ("#############################\n" ); } }
@@ -1252,7 +1252,7 @@ static int validate_recv_frame(struct adapter *adapter, struct recv_frame *precv/* remove the wlanhdr and add the eth_hdr */ -static int wlanhdr_to_ethhdr (struct recv_frame *precvframe) +static int wlanhdr_to_ethhdr (struct recv_frame *precvframe) {int rmv_len;u16 eth_type, len;
@@ -1271,8 +1271,8 @@ static int wlanhdr_to_ethhdr (struct recv_frame *precvframe)if (pattrib->encrypt)recvframe_pull_tail (precvframe, pattrib->icv_len); - psnap = (struct ieee80211_snap_hdr *)(ptr+pattrib->hdrlen + pattrib->iv_len); - psnap_type = ptr+pattrib->hdrlen + pattrib->iv_len+SNAP_SIZE ; + psnap = (struct ieee80211_snap_hdr *)(ptr + pattrib->hdrlen + pattrib->iv_len); + psnap_type = ptr + pattrib->hdrlen + pattrib->iv_len +SNAP_SIZE ;/* convert hdr + possible LLC headers into Ethernet header */ if ((!memcmp(psnap, rtw_rfc1042_header, SNAP_SIZE) && memcmp(psnap_type, SNAP_ETH_TYPE_IPX, 2) &&
@@ -1288,30 +1288,30 @@ static int wlanhdr_to_ethhdr (struct recv_frame *precvframe) rmv_len = pattrib->hdrlen + pattrib->iv_len + (bsnaphdr ?SNAP_SIZE :0 ); len = precvframe->len - rmv_len; -memcpy (&be_tmp, ptr+rmv_len,2 ); +memcpy (&be_tmp, ptr + rmv_len,2 ); eth_type =ntohs (be_tmp);/* pattrib->ether_type */ pattrib->eth_type = eth_type;if ((check_fwstate (pmlmepriv,WIFI_MP_STATE ))) { ptr += rmv_len; *ptr =0x87 ; - *(ptr+1 ) =0x12 ; + *(ptr +1 ) =0x12 ; eth_type =0x8712 ;/* append rx status for mp test packets */ - ptr =recvframe_pull (precvframe, (rmv_len-sizeof (struct ethhdr )+2 )-24 ); + ptr =recvframe_pull (precvframe, (rmv_len -sizeof (struct ethhdr ) +2 ) -24 );memcpy (ptr,get_rxmem (precvframe),24 ); ptr +=24 ; }else { - ptr =recvframe_pull (precvframe, (rmv_len-sizeof (struct ethhdr ) + (bsnaphdr ?2 :0 ))); + ptr =recvframe_pull (precvframe, (rmv_len -sizeof (struct ethhdr ) + (bsnaphdr ?2 :0 ))); }memcpy (ptr, pattrib->dst,ETH_ALEN ); -memcpy (ptr+ETH_ALEN , pattrib->src,ETH_ALEN ); +memcpy (ptr +ETH_ALEN , pattrib->src,ETH_ALEN );if (!bsnaphdr) { be_tmp =htons (len); -memcpy (ptr+12 , &be_tmp,2 ); +memcpy (ptr +12 , &be_tmp,2 ); }return ret;
@@ -1558,7 +1558,7 @@ static int amsdu_to_msdu(struct adapter *padapter, struct recv_frame *prframe) pdata += nSubframe_Length; a_len -= nSubframe_Length;if (a_len !=0 ) { - padding_len =4 - ((nSubframe_Length +ETH_HLEN ) & (4 -1 )); + padding_len =4 - ((nSubframe_Length +ETH_HLEN ) & (4 -1 ));if (padding_len ==4 ) { padding_len =0 ; }
@@ -1755,7 +1755,7 @@ static int recv_indicatepkt_reorder(struct adapter *padapter, struct recv_frame preorder_ctrl->indicate_seq = pattrib->seq_num;rtw_recv_indicatepkt (padapter, prframe); - preorder_ctrl->indicate_seq = (preorder_ctrl->indicate_seq +1 )%4096 ; + preorder_ctrl->indicate_seq = (preorder_ctrl->indicate_seq +1 ) %4096 ;return _SUCCESS; } }else if (pattrib->amsdu ==1 ) {/* temp filter -> means didn't support A-MSDUs in a A-MPDU */
@@ -1763,7 +1763,7 @@ static int recv_indicatepkt_reorder(struct adapter *padapter, struct recv_frame preorder_ctrl->indicate_seq = pattrib->seq_num; retval =amsdu_to_msdu (padapter, prframe); - preorder_ctrl->indicate_seq = (preorder_ctrl->indicate_seq +1 )%4096 ; + preorder_ctrl->indicate_seq = (preorder_ctrl->indicate_seq +1 ) %4096 ;return retval; } }
@@ -1843,7 +1843,7 @@ static int process_recv_indicatepkts(struct adapter *padapter, struct recv_frame } } }else {/* B/G mode */ - retval =wlanhdr_to_ethhdr (prframe); + retval =wlanhdr_to_ethhdr (prframe);if (retval != _SUCCESS)return retval;
@@ -1963,7 +1963,7 @@ static int recv_func(struct adapter *padapter, struct recv_frame *rframe) !psecuritypriv->busetkipkey) {rtw_enqueue_recvframe (rframe, &padapter->recvpriv.uc_swdec_pending_queue);DBG_88E ("%s: no key, enqueue uc_swdec_pending_queue\n" , __func__); -if (recvpriv->free_recvframe_cnt <NR_RECVFRAME /4 ) { +if (recvpriv->free_recvframe_cnt <NR_RECVFRAME /4 ) {/* to prevent from recvframe starvation, * get recvframe from uc_swdec_pending_queue to * free_recvframe_cnt */
@@ -2036,19 +2036,19 @@ void rtw_signal_stat_timer_hdl(struct timer_list *t)/* update value of signal_strength, rssi, signal_qual */ if (check_fwstate (&adapter->mlmepriv, _FW_UNDER_SURVEY) == false) { - tmp_s = (avg_signal_strength+(_alpha-1 )*recvpriv->signal_strength); + tmp_s = (avg_signal_strength + (_alpha -1 ) * recvpriv->signal_strength);if (tmp_s % _alpha) - tmp_s = tmp_s/_alpha +1 ; + tmp_s = tmp_s / _alpha +1 ;else - tmp_s = tmp_s/_alpha; + tmp_s = tmp_s / _alpha;if (tmp_s >100 ) tmp_s =100 ; - tmp_q = (avg_signal_qual+(_alpha-1 )*recvpriv->signal_qual); + tmp_q = (avg_signal_qual + (_alpha -1 ) * recvpriv->signal_qual);if (tmp_q % _alpha) - tmp_q = tmp_q/_alpha +1 ; + tmp_q = tmp_q / _alpha +1 ;else - tmp_q = tmp_q/_alpha; + tmp_q = tmp_q / _alpha;if (tmp_q >100 ) tmp_q =100 ;
Signature · 1 line
2.32.0
PATCH 17/23 staging: r8188eu: clean up spacing style issues in core/rtw_security.c
In reply to Michael StraubeClean up spacing style issues in core/rtw_security.c reported by checkpatch.
CHECK: spaces preferred around that ...
CHECK: No space is necessary after a cast
WARNING: space prohibited before semicolon
--- drivers/staging/r8188eu/core/rtw_security.c | 188 ++++++++++---------- 1 file changed, 94 insertions(+), 94 deletions(-)
drivers/staging/r8188eu/core/rtw_security.c +94 -94
@@ -108,25 +108,25 @@ void rtw_wep_encrypt(struct adapter *padapter, u8 *pxmitframe) keylength = psecuritypriv->dot11DefKeylen[psecuritypriv->dot11PrivacyKeyIndex];for (curfragnum =0 ; curfragnum < pattrib->nr_frags; curfragnum++) { - iv = pframe+pattrib->hdrlen; + iv = pframe + pattrib->hdrlen;memcpy (&wepkey[0 ], iv,3 );memcpy (&wepkey[3 ], &psecuritypriv->dot11DefKey[psecuritypriv->dot11PrivacyKeyIndex].skey[0 ], keylength); - payload = pframe+pattrib->iv_len+pattrib->hdrlen; + payload = pframe + pattrib->iv_len + pattrib->hdrlen; -if ((curfragnum+1 ) == pattrib->nr_frags) {/* the last fragment */ - length = pattrib->last_txcmdsz-pattrib->hdrlen-pattrib->iv_len-pattrib->icv_len; +if ((curfragnum +1 ) == pattrib->nr_frags) {/* the last fragment */ + length = pattrib->last_txcmdsz - pattrib->hdrlen - pattrib->iv_len - pattrib->icv_len; crc.f0 =cpu_to_le32 (~crc32_le (~0 , payload, length)); -arcfour_init (&mycontext, wepkey,3 +keylength); +arcfour_init (&mycontext, wepkey,3 + keylength);arcfour_encrypt (&mycontext, payload, payload, length); -arcfour_encrypt (&mycontext, payload+length, crc.f1,4 ); +arcfour_encrypt (&mycontext, payload + length, crc.f1,4 ); }else { - length = pxmitpriv->frag_len-pattrib->hdrlen-pattrib->iv_len-pattrib->icv_len; + length = pxmitpriv->frag_len - pattrib->hdrlen - pattrib->iv_len - pattrib->icv_len; crc.f0 =cpu_to_le32 (~crc32_le (~0 , payload, length)); -arcfour_init (&mycontext, wepkey,3 +keylength); +arcfour_init (&mycontext, wepkey,3 + keylength);arcfour_encrypt (&mycontext, payload, payload, length); -arcfour_encrypt (&mycontext, payload+length, crc.f1,4 ); +arcfour_encrypt (&mycontext, payload + length, crc.f1,4 ); pframe += pxmitpriv->frag_len; pframe = (u8 *)RND4 ((size_t )(pframe));
@@ -151,17 +151,17 @@ void rtw_wep_decrypt(struct adapter *padapter, u8 *precvframe)/* start to decrypt recvframe */ if ((prxattrib->encrypt == _WEP40_) || (prxattrib->encrypt == _WEP104_)) { - iv = pframe+prxattrib->hdrlen; + iv = pframe + prxattrib->hdrlen; keyindex = prxattrib->key_index; keylength = psecuritypriv->dot11DefKeylen[keyindex];memcpy (&wepkey[0 ], iv,3 );memcpy (&wepkey[3 ], &psecuritypriv->dot11DefKey[keyindex].skey[0 ], keylength); - length = ((struct recv_frame *)precvframe)->len-prxattrib->hdrlen-prxattrib->iv_len; + length = ((struct recv_frame *)precvframe)->len - prxattrib->hdrlen - prxattrib->iv_len; - payload = pframe+prxattrib->iv_len+prxattrib->hdrlen; + payload = pframe + prxattrib->iv_len + prxattrib->hdrlen;/* decrypt payload include icv */ -arcfour_init (&mycontext, wepkey,3 +keylength); +arcfour_init (&mycontext, wepkey,3 + keylength);arcfour_encrypt (&mycontext, payload, payload, length); } }
@@ -175,7 +175,7 @@ static u32 secmicgetuint32(u8 *p)u32 res =0 ;for (i =0 ; i <4 ; i++) - res |= ((u32)(*p++)) << (8 *i); + res |= ((u32)(*p++)) << (8 * i);return res; }
@@ -186,7 +186,7 @@ static void secmicputuint32(u8 *p, u32 val)long i;for (i =0 ; i <4 ; i++) { - *p++ = (u8) (val &0xff ); + *p++ = (u8)(val &0xff ); val >>=8 ; }
@@ -218,7 +218,7 @@ void rtw_secmicappendbyte(struct mic_data *pmicdata, u8 b) {/* Append the byte to our word-sized buffer */ - pmicdata->M |= ((unsigned long )b) << (8 *pmicdata->nBytesInM); + pmicdata->M |= ((unsigned long )b) << (8 * pmicdata->nBytesInM); pmicdata->nBytesInM++;/* Process the word if it is full. */ if (pmicdata->nBytesInM >=4 ) {
@@ -263,7 +263,7 @@ void rtw_secgetmic(struct mic_data *pmicdata, u8 *dst)rtw_secmicappendbyte (pmicdata,0 );/* The appendByte function has already computed the result. */ secmicputuint32 (dst, pmicdata->L); -secmicputuint32 (dst+4 , pmicdata->R); +secmicputuint32 (dst +4 , pmicdata->R);/* Reset to the empty message. */ secmicclear (pmicdata);
@@ -278,15 +278,15 @@ void rtw_seccalctkipmic(u8 *key, u8 *header, u8 *data, u32 data_len, u8 *mic_cod priority[0 ] = pri;/* Michael MIC pseudo header: DA, SA, 3 x 0, Priority */ -if (header[1 ]&1 ) {/* ToDS == 1 */ +if (header[1 ] &1 ) {/* ToDS == 1 */ rtw_secmicappend (&micdata, &header[16 ],6 );/* DA */ -if (header[1 ]&2 )/* From Ds == 1 */ +if (header[1 ] &2 )/* From Ds == 1 */ rtw_secmicappend (&micdata, &header[24 ],6 );else rtw_secmicappend (&micdata, &header[10 ],6 ); }else {/* ToDS == 0 */ rtw_secmicappend (&micdata, &header[4 ],6 );/* DA */ -if (header[1 ]&2 )/* From Ds == 1 */ +if (header[1 ] &2 )/* From Ds == 1 */ rtw_secmicappend (&micdata, &header[16 ],6 );else rtw_secmicappend (&micdata, &header[10 ],6 );
@@ -308,7 +308,7 @@ void rtw_seccalctkipmic(u8 *key, u8 *header, u8 *data, u32 data_len, u8 *mic_cod#define Mk16 (hi, lo) ((lo) ^ (((u16)(hi)) << 8))/* select the Nth 16-bit word of the temporal key unsigned char array TK[] */ -#define TK16 (N ) Mk16(tk[2*(N)+1], tk[2*(N)]) +#define TK16 (N ) Mk16(tk[2 * (N) + 1], tk[2 * (N)])/* S-box lookup: 16 bits --> 16 bits */ #define _S_ (v16) (Sbox1[0][Lo8(v16)] ^ Sbox1[1][Hi8(v16)])
@@ -424,11 +424,11 @@ static void phase1(u16 *p1k, const u8 *tk, const u8 *ta, u32 iv32)/* Now compute an unbalanced Feistel cipher with 80-bit block */ /* size on the 80-bit block P1K[], using the 128-bit key TK[] */ for (i =0 ; i <PHASE1_LOOP_CNT ; i++) {/* Each add operation here is mod 2**16 */ - p1k[0 ] +=_S_ (p1k[4 ] ^TK16 ((i&1 )+0 )); - p1k[1 ] +=_S_ (p1k[0 ] ^TK16 ((i&1 )+2 )); - p1k[2 ] +=_S_ (p1k[1 ] ^TK16 ((i&1 )+4 )); - p1k[3 ] +=_S_ (p1k[2 ] ^TK16 ((i&1 )+6 )); - p1k[4 ] +=_S_ (p1k[3 ] ^TK16 ((i&1 )+0 )); + p1k[0 ] +=_S_ (p1k[4 ] ^TK16 ((i &1 ) +0 )); + p1k[1 ] +=_S_ (p1k[0 ] ^TK16 ((i &1 ) +2 )); + p1k[2 ] +=_S_ (p1k[1 ] ^TK16 ((i &1 ) +4 )); + p1k[3 ] +=_S_ (p1k[2 ] ^TK16 ((i &1 ) +6 )); + p1k[4 ] +=_S_ (p1k[3 ] ^TK16 ((i &1 ) +0 )); p1k[4 ] += (unsigned short )i;/* avoid "slide attacks" */ }
@@ -495,8 +495,8 @@ static void phase2(u8 *rc4key, const u8 *tk, const u16 *p1k, u16 iv16)/* Copy 96 bits of PPK[0..5] to RC4KEY[4..15] (little-endian) */ for (i =0 ; i <6 ; i++) { - rc4key[4 +2 *i] =Lo8 (PPK [i]); - rc4key[5 +2 *i] =Hi8 (PPK [i]); + rc4key[4 +2 * i] =Lo8 (PPK [i]); + rc4key[5 +2 * i] =Hi8 (PPK [i]); } }
@@ -544,30 +544,30 @@ u32 rtw_tkip_encrypt(struct adapter *padapter, u8 *pxmitframe) prwskey = &stainfo->dot118021x_UncstKey.skey[0 ];for (curfragnum =0 ; curfragnum < pattrib->nr_frags; curfragnum++) { - iv = pframe+pattrib->hdrlen; - payload = pframe+pattrib->iv_len+pattrib->hdrlen; + iv = pframe + pattrib->hdrlen; + payload = pframe + pattrib->iv_len + pattrib->hdrlen;GET_TKIP_PN (iv, dot11txpn); pnl = (u16)(dot11txpn.val); - pnh = (u32)(dot11txpn.val>>16 ); + pnh = (u32)(dot11txpn.val >>16 );phase1 ((u16 *)&ttkey[0 ], prwskey, &pattrib->ta[0 ], pnh);phase2 (&rc4key[0 ], prwskey, (u16 *)&ttkey[0 ], pnl); -if ((curfragnum+1 ) == pattrib->nr_frags) {/* 4 the last fragment */ - length = pattrib->last_txcmdsz-pattrib->hdrlen-pattrib->iv_len-pattrib->icv_len; +if ((curfragnum +1 ) == pattrib->nr_frags) {/* 4 the last fragment */ + length = pattrib->last_txcmdsz - pattrib->hdrlen - pattrib->iv_len - pattrib->icv_len; crc.f0 =cpu_to_le32 (~crc32_le (~0 , payload, length));arcfour_init (&mycontext, rc4key,16 );arcfour_encrypt (&mycontext, payload, payload, length); -arcfour_encrypt (&mycontext, payload+length, crc.f1,4 ); +arcfour_encrypt (&mycontext, payload + length, crc.f1,4 ); }else { - length = pxmitpriv->frag_len-pattrib->hdrlen-pattrib->iv_len-pattrib->icv_len ; + length = pxmitpriv->frag_len - pattrib->hdrlen - pattrib->iv_len - pattrib->icv_len; crc.f0 =cpu_to_le32 (~crc32_le (~0 , payload, length));arcfour_init (&mycontext, rc4key,16 );arcfour_encrypt (&mycontext, payload, payload, length); -arcfour_encrypt (&mycontext, payload+length, crc.f1,4 ); +arcfour_encrypt (&mycontext, payload + length, crc.f1,4 ); pframe += pxmitpriv->frag_len; pframe = (u8 *)RND4 ((size_t )(pframe));
@@ -619,14 +619,14 @@ u32 rtw_tkip_decrypt(struct adapter *padapter, u8 *precvframe) prwskey = &stainfo->dot118021x_UncstKey.skey[0 ]; } - iv = pframe+prxattrib->hdrlen; - payload = pframe+prxattrib->iv_len+prxattrib->hdrlen; - length = ((struct recv_frame *)precvframe)->len-prxattrib->hdrlen-prxattrib->iv_len; + iv = pframe + prxattrib->hdrlen; + payload = pframe + prxattrib->iv_len + prxattrib->hdrlen; + length = ((struct recv_frame *)precvframe)->len - prxattrib->hdrlen - prxattrib->iv_len;GET_TKIP_PN (iv, dot11txpn); pnl = (u16)(dot11txpn.val); - pnh = (u32)(dot11txpn.val>>16 ); + pnh = (u32)(dot11txpn.val >>16 );phase1 ((u16 *)&ttkey[0 ], prwskey, &prxattrib->ta[0 ], pnh);phase2 (&rc4key[0 ], prwskey, (unsigned short *)&ttkey[0 ], pnl);
@@ -638,10 +638,10 @@ u32 rtw_tkip_decrypt(struct adapter *padapter, u8 *precvframe) crc.f0 =cpu_to_le32 (~crc32_le (~0 , payload, length)); -if (crc.f1[3 ] != payload[length-1 ] || - crc.f1[2 ] != payload[length-2 ] || - crc.f1[1 ] != payload[length-3 ] || - crc.f1[0 ] != payload[length-4 ]) +if (crc.f1[3 ] != payload[length -1 ] || + crc.f1[2 ] != payload[length -2 ] || + crc.f1[1 ] != payload[length -3 ] || + crc.f1[0 ] != payload[length -4 ]) res = _FAIL; }else { res = _FAIL;
@@ -832,7 +832,7 @@ static void mix_column(u8 *in, u8 *out)for (i =3 ; i >0 ; i--) {/* logical shift left 1 bit */ andf7[i] = andf7[i] <<1 ; -if ((andf7[i-1 ] &0x80 ) ==0x80 ) +if ((andf7[i -1 ] &0x80 ) ==0x80 ) andf7[i] = (andf7[i] |0x01 ); } andf7[0 ] = andf7[0 ] <<1 ;
@@ -906,8 +906,8 @@ static void construct_mic_iv(u8 *mic_iv, int qc_exists, int a4_exists, u8 *mpdu, mic_iv[i] = mpdu[i +8 ];/* mic_iv[2:7] = A2[0:5] = mpdu[10:15] */ for (i =8 ; i <14 ; i++) mic_iv[i] = pn_vector[13 - i];/* mic_iv[8:13] = PN[5:0] */ - mic_iv[14 ] = (unsigned char ) (payload_length /256 ); - mic_iv[15 ] = (unsigned char ) (payload_length %256 ); + mic_iv[14 ] = (unsigned char )(payload_length /256 ); + mic_iv[15 ] = (unsigned char )(payload_length %256 ); }
@@ -962,7 +962,7 @@ static void construct_mic_header2(u8 *mic_header2, u8 *mpdu, int a4_exists, intif (!qc_exists && a4_exists) {for (i =0 ; i <6 ; i++) - mic_header2[8 +i] = mpdu[24 +i];/* A4 */ + mic_header2[8 + i] = mpdu[24 + i];/* A4 */ }if (qc_exists && !a4_exists) {
@@ -972,7 +972,7 @@ static void construct_mic_header2(u8 *mic_header2, u8 *mpdu, int a4_exists, intif (qc_exists && a4_exists) {for (i =0 ; i <6 ; i++) - mic_header2[8 +i] = mpdu[24 +i];/* A4 */ + mic_header2[8 + i] = mpdu[24 + i];/* A4 */ mic_header2[14 ] = mpdu[30 ] &0x0f ; mic_header2[15 ] = mpdu[31 ] &0x00 ;
@@ -1003,8 +1003,8 @@ static void construct_ctr_preload(u8 *ctr_preload, int a4_exists, int qc_exists, ctr_preload[i] = mpdu[i +8 ];/* ctr_preload[2:7] = A2[0:5] = mpdu[10:15] */ for (i =8 ; i <14 ; i++) ctr_preload[i] = pn_vector[13 - i];/* ctr_preload[8:13] = PN[5:0] */ - ctr_preload[14 ] = (unsigned char ) (c /256 );/* Ctr */ - ctr_preload[15 ] = (unsigned char ) (c %256 ); + ctr_preload[14 ] = (unsigned char )(c /256 );/* Ctr */ + ctr_preload[15 ] = (unsigned char )(c %256 ); }
@@ -1040,7 +1040,7 @@ static int aes_cipher(u8 *key, uint hdrlen, u8 *pframe, uint plen)uint frtype =GetFrameType (pframe);uint frsubtype =GetFrameSubType (pframe); - frsubtype = frsubtype>>4 ; + frsubtype = frsubtype >>4 ;memset ((void *)mic_iv,0 ,16 );memset ((void *)mic_header1,0 ,16 );
@@ -1068,11 +1068,11 @@ static int aes_cipher(u8 *key, uint hdrlen, u8 *pframe, uint plen) } pn_vector[0 ] = pframe[hdrlen]; - pn_vector[1 ] = pframe[hdrlen+1 ]; - pn_vector[2 ] = pframe[hdrlen+4 ]; - pn_vector[3 ] = pframe[hdrlen+5 ]; - pn_vector[4 ] = pframe[hdrlen+6 ]; - pn_vector[5 ] = pframe[hdrlen+7 ]; + pn_vector[1 ] = pframe[hdrlen +1 ]; + pn_vector[2 ] = pframe[hdrlen +4 ]; + pn_vector[3 ] = pframe[hdrlen +5 ]; + pn_vector[4 ] = pframe[hdrlen +6 ]; + pn_vector[5 ] = pframe[hdrlen +7 ];construct_mic_iv (mic_iv, qc_exists, a4_exists, pframe, plen, pn_vector);
@@ -1114,11 +1114,11 @@ static int aes_cipher(u8 *key, uint hdrlen, u8 *pframe, uint plen)/* Insert MIC into payload */ for (j =0 ; j <8 ; j++) - pframe[payload_index+j] = mic[j];/* message[payload_index+j] = mic[j]; */ + pframe[payload_index + j] = mic[j];/* message[payload_index+j] = mic[j]; */ payload_index = hdrlen +8 ;for (i =0 ; i < num_blocks; i++) { -construct_ctr_preload (ctr_preload, a4_exists, qc_exists, pframe, pn_vector, i+1 ); +construct_ctr_preload (ctr_preload, a4_exists, qc_exists, pframe, pn_vector, i +1 );aes128k128d (key, ctr_preload, aes_out);bitwise_xor (aes_out, &pframe[payload_index], chain_buffer);for (j =0 ; j <16 ; j++)
@@ -1127,12 +1127,12 @@ static int aes_cipher(u8 *key, uint hdrlen, u8 *pframe, uint plen)if (payload_remainder >0 ) {/* If there is a short final block, then pad it,*/ /* encrypt it and copy the unpadded part back */ -construct_ctr_preload (ctr_preload, a4_exists, qc_exists, pframe, pn_vector, num_blocks+1 ); +construct_ctr_preload (ctr_preload, a4_exists, qc_exists, pframe, pn_vector, num_blocks +1 );for (j =0 ; j <16 ; j++) padded_buffer[j] =0x00 ;for (j =0 ; j < payload_remainder; j++) - padded_buffer[j] = pframe[payload_index+j]; + padded_buffer[j] = pframe[payload_index + j];aes128k128d (key, ctr_preload, aes_out);bitwise_xor (aes_out, padded_buffer, chain_buffer);for (j =0 ; j < payload_remainder; j++)
@@ -1144,7 +1144,7 @@ static int aes_cipher(u8 *key, uint hdrlen, u8 *pframe, uint plen)for (j =0 ; j <16 ; j++) padded_buffer[j] =0x00 ;for (j =0 ; j <8 ; j++) - padded_buffer[j] = pframe[j+hdrlen+8 +plen]; + padded_buffer[j] = pframe[j + hdrlen +8 + plen];aes128k128d (key, ctr_preload, aes_out);bitwise_xor (aes_out, padded_buffer, chain_buffer);
@@ -1193,12 +1193,12 @@ u32 rtw_aes_encrypt(struct adapter *padapter, u8 *pxmitframe)else prwskey = &stainfo->dot118021x_UncstKey.skey[0 ];for (curfragnum =0 ; curfragnum < pattrib->nr_frags; curfragnum++) { -if ((curfragnum+1 ) == pattrib->nr_frags) {/* 4 the last fragment */ - length = pattrib->last_txcmdsz-pattrib->hdrlen-pattrib->iv_len-pattrib->icv_len; +if ((curfragnum +1 ) == pattrib->nr_frags) {/* 4 the last fragment */ + length = pattrib->last_txcmdsz - pattrib->hdrlen - pattrib->iv_len - pattrib->icv_len;aes_cipher (prwskey, pattrib->hdrlen, pframe, length); }else { - length = pxmitpriv->frag_len-pattrib->hdrlen-pattrib->iv_len-pattrib->icv_len ; + length = pxmitpriv->frag_len - pattrib->hdrlen - pattrib->iv_len - pattrib->icv_len;aes_cipher (prwskey, pattrib->hdrlen, pframe, length); pframe += pxmitpriv->frag_len;
@@ -1236,7 +1236,7 @@ static int aes_decipher(u8 *key, uint hdrlen,uint frtype =GetFrameType (pframe);uint frsubtype =GetFrameSubType (pframe); - frsubtype = frsubtype>>4 ; + frsubtype = frsubtype >>4 ;memset ((void *)mic_iv,0 ,16 );memset ((void *)mic_header1,0 ,16 );
@@ -1248,16 +1248,16 @@ static int aes_decipher(u8 *key, uint hdrlen,/* start to decrypt the payload */ - num_blocks = (plen-8 ) /16 ;/* plen including llc, payload_length and mic) */ + num_blocks = (plen -8 ) /16 ;/* plen including llc, payload_length and mic) */ - payload_remainder = (plen-8 ) %16 ; + payload_remainder = (plen -8 ) %16 ; pn_vector[0 ] = pframe[hdrlen]; - pn_vector[1 ] = pframe[hdrlen+1 ]; - pn_vector[2 ] = pframe[hdrlen+4 ]; - pn_vector[3 ] = pframe[hdrlen+5 ]; - pn_vector[4 ] = pframe[hdrlen+6 ]; - pn_vector[5 ] = pframe[hdrlen+7 ]; + pn_vector[1 ] = pframe[hdrlen +1 ]; + pn_vector[2 ] = pframe[hdrlen +4 ]; + pn_vector[3 ] = pframe[hdrlen +5 ]; + pn_vector[4 ] = pframe[hdrlen +6 ]; + pn_vector[5 ] = pframe[hdrlen +7 ];if ((hdrlen ==WLAN_HDR_A3_LEN ) || (hdrlen ==WLAN_HDR_A3_QOS_LEN )) a4_exists =0 ;
@@ -1283,7 +1283,7 @@ static int aes_decipher(u8 *key, uint hdrlen, payload_index = hdrlen +8 ;/* 8 is for extiv */ for (i =0 ; i < num_blocks; i++) { -construct_ctr_preload (ctr_preload, a4_exists, qc_exists, pframe, pn_vector, i+1 ); +construct_ctr_preload (ctr_preload, a4_exists, qc_exists, pframe, pn_vector, i +1 );aes128k128d (key, ctr_preload, aes_out);bitwise_xor (aes_out, &pframe[payload_index], chain_buffer);
@@ -1294,12 +1294,12 @@ static int aes_decipher(u8 *key, uint hdrlen,if (payload_remainder >0 ) {/* If there is a short final block, then pad it,*/ /* encrypt it and copy the unpadded part back */ -construct_ctr_preload (ctr_preload, a4_exists, qc_exists, pframe, pn_vector, num_blocks+1 ); +construct_ctr_preload (ctr_preload, a4_exists, qc_exists, pframe, pn_vector, num_blocks +1 );for (j =0 ; j <16 ; j++) padded_buffer[j] =0x00 ;for (j =0 ; j < payload_remainder; j++) - padded_buffer[j] = pframe[payload_index+j]; + padded_buffer[j] = pframe[payload_index + j];aes128k128d (key, ctr_preload, aes_out);bitwise_xor (aes_out, padded_buffer, chain_buffer);for (j =0 ; j < payload_remainder; j++)
@@ -1307,22 +1307,22 @@ static int aes_decipher(u8 *key, uint hdrlen, }/* start to calculate the mic */ -if ((hdrlen+plen+8 ) <=MAX_MSG_SIZE ) -memcpy (message, pframe, (hdrlen + plen+8 ));/* 8 is for ext iv len */ +if ((hdrlen + plen +8 ) <=MAX_MSG_SIZE ) +memcpy (message, pframe, (hdrlen + plen +8 ));/* 8 is for ext iv len */ pn_vector[0 ] = pframe[hdrlen]; - pn_vector[1 ] = pframe[hdrlen+1 ]; - pn_vector[2 ] = pframe[hdrlen+4 ]; - pn_vector[3 ] = pframe[hdrlen+5 ]; - pn_vector[4 ] = pframe[hdrlen+6 ]; - pn_vector[5 ] = pframe[hdrlen+7 ]; -construct_mic_iv (mic_iv, qc_exists, a4_exists, message, plen-8 , pn_vector); + pn_vector[1 ] = pframe[hdrlen +1 ]; + pn_vector[2 ] = pframe[hdrlen +4 ]; + pn_vector[3 ] = pframe[hdrlen +5 ]; + pn_vector[4 ] = pframe[hdrlen +6 ]; + pn_vector[5 ] = pframe[hdrlen +7 ]; +construct_mic_iv (mic_iv, qc_exists, a4_exists, message, plen -8 , pn_vector);construct_mic_header1 (mic_header1, hdrlen, message);construct_mic_header2 (mic_header2, message, a4_exists, qc_exists); - payload_remainder = (plen-8 ) %16 ; - num_blocks = (plen-8 ) /16 ; + payload_remainder = (plen -8 ) %16 ; + num_blocks = (plen -8 ) /16 ;/* Find start of payload */ payload_index = (hdrlen +8 );
@@ -1356,11 +1356,11 @@ static int aes_decipher(u8 *key, uint hdrlen,/* Insert MIC into payload */ for (j =0 ; j <8 ; j++) - message[payload_index+j] = mic[j]; + message[payload_index + j] = mic[j]; payload_index = hdrlen +8 ;for (i =0 ; i < num_blocks; i++) { -construct_ctr_preload (ctr_preload, a4_exists, qc_exists, message, pn_vector, i+1 ); +construct_ctr_preload (ctr_preload, a4_exists, qc_exists, message, pn_vector, i +1 );aes128k128d (key, ctr_preload, aes_out);bitwise_xor (aes_out, &message[payload_index], chain_buffer);for (j =0 ; j <16 ; j++)
@@ -1369,12 +1369,12 @@ static int aes_decipher(u8 *key, uint hdrlen,if (payload_remainder >0 ) {/* If there is a short final block, then pad it,*/ /* encrypt it and copy the unpadded part back */ -construct_ctr_preload (ctr_preload, a4_exists, qc_exists, message, pn_vector, num_blocks+1 ); +construct_ctr_preload (ctr_preload, a4_exists, qc_exists, message, pn_vector, num_blocks +1 );for (j =0 ; j <16 ; j++) padded_buffer[j] =0x00 ;for (j =0 ; j < payload_remainder; j++) - padded_buffer[j] = message[payload_index+j]; + padded_buffer[j] = message[payload_index + j];aes128k128d (key, ctr_preload, aes_out);bitwise_xor (aes_out, padded_buffer, chain_buffer);for (j =0 ; j < payload_remainder; j++)
@@ -1387,7 +1387,7 @@ static int aes_decipher(u8 *key, uint hdrlen,for (j =0 ; j <16 ; j++) padded_buffer[j] =0x00 ;for (j =0 ; j <8 ; j++) - padded_buffer[j] = message[j+hdrlen+8 +plen-8 ]; + padded_buffer[j] = message[j + hdrlen +8 + plen -8 ];aes128k128d (key, ctr_preload, aes_out);bitwise_xor (aes_out, padded_buffer, chain_buffer);
@@ -1396,9 +1396,9 @@ static int aes_decipher(u8 *key, uint hdrlen,/* compare the mic */ for (i =0 ; i <8 ; i++) { -if (pframe[hdrlen+8 +plen-8 +i] != message[hdrlen+8 +plen-8 +i]) { +if (pframe[hdrlen +8 + plen -8 + i] != message[hdrlen +8 + plen -8 + i]) {DBG_88E ("aes_decipher:mic check error mic[%d]: pframe(%x)!=message(%x)\n" , - i, pframe[hdrlen+8 +plen-8 +i], message[hdrlen+8 +plen-8 +i]); + i, pframe[hdrlen +8 + plen -8 + i], message[hdrlen +8 + plen -8 + i]); res = _FAIL; } }
@@ -1438,7 +1438,7 @@ u32 rtw_aes_decrypt(struct adapter *padapter, u8 *precvframe) }else { prwskey = &stainfo->dot118021x_UncstKey.skey[0 ]; } - length = ((struct recv_frame *)precvframe)->len-prxattrib->hdrlen-prxattrib->iv_len; + length = ((struct recv_frame *)precvframe)->len - prxattrib->hdrlen - prxattrib->iv_len; res =aes_decipher (prwskey, prxattrib->hdrlen, pframe, length); }else { res = _FAIL;
Signature · 1 line
2.32.0
PATCH 18/23 staging: r8188eu: add spaces around operators in core/rtw_wlan_util.c
In reply to Michael StraubeAdd missung spaces around operators in core/rtw_wlan_util.c reported by checkpatch.
--- drivers/staging/r8188eu/core/rtw_wlan_util.c | 60 ++++++++++---------- 1 file changed, 30 insertions(+), 30 deletions(-)
drivers/staging/r8188eu/core/rtw_wlan_util.c +30 -30
@@ -29,20 +29,20 @@ unsigned char REALTEK_96B_IE[] = {0x00, 0xe0, 0x4c, 0x02, 0x01, 0x20};#define WAIT_FOR_BCN_TO_MAX (20000)static u8 rtw_basic_rate_cck[4 ] = { -IEEE80211_CCK_RATE_1MB |IEEE80211_BASIC_RATE_MASK ,IEEE80211_CCK_RATE_2MB |IEEE80211_BASIC_RATE_MASK , -IEEE80211_CCK_RATE_5MB |IEEE80211_BASIC_RATE_MASK ,IEEE80211_CCK_RATE_11MB |IEEE80211_BASIC_RATE_MASK +IEEE80211_CCK_RATE_1MB |IEEE80211_BASIC_RATE_MASK ,IEEE80211_CCK_RATE_2MB |IEEE80211_BASIC_RATE_MASK , +IEEE80211_CCK_RATE_5MB |IEEE80211_BASIC_RATE_MASK ,IEEE80211_CCK_RATE_11MB |IEEE80211_BASIC_RATE_MASK };static u8 rtw_basic_rate_ofdm[3 ] = { -IEEE80211_OFDM_RATE_6MB |IEEE80211_BASIC_RATE_MASK ,IEEE80211_OFDM_RATE_12MB |IEEE80211_BASIC_RATE_MASK , -IEEE80211_OFDM_RATE_24MB |IEEE80211_BASIC_RATE_MASK +IEEE80211_OFDM_RATE_6MB |IEEE80211_BASIC_RATE_MASK ,IEEE80211_OFDM_RATE_12MB |IEEE80211_BASIC_RATE_MASK , +IEEE80211_OFDM_RATE_24MB |IEEE80211_BASIC_RATE_MASK };static u8 rtw_basic_rate_mix[7 ] = { -IEEE80211_CCK_RATE_1MB |IEEE80211_BASIC_RATE_MASK ,IEEE80211_CCK_RATE_2MB |IEEE80211_BASIC_RATE_MASK , -IEEE80211_CCK_RATE_5MB |IEEE80211_BASIC_RATE_MASK ,IEEE80211_CCK_RATE_11MB |IEEE80211_BASIC_RATE_MASK , -IEEE80211_OFDM_RATE_6MB |IEEE80211_BASIC_RATE_MASK ,IEEE80211_OFDM_RATE_12MB |IEEE80211_BASIC_RATE_MASK , -IEEE80211_OFDM_RATE_24MB |IEEE80211_BASIC_RATE_MASK +IEEE80211_CCK_RATE_1MB |IEEE80211_BASIC_RATE_MASK ,IEEE80211_CCK_RATE_2MB |IEEE80211_BASIC_RATE_MASK , +IEEE80211_CCK_RATE_5MB |IEEE80211_BASIC_RATE_MASK ,IEEE80211_CCK_RATE_11MB |IEEE80211_BASIC_RATE_MASK , +IEEE80211_OFDM_RATE_6MB |IEEE80211_BASIC_RATE_MASK ,IEEE80211_OFDM_RATE_12MB |IEEE80211_BASIC_RATE_MASK , +IEEE80211_OFDM_RATE_24MB |IEEE80211_BASIC_RATE_MASK };int cckrates_included (unsigned char *rate,int ratelen)
@@ -407,7 +407,7 @@ int is_client_associated_to_ap(struct adapter *padapter) pmlmeext = &padapter->mlmeextpriv; pmlmeinfo = &pmlmeext->mlmext_info; -if ((pmlmeinfo->state &WIFI_FW_ASSOC_SUCCESS ) && ((pmlmeinfo->state&0x03 ) ==WIFI_FW_STATION_STATE )) +if ((pmlmeinfo->state &WIFI_FW_ASSOC_SUCCESS ) && ((pmlmeinfo->state &0x03 ) ==WIFI_FW_STATION_STATE ))return true;else return _FAIL;
@@ -418,7 +418,7 @@ int is_client_associated_to_ibss(struct adapter *padapter)struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;struct mlme_ext_info *pmlmeinfo = &pmlmeext->mlmext_info; -if ((pmlmeinfo->state &WIFI_FW_ASSOC_SUCCESS ) && ((pmlmeinfo->state&0x03 ) ==WIFI_FW_ADHOC_STATE )) +if ((pmlmeinfo->state &WIFI_FW_ASSOC_SUCCESS ) && ((pmlmeinfo->state &0x03 ) ==WIFI_FW_ADHOC_STATE ))return true;else return _FAIL;
@@ -475,7 +475,7 @@ void write_cam(struct adapter *padapter, u8 entry, u16 ctrl, u8 *mac, u8 *key)break ;default : i = (j -2 ) <<2 ; - val = (key[i] | (key[i+1 ] <<8 ) | (key[i+2 ] <<16 ) | (key[i+3 ] <<24 )); + val = (key[i] | (key[i +1 ] <<8 ) | (key[i +2 ] <<16 ) | (key[i +3 ] <<24 ));break ; }
@@ -613,7 +613,7 @@ void WMMOnAssocRsp(struct adapter *padapter)/* entry indx: 0->vo, 1->vi, 2->be, 3->bk. */ for (i =0 ; i <4 ; i++) { -for (j = i+1 ; j <4 ; j++) { +for (j = i +1 ; j <4 ; j++) {/* compare CW and AIFS */ if ((edca[j] &0xFFFF ) < (edca[i] &0xFFFF )) { change_inx = true;
@@ -942,7 +942,7 @@ int rtw_check_bcn_info(struct adapter *Adapter, u8 *pframe, u32 packet_len) ht_info_infos_0 =0 ; }if (ht_cap_info != cur_network->BcnInfo.ht_cap_info || - ((ht_info_infos_0&0x03 ) != (cur_network->BcnInfo.ht_info_infos_0&0x03 ))) { + ((ht_info_infos_0 &0x03 ) != (cur_network->BcnInfo.ht_info_infos_0 &0x03 ))) {DBG_88E ("%s bcn now: ht_cap_info:%x ht_info_infos_0:%x\n" , __func__, ht_cap_info, ht_info_infos_0); DBG_88E("%s bcn link: ht_cap_info:%x ht_info_infos_0:%x\n", __func__,
@@ -1029,14 +1029,14 @@ int rtw_check_bcn_info(struct adapter *Adapter, u8 *pframe, u32 packet_len) }if (encryp_protocol ==ENCRYP_PROTOCOL_WPA || encryp_protocol ==ENCRYP_PROTOCOL_WPA2 ) { - pbuf =rtw_get_wpa_ie (&bssid->IEs[12 ], &wpa_ielen, bssid->IELength-12 ); + pbuf =rtw_get_wpa_ie (&bssid->IEs[12 ], &wpa_ielen, bssid->IELength -12 );if (pbuf && (wpa_ielen >0 )) { -rtw_parse_wpa_ie (pbuf, wpa_ielen+2 , &group_cipher, &pairwise_cipher, &is_8021x); +rtw_parse_wpa_ie (pbuf, wpa_ielen +2 , &group_cipher, &pairwise_cipher, &is_8021x); }else { - pbuf =rtw_get_wpa2_ie (&bssid->IEs[12 ], &wpa_ielen, bssid->IELength-12 ); + pbuf =rtw_get_wpa2_ie (&bssid->IEs[12 ], &wpa_ielen, bssid->IELength -12 );if (pbuf && (wpa_ielen >0 )) -rtw_parse_wpa2_ie (pbuf, wpa_ielen+2 , &group_cipher, &pairwise_cipher, &is_8021x); +rtw_parse_wpa2_ie (pbuf, wpa_ielen +2 , &group_cipher, &pairwise_cipher, &is_8021x); }if (pairwise_cipher != cur_network->BcnInfo.pairwise_cipher || group_cipher != cur_network->BcnInfo.group_cipher) {
@@ -1193,40 +1193,40 @@ int wifirate2_ratetbl_inx(unsigned char rate) rate = rate &0x7f ;switch (rate) { -case 54 *2 : +case 54 *2 : inx =11 ;break ; -case 48 *2 : +case 48 *2 : inx =10 ;break ; -case 36 *2 : +case 36 *2 : inx =9 ;break ; -case 24 *2 : +case 24 *2 : inx =8 ;break ; -case 18 *2 : +case 18 *2 : inx =7 ;break ; -case 12 *2 : +case 12 *2 : inx =6 ;break ; -case 9 *2 : +case 9 *2 : inx =5 ;break ; -case 6 *2 : +case 6 *2 : inx =4 ;break ; -case 11 *2 : +case 11 *2 : inx =3 ;break ;case 11 : inx =2 ;break ; -case 2 *2 : +case 2 *2 : inx =1 ;break ; -case 1 *2 : +case 1 *2 : inx =0 ;break ; }
@@ -1584,7 +1584,7 @@ void process_addba_req(struct adapter *padapter, u8 *paddba_req, u8 *addr)if (psta) { param =le16_to_cpu (preq->BA_para_set); - tid = (param>>2 )&0x0f ; + tid = (param >>2 ) &0x0f ; preorder_ctrl = &psta->recvreorder_ctrl[tid]; preorder_ctrl->indicate_seq =0xffff ; preorder_ctrl->enable = (pmlmeinfo->bAcceptAddbaReq) ? true : false;
@@ -1599,7 +1599,7 @@ void update_TSF(struct mlme_ext_priv *pmlmeext, u8 *pframe, uint len) pIE = pframe +sizeof (struct rtw_ieee80211_hdr_3addr ); pbuf = (__le32 *)pIE; - pmlmeext->TSFValue =le32_to_cpu (*(pbuf+1 )); + pmlmeext->TSFValue =le32_to_cpu (*(pbuf +1 )); pmlmeext->TSFValue = pmlmeext->TSFValue <<32 ;
Signature · 1 line
2.32.0
PATCH 19/23 staging: r8188eu: clean up spacing style issues in core/rtw_xmit.c
In reply to Michael StraubeClean up spacing style issues in core/rtw_xmit.c reported by checkpatch.
CHECK: spaces preferred around that ...
WARNING: space prohibited between function name and open parenthesis '('
--- drivers/staging/r8188eu/core/rtw_xmit.c | 122 ++++++++++++------------ 1 file changed, 61 insertions(+), 61 deletions(-)
drivers/staging/r8188eu/core/rtw_xmit.c +61 -61
@@ -26,7 +26,7 @@ static void _init_txservq(struct tx_servq *ptxservq)void _rtw_init_sta_xmit_priv (struct sta_xmit_priv *psta_xmitpriv) { -memset ((unsigned char *)psta_xmitpriv,0 ,sizeof (struct sta_xmit_priv )); +memset ((unsigned char *)psta_xmitpriv,0 ,sizeof (struct sta_xmit_priv ));spin_lock_init (&psta_xmitpriv->lock);_init_txservq (&psta_xmitpriv->be_q);_init_txservq (&psta_xmitpriv->bk_q);
@@ -207,11 +207,11 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter)return res; } -static void rtw_mfree_xmit_priv_lock (struct xmit_priv *pxmitpriv) +static void rtw_mfree_xmit_priv_lock (struct xmit_priv *pxmitpriv) { } -void _rtw_free_xmit_priv (struct xmit_priv *pxmitpriv) +void _rtw_free_xmit_priv (struct xmit_priv *pxmitpriv) {int i;struct adapter *padapter = pxmitpriv->adapter;
@@ -514,7 +514,7 @@ static s32 update_attrib(struct adapter *padapter, struct sk_buff *pkt, struct p pattrib->subtype =WIFI_DATA_TYPE ; pattrib->priority =0 ; -if (check_fwstate (pmlmepriv,WIFI_AP_STATE |WIFI_ADHOC_STATE |WIFI_ADHOC_MASTER_STATE )) { +if (check_fwstate (pmlmepriv,WIFI_AP_STATE |WIFI_ADHOC_STATE |WIFI_ADHOC_MASTER_STATE )) {if (psta->qos_option)set_qos (&pktfile, pattrib); }else {
@@ -637,15 +637,15 @@ static s32 xmitframe_addmic(struct adapter *padapter, struct xmit_frame *pxmitfrrtw_secmicsetkey (&micdata, &stainfo->dot11tkiptxmickey.skey[0 ]); } -if (pframe[1 ]&1 ) {/* ToDS == 1 */ +if (pframe[1 ] &1 ) {/* ToDS == 1 */ rtw_secmicappend (&micdata, &pframe[16 ],6 );/* DA */ -if (pframe[1 ]&2 )/* From Ds == 1 */ +if (pframe[1 ] &2 )/* From Ds == 1 */ rtw_secmicappend (&micdata, &pframe[24 ],6 );else rtw_secmicappend (&micdata, &pframe[10 ],6 ); }else {/* ToDS == 0 */ rtw_secmicappend (&micdata, &pframe[4 ],6 );/* DA */ -if (pframe[1 ]&2 )/* From Ds == 1 */ +if (pframe[1 ] &2 )/* From Ds == 1 */ rtw_secmicappend (&micdata, &pframe[16 ],6 );else rtw_secmicappend (&micdata, &pframe[10 ],6 );
@@ -661,15 +661,15 @@ static s32 xmitframe_addmic(struct adapter *padapter, struct xmit_frame *pxmitfrfor (curfragnum =0 ; curfragnum < pattrib->nr_frags; curfragnum++) { payload = (u8 *)RND4 ((size_t )(payload)); - payload = payload+pattrib->hdrlen+pattrib->iv_len; -if ((curfragnum+1 ) == pattrib->nr_frags) { - length = pattrib->last_txcmdsz-pattrib->hdrlen-pattrib->iv_len-((pattrib->bswenc) ? pattrib->icv_len :0 ); + payload = payload + pattrib->hdrlen + pattrib->iv_len; +if ((curfragnum +1 ) == pattrib->nr_frags) { + length = pattrib->last_txcmdsz - pattrib->hdrlen - pattrib->iv_len - ((pattrib->bswenc) ? pattrib->icv_len :0 );rtw_secmicappend (&micdata, payload, length); - payload = payload+length; + payload = payload + length; }else { - length = pxmitpriv->frag_len-pattrib->hdrlen-pattrib->iv_len-((pattrib->bswenc) ? pattrib->icv_len :0 ); + length = pxmitpriv->frag_len - pattrib->hdrlen - pattrib->iv_len - ((pattrib->bswenc) ? pattrib->icv_len :0 );rtw_secmicappend (&micdata, payload, length); - payload = payload+length+pattrib->icv_len; + payload = payload + length + pattrib->icv_len; } }rtw_secgetmic (&micdata, &mic[0 ]);
@@ -678,7 +678,7 @@ static s32 xmitframe_addmic(struct adapter *padapter, struct xmit_frame *pxmitfrmemcpy (payload, &mic[0 ],8 ); pattrib->last_txcmdsz +=8 ; - payload = payload-pattrib->last_txcmdsz+8 ; + payload = payload - pattrib->last_txcmdsz +8 ; } }
@@ -709,7 +709,7 @@ static s32 xmitframe_swencrypt(struct adapter *padapter, struct xmit_frame *pxmireturn _SUCCESS; } -s32 rtw_make_wlanhdr (struct adapter *padapter,u8 *hdr,struct pkt_attrib *pattrib) +s32 rtw_make_wlanhdr (struct adapter *padapter,u8 *hdr,struct pkt_attrib *pattrib) {u16 *qc;
@@ -816,11 +816,11 @@ s32 rtw_make_wlanhdr (struct adapter *padapter, u8 *hdr, struct pkt_attrib *pattif (SN_LESS (pattrib->seqnum, tx_seq)) { pattrib->ampdu_en = false;/* AGG BK */ }else if (SN_EQUAL (pattrib->seqnum, tx_seq)) { - psta->BA_starting_seqctrl[pattrib->priority &0x0f ] = (tx_seq+1 )&0xfff ; + psta->BA_starting_seqctrl[pattrib->priority &0x0f ] = (tx_seq +1 ) &0xfff ; pattrib->ampdu_en = true;/* AGG EN */ }else { - psta->BA_starting_seqctrl[pattrib->priority &0x0f ] = (pattrib->seqnum+1 )&0xfff ; + psta->BA_starting_seqctrl[pattrib->priority &0x0f ] = (pattrib->seqnum +1 ) &0xfff ; pattrib->ampdu_en = true;/* AGG EN */ } }
@@ -1125,7 +1125,7 @@ void rtw_count_tx_stats(struct adapter *padapter, struct xmit_frame *pxmitframe,struct xmit_priv *pxmitpriv = &padapter->xmitpriv;struct mlme_priv *pmlmepriv = &padapter->mlmepriv; -if ((pxmitframe->frame_tag&0x0f ) ==DATA_FRAMETAG ) { +if ((pxmitframe->frame_tag &0x0f ) ==DATA_FRAMETAG ) { pxmitpriv->tx_bytes += sz; pmlmepriv->LinkDetectInfo.NumTxOkInPeriod += pxmitframe->agg_num;
@@ -1584,32 +1584,32 @@ static int rtw_br_client_tx(struct adapter *padapter, struct sk_buff **pskb)rcu_read_unlock ();spin_lock_bh (&padapter->br_ext_lock);if (!(skb->data[0 ] &1 ) && br_port && -memcmp (skb->data+MACADDRLEN , padapter->br_mac,MACADDRLEN ) && - *((__be16 *)(skb->data+MACADDRLEN *2 )) !=__constant_htons (ETH_P_8021Q ) && - *((__be16 *)(skb->data+MACADDRLEN *2 )) ==__constant_htons (ETH_P_IP ) && - !memcmp (padapter->scdb_mac, skb->data+MACADDRLEN ,MACADDRLEN ) && padapter->scdb_entry) { -memcpy (skb->data+MACADDRLEN ,GET_MY_HWADDR (padapter),MACADDRLEN ); +memcmp (skb->data +MACADDRLEN , padapter->br_mac,MACADDRLEN ) && + *((__be16 *)(skb->data +MACADDRLEN *2 )) !=__constant_htons (ETH_P_8021Q ) && + *((__be16 *)(skb->data +MACADDRLEN *2 )) ==__constant_htons (ETH_P_IP ) && + !memcmp (padapter->scdb_mac, skb->data +MACADDRLEN ,MACADDRLEN ) && padapter->scdb_entry) { +memcpy (skb->data +MACADDRLEN ,GET_MY_HWADDR (padapter),MACADDRLEN ); padapter->scdb_entry->ageing_timer = jiffies;spin_unlock_bh (&padapter->br_ext_lock); }else { -if (*((__be16 *)(skb->data+MACADDRLEN *2 )) ==__constant_htons (ETH_P_8021Q )) { +if (*((__be16 *)(skb->data +MACADDRLEN *2 )) ==__constant_htons (ETH_P_8021Q )) { is_vlan_tag =1 ; - vlan_hdr = *((unsigned short *)(skb->data+MACADDRLEN *2 +2 )); + vlan_hdr = *((unsigned short *)(skb->data +MACADDRLEN *2 +2 ));for (i =0 ; i <6 ; i++) - *((unsigned short *)(skb->data+MACADDRLEN *2 +2 -i*2 )) = *((unsigned short *)(skb->data+MACADDRLEN *2 -2 -i*2 )); + *((unsigned short *)(skb->data +MACADDRLEN *2 +2 - i *2 )) = *((unsigned short *)(skb->data +MACADDRLEN *2 -2 - i *2 ));skb_pull (skb,4 ); } -if (!memcmp (skb->data+MACADDRLEN , padapter->br_mac,MACADDRLEN ) && - (*((__be16 *)(skb->data+MACADDRLEN *2 )) ==__constant_htons (ETH_P_IP ))) -memcpy (padapter->br_ip, skb->data+WLAN_ETHHDR_LEN +12 ,4 ); +if (!memcmp (skb->data +MACADDRLEN , padapter->br_mac,MACADDRLEN ) && + (*((__be16 *)(skb->data +MACADDRLEN *2 )) ==__constant_htons (ETH_P_IP ))) +memcpy (padapter->br_ip, skb->data +WLAN_ETHHDR_LEN +12 ,4 ); -if (*((__be16 *)(skb->data+MACADDRLEN *2 )) ==__constant_htons (ETH_P_IP )) { -if (memcmp (padapter->scdb_mac, skb->data+MACADDRLEN ,MACADDRLEN )) { +if (*((__be16 *)(skb->data +MACADDRLEN *2 )) ==__constant_htons (ETH_P_IP )) { +if (memcmp (padapter->scdb_mac, skb->data +MACADDRLEN ,MACADDRLEN )) { padapter->scdb_entry = (struct nat25_network_db_entry *)scdb_findEntry (padapter, - skb->data+MACADDRLEN , skb->data+WLAN_ETHHDR_LEN +12 ); + skb->data +MACADDRLEN , skb->data +WLAN_ETHHDR_LEN +12 );if (padapter->scdb_entry) { -memcpy (padapter->scdb_mac, skb->data+MACADDRLEN ,MACADDRLEN ); -memcpy (padapter->scdb_ip, skb->data+WLAN_ETHHDR_LEN +12 ,4 ); +memcpy (padapter->scdb_mac, skb->data +MACADDRLEN ,MACADDRLEN ); +memcpy (padapter->scdb_ip, skb->data +WLAN_ETHHDR_LEN +12 ,4 ); padapter->scdb_entry->ageing_timer = jiffies; do_nat25 =0 ; }
@@ -1631,9 +1631,9 @@ static int rtw_br_client_tx(struct adapter *padapter, struct sk_buff **pskb)if (is_vlan_tag) {skb_push (skb,4 );for (i =0 ; i <6 ; i++) - *((unsigned short *)(skb->data+i*2 )) = *((unsigned short *)(skb->data+4 +i*2 )); - *((__be16 *)(skb->data+MACADDRLEN *2 )) =__constant_htons (ETH_P_8021Q ); - *((unsigned short *)(skb->data+MACADDRLEN *2 +2 )) = vlan_hdr; + *((unsigned short *)(skb->data + i *2 )) = *((unsigned short *)(skb->data +4 + i *2 )); + *((__be16 *)(skb->data +MACADDRLEN *2 )) =__constant_htons (ETH_P_8021Q ); + *((unsigned short *)(skb->data +MACADDRLEN *2 +2 )) = vlan_hdr; } newskb =skb_copy (skb,GFP_ATOMIC );
@@ -1645,9 +1645,9 @@ static int rtw_br_client_tx(struct adapter *padapter, struct sk_buff **pskb) *pskb = skb = newskb;if (is_vlan_tag) { - vlan_hdr = *((unsigned short *)(skb->data+MACADDRLEN *2 +2 )); + vlan_hdr = *((unsigned short *)(skb->data +MACADDRLEN *2 +2 ));for (i =0 ; i <6 ; i++) - *((unsigned short *)(skb->data+MACADDRLEN *2 +2 -i*2 )) = *((unsigned short *)(skb->data+MACADDRLEN *2 -2 -i*2 )); + *((unsigned short *)(skb->data +MACADDRLEN *2 +2 - i *2 )) = *((unsigned short *)(skb->data +MACADDRLEN *2 -2 - i *2 ));skb_pull (skb,4 ); } }
@@ -1671,21 +1671,21 @@ static int rtw_br_client_tx(struct adapter *padapter, struct sk_buff **pskb) } } -memcpy (skb->data+MACADDRLEN ,GET_MY_HWADDR (padapter),MACADDRLEN ); +memcpy (skb->data +MACADDRLEN ,GET_MY_HWADDR (padapter),MACADDRLEN );dhcp_flag_bcast (padapter, skb);if (is_vlan_tag) {skb_push (skb,4 );for (i =0 ; i <6 ; i++) - *((unsigned short *)(skb->data+i*2 )) = *((unsigned short *)(skb->data+4 +i*2 )); - *((__be16 *)(skb->data+MACADDRLEN *2 )) =__constant_htons (ETH_P_8021Q ); - *((unsigned short *)(skb->data+MACADDRLEN *2 +2 )) = vlan_hdr; + *((unsigned short *)(skb->data + i *2 )) = *((unsigned short *)(skb->data +4 + i *2 )); + *((__be16 *)(skb->data +MACADDRLEN *2 )) =__constant_htons (ETH_P_8021Q ); + *((unsigned short *)(skb->data +MACADDRLEN *2 +2 )) = vlan_hdr; } }/* check if SA is equal to our MAC */ -if (memcmp (skb->data+MACADDRLEN ,GET_MY_HWADDR (padapter),MACADDRLEN )) { +if (memcmp (skb->data +MACADDRLEN ,GET_MY_HWADDR (padapter),MACADDRLEN )) {DEBUG_ERR ("TX DROP: untransformed frame SA:%02X%02X%02X%02X%02X%02X!\n" , skb->data[6 ], skb->data[7 ], skb->data[8 ], skb->data[9 ], skb->data[10 ], skb->data[11 ]);return -1 ;
@@ -1765,7 +1765,7 @@ s32 rtw_xmit(struct adapter *padapter, struct sk_buff **ppkt) br_port =rcu_dereference (padapter->pnetdev->rx_handler_data);rcu_read_unlock (); -if (br_port &&check_fwstate (pmlmepriv,WIFI_STATION_STATE |WIFI_ADHOC_STATE )) { +if (br_port &&check_fwstate (pmlmepriv,WIFI_STATION_STATE |WIFI_ADHOC_STATE )) { res =rtw_br_client_tx (padapter, ppkt);if (res ==-1 ) {rtw_free_xmitframe (pxmitpriv, pxmitframe);
@@ -1853,10 +1853,10 @@ int xmitframe_enqueue_for_sleeping_sta(struct adapter *padapter, struct xmit_fraspin_lock_bh (&psta->sleep_q.lock); -if (psta->state&WIFI_SLEEP_STATE ) { +if (psta->state &WIFI_SLEEP_STATE ) {u8 wmmps_ac =0 ; -if (pstapriv->sta_dz_bitmap&BIT (psta->aid)) { +if (pstapriv->sta_dz_bitmap &BIT (psta->aid)) {list_del_init (&pxmitframe->list);list_add_tail (&pxmitframe->list,get_list_head (&psta->sleep_q));
@@ -1866,20 +1866,20 @@ int xmitframe_enqueue_for_sleeping_sta(struct adapter *padapter, struct xmit_fraswitch (pattrib->priority) {case 1 :case 2 : - wmmps_ac = psta->uapsd_bk&BIT (0 ); + wmmps_ac = psta->uapsd_bk &BIT (0 );break ;case 4 :case 5 : - wmmps_ac = psta->uapsd_vi&BIT (0 ); + wmmps_ac = psta->uapsd_vi &BIT (0 );break ;case 6 :case 7 : - wmmps_ac = psta->uapsd_vo&BIT (0 ); + wmmps_ac = psta->uapsd_vo &BIT (0 );break ;case 0 :case 3 :default : - wmmps_ac = psta->uapsd_be&BIT (0 ); + wmmps_ac = psta->uapsd_be &BIT (0 );break ; }
@@ -1993,20 +1993,20 @@ void wakeup_sta_to_xmit(struct adapter *padapter, struct sta_info *psta)switch (pxmitframe->attrib.priority) {case 1 :case 2 : - wmmps_ac = psta->uapsd_bk&BIT (1 ); + wmmps_ac = psta->uapsd_bk &BIT (1 );break ;case 4 :case 5 : - wmmps_ac = psta->uapsd_vi&BIT (1 ); + wmmps_ac = psta->uapsd_vi &BIT (1 );break ;case 6 :case 7 : - wmmps_ac = psta->uapsd_vo&BIT (1 ); + wmmps_ac = psta->uapsd_vo &BIT (1 );break ;case 0 :case 3 :default : - wmmps_ac = psta->uapsd_be&BIT (1 ); + wmmps_ac = psta->uapsd_be &BIT (1 );break ; }
@@ -2040,7 +2040,7 @@ void wakeup_sta_to_xmit(struct adapter *padapter, struct sta_info *psta) update_mask =BIT (0 ); -if (psta->state&WIFI_SLEEP_STATE ) +if (psta->state &WIFI_SLEEP_STATE ) psta->state ^=WIFI_SLEEP_STATE ;if (psta->state &WIFI_STA_ALIVE_CHK_STATE ) {
@@ -2058,7 +2058,7 @@ void wakeup_sta_to_xmit(struct adapter *padapter, struct sta_info *psta)if (!psta_bmc)return ; -if ((pstapriv->sta_dz_bitmap&0xfffe ) ==0x0 ) {/* no any sta in ps mode */ +if ((pstapriv->sta_dz_bitmap &0xfffe ) ==0x0 ) {/* no any sta in ps mode */ spin_lock_bh (&psta_bmc->sleep_q.lock); xmitframe_phead =get_list_head (&psta_bmc->sleep_q);
@@ -2119,20 +2119,20 @@ void xmit_delivery_enabled_frames(struct adapter *padapter, struct sta_info *pstswitch (pxmitframe->attrib.priority) {case 1 :case 2 : - wmmps_ac = psta->uapsd_bk&BIT (1 ); + wmmps_ac = psta->uapsd_bk &BIT (1 );break ;case 4 :case 5 : - wmmps_ac = psta->uapsd_vi&BIT (1 ); + wmmps_ac = psta->uapsd_vi &BIT (1 );break ;case 6 :case 7 : - wmmps_ac = psta->uapsd_vo&BIT (1 ); + wmmps_ac = psta->uapsd_vo &BIT (1 );break ;case 0 :case 3 :default : - wmmps_ac = psta->uapsd_be&BIT (1 ); + wmmps_ac = psta->uapsd_be &BIT (1 );break ; }
Signature · 1 line
2.32.0
PATCH 20/23 staging: r8188eu: clean up spacing style issues in core/rtw_debug.c
In reply to Michael StraubeClean up spacing style issues in core/rtw_debug.c reported by checkpatch.
CHECK: spaces preferred around that '%' (ctx:VxV)
WARNING: space prohibited before semicolon
--- drivers/staging/r8188eu/core/rtw_debug.c | 42 ++++++++++++------------ 1 file changed, 21 insertions(+), 21 deletions(-)
drivers/staging/r8188eu/core/rtw_debug.c +21 -21
@@ -309,10 +309,10 @@ int proc_get_mac_reg_dump1(char *page, char **start, len +=snprintf (page + len, count - len,"\n======= MAC REG =======\n" );for (i =0x0 ; i <0x300 ; i +=4 ) { -if (j%4 ==1 ) +if (j %4 ==1 ) len +=snprintf (page + len, count - len,"0x%02x" , i); len +=snprintf (page + len, count - len," 0x%08x " ,rtw_read32 (padapter, i)); -if ((j++)%4 ==0 ) +if ((j++) %4 ==0 ) len +=snprintf (page + len, count - len,"\n" ); }
@@ -332,10 +332,10 @@ int proc_get_mac_reg_dump2(char *page, char **start, len +=snprintf (page + len, count - len,"\n======= MAC REG =======\n" );memset (page,0 , count);for (i =0x300 ; i <0x600 ; i +=4 ) { -if (j%4 ==1 ) +if (j %4 ==1 ) len +=snprintf (page + len, count - len,"0x%02x" , i); len +=snprintf (page + len, count - len," 0x%08x " ,rtw_read32 (padapter, i)); -if ((j++)%4 ==0 ) +if ((j++) %4 ==0 ) len +=snprintf (page + len, count - len,"\n" ); }
@@ -355,10 +355,10 @@ int proc_get_mac_reg_dump3(char *page, char **start, len +=snprintf (page + len, count - len,"\n======= MAC REG =======\n" );for (i =0x600 ; i <0x800 ; i +=4 ) { -if (j%4 ==1 ) +if (j %4 ==1 ) len +=snprintf (page + len, count - len,"0x%02x" , i); len +=snprintf (page + len, count - len," 0x%08x " ,rtw_read32 (padapter, i)); -if ((j++)%4 ==0 ) +if ((j++) %4 ==0 ) len +=snprintf (page + len, count - len,"\n" ); }
@@ -377,10 +377,10 @@ int proc_get_bb_reg_dump1(char *page, char **start, len +=snprintf (page + len, count - len,"\n======= BB REG =======\n" );for (i =0x800 ; i <0xB00 ; i +=4 ) { -if (j%4 ==1 ) +if (j %4 ==1 ) len +=snprintf (page + len, count - len,"0x%02x" , i); len +=snprintf (page + len, count - len," 0x%08x " ,rtw_read32 (padapter, i)); -if ((j++)%4 ==0 ) +if ((j++) %4 ==0 ) len +=snprintf (page + len, count - len,"\n" ); } *eof =1 ;
@@ -398,10 +398,10 @@ int proc_get_bb_reg_dump2(char *page, char **start, len +=snprintf (page + len, count - len,"\n======= BB REG =======\n" );for (i =0xB00 ; i <0xE00 ; i +=4 ) { -if (j%4 ==1 ) +if (j %4 ==1 ) len +=snprintf (page + len, count - len,"0x%02x" , i); len +=snprintf (page + len, count - len," 0x%08x " ,rtw_read32 (padapter, i)); -if ((j++)%4 ==0 ) +if ((j++) %4 ==0 ) len +=snprintf (page + len, count - len,"\n" ); } *eof =1 ;
@@ -419,10 +419,10 @@ int proc_get_bb_reg_dump3(char *page, char **start, len +=snprintf (page + len, count - len,"\n======= BB REG =======\n" );for (i =0xE00 ; i <0x1000 ; i +=4 ) { -if (j%4 ==1 ) +if (j %4 ==1 ) len +=snprintf (page + len, count - len,"0x%02x" , i); len +=snprintf (page + len, count - len," 0x%08x " ,rtw_read32 (padapter, i)); -if ((j++)%4 ==0 ) +if ((j++) %4 ==0 ) len +=snprintf (page + len, count - len,"\n" ); } *eof =1 ;
@@ -444,10 +444,10 @@ int proc_get_rf_reg_dump1(char *page, char **start, len +=snprintf (page + len, count - len,"\nRF_Path(%x)\n" , path);for (i =0 ; i <0xC0 ; i++) { value =rtw_hal_read_rfreg (padapter, path, i,0xffffffff ); -if (j%4 ==1 ) +if (j %4 ==1 ) len +=snprintf (page + len, count - len,"0x%02x " , i); len +=snprintf (page + len, count - len," 0x%08x " , value); -if ((j++)%4 ==0 ) +if ((j++) %4 ==0 ) len +=snprintf (page + len, count - len,"\n" ); } *eof =1 ;
@@ -469,10 +469,10 @@ int proc_get_rf_reg_dump2(char *page, char **start, len +=snprintf (page + len, count - len,"\nRF_Path(%x)\n" , path);for (i =0xC0 ; i <0x100 ; i++) { value =rtw_hal_read_rfreg (padapter, path, i,0xffffffff ); -if (j%4 ==1 ) +if (j %4 ==1 ) len +=snprintf (page + len, count - len,"0x%02x " , i); len +=snprintf (page + len, count - len," 0x%08x " , value); -if ((j++)%4 ==0 ) +if ((j++) %4 ==0 ) len +=snprintf (page + len, count - len,"\n" ); } *eof =1 ;
@@ -494,10 +494,10 @@ int proc_get_rf_reg_dump3(char *page, char **start, len +=snprintf (page + len, count - len,"\nRF_Path(%x)\n" , path);for (i =0 ; i <0xC0 ; i++) { value =rtw_hal_read_rfreg (padapter, path, i,0xffffffff ); -if (j%4 ==1 ) +if (j %4 ==1 ) len +=snprintf (page + len, count - len,"0x%02x " , i); len +=snprintf (page + len, count - len," 0x%08x " , value); -if ((j++)%4 ==0 ) +if ((j++) %4 ==0 ) len +=snprintf (page + len, count - len,"\n" ); }
@@ -520,10 +520,10 @@ int proc_get_rf_reg_dump4(char *page, char **start, len +=snprintf (page + len, count - len,"\nRF_Path(%x)\n" , path);for (i =0xC0 ; i <0x100 ; i++) { value =rtw_hal_read_rfreg (padapter, path, i,0xffffffff ); -if (j%4 ==1 ) +if (j %4 ==1 ) len +=snprintf (page + len, count - len,"0x%02x " , i); len +=snprintf (page + len, count - len," 0x%08x " , value); -if ((j++)%4 ==0 ) +if ((j++) %4 ==0 ) len +=snprintf (page + len, count - len,"\n" ); } *eof =1 ;
@@ -801,7 +801,7 @@ int proc_set_rssi_disp(struct file *file, const char __user *buffer,if (enable) {DBG_88E ("Turn On Rx RSSI Display Function\n" ); - padapter->bRxRSSIDisplay = enable ; + padapter->bRxRSSIDisplay = enable; }else {DBG_88E ("Turn Off Rx RSSI Display Function\n" ); padapter->bRxRSSIDisplay =0 ;
Signature · 1 line
2.32.0
PATCH 21/23 staging: r8188eu: add space around operator in core/rtw_sreset.c
In reply to Michael StraubeAdd missing space around operator in core/rtw_sreset.c reported by checkpatch.
CHECK: spaces preferred around that '|' (ctx:VxV)
--- drivers/staging/r8188eu/core/rtw_sreset.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/r8188eu/core/rtw_sreset.c +1 -1
@@ -45,7 +45,7 @@ u8 sreset_get_wifi_status(struct adapter *padapter)if (WIFI_STATUS_SUCCESS != psrtpriv->Wifi_Error_Status) {DBG_88E ("==>%s error_status(0x%x)\n" , __func__, psrtpriv->Wifi_Error_Status); - status = (psrtpriv->Wifi_Error_Status & (~(USB_READ_PORT_FAIL |USB_WRITE_PORT_FAIL ))); + status = (psrtpriv->Wifi_Error_Status & (~(USB_READ_PORT_FAIL |USB_WRITE_PORT_FAIL ))); }DBG_88E ("==> %s wifi_status(0x%x)\n" , __func__, status);
Signature · 1 line
2.32.0
PATCH 22/23 staging: r8188eu: clean up spacing style issues in core/rtw_sta_mgt.c
In reply to Michael StraubeClean up spacing style issues in core/rtw_sta_mgt.c reported by checkpatch.
WARNING: space prohibited between function name and open parenthesis '('
CHECK: spaces preferred around that '/' (ctx:VxV)
WARNING: space prohibited before semicolon
--- drivers/staging/r8188eu/core/rtw_sta_mgt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/r8188eu/core/rtw_sta_mgt.c +3 -3
@@ -13,7 +13,7 @@static void _rtw_init_stainfo (struct sta_info *psta) { -memset ((u8 *)psta,0 ,sizeof (struct sta_info )); +memset ((u8 *)psta,0 ,sizeof (struct sta_info ));spin_lock_init (&psta->lock);INIT_LIST_HEAD (&psta->list);
@@ -111,7 +111,7 @@ u32 _rtw_init_sta_priv(struct sta_priv *pstapriv)inline int rtw_stainfo_offset (struct sta_priv *stapriv,struct sta_info *sta) { -int offset = (((u8 *)sta) - stapriv->pstainfo_buf)/sizeof (struct sta_info ); +int offset = (((u8 *)sta) - stapriv->pstainfo_buf) /sizeof (struct sta_info );if (!stainfo_offset_valid (offset))DBG_88E ("%s invalid offset(%d), out of range!!!" , __func__, offset);
@@ -196,7 +196,7 @@ struct sta_info *rtw_alloc_stainfo(struct sta_priv *pstapriv, u8 *hwaddr)list_add_tail (&psta->hash_list, phash_list); - pstapriv->asoc_sta_count++ ; + pstapriv->asoc_sta_count++;spin_unlock_bh (&pstapriv->sta_hash_lock);
Signature · 1 line
2.32.0
PATCH 23/23 staging: r8188eu: add spaces around operators in core/rtw_br_ext.c
In reply to Michael StraubeAdd missing spaces around operators in core/rtw_br_ext.c reported by chackpatch.
--- drivers/staging/r8188eu/core/rtw_br_ext.c | 104 +++++++++++----------- 1 file changed, 52 insertions(+), 52 deletions(-)
drivers/staging/r8188eu/core/rtw_br_ext.c +52 -52
@@ -89,19 +89,19 @@ static int skb_pull_and_merge(struct sk_buff *skb, unsigned char *src, int len)int tail_len;unsigned long end, tail; -if ((src+len) >skb_tail_pointer (skb) || skb->len < len) +if ((src + len) >skb_tail_pointer (skb) || skb->len < len)return -1 ; tail = (unsigned long )skb_tail_pointer (skb); - end = (unsigned long )src+len; + end = (unsigned long )src + len;if (tail < end)return -1 ; - tail_len = (int )(tail-end); + tail_len = (int )(tail - end);if (tail_len >0 ) -memmove (src, src+len, tail_len); +memmove (src, src + len, tail_len); -skb_trim (skb, skb->len-len); +skb_trim (skb, skb->len - len);return 0 ; }
@@ -109,7 +109,7 @@ static unsigned long __nat25_timeout(struct adapter *priv) {unsigned long timeout; - timeout = jiffies -NAT25_AGEING_TIME *HZ ; + timeout = jiffies -NAT25_AGEING_TIME *HZ ;return timeout; }
@@ -129,7 +129,7 @@ static void __nat25_generate_ipv4_network_addr(unsigned char *networkAddr,memset (networkAddr,0 ,MAX_NETWORK_ADDR_LEN ); networkAddr[0 ] =NAT25_IPV4 ; -memcpy (networkAddr+7 , (unsigned char *)ipAddr,4 ); +memcpy (networkAddr +7 , (unsigned char *)ipAddr,4 ); } static void __nat25_generate_pppoe_network_addr(unsigned char *networkAddr,
@@ -138,8 +138,8 @@ static void __nat25_generate_pppoe_network_addr(unsigned char *networkAddr,memset (networkAddr,0 ,MAX_NETWORK_ADDR_LEN ); networkAddr[0 ] =NAT25_PPPOE ; -memcpy (networkAddr+1 , (unsigned char *)sid,2 ); -memcpy (networkAddr+3 , (unsigned char *)ac_mac,6 ); +memcpy (networkAddr +1 , (unsigned char *)sid,2 ); +memcpy (networkAddr +3 , (unsigned char *)ac_mac,6 ); } static void __nat25_generate_ipv6_network_addr(unsigned char *networkAddr,
@@ -148,17 +148,17 @@ static void __nat25_generate_ipv6_network_addr(unsigned char *networkAddr,memset (networkAddr,0 ,MAX_NETWORK_ADDR_LEN ); networkAddr[0 ] =NAT25_IPV6 ; -memcpy (networkAddr+1 , (unsigned char *)ipAddr,16 ); +memcpy (networkAddr +1 , (unsigned char *)ipAddr,16 ); }static unsigned char *scan_tlv (unsigned char *data,int len,unsigned char tag,unsigned char len8b) {while (len >0 ) { -if (*data == tag && *(data+1 ) == len8b && len >= len8b*8 ) -return data+2 ; +if (*data == tag && *(data +1 ) == len8b && len >= len8b *8 ) +return data +2 ; - len -= (*(data+1 ))*8 ; - data += (*(data+1 ))*8 ; + len -= (*(data +1 )) *8 ; + data += (*(data +1 )) *8 ; }return NULL ; }
@@ -170,7 +170,7 @@ static int update_nd_link_layer_addr(unsigned char *data, int len, unsigned charif (icmphdr->icmp6_type ==NDISC_ROUTER_SOLICITATION ) {if (len >=8 ) { - mac =scan_tlv (&data[8 ], len-8 ,1 ,1 ); + mac =scan_tlv (&data[8 ], len -8 ,1 ,1 );if (mac) { _DEBUG_INFO("Router Solicitation, replace MAC From: %02x:%02x:%02x:%02x:%02x:%02x, To: %02x:%02x:%02x:%02x:%02x:%02x\n", mac[0], mac[1], mac[2], mac[3], mac[4], mac[5],
@@ -181,7 +181,7 @@ static int update_nd_link_layer_addr(unsigned char *data, int len, unsigned char } }else if (icmphdr->icmp6_type ==NDISC_ROUTER_ADVERTISEMENT ) {if (len >=16 ) { - mac =scan_tlv (&data[16 ], len-16 ,1 ,1 ); + mac =scan_tlv (&data[16 ], len -16 ,1 ,1 );if (mac) { _DEBUG_INFO("Router Advertisement, replace MAC From: %02x:%02x:%02x:%02x:%02x:%02x, To: %02x:%02x:%02x:%02x:%02x:%02x\n", mac[0], mac[1], mac[2], mac[3], mac[4], mac[5],
@@ -192,7 +192,7 @@ static int update_nd_link_layer_addr(unsigned char *data, int len, unsigned char } }else if (icmphdr->icmp6_type ==NDISC_NEIGHBOUR_SOLICITATION ) {if (len >=24 ) { - mac =scan_tlv (&data[24 ], len-24 ,1 ,1 ); + mac =scan_tlv (&data[24 ], len -24 ,1 ,1 );if (mac) { _DEBUG_INFO("Neighbor Solicitation, replace MAC From: %02x:%02x:%02x:%02x:%02x:%02x, To: %02x:%02x:%02x:%02x:%02x:%02x\n", mac[0], mac[1], mac[2], mac[3], mac[4], mac[5],
@@ -203,7 +203,7 @@ static int update_nd_link_layer_addr(unsigned char *data, int len, unsigned char } }else if (icmphdr->icmp6_type ==NDISC_NEIGHBOUR_ADVERTISEMENT ) {if (len >=24 ) { - mac =scan_tlv (&data[24 ], len-24 ,2 ,1 ); + mac =scan_tlv (&data[24 ], len -24 ,2 ,1 );if (mac) { _DEBUG_INFO("Neighbor Advertisement, replace MAC From: %02x:%02x:%02x:%02x:%02x:%02x, To: %02x:%02x:%02x:%02x:%02x:%02x\n", mac[0], mac[1], mac[2], mac[3], mac[4], mac[5],
@@ -214,7 +214,7 @@ static int update_nd_link_layer_addr(unsigned char *data, int len, unsigned char } }else if (icmphdr->icmp6_type ==NDISC_REDIRECT ) {if (len >=40 ) { - mac =scan_tlv (&data[40 ], len-40 ,2 ,1 ); + mac =scan_tlv (&data[40 ], len -40 ,2 ,1 );if (mac) { _DEBUG_INFO("Redirect, replace MAC From: %02x:%02x:%02x:%02x:%02x:%02x, To: %02x:%02x:%02x:%02x:%02x:%02x\n", mac[0], mac[1], mac[2], mac[3], mac[4], mac[5],
@@ -463,7 +463,7 @@ int nat25_db_handle(struct adapter *priv, struct sk_buff *skb, int method)if (protocol ==ETH_P_IP ) {struct iphdr *iph = (struct iphdr *)(skb->data +ETH_HLEN ); -if (((unsigned char *)(iph) + (iph->ihl<<2 )) >= (skb->data +ETH_HLEN + skb->len)) { +if (((unsigned char *)(iph) + (iph->ihl <<2 )) >= (skb->data +ETH_HLEN + skb->len)) {DEBUG_WARN ("NAT25: malformed IP packet !\n" );return -1 ; }
@@ -480,7 +480,7 @@ int nat25_db_handle(struct adapter *priv, struct sk_buff *skb, int method)DEBUG_INFO ("NAT25: Insert IP, SA =%08x, DA =%08x\n" , tmp, iph->daddr);__nat25_generate_ipv4_network_addr (networkAddr, &tmp);/* record source IP address and , source mac address into db */ -__nat25_db_network_insert (priv, skb->data+ETH_ALEN , networkAddr); +__nat25_db_network_insert (priv, skb->data +ETH_ALEN , networkAddr);__nat25_db_print (priv);return 0 ;
@@ -497,7 +497,7 @@ int nat25_db_handle(struct adapter *priv, struct sk_buff *skb, int method) }else {/* forward unknow IP packet to upper TCP/IP */ DEBUG_INFO ("NAT25: Replace DA with BR's MAC\n" ); -if ((*(u32 *)priv->br_mac) ==0 && (*(u16 *)(priv->br_mac+4 )) ==0 ) { +if ((*(u32 *)priv->br_mac) ==0 && (*(u16 *)(priv->br_mac +4 )) ==0 ) {printk ("Re-init netdev_br_init() due to br_mac == 0!\n" );netdev_br_init (priv->pnetdev); }
@@ -533,7 +533,7 @@ int nat25_db_handle(struct adapter *priv, struct sk_buff *skb, int method) arp_ptr += arp->ar_hln; sender = (unsigned int *)arp_ptr;__nat25_generate_ipv4_network_addr (networkAddr, sender); -__nat25_db_network_insert (priv, skb->data+ETH_ALEN , networkAddr); +__nat25_db_network_insert (priv, skb->data +ETH_ALEN , networkAddr);__nat25_db_print (priv);return 0 ;case NAT25_LOOKUP :
@@ -578,28 +578,28 @@ int nat25_db_handle(struct adapter *priv, struct sk_buff *skb, int method) pOldTag = (struct pppoe_tag *)__nat25_find_pppoe_tag (ph,ntohs (PTT_RELAY_SID ));if (pOldTag) {/* if SID existed, copy old value and delete it */ old_tag_len =ntohs (pOldTag->tag_len); -if (old_tag_len+TAG_HDR_LEN +MAGIC_CODE_LEN +RTL_RELAY_TAG_LEN >sizeof (tag_buf)) { +if (old_tag_len +TAG_HDR_LEN +MAGIC_CODE_LEN +RTL_RELAY_TAG_LEN >sizeof (tag_buf)) {DEBUG_ERR ("SID tag length too long!\n" );return -1 ; } -memcpy (tag->tag_data+MAGIC_CODE_LEN +RTL_RELAY_TAG_LEN , +memcpy (tag->tag_data +MAGIC_CODE_LEN +RTL_RELAY_TAG_LEN , pOldTag->tag_data, old_tag_len); -if (skb_pull_and_merge (skb, (unsigned char *)pOldTag,TAG_HDR_LEN +old_tag_len) <0 ) { +if (skb_pull_and_merge (skb, (unsigned char *)pOldTag,TAG_HDR_LEN + old_tag_len) <0 ) {DEBUG_ERR ("call skb_pull_and_merge() failed in PADI/R packet!\n" );return -1 ; } - ph->length =htons (ntohs (ph->length)-TAG_HDR_LEN -old_tag_len); + ph->length =htons (ntohs (ph->length) -TAG_HDR_LEN - old_tag_len); } tag->tag_type =PTT_RELAY_SID ; - tag->tag_len =htons (MAGIC_CODE_LEN +RTL_RELAY_TAG_LEN +old_tag_len); + tag->tag_len =htons (MAGIC_CODE_LEN +RTL_RELAY_TAG_LEN + old_tag_len);/* insert the magic_code+client mac in relay tag */ pMagic = (unsigned short *)tag->tag_data; *pMagic =htons (MAGIC_CODE ); -memcpy (tag->tag_data+MAGIC_CODE_LEN , skb->data+ETH_ALEN ,ETH_ALEN ); +memcpy (tag->tag_data +MAGIC_CODE_LEN , skb->data +ETH_ALEN ,ETH_ALEN );/* Add relay tag */ if (__nat25_add_pppoe_tag (skb, tag) <0 )
@@ -609,13 +609,13 @@ int nat25_db_handle(struct adapter *priv, struct sk_buff *skb, int method) (ph->code == PADI_CODE ? "PADI" : "PADR")); }else {/* not add relay tag */ if (priv->pppoe_connection_in_progress && -memcmp (skb->data+ETH_ALEN , priv->pppoe_addr,ETH_ALEN )) { +memcmp (skb->data +ETH_ALEN , priv->pppoe_addr,ETH_ALEN )) {DEBUG_ERR ("Discard PPPoE packet due to another PPPoE connection is in progress!\n" );return -2 ; }if (priv->pppoe_connection_in_progress ==0 ) -memcpy (priv->pppoe_addr, skb->data+ETH_ALEN ,ETH_ALEN ); +memcpy (priv->pppoe_addr, skb->data +ETH_ALEN ,ETH_ALEN ); priv->pppoe_connection_in_progress =WAIT_TIME_PPPOE ; }
@@ -627,13 +627,13 @@ int nat25_db_handle(struct adapter *priv, struct sk_buff *skb, int method)__nat25_generate_pppoe_network_addr (networkAddr, skb->data, &ph->sid); -__nat25_db_network_insert (priv, skb->data+ETH_ALEN , networkAddr); +__nat25_db_network_insert (priv, skb->data +ETH_ALEN , networkAddr);__nat25_db_print (priv);if (!priv->ethBrExtInfo.addPPPoETag && priv->pppoe_connection_in_progress && - !memcmp (skb->data+ETH_ALEN , priv->pppoe_addr,ETH_ALEN )) + !memcmp (skb->data +ETH_ALEN , priv->pppoe_addr,ETH_ALEN )) priv->pppoe_connection_in_progress =0 ; }return 0 ;
@@ -655,7 +655,7 @@ int nat25_db_handle(struct adapter *priv, struct sk_buff *skb, int method) tagType = (unsigned short )((ptr[0 ] <<8 ) + ptr[1 ]); tagLen = (unsigned short )((ptr[2 ] <<8 ) + ptr[3 ]); -if ((tagType !=ntohs (PTT_RELAY_SID )) || (tagLen < (MAGIC_CODE_LEN +RTL_RELAY_TAG_LEN ))) { +if ((tagType !=ntohs (PTT_RELAY_SID )) || (tagLen < (MAGIC_CODE_LEN +RTL_RELAY_TAG_LEN ))) {DEBUG_ERR ("Invalid PTT_RELAY_SID tag length [%d]!\n" , tagLen);return -1 ; }
@@ -667,18 +667,18 @@ int nat25_db_handle(struct adapter *priv, struct sk_buff *skb, int method)return -1 ; } -memcpy (skb->data, tag->tag_data+MAGIC_CODE_LEN ,ETH_ALEN ); +memcpy (skb->data, tag->tag_data +MAGIC_CODE_LEN ,ETH_ALEN ); -if (tagLen >MAGIC_CODE_LEN +RTL_RELAY_TAG_LEN ) +if (tagLen >MAGIC_CODE_LEN +RTL_RELAY_TAG_LEN ) offset =TAG_HDR_LEN ; -if (skb_pull_and_merge (skb, ptr+offset,TAG_HDR_LEN +MAGIC_CODE_LEN +RTL_RELAY_TAG_LEN -offset) <0 ) { +if (skb_pull_and_merge (skb, ptr + offset,TAG_HDR_LEN +MAGIC_CODE_LEN +RTL_RELAY_TAG_LEN - offset) <0 ) {DEBUG_ERR ("call skb_pull_and_merge() failed in PADO packet!\n" );return -1 ; } - ph->length =htons (ntohs (ph->length)-(TAG_HDR_LEN +MAGIC_CODE_LEN +RTL_RELAY_TAG_LEN -offset)); + ph->length =htons (ntohs (ph->length) - (TAG_HDR_LEN +MAGIC_CODE_LEN +RTL_RELAY_TAG_LEN - offset));if (offset >0 ) - tag->tag_len =htons (tagLen-MAGIC_CODE_LEN -RTL_RELAY_TAG_LEN ); + tag->tag_len =htons (tagLen -MAGIC_CODE_LEN -RTL_RELAY_TAG_LEN );DEBUG_INFO ("NAT25: Lookup PPPoE, forward %s Packet from %s\n" , (ph->code ==PADO_CODE ?"PADO" :"PADS" ), skb->dev->name);
@@ -693,7 +693,7 @@ int nat25_db_handle(struct adapter *priv, struct sk_buff *skb, int method) }else {if (ph->sid !=0 ) {DEBUG_INFO ("NAT25: Lookup PPPoE, lookup session packet from %s\n" , skb->dev->name); -__nat25_generate_pppoe_network_addr (networkAddr, skb->data+ETH_ALEN , &ph->sid); +__nat25_generate_pppoe_network_addr (networkAddr, skb->data +ETH_ALEN , &ph->sid);__nat25_db_network_lookup_and_replace (priv, skb, networkAddr);__nat25_db_print (priv); }else {
@@ -758,7 +758,7 @@ int nat25_db_handle(struct adapter *priv, struct sk_buff *skb, int method)if (memcmp (&iph->saddr,"\x0\x0\x0\x0\x0\x0\x0\x0\x0\x0\x0\x0\x0\x0\x0\x0" ,16 )) {__nat25_generate_ipv6_network_addr (networkAddr, (unsigned int *)&iph->saddr); -__nat25_db_network_insert (priv, skb->data+ETH_ALEN , networkAddr); +__nat25_db_network_insert (priv, skb->data +ETH_ALEN , networkAddr);__nat25_db_print (priv); if (iph->nexthdr == IPPROTO_ICMPV6 &&
@@ -801,9 +801,9 @@ int nat25_handle_frame(struct adapter *priv, struct sk_buff *skb) protocol =be16_to_cpu (*((__be16 *)(skb->data +2 *ETH_ALEN )));if (protocol ==ETH_P_8021Q ) { is_vlan_tag =1 ; - vlan_hdr = *((unsigned short *)(skb->data+ETH_ALEN *2 +2 )); + vlan_hdr = *((unsigned short *)(skb->data +ETH_ALEN *2 +2 ));for (i =0 ; i <6 ; i++) - *((unsigned short *)(skb->data+ETH_ALEN *2 +2 -i*2 )) = *((unsigned short *)(skb->data+ETH_ALEN *2 -2 -i*2 )); + *((unsigned short *)(skb->data +ETH_ALEN *2 +2 - i *2 )) = *((unsigned short *)(skb->data +ETH_ALEN *2 -2 - i *2 ));skb_pull (skb,4 ); }
@@ -815,8 +815,8 @@ int nat25_handle_frame(struct adapter *priv, struct sk_buff *skb)* corresponding network protocol is NOT support. */ if (!priv->ethBrExtInfo.nat25sc_disable && - (be16_to_cpu (*((__be16 *)(skb->data+ETH_ALEN *2 ))) ==ETH_P_IP ) && - !memcmp (priv->scdb_ip, skb->data+ETH_HLEN +16 ,4 )) { + (be16_to_cpu (*((__be16 *)(skb->data +ETH_ALEN *2 ))) ==ETH_P_IP ) && + !memcmp (priv->scdb_ip, skb->data +ETH_HLEN +16 ,4 )) {memcpy (skb->data, priv->scdb_mac,ETH_ALEN );spin_unlock_bh (&priv->br_ext_lock);
@@ -826,10 +826,10 @@ int nat25_handle_frame(struct adapter *priv, struct sk_buff *skb) retval =nat25_db_handle (priv, skb,NAT25_LOOKUP ); } }else { -if (((be16_to_cpu (*((__be16 *)(skb->data+ETH_ALEN *2 ))) ==ETH_P_IP ) && - !memcmp (priv->br_ip, skb->data+ETH_HLEN +16 ,4 )) || - ((be16_to_cpu (*((__be16 *)(skb->data+ETH_ALEN *2 ))) ==ETH_P_ARP ) && - !memcmp (priv->br_ip, skb->data+ETH_HLEN +24 ,4 ))) { +if (((be16_to_cpu (*((__be16 *)(skb->data +ETH_ALEN *2 ))) ==ETH_P_IP ) && + !memcmp (priv->br_ip, skb->data +ETH_HLEN +16 ,4 )) || + ((be16_to_cpu (*((__be16 *)(skb->data +ETH_ALEN *2 ))) ==ETH_P_ARP ) && + !memcmp (priv->br_ip, skb->data +ETH_HLEN +24 ,4 ))) {/* for traffic to upper TCP/IP */ retval =nat25_db_handle (priv, skb,NAT25_LOOKUP ); }
@@ -838,9 +838,9 @@ int nat25_handle_frame(struct adapter *priv, struct sk_buff *skb)if (is_vlan_tag) {skb_push (skb,4 );for (i =0 ; i <6 ; i++) - *((unsigned short *)(skb->data+i*2 )) = *((unsigned short *)(skb->data+4 +i*2 )); - *((__be16 *)(skb->data+ETH_ALEN *2 )) =__constant_htons (ETH_P_8021Q ); - *((unsigned short *)(skb->data+ETH_ALEN *2 +2 )) = vlan_hdr; + *((unsigned short *)(skb->data + i *2 )) = *((unsigned short *)(skb->data +4 + i *2 )); + *((__be16 *)(skb->data +ETH_ALEN *2 )) =__constant_htons (ETH_P_8021Q ); + *((unsigned short *)(skb->data +ETH_ALEN *2 +2 )) = vlan_hdr; }if (retval ==-1 ) {
Signature · 1 line
2.32.0
Thanks! This was very nicely broken up so it was easy to review.
regards,
dan carpenter
Quoted 7 lines · Dan Carpenter
Thanks! This was very nicely broken up so it was easy to review.
Reviewed-by Dan Carpenter <[email protected]>regards,
dan carpenter
Has been merged already. But many thanks for taking the time to review it!
Thanks,
Michael