New: mkpasswd.c:183: pointless test ?
https://bugs.busybox.net/show_bug.cgi?id=10211
Bug ID: 10211
Summary: mkpasswd.c:183: pointless test ?
Product: buildroot
Version: unspecified
Hardware: All
OS: Linux
Status: NEW
Severity: trivial
Priority: P5
Component: Other
Assignee: unassigned at buildroot.uclibc.org
Reporter: dcb314 at hotmail.com
CC: buildroot at uclibc.org
Target Milestone: ---
buildroot-2017.08-rc1/package/mkpasswd/mkpasswd.c:183]: (style) Checking if unsigned variable 'rounds' is less than zero.
Source code is
rounds = strtol(optarg, &p, 10);
if (p == NULL || *p != '\0' || rounds < 0) {Maybe a call to strtoul would be better ?
Signature · 2 lines
You are receiving this mail because: You are on the CC list for the bug.
[Buildroot] [Bug 10211] mkpasswd.c:183: pointless test ?
https://bugs.busybox.net/show_bug.cgi?id=10211
Thomas Petazzoni <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |WONTFIX
Status|NEW |RESOLVED--- Comment #1 from Thomas Petazzoni <[email protected]> --- This code comes from the whois project at
https://github.com/rfc1036/whois/blob/next/mkpasswd.c. If there are any issues, please report them to the upstream project. We can then backport the fix, or upgrade to a newer version.
Signature · 2 lines
You are receiving this mail because: You are on the CC list for the bug.