New: tar file from git repository generation issue
https://bugs.busybox.net/show_bug.cgi?id=13616
Bug ID: 13616
Summary: tar file from git repository generation issue
Product: buildroot
Version: 2020.02.8
Hardware: All
OS: Linux
Status: NEW
Severity: normal
Priority: P5
Component: Other
Assignee: unassigned at buildroot.uclibc.org
Reporter: jpcartal at free.fr
CC: buildroot at uclibc.org
Target Milestone: ---
Created attachment 8791
--> https://bugs.busybox.net/attachment.cgi?id=8791&action=edit
Master branch patch
Hello,
The support/download/git script is generating tar files from git repositories using the following command :
# Create GNU-format tarballs, since that's the format of the tarballs on
# sources.buildroot.org and used in the *.hash files
tar cf - --transform="s#^\./#${basename}/#" \
--numeric-owner --owner=0 --group=0 --mtime="${date}" --format=gnu \
-T "${output}.list.sorted" >"${output}.tar"In one of our repository, the --transform option is generating unusable tar files because of the bug described here :
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=775247
Links with the following pattern src/foo -> ./foo_bar/bar are replaced with src/foo -> ${basename}/foo_bar/bar and thus the generated tarball is not usable.
As explained in the debian bug report, adding the S flag to the transform pattern (i.e. --transform="s#^\./#${basename}/#" => --transform="s#^\./#${basename}/#S") solves this issue.
Attaching the corresponding patches for master and 2020.02.x branches
Regards.
Signature · 2 lines
You are receiving this mail because: You are on the CC list for the bug.
[Buildroot] [Bug 13616] tar file from git repository generation issue
https://bugs.busybox.net/show_bug.cgi?id=13616
--- Comment #1 from Jean-pierre Cartal <[email protected]> --- Created attachment 8796
--> https://bugs.busybox.net/attachment.cgi?id=8796&action=edit
2020.02.x branch patch
Signature · 2 lines
You are receiving this mail because: You are on the CC list for the bug.
[Buildroot] [Bug 13616] tar file from git repository generation issue
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=13616
Jean-pierre Cartal <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|2020.02.8 |2021.02
Signature · 2 lines
You are receiving this mail because: You are on the CC list for the bug.
[Buildroot] [Bug 13616] tar file from git repository generation issue
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=13616
--- Comment #2 from Vincent Fazio <[email protected]> ---
This will potentially cause a rev change in the tarballs generated by both svn and git since hashes are likely to change for affected repositories.
Signature · 2 lines
You are receiving this mail because: You are on the CC list for the bug.
[Buildroot] [Bug 13616] tar file from git repository generation issue
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=13616
Yann E. MORIN <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |yann.morin.1998 at free.fr
Assignee|unassigned at buildroot.uclibc |yann.morin.1998 at free.fr
|.org |
Status|NEW |ASSIGNED--- Comment #3 from Yann E. MORIN <[email protected]> --- Jean-Pierre, All,
Thanks for the report.
The use of --transform (in the current form or similar) has been introduced in commit 6d938bcb5249 in 2018-04-02, and although we had a few fixups over the following days, it has stayed like that ever since, until we introduced the current generic helper, that reuses that exact same --transform pattern.
So, is this a new behaviour on your side, or is it a new package you are introducing?
In any case, the use of the 'S' flag does indeed make sense.
Can you submit your patches to the mailing list, please?
Regards,
Yann E. MORIN.
Signature · 2 lines
You are receiving this mail because: You are on the CC list for the bug.
[Buildroot] [Bug 13616] tar file from git repository generation issue
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=13616
--- Comment #4 from Jean-pierre Cartal <[email protected]> --- (In reply to Yann E. MORIN from comment #3)
Yann,
I think this is not a new behaviour, neither a new package, but up to now we've been using the OVERRIDE_SRCDIR mechanism to generate binary tar files that were then used as part of the build. We just tried to make a full build from sources with this package and ended up hitting the reported issue.
I'll submit the patches to the mailing list as soon as possible.
Regards.
Signature · 2 lines
You are receiving this mail because: You are on the CC list for the bug.
[Buildroot] [Bug 13616] tar file from git repository generation issue
In reply to bugzilla at busybox.nethttps://bugs.busybox.net/show_bug.cgi?id=13616
Peter Korsgaard <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED--- Comment #5 from Peter Korsgaard <[email protected]> --- Fixed in git by
https://git.buildroot.org/buildroot/commit/?id=c9f27fdc1bf36da745218cec6722a3d09c2bcd3b
and
https://git.buildroot.org/buildroot/commit/?h=2020.02.x&id=7d377e1f449e36f2756255cc528ebff5ea96e568
thanks.
Signature · 2 lines
You are receiving this mail because: You are on the CC list for the bug.