New: c-stack.c:55:26: error: missing binary operator before token "("

https://bugs.busybox.net/show_bug.cgi?id=13721

Bug ID: 13721
Summary: c-stack.c:55:26: error: missing binary operator before
token "("
Product: buildroot
Version: unspecified
Hardware: All
OS: Linux
Status: NEW
Severity: normal
Priority: P5
Component: Other
Assignee: unassigned at buildroot.uclibc.org
Reporter: stsp2 at yandex.ru
CC: buildroot at uclibc.org
Target Milestone: ---

Tried to compile buildroot from git:

$ make pc_x86_64_efi_defconfig
$ make -j 9

PATH="/home/stas/src/fdpp/buildroot/output/host/bin:/home/stas/src/fdpp/buildroot/output/host/sbin:/home/stas/.local/bin:/home/stas/.local/bin:/home/stas/.local/bin:/usr/lib64/qt-3.3/bin:/usr/share/Modules/bin:/usr/kerberos/bin:/usr/local/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/home/stas/bin" PKG_CONFIG="/home/stas/src/fdpp/buildroot/output/host/bin/pkg-config"
PKG_CONFIG_SYSROOT_DIR="/" PKG_CONFIG_ALLOW_SYSTEM_CFLAGS=1
PKG_CONFIG_ALLOW_SYSTEM_LIBS=1
PKG_CONFIG_LIBDIR="/home/stas/src/fdpp/buildroot/output/host/lib/pkgconfig:/home/stas/src/fdpp/buildroot/output/host/share/pkgconfig"
/usr/bin/make -j9 -C
/home/stas/src/fdpp/buildroot/output/build/host-m4-1.4.18/
/usr/bin/make all-recursive
Making all in .
make[4]: Nothing to be done for 'all-am'.
Making all in examples
make[4]: Nothing to be done for 'all'.
Making all in lib
/usr/bin/make all-am

  CC       c-stack.o
  CC       execute.o
  CC       fd-safer-flag.o
  CC       fatal-signal.o
  CC       exitfail.o
  CC       fd-hook.o
  CC       filenamecat.o
  CC       stripslash.o
  CC       dup-safer-flag.o
  CC       filenamecat-lgpl.o
In file included from /usr/include/signal.h:315,
                 from ./signal.h:52,
                 from c-stack.c:49:
c-stack.c:55:26: error: missing binary operator before token "("
   55 | #elif HAVE_LIBSIGSEGV && SIGSTKSZ < 16384
      |                          ^~~~~~~~

c-stack.c:134:8: error: variably modified 'buffer'@file scope
134 | char buffer[SIGSTKSZ];

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=13721

--- Comment #1 from Fabrice Fontaine <[email protected]> --- Created attachment 8886
--> https://bugs.busybox.net/attachment.cgi?id=8886&action=edit
Patch

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=13721

--- Comment #2 from Fabrice Fontaine <[email protected]> --- This is a known issue with m4/gnulib and glibc 2.34, can you confirm that attached patch is fixing your issue?

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=13721

--- Comment #3 from Fabrice Fontaine <[email protected]> --- This second iteration should be better.

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=13721

--- Comment #4 from Fabrice Fontaine <[email protected]> --- Created attachment 8891
--> https://bugs.busybox.net/attachment.cgi?id=8891&action=edit
Second iteration

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=13721

Fabrice Fontaine <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

   Attachment #8886|0                           |1

is obsolete| |

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=13721

--- Comment #5 from stsp <[email protected]> ---
Created attachment 8896
--> https://bugs.busybox.net/attachment.cgi?id=8896&action=edit
The patch that I googled

Hi.

Your patch doesn't work as-is (or at least I don't know how), but after I extracted 0003-c-stack-stop-using-SIGSTKSZ.patch out of it, it worked.
Your original patch only creates another patch file, maybe that's on purpose, I just don't know how to utilize it in that form.

In any case, I already googled out another patch, which I now attach here.
Pleas let me know which one is "better".

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=13721

--- Comment #6 from stsp <[email protected]> ---
OK, I realized that your patch is
against buildroot as a whole, whereas
I put the patches to BR2_EXTERNAL, on
a per-package basis.

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=13721

--- Comment #7 from Fabrice Fontaine <[email protected]> --- Ok thanks for your feedback.
We could use the patch that you googled but you'll have to provide some link to allow me to find the author as we can't add a patch that don't have a "Signed-off-by" to buildroot (due to license concerns)
Otherwise, if my patch also is working fine, I can submit it on the mailing list, and hopefully it should be merged.

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=13721

--- Comment #8 from stsp <[email protected]> ---
Its here:
https://lists.gnu.org/archive/html/bug-m4/2021-03/txtXNCmNj0dPI.txt
https://lists.gnu.org/archive/html/bug-m4/2021-03/msg00024.html

You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.busybox.net/show_bug.cgi?id=13721

Thomas Petazzoni <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #9 from Thomas Petazzoni <[email protected]> --- Fixed by
https://git.buildroot.org/buildroot/commit/?id=5a9504831f3fa1ef3be334036c93da30150fde55.
Thanks!

You are receiving this mail because:
You are on the CC list for the bug.