Skip to contentSkip to conversation

Regression: vdev device not setup in secondary process

DPDK/core Bug 1450 [email protected] 1 participant 2 messages May 31, 2024 – Jul 30, 2024

lore
Share & tools
lore

[email protected]

author Acked-by Anatoly Burakov
#0 lore raw

https://bugs.dpdk.org/show_bug.cgi?id=1450

            Bug ID: 1450
           Summary: Regression: vdev device not setup in secondary process
           Product: DPDK
           Version: 24.03
          Hardware: All
                OS: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: Normal
         Component: core
          Assignee: [email protected]
          Reporter: [email protected]

Target Milestone: ---

If I run testpmd as primary and dumpcap as secondary process with a vdev (null, tap, etc). The the vdev device is not setup in the secondary process.

Example:

# ./build/app/dpdk-dumpcap  -D
EAL: Detected CPU lcores: 8
EAL: Detected NUMA nodes: 1
EAL: Detected static linkage of DPDK
EAL: Multi-process socket /var/run/dpdk/rte/mp_socket_51860_420642a7f63
vdev_action(): failed to add vdev, net_null0

This works with 23.11 and earlier releases and is a regression. Not only is this a regression bug, it shows a short coming in the CI system for not catching it.

Bisection reveals the commit causing the regression is:

commit 6666628362c94a0b567a39a0177539c12c97d999

Author: Mingjin Ye <[email protected]>
Date:   Fri Sep 1 07:24:09 2023 +0000

bus/vdev: fix devargs in secondary process

When a device is created by a secondary process, an empty devargs is temporarily generated and bound to it. This causes the device to not be associated with the correct devargs, and the empty devargs are not released when the resource is freed.

This patch fixes the issue by matching the devargs when inserting a device in secondary process.

Fixes dda987315ca2 ("vdev: make virtual bus use its device struct")
Fixes a16040453968 ("eal: extract vdev infra")
Cc [email protected]
Signed-off-by Mingjin Ye <[email protected]>
Acked-by Anatoly Burakov <[email protected]>
Signature · 2 lines
You are receiving this mail because:
You are the assignee for the bug.
author
#1 lore raw

https://bugs.dpdk.org/show_bug.cgi?id=1450

Thomas Monjalon ([email protected]) changed:

What |Removed |Added
----------------------------------------------------------------------------

             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Thomas Monjalon ([email protected]) --- Resolved in http://git.dpdk.org/dpdk/commit/?id=22ce39b3aa

Signature · 2 lines
You are receiving this mail because:
You are the assignee for the bug.