Skip to contentSkip to conversation

New: post-build.sh PC grub config

Buildroot [email protected] 1 participant 2 messages Jan 11, 2023 – Jan 28, 2023

lore
Share & tools
lore
#0 lore raw

https://bugs.busybox.net/show_bug.cgi?id=15241

            Bug ID: 15241
              Host: x86 PC with bios OR x86 PC with efi
             Build: Ubuntu 22 X86_64
           Summary: post-build.sh PC grub config
           Product: buildroot
           Version: 2022.11
          Hardware: PC
               URL: https://github.com/buildroot/buildroot/pull/121
                OS: Linux
            Status: NEW
          Keywords: FIXME
          Severity: normal
          Priority: P5
         Component: Other
          Assignee: [email protected]
          Reporter: [email protected]
                CC: [email protected]

Target Milestone: ---

Hello.

I think user can select BR2_TARGET_GRUB2_I386_EFI OR BR2_TARGET_GRUB2_I386_PC but not both. At this moment if user select both, post-build.sh ignore BR2_TARGET_GRUB2_I386_PC case.

Also please see my commits https://github.com/buildroot/buildroot/pull/121 I also provide git patches via email, but still waiting answer.

Signature · 6 lines
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

[Buildroot] [Bug 15241] post-build.sh PC grub config

https://bugs.busybox.net/show_bug.cgi?id=15241

Thomas Petazzoni <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

             Status|NEW                         |RESOLVED
         Resolution|---                         |WONTFIX

--- Comment #1 from Thomas Petazzoni <[email protected]> --- Which post-build.sh script are you talking about?

post-build.sh scripts provided in Buildroot upstream are bound to a specific defconfig. They are not meant to be generic and valid for all situations.

If we assume that you're talking about ./board/pc/post-build.sh, then this script is used by configs/pc_x86_64_bios_defconfig (which enables BR2_TARGET_GRUB2_I386_PC=y) and by configs/pc_x86_64_efi_defconfig (which enables BR2_TARGET_GRUB2_X86_64_EFI=y).

Therefore, this post-build.sh script is never used in a situation where both BR2_TARGET_GRUB2_I386_PC and BR2_TARGET_GRUB2_I386_EFI are used. Consequently, there is no bug.

If you create your own defconfig, which enables both BR2_TARGET_GRUB2_I386_EFI and BR2_TARGET_GRUB2_I386_PC, you need to provide your own post-build.sh script.

Signature · 6 lines
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot