Skip to contentSkip to conversation

New: QuickJS binaries in `/usr/local/bin` (instead of `/usr/bin`)

Buildroot [email protected] 1 participant 2 messages Jun 17, 2024

lore
Share & tools
lore
#0 lore raw

https://bugs.busybox.net/show_bug.cgi?id=16111

            Bug ID: 16111
           Summary: QuickJS binaries in `/usr/local/bin` (instead of
                    `/usr/bin`)
           Product: buildroot
           Version: 2024.05
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Other
          Assignee: [email protected]
          Reporter: [email protected]
                CC: [email protected]

Target Milestone: ---

After BuildRoot has updated QuickJS to version 2024-01-13, now QuickJS installs it's binaries under /usr/local/bin as opposed to /usr/bin (as it was before the update of QuickJS release).

Apparently the BuildRoot quickjs.mk script uses prefix=/usr, but the latest QuickJS makefile seems to expect PREFIX=/usr.

The following minor patch solves the issue:
~~~~

package/quickjs/quickjs.mk +2 -2
@@ -22,25 +22,25 @@ define QUICKJS_BUILD_CMDS
        EXTRA_LIBS="$(QUICKJS_EXTRA_LIBS)" \
        all
 endef
 
 define QUICKJS_INSTALL_STAGING_CMDS
    $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) \
        CROSS_PREFIX="$(TARGET_CROSS)" \
        EXTRA_LIBS="$(QUICKJS_EXTRA_LIBS)" \
        DESTDIR=$(STAGING_DIR) \
        STRIP=/bin/true \
-       prefix=/usr \
+       PREFIX=/usr \
        install
 endef
 
 define QUICKJS_INSTALL_TARGET_CMDS
    $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) \
        CROSS_PREFIX="$(TARGET_CROSS)" \
        EXTRA_LIBS="$(QUICKJS_EXTRA_LIBS)" \
        DESTDIR=$(TARGET_DIR) \
        STRIP=/bin/true \
-       prefix=/usr \
+       PREFIX=/usr \
        install
 endef
 
 $(eval $(generic-package))

~~~~

Signature · 6 lines
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

[Buildroot] [Bug 16111] QuickJS binaries in `/usr/local/bin` (instead of `/usr/bin`)

https://bugs.busybox.net/show_bug.cgi?id=16111

Yann E. MORIN <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

                 CC|                            |[email protected]
             Status|NEW                         |RESOLVED
         Resolution|---                         |MOVED

--- Comment #1 from Yann E. MORIN <[email protected]> --- Thank you for your report.

The issue tracker for the Buildroot project has been moved to the Gitlab.com issue tracker:
https://gitlab.com/buildroot.org/buildroot/-/issues

Please open an issue there.

Thank you!

Signature · 6 lines
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot