Skip to contentSkip to conversation

New: Xtensa architecrute port

Buildroot bugzilla at busybox.net 4 participants 18 messages Mar 9, 2009 – Jul 24, 2009

lore
Share & tools
lore
#0 lore raw

https://bugs.busybox.net/show_bug.cgi?id=163

Host: GNU/Linux X86
Target: Xtensa
Build: current
Summary: Xtensa architecrute port
Product: buildroot
Version: unspecified
Platform: PC
OS/Version: Linux
Status: NEW
Severity: enhancement
Priority: P3
Component: Other
AssignedTo: unassigned at buildroot.uclibc.org
ReportedBy: maxim2405 at gmail.com
CC: buildroot at uclibc.org
Estimated Hours: 0.0

I would like to submit an Xtensa architecture port to BUILDROOT repository. The submission assumes a set of patches. Most of them are architecture-specific.

Xtensa is a family of configurable and extensible processors, which have been on the IP market for quite some time now. For those of you who are interested, please, look at

http://www.tensilica.com/

Maxim Grigoriev

Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
#1 lore raw

[Buildroot] [Bug 163] Xtensa architecrute port

https://bugs.busybox.net/show_bug.cgi?id=163

--- Comment #1 from Maxim Grigoriev <[email protected]> 2009-03-09 20:22:16 UTC --- Created an attachment (id=115)
--> (https://bugs.busybox.net/attachment.cgi?id=115)
This is the first patch in a set of Xtensa port patches

Xtensa BUILDROOT uses a concept of source overlays, which are necessary because Xtensa processors are configurable and extensible. Xtensa tools, e.g. gcc, gdb, and binutils, use source overlays, which can not be substituted by the current BUILDROOT patching mechanism. This update makes patch-kernel.sh script capable of handling these overlays.

Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
#2 lore raw

[Buildroot] [Bug 163] Xtensa architecture port

In reply to bugzilla at busybox.net

https://bugs.busybox.net/show_bug.cgi?id=163

Maxim Grigoriev <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------
Summary|Xtensa architecrute port |Xtensa architecture port

Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
#3 lore raw

[Buildroot] [Bug 163] Xtensa architecture port

In reply to bugzilla at busybox.net

https://bugs.busybox.net/show_bug.cgi?id=163

Bernhard <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

              Build|current                     |
               Host|GNU/Linux X86               |
             Target|Xtensa                      |xtensa-*-*

--- Comment #2 from Bernhard <[email protected]> 2009-03-10 16:09:34 UTC --- Host, Target, Build are the respective triplets.

Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
#4 lore raw

[Buildroot] [Bug 163] Xtensa architecture port

In reply to bugzilla at busybox.net

https://bugs.busybox.net/show_bug.cgi?id=163

--- Comment #3 from Bernhard <[email protected]> 2009-03-10 16:14:23 UTC --- First, there are superfluous trailing ';' chars in your patch.

Does this:
+ uncomp="tar cf - --exclude=.svn --no-anchored -C";
work with busybox's tar?

What is "uparm" ment to be? Please use a more descriptive name.

Last, can you give some examples that show why you need these changes?

Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
#5 lore raw

[Buildroot] [Bug 163] Xtensa architecture port

In reply to bugzilla at busybox.net

https://bugs.busybox.net/show_bug.cgi?id=163

--- Comment #4 from Maxim Grigoriev <[email protected]> 2009-03-10 22:46:01 UTC --- Created an attachment (id=131)
--> (https://bugs.busybox.net/attachment.cgi?id=131)
Improved and extended patch for patch-kernal.sh and toolchain Makefiles

Quoted 1 line
Quoted 1 line

--- Comment #3 from Bernhard <[email protected]> 2009-03-10 16:14:23 UTC ---

Thanks much for your comments, Bernhard.
I've attached a new extended patch. I made it more self-explanatory and consistent by adding binutils/gcc/gdb Makefiles' updates related to our toolchain/patch-kernel.sh changes.

Quoted 1 line
Quoted 1 line

First, there are superfluous trailing ';' chars in your patch.

Removed.

Quoted 3 lines
Quoted 3 lines

Does this:
+ uncomp="tar cf - --exclude=.svn --no-anchored -C";
work with busybox's tar?

Given that busybox tar is 1.18, I say "Yes". It works.
I was not able to build my busybox TAR package because of the build errors. But, I checked it on my x86-linux box after installing GNU/TAR 1.18.

Quoted 1 line
Quoted 1 line

What is "uparm" meant to be? Please use a more descriptive name.

It's been replaced by "uncomp_parm" in the new patch.

Quoted 1 line
Quoted 1 line

Last, can you give some examples that show why you need these changes?

Applying Xtensa source overlays could be done without changing patch-kernel.sh, but they would result in much more extensive changes to other Makefiles. This change to patch-kernel.sh is the simplest and most elegant way we found of applying source overlays. It simply expands patch-kernel.sh to handle tar files, and thus patch not just files, but also source trees.

Isn't it nice ? Can other BUILDROOT users find it useful ?

An example might be Xtensa overlay support for GDB. With this change to patch-kernel.sh, all we needed to edit in toolchain/gdb/gdb.mk was to add a conditional include:

  ifneq ($(filter xtensa%,$(ARCH)),)
  include target/xtensa/patch.in
  GDB_PATCH_EXTRA:=$(call XTENSA_PATCH,gdb,$(GDB_PATCH_DIR),. ..)
  endif

and add $(GDB_PATCH_EXTRA) to the list of what patch-kernel.sh patches:

< toolchain/patch-kernel.sh $(GDB_DIR) $(GDB_PATCH_DIR) \*.patch
--

Quoted 1 line
     toolchain/patch-kernel.sh $(GDB_DIR) $(GDB_PATCH_DIR) \*.patch

$(GDB_PATCH_EXTRA)

The alternative is to add an Xtensa-specific line(s) to the gdb-unpacked rule, which didn't seem quite as kosher.

Thanks,
-- Maxim

Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
#6 lore raw

[Buildroot] [Bug 163] Xtensa architecture port

In reply to bugzilla at busybox.net

https://bugs.busybox.net/show_bug.cgi?id=163

Maxim Grigoriev <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------
Target|xtensa-*-* |xtensa*-*-*

Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
#7 lore raw

[Buildroot] [Bug 163] Xtensa architecture port

In reply to bugzilla at busybox.net

https://bugs.busybox.net/show_bug.cgi?id=163

--- Comment #5 from Maxim Grigoriev <[email protected]> 2009-05-09 00:05:55 UTC --- Created an attachment (id=299)
--> (https://bugs.busybox.net/attachment.cgi?id=299)
Add Xtensa support to the top Buildroot Makefile

Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
#8 lore raw

[Buildroot] [Bug 163] Xtensa architecture port

In reply to bugzilla at busybox.net

https://bugs.busybox.net/show_bug.cgi?id=163

--- Comment #6 from Maxim Grigoriev <[email protected]> 2009-05-09 00:06:40 UTC --- Created an attachment (id=301)
--> (https://bugs.busybox.net/attachment.cgi?id=301)
Add Xtensa support to Buildroot uClibc

Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
#9 lore raw

[Buildroot] [Bug 163] Xtensa architecture port

In reply to bugzilla at busybox.net

https://bugs.busybox.net/show_bug.cgi?id=163

--- Comment #7 from Maxim Grigoriev <[email protected]> 2009-05-09 00:18:20 UTC --- Created an attachment (id=303)
--> (https://bugs.busybox.net/attachment.cgi?id=303)
Add Xtensa to Buildroot projects

Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
#10 lore raw

[Buildroot] [Bug 163] Xtensa architecture port

In reply to bugzilla at busybox.net

https://bugs.busybox.net/show_bug.cgi?id=163

--- Comment #8 from Maxim Grigoriev <[email protected]> 2009-05-09 01:29:30 UTC --- Created an attachment (id=305)
--> (https://bugs.busybox.net/attachment.cgi?id=305)
Add Xtensa target to Buildroot

The list of files added/updated :

target/Config.in.arch
target/Makefile.in
target/xtensa/...
target/device/Config.in
target/device/xtensa/...

Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
#11 lore raw

[Buildroot] [Bug 163] Xtensa architecture port

In reply to bugzilla at busybox.net

https://bugs.busybox.net/show_bug.cgi?id=163

--- Comment #9 from Maxim Grigoriev <[email protected]> 2009-05-09 01:59:06 UTC --- Created an attachment (id=307)
--> (https://bugs.busybox.net/attachment.cgi?id=307)
Add Xtensa to Buildroot packages

Touches

package/gnuconfig/...
package/Makefile.in

Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
#12 lore raw

[Buildroot] [Bug 163] Xtensa architecture port

Hello Buildroot maintainers and developers,

Last Friday, I finished submitting Xtensa Buildroot support :
All the patches are attached to

    https://bugs.busybox.net/show_bug.cgi?id=163

Can anybody, please, give me a clue on how good the chances are these patches will be reviewed anytime soon ?

Thanks,
-- Maxim

#13 lore raw

[Buildroot] [Bug 163] Xtensa architecture port

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Maxim" == Maxim Grigoriev <[email protected]> writes:

Maxim> Hello Buildroot maintainers and developers,
Maxim> Last Friday, I finished submitting Xtensa Buildroot support :
Maxim> All the patches are attached to

Maxim> https://bugs.busybox.net/show_bug.cgi?id=163

Maxim> Can anybody, please, give me a clue on how good the chances are Maxim> these patches will be reviewed anytime soon ?

Sorry for the slow response on this. We're right now busy getting 2009.05 released, but I'll commit the patches once that's out unless someone complains..

Signature · 1 line
Bye, Peter Korsgaard
#14 lore raw

[Buildroot] [Bug 163] Xtensa architecture port

Quoted 8 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Maxim" == Maxim Grigoriev <[email protected]> writes:

Maxim> Hello Buildroot maintainers and developers,
Maxim> Last Friday, I finished submitting Xtensa Buildroot support :
Maxim> All the patches are attached to

Maxim> https://bugs.busybox.net/show_bug.cgi?id=163

Quoted 7 lines

Maxim> Can anybody, please, give me a clue on how good the
chances are
Maxim> these patches will be reviewed anytime soon ?

Sorry for the slow response on this. We're right now busy getting 2009.05 released, but I'll commit the patches once that's out unless someone complains..

Cool, thank you!

-Marc

#16 lore raw

[Buildroot] [Bug 163] Xtensa architecture port

In reply to bugzilla at busybox.net

https://bugs.busybox.net/show_bug.cgi?id=163

--- Comment #11 from Thomas Petazzoni <[email protected]> 2009-07-24 08:53:40 UTC --- Peter, I don't think you committed the Xtensa support. Probably your comment
was related to another bug entry ?

Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
#17 lore raw

[Buildroot] [Bug 163] Xtensa architecture port

In reply to bugzilla at busybox.net

https://bugs.busybox.net/show_bug.cgi?id=163

Peter Korsgaard <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #12 from Peter Korsgaard <[email protected]> 2009-07-24 12:50:12 UTC --- (In reply to comment #11)

Quoted 2 lines

Peter, I don't think you committed the Xtensa support. Probably your comment was related to another bug entry ?

ehh, no - I committed the 6 patches this morning. The last one is

http://git.buildroot.net/buildroot/commit/?id=edb5ca9c529804c449a5ff3a11607bd26eef394b

Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.