Skip to contentSkip to conversation

New: [PATCH] mplayer: convert to autotools infrastructure

Buildroot New bugzilla at busybox.net 1 participant 11 messages May 10, 2010 – Dec 14, 2010

lore
Share & tools
lore
#0 lore raw

https://bugs.busybox.net/show_bug.cgi?id=1735

Host: Kubuntu 9.10
Target: armv4
Summary: [PATCH] mplayer: convert to autotools infrastructure
Product: buildroot
Version: unspecified
Platform: PC
OS/Version: Linux
Status: NEW
Severity: minor
Priority: P5
Component: Other
AssignedTo: unassigned at buildroot.uclibc.org
ReportedBy: keguang.zhang at gmail.com
CC: buildroot at uclibc.org
Estimated Hours: 0.0

Created attachment 1711
--> https://bugs.busybox.net/attachment.cgi?id=1711
Convert mplayer to autotools infrastructure

Convert mplayer to autotools infrastructure.

Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
#1 lore raw

PATCH 1/1 mplayer: convert to autotools infrastructure

https://bugs.busybox.net/show_bug.cgi?id=1735

--- Comment #1 from Thomas Petazzoni <[email protected]> --- Don't set MPLAYER_CONFIGURE_CMDS but use MPLAYER_CONF_OPT instead. Remember that most ./configure options (prefix, etc.) are already passed. You just need to pass options that are specific to the package.

Here too I'd like to make sure that MPLAYER_INSTALL_TARGET_OPT is needed.

Thanks!

Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
#2 lore raw

PATCH 1/1 mplayer: convert to autotools infrastructure

In reply to bugzilla at busybox.net

https://bugs.busybox.net/show_bug.cgi?id=1735

--- Comment #2 from Peter Korsgaard <[email protected]> --- (In reply to comment #1)

Quoted 3 lines

Don't set MPLAYER_CONFIGURE_CMDS but use MPLAYER_CONF_OPT instead. Remember that most ./configure options (prefix, etc.) are already passed. You just need to pass options that are specific to the package.

Careful though, mplayer uses (or atleast used to use) a handwritten configure script, E.G. no autotools - And in the past it would error out on unknown configure args.

Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
#3 lore raw

PATCH 1/1 mplayer: convert to autotools infrastructure

In reply to bugzilla at busybox.net

https://bugs.busybox.net/show_bug.cgi?id=1735

--- Comment #3 from Gustavo Zacarias <[email protected]> --- We should really use a newer version, 1.0rc2 is very old, has security bugs and lacks newer optimizations (neon for example).
That said they haven't released tarballs in a while now so it would be snapshot-based (svn).

Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
#4 lore raw

PATCH 1/1 mplayer: convert to autotools infrastructure

In reply to bugzilla at busybox.net

https://bugs.busybox.net/show_bug.cgi?id=1735

--- Comment #4 from Thomas Petazzoni <[email protected]> --- If mplayer doesn't use the autotools, then please do not use AUTOTARGETS but GENTARGETS instead (see the Buildroot documentation for details). A short comment explaining why GENTARGETS is used instead of AUTOTARGETS would be fine (so that in the future we don't ask ourselves why the hell this package is doing ./configure and not using AUTOTARGETS).

Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
#5 lore raw

PATCH 1/1 mplayer: convert to autotools infrastructure

In reply to bugzilla at busybox.net

https://bugs.busybox.net/show_bug.cgi?id=1735

--- Comment #5 from Peter Korsgaard <[email protected]> --- (In reply to comment #3)

Quoted 4 lines

We should really use a newer version, 1.0rc2 is very old, has security bugs and lacks newer optimizations (neon for example).
That said they haven't released tarballs in a while now so it would be snapshot-based (svn).

Even though it isn't the newest sw, 1.0rc3 was released last week.

http://www.mplayerhq.hu/design7/news.html#mplayer10rc3

Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
#6 lore raw

PATCH 1/1 mplayer: convert to autotools infrastructure

In reply to bugzilla at busybox.net

https://bugs.busybox.net/show_bug.cgi?id=1735

Kelvin Cheung <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

   Attachment #1711|0                           |1

is obsolete| |

--- Comment #6 from Kelvin Cheung <[email protected]> --- Created attachment 1963
--> https://bugs.busybox.net/attachment.cgi?id=1963
convert mplayer to generic package infrastructure

Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
#7 lore raw

PATCH 1/1 mplayer: convert to autotools infrastructure

In reply to bugzilla at busybox.net

https://bugs.busybox.net/show_bug.cgi?id=1735

--- Comment #7 from Kelvin Cheung <[email protected]> --- Created attachment 1969
--> https://bugs.busybox.net/attachment.cgi?id=1969
convert mplayer to generic package infrastructure and bump to version 1.0rc3

Here is 1.0rc3.
But I don't know how to deal with the rc2 patches.

Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
#8 lore raw

PATCH 1/1 mplayer: convert to autotools infrastructure

In reply to bugzilla at busybox.net

https://bugs.busybox.net/show_bug.cgi?id=1735

Thomas Petazzoni <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|2010.05 |2010.11

--- Comment #8 from Thomas Petazzoni <[email protected]> --- That's something we're going to handle post 2010.08, I think.

Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
#9 lore raw

PATCH 1/1 mplayer: convert to autotools infrastructure

In reply to bugzilla at busybox.net

https://bugs.busybox.net/show_bug.cgi?id=1735

Thomas Petazzoni <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------
Severity|minor |enhancement

Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
#10 lore raw

PATCH 1/1 mplayer: convert to autotools infrastructure

In reply to bugzilla at busybox.net

https://bugs.busybox.net/show_bug.cgi?id=1735

Thomas Petazzoni <[email protected]> changed:

What |Removed |Added
----------------------------------------------------------------------------

             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #9 from Thomas Petazzoni <[email protected]> --- Fixed by
http://git.buildroot.net/buildroot/commit/?id=6bcedeed375c3504d4d6f82fca020790866e2c6e

Signature · 3 lines
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.