net/cnxk: identincal code in branches

https://bugs.dpdk.org/show_bug.cgi?id=1739

Bug ID: 1739
Summary: net/cnxk: identincal code in branches
Product: DPDK
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: minor
Priority: Normal
Component: ethdev
Assignee: [email protected]
Reporter: [email protected]
Target Milestone: ---

Enabling compiler flag to detect identical branches in conditional finds:

[228/3418] Compiling C object drivers/libtmp_rte_common_cnxk.a.p/common_cnxk_roc_cpt.c.o ../drivers/common/cnxk/roc_cpt.c: In function ‘cpt_get_blkaddr’:
../drivers/common/cnxk/roc_cpt.c:677:12: warning: this condition has identical branches [-Wduplicated-branches]
677 | if (dev_is_vf(dev))
| ^

uint64_t
cpt_get_blkaddr(struct dev *dev)

{
        uint64_t reg;
        uint64_t off;

        /* Reading the discovery register to know which CPT is the LF
         * attached to. Assume CPT LF's of only one block are attached
         * to a pffunc.
         */
        if (dev_is_vf(dev))
                off = RVU_VF_BLOCK_ADDRX_DISC(RVU_BLOCK_ADDR_CPT1);
        else
                off = RVU_PF_BLOCK_ADDRX_DISC(RVU_BLOCK_ADDR_CPT1);

And many more.

[243/3418] Compiling C object drivers/libtmp_rte_common_cnxk.a.p/common_cnxk_roc_nix_inl_dev.c.o ../drivers/common/cnxk/roc_nix_inl_dev.c: In function ‘nix_inl_nix_setup’:
../drivers/common/cnxk/roc_nix_inl_dev.c:833:17: warning: this condition has identical branches [-Wduplicated-branches]
833 | else if (roc_model_is_cn10k())
| ^
[246/3418] Compiling C object drivers/libtmp_rte_common_cnxk.a.p/common_cnxk_roc_nix_inl.c.o ../drivers/common/cnxk/roc_nix_inl.c: In function ‘nix_inl_inb_ipsec_sa_tbl_setup’:
../drivers/common/cnxk/roc_nix_inl.c:426:17: warning: this condition has identical branches [-Wduplicated-branches]
426 | else if (roc_model_is_cn10k())
| ^
../drivers/common/cnxk/roc_nix_inl.c: In function ‘nix_inl_eng_caps_get’:
../drivers/common/cnxk/roc_nix_inl.c:1215:12: warning: this condition has identical branches [-Wduplicated-branches]
1215 | if (roc_model_is_cn9k() || roc_model_is_cn10k())
| ^
../drivers/common/cnxk/roc_nix_inl.c: In function ‘roc_nix_inl_outb_init’:
../drivers/common/cnxk/roc_nix_inl.c:1616:17: warning: this condition has identical branches [-Wduplicated-branches]
1616 | else if (roc_model_is_cn10k())
| ^
[260/3418] Compiling C object drivers/libtmp_rte_common_cnxk.a.p/common_cnxk_roc_nix_queue.c.o ../drivers/common/cnxk/roc_nix_queue.c: In function ‘roc_nix_cq_init’:
../drivers/common/cnxk/roc_nix_queue.c:1290:90: warning: this condition has identical branches [-Wduplicated-branches]
1290 | cq_ctx->lbp_frac = force_tail_drop ?
NIX_CQ_LBP_THRESH_FRAC_REF1 :

      |

You are receiving this mail because:
You are the assignee for the bug.