net/zxdh shadowed declarations

https://bugs.dpdk.org/show_bug.cgi?id=1782

            Bug ID: 1782
           Summary: net/zxdh shadowed declarations
           Product: DPDK
           Version: 25.07
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: ethdev
          Assignee: [email protected]
          Reporter: [email protected]

Target Milestone: ---

Compiling DPDK with -Wshadow causes additional warnings about potential issues caused by duplicate shadow declarations. One driver with issues is net/zxdh.

[1528/3627] Compiling C object drivers/libtmp_rte_net_zxdh.a.p/net_zxdh_zxdh_msg.c.o In file included from ../drivers/net/zxdh/zxdh_msg.h:14,

                 from ../drivers/net/zxdh/zxdh_msg.c:17:

../drivers/net/zxdh/zxdh_msg.c: In function ‘zxdh_add_vf_mac_table’:
../drivers/net/zxdh/zxdh_common.h:94:18: warning: declaration of ‘addr’ shadows a previous local [-Wshadow]
94 | uint8_t *addr = ZXDH_ADDR_OF(typ, p, fld); \
| ^~~~
../drivers/net/zxdh/zxdh_msg.c:1441:17: note: in expansion of macro ‘ZXDH_SET’
1441 | ZXDH_SET(mac_reply_msg, mac_reply_msg_addr, mac_flag,

ZXDH_EEXIST_MAC_FLAG);
      |                 ^~~~~~~~

../drivers/net/zxdh/zxdh_msg.c:1428:32: note: shadowed declaration is here
1428 | struct rte_ether_addr *addr = &mac_filter->mac;
| ^~~~
../drivers/net/zxdh/zxdh_common.h:94:18: warning: declaration of ‘addr’ shadows a previous local [-Wshadow]
94 | uint8_t *addr = ZXDH_ADDR_OF(typ, p, fld); \
| ^~~~
../drivers/net/zxdh/zxdh_msg.c:1462:9: note: in expansion of macro ‘ZXDH_SET’

 1462 |         ZXDH_SET(msg_reply_body, reply_body, flag, ZXDH_REPS_SUCC);
      |         ^~~~~~~~

../drivers/net/zxdh/zxdh_msg.c:1428:32: note: shadowed declaration is here
1428 | struct rte_ether_addr *addr = &mac_filter->mac;
| ^~~~
../drivers/net/zxdh/zxdh_common.h:94:18: warning: declaration of ‘addr’ shadows a previous local [-Wshadow]
94 | uint8_t *addr = ZXDH_ADDR_OF(typ, p, fld); \
| ^~~~
../drivers/net/zxdh/zxdh_msg.c:1468:9: note: in expansion of macro ‘ZXDH_SET’

 1468 |         ZXDH_SET(msg_reply_body, reply_body, flag, ZXDH_REPS_FAIL);
      |         ^~~~~~~~

../drivers/net/zxdh/zxdh_msg.c:1428:32: note: shadowed declaration is here
1428 | struct rte_ether_addr *addr =

You are receiving this mail because:
You are the assignee for the bug.

Hello Junlong and Lijie,

fyi above. Can you register in dpdk bugzilla (https://bugs.dpdk.org/) ? Then I can make you aware of any reported issues without having to send separate emails.

thanks,
Kevin.