net/intel: possible misuse of comma operator

http://bugs.dpdk.org/show_bug.cgi?id=1809

            Bug ID: 1809
           Summary: net/intel: possible misuse of comma operator
           Product: DPDK
           Version: 20.11
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: ethdev
          Assignee: [email protected]
          Reporter: [email protected]

Target Milestone: ---

If DPDK is built with clang and -Wcomma is enabled for drivers then:

[1127/3622] Compiling C object drivers/libtmp_rte_net_ice.a.p/net_intel_ice_ice_ethdev.c.o ../drivers/net/intel/ice/ice_ethdev.c:945:52: warning: possible misuse of comma operator here [-Wcomma]
945 | entry && (next_entry = LIST_NEXT(entry, next), 1);
| ^
../drivers/net/intel/ice/ice_ethdev.c:945:17: note: cast expression to void to silence warning

  945 |              entry && (next_entry = LIST_NEXT(entry, next), 1);
      |                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                        (void)(                            )

../drivers/net/intel/ice/ice_ethdev.c:952:52: warning: possible misuse of comma operator here [-Wcomma]
952 | entry && (next_entry = LIST_NEXT(entry, next), 1);
| ^
../drivers/net/intel/ice/ice_ethdev.c:952:17: note: cast expression to void to silence warning

  952 |              entry && (next_entry = LIST_NEXT(entry, next), 1);
      |                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                        (void)(                            )

2 warnings generated.
[1150/3622] Compiling C object drivers/libtmp_rte_net_i40e.a.p/net_intel_i40e_i40e_ethdev.c.o ../drivers/net/intel/i40e/i40e_ethdev.c:5102:49: warning: possible misuse of comma operator here [-Wcomma]
5102 | entry && (next_entry = LIST_NEXT(entry, next),
1);
| ^
../drivers/net/intel/i40e/i40e_ethdev.c:5102:14: note: cast expression to void to silence warning
5102 | entry && (next_entry = LIST_NEXT(entry, next),
1);

      |                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                   (void)(                            )

../drivers/net/intel/i40e/i40e_ethdev.c:5109:49: warning: possible misuse of comma operator here [-Wcomma]
5109 | entry && (next_entry = LIST_NEXT(entry, next),
1);
| ^
../drivers/net/intel/i40e/i40e_ethdev.c:5109:14: note: cast expression to void to silence warning
5109 | entry && (next_entry = LIST_NEXT(entry, next),
1);

      |                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                   (void)(                            )

2 warnings generated.

Suggest looking at how LIST_NEXT could be changed to not generate warnings, not seen elsewhere.

You are receiving this mail because:
You are the assignee for the bug.