Comment about /dev/zero in eal_common_memory.c is obsolete

http://bugs.dpdk.org/show_bug.cgi?id=1853

Bug ID: 1853
Summary: Comment about /dev/zero in eal_common_memory.c is
obsolete
Product: DPDK
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: Normal
Component: core
Assignee: [email protected]
Reporter: [email protected]
Target Milestone: ---

This comment is in lib/eal/common/eal_common_memory.c:

/*
* Try to mmap *size bytes in /dev/zero. If it is successful, return the
* pointer to the mmap'd area and keep *size unmodified. Else, retry
* with a smaller zone: decrease *size by hugepage_sz until it reaches
* 0. In this case, return NULL. Note: this function returns an address
* which is a multiple of hugepage size.
*/

Unfortunately, the comment is no longer accurate. The mmap-ing of *size bytes in /dev/zero has been removed in April 2018 and since that the implementation is different. The comment should be updated to reflect the current code.

You are receiving this mail because:
You are the assignee for the bug.