THERM_WINDTUNNEL not working any longer in kernel 4.19.x (PowerMac G4 MDD)
A message that is not in the archive (sent off-list or not yet received): [email protected]/
[email protected]
Acked-by Michael Ellermanhttps://bugzilla.kernel.org/show_bug.cgi?id=201723
--- Comment #4 from Erhard F. ([email protected]) --- Created attachment 285535
--> https://bugzilla.kernel.org/attachment.cgi?id=285535&action=edit
bisect.log
Final bisect commit.
It's not a bug, it's a feature. :(
# git bisect bad | tee -a ~/bisect.log 3e7bed52719de4b5b5fb900869e293eae0bc3f3e is the first bad commit commit 3e7bed52719de4b5b5fb900869e293eae0bc3f3e Author: Wolfram Sang <[email protected]> Date: Tue Aug 21 17:02:39 2018 +0200
macintosh: therm_windtunnel: drop using attach_adapter
As we now have deferred probing, we can use a custom mechanism and finally get rid of the legacy interface from the i2c core.
:040000 040000 04029fe24bce33dd0b815fa961cfa847a2abce772dc14e16e628b7e2fa4b65bfd6544c9c5e165a9a M drivers
Signature · 2 lines
You are receiving this mail because: You are watching the assignee of the bug.
https://bugzilla.kernel.org/show_bug.cgi?id=201723
--- Comment #5 from Wolfram Sang ([email protected]) ---
I contacted Erhard by email to gather some more debug output. If we make substantial progress, I will report it here.
Sidenote: therm_windtunnel has its own ADM1030 and DS1775 handling, so it doesn't need the seperate drivers from HWMON. In theory, it should, but I guess noone is up to refactoring all that old code.
Signature · 2 lines
You are receiving this mail because: You are watching the assignee of the bug.
https://bugzilla.kernel.org/show_bug.cgi?id=201723
Wolfram Sang ([email protected]) changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--- Comment #6 from Wolfram Sang ([email protected]) --- Patch which works for Erhard is sent out:
http://patchwork.ozlabs.org/patch/1244322/
Signature · 2 lines
You are receiving this mail because: You are watching the assignee of the bug.
https://bugzilla.kernel.org/show_bug.cgi?id=201723
Wolfram Sang ([email protected]) changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |CODE_FIX--- Comment #7 from Wolfram Sang ([email protected]) --- Commited as 38b17afb0ebb ("macintosh: therm_windtunnel: fix regression when instantiating devices") and available upstream since v5.6-rc4.
Thanks for everyone helping, especially Erhard, of course!
Signature · 2 lines
You are receiving this mail because: You are watching the assignee of the bug.