New: kernel 5.2.1: "floating point exception" in qemu with kvm enabled

https://bugzilla.kernel.org/show_bug.cgi?id=204209

            Bug ID: 204209
           Summary: kernel 5.2.1: "floating point exception" in qemu with
                    kvm enabled
           Product: Virtualization
           Version: unspecified
    Kernel Version: 5.2.1
          Hardware: x86-64
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: high
          Priority: P1
         Component: kvm
          Assignee: [email protected]
          Reporter: [email protected]
        Regression: No

After updating the kernel from 5.1.17 to 5.2.1, when I use the g++ compiler in qemu with kvm enabled, often the compiler launched in the guest for compile my sources ends with this error: "exception in floating point".

Moreever it is not possible to update the bsd system because the process (that use g++ compiler) exits with the same error.

Same thing for some system utilities, like "pkg update".

But if I boot the system with the previous 5.1.17 kernel and launch qemu, as indicated above, everything works fine and I don't detect errors.

Command line is:

/usr/bin/qemu-system-x86_64 -k it -machine accel=kvm -m 4096 -no-fd-bootchk -show-cursor -drive file="vmdragon.img",if=ide,media=disk -boot once=c,menu=off -net none -rtc base=localtime -name "vmdragon" -smp 8 -vga std -device qemu-xhci,id=xhci

I can't test without kvm because the process is very slow, but I think the problem could be in some changes made to the kvm module.

Thanks,
Antonio

You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.kernel.org/show_bug.cgi?id=204209

Thomas Lambertz ([email protected]) changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |[email protected]

--- Comment #1 from Thomas Lambertz ([email protected]) ---
I can confirm this issue. It occurs since 5.2, when the FPU state changes were introduced. I send an e-mail about this yesterday, seems I should have included the kvm mailing list:

https://lkml.org/lkml/2019/7/17/758

- Thomas

You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.kernel.org/show_bug.cgi?id=204209

--- Comment #2 from anthony ([email protected]) ---
I tested the patch indicated on https://lkml.org/lkml/2019/7/19/644 with simple row position adjustments for the kernel 5.2.1 and it seems to work.

@@ -3264,6 +3264,12 @@
 
    kvm_x86_ops->vcpu_load(vcpu, cpu);
 
+
+   // fix floating point error kvm guest
+   if (test_thread_flag(TIF_NEED_FPU_LOAD))
+       switch_fpu_return();
+
+
    /* Apply any externally detected TSC adjustments (due to suspend) */
    if (unlikely(vcpu->arch.tsc_offset_adjustment)) {
        adjust_tsc_offset_host(vcpu, vcpu->arch.tsc_offset_adjustment);

@@ -7955,9 +7961,11 @@
        wait_lapic_expire(vcpu);
    guest_enter_irqoff();
 
-   fpregs_assert_state_consistent();
-   if (test_thread_flag(TIF_NEED_FPU_LOAD))
-       switch_fpu_return();
+// fix floating point error kvm guest
+//
+//     fpregs_assert_state_consistent();
+//     if (test_thread_flag(TIF_NEED_FPU_LOAD))
+//         switch_fpu_return();
 
    if (unlikely(vcpu->arch.switch_db_regs)) {
        set_debugreg(0, 7);

You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.kernel.org/show_bug.cgi?id=204209

--- Comment #3 from anthony ([email protected]) --- Today I saw the following commit:

applied to the 5.2.4 kernel and I thought it could relate to the reported bug, but recompiling the kernel without previous indicated patch, the guest report "fpu exception" error again: it was necessary to re-include the patch and recompile the kernel for it to work.

You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.kernel.org/show_bug.cgi?id=204209

anthony ([email protected]) changed:

What |Removed |Added
----------------------------------------------------------------------------

             Status|NEW                         |RESOLVED
         Resolution|---                         |CODE_FIX

--- Comment #4 from anthony ([email protected]) --- Tested with Kernel 5.2.5: problem solved.

Thanks,
Antonio

You are receiving this mail because:
You are watching the assignee of the bug.