Skip to contentSkip to conversation

New: xfs: data race on ctx->space_used in xlog_cil_insert_items()

Bug 207711 [email protected] 2 participants 4 messages May 13, 2020

lore
Share & tools
lore
#0 lore raw

https://bugzilla.kernel.org/show_bug.cgi?id=207711

            Bug ID: 207711
           Summary: xfs: data race on ctx->space_used in
                    xlog_cil_insert_items()
           Product: File System
           Version: 2.5
    Kernel Version: 5.4
          Hardware: All
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: XFS
          Assignee: [email protected]
          Reporter: [email protected]
        Regression: No

The functions xlog_cil_insert_items() and xlog_cil_push_background() are concurrently executed at runtime at the following call contexts:

Thread 1:
xfs_file_write_iter()
xfs_file_buffered_aio_write()

    xfs_file_aio_write_checks()
      xfs_vn_update_time()
        xfs_trans_commit()
          __xfs_trans_commit()
            xfs_log_commit_cil()
              xlog_cil_insert_items()

Thread 2:
xfs_file_write_iter()
xfs_file_buffered_aio_write()

    xfs_file_aio_write_checks()
      xfs_vn_update_time()
        xfs_trans_commit()
          __xfs_trans_commit()
            xfs_log_commit_cil()
              xlog_cil_push_background()

In xlog_cil_insert_items():
ctx->space_used += len;

In xlog_cil_push_background():
if (cil->xc_ctx->space_used < XLOG_CIL_SPACE_LIMIT(log))

The variables ctx->space_used and cil->xc_ctx->space_used access the same memory, and thus a data race can occur.

This data race was found and actually reproduced by our concurrency fuzzer.

I am not sure whether this data race is harmful and how to fix this data race properly, so I want to listen to your opinions, thanks :)

Signature · 2 lines
You are receiving this mail because:
You are watching the assignee of the bug.
#1 lore raw
Quoted 42 lines · On Wed, May 13, 2020 at 02:45:54AM +0000, [email protected]…

https://bugzilla.kernel.org/show_bug.cgi?id=207711

            Bug ID: 207711
           Summary: xfs: data race on ctx->space_used in
                    xlog_cil_insert_items()
           Product: File System
           Version: 2.5
    Kernel Version: 5.4
          Hardware: All
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: XFS
          Assignee: [email protected]
          Reporter: [email protected]
        Regression: No

The functions xlog_cil_insert_items() and xlog_cil_push_background() are concurrently executed at runtime at the following call contexts:

Thread 1:
xfs_file_write_iter()
xfs_file_buffered_aio_write()

    xfs_file_aio_write_checks()
      xfs_vn_update_time()
        xfs_trans_commit()
          __xfs_trans_commit()
            xfs_log_commit_cil()
              xlog_cil_insert_items()

Thread 2:
xfs_file_write_iter()
xfs_file_buffered_aio_write()

    xfs_file_aio_write_checks()
      xfs_vn_update_time()
        xfs_trans_commit()
          __xfs_trans_commit()
            xfs_log_commit_cil()
              xlog_cil_push_background()
Quoted 5 lines

In xlog_cil_insert_items():
ctx->space_used += len;

In xlog_cil_push_background():
if (cil->xc_ctx->space_used < XLOG_CIL_SPACE_LIMIT(log))

Intentionally racy accounting check as it's not critical to be perfectly accurate here.

Not a bug, please close.

-Dave.

Signature · 2 lines
Dave Chinner
[email protected]
#2 lore raw

[Bug 207711] xfs: data race on ctx->space_used in xlog_cil_insert_items()

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=207711

--- Comment #1 from Dave Chinner ([email protected]) ---

Quoted 42 lines · On Wed, May 13, 2020 at 02:45:54AM +0000, [email protected]…

https://bugzilla.kernel.org/show_bug.cgi?id=207711

            Bug ID: 207711
           Summary: xfs: data race on ctx->space_used in
                    xlog_cil_insert_items()
           Product: File System
           Version: 2.5
    Kernel Version: 5.4
          Hardware: All
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: XFS
          Assignee: [email protected]
          Reporter: [email protected]
        Regression: No

The functions xlog_cil_insert_items() and xlog_cil_push_background() are concurrently executed at runtime at the following call contexts:

Thread 1:
xfs_file_write_iter()
xfs_file_buffered_aio_write()

    xfs_file_aio_write_checks()
      xfs_vn_update_time()
        xfs_trans_commit()
          __xfs_trans_commit()
            xfs_log_commit_cil()
              xlog_cil_insert_items()

Thread 2:
xfs_file_write_iter()
xfs_file_buffered_aio_write()

    xfs_file_aio_write_checks()
      xfs_vn_update_time()
        xfs_trans_commit()
          __xfs_trans_commit()
            xfs_log_commit_cil()
              xlog_cil_push_background()
Quoted 5 lines

In xlog_cil_insert_items():
ctx->space_used += len;

In xlog_cil_push_background():
if (cil->xc_ctx->space_used < XLOG_CIL_SPACE_LIMIT(log))

Intentionally racy accounting check as it's not critical to be perfectly accurate here.

Not a bug, please close.

-Dave.

Signature · 2 lines
You are receiving this mail because:
You are watching the assignee of the bug.
#3 lore raw

[Bug 207711] xfs: data race on ctx->space_used in xlog_cil_insert_items()

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=207711

Jia-Ju Bai ([email protected]) changed:

What |Removed |Added
----------------------------------------------------------------------------

             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #2 from Jia-Ju Bai ([email protected]) --- Okay, thanks for explanation.

Signature · 2 lines
You are receiving this mail because:
You are watching the assignee of the bug.