New: xfs: data race on lip->li_lsn in xfs_trans_ail_update_bulk()
https://bugzilla.kernel.org/show_bug.cgi?id=207715
Bug ID: 207715
Summary: xfs: data race on lip->li_lsn in
xfs_trans_ail_update_bulk()
Product: File System
Version: 2.5
Kernel Version: 5.4
Hardware: All
OS: Linux
Tree: Mainline
Status: NEW
Severity: normal
Priority: P1
Component: XFS
Assignee: [email protected]
Reporter: [email protected]
Regression: NoThe functions xfs_trans_ail_update_bulk() and xfs_inode_item_format_core() are concurrently executed at runtime in the following call contexts:
Thread 1:xlog_ioend_work()
xlog_state_done_syncing()
xlog_state_do_callback()
xlog_state_do_iclog_callbacks()
xlog_cil_process_committed()
xlog_cil_committed()
xfs_trans_committed_bulk()
xfs_log_item_batch_insert()
xfs_trans_ail_update_bulk()
Thread 2:xfs_file_write_iter()
xfs_file_buffered_aio_write()
xfs_file_aio_write_checks()
xfs_vn_update_time()
xfs_trans_commit()
__xfs_trans_commit()
xfs_log_commit_cil()
xlog_cil_insert_items()
xlog_cil_insert_format_items()
xfs_inode_item_format()
xfs_inode_item_format_core()In xfs_trans_ail_update_bulk():
lip->li_lsn = lsn;
In xfs_inode_item_format_core():
xfs_inode_to_log_dinode(ip, dic, ip->i_itemp->ili_item.li_lsn);
The variables lip->li_lsn and ip->i_itemp->ili_item.li_lsn access the same memory, and thus a data race can occur.
This data race was found and actually reproduced by our concurrency fuzzer.
I am not sure whether this data race is harmful and how to fix this data race properly, so I want to listen to your opinions, thanks :)
Signature · 2 lines
You are receiving this mail because: You are watching the assignee of the bug.
[Bug 207715] xfs: data race on lip->li_lsn in xfs_trans_ail_update_bulk()
https://bugzilla.kernel.org/show_bug.cgi?id=207715
--- Comment #1 from Dave Chinner ([email protected]) ---
Quoted 47 lines · On Wed, May 13, 2020 at 03:21:05AM +0000, [email protected]…
https://bugzilla.kernel.org/show_bug.cgi?id=207715
Bug ID: 207715 Summary: xfs: data race on lip->li_lsn in xfs_trans_ail_update_bulk() Product: File System Version: 2.5 Kernel Version: 5.4 Hardware: All OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: XFS Assignee: [email protected] Reporter: [email protected] Regression: NoThe functions
xfs_trans_ail_update_bulk()andxfs_inode_item_format_core()are
concurrently executed at runtime in the following call contexts:Thread 1:
xlog_ioend_work()
xlog_state_done_syncing()
xlog_state_do_callback()
xlog_state_do_iclog_callbacks()
xlog_cil_process_committed()
xlog_cil_committed()
xfs_trans_committed_bulk()
xfs_log_item_batch_insert()
xfs_trans_ail_update_bulk()Thread 2:
xfs_file_write_iter()
xfs_file_buffered_aio_write()xfs_file_aio_write_checks() xfs_vn_update_time() xfs_trans_commit() __xfs_trans_commit() xfs_log_commit_cil() xlog_cil_insert_items() xlog_cil_insert_format_items() xfs_inode_item_format() xfs_inode_item_format_core()
Quoted 5 lines
In
xfs_trans_ail_update_bulk():
lip->li_lsn= lsn;In
xfs_inode_item_format_core():
xfs_inode_to_log_dinode(ip, dic, ip->i_itemp->ili_item.li_lsn);
Probably a bug on 32 bit systems where a torn write can be seen. Likely should use xfs_trans_ail_copy_lsn() to sample the lsn out of the log item.
Cheers,
Dave.
Signature · 2 lines
You are receiving this mail because: You are watching the assignee of the bug.
Quoted 46 lines · On Wed, May 13, 2020 at 03:21:05AM +0000, [email protected]…
https://bugzilla.kernel.org/show_bug.cgi?id=207715
Bug ID: 207715 Summary: xfs: data race on lip->li_lsn in xfs_trans_ail_update_bulk() Product: File System Version: 2.5 Kernel Version: 5.4 Hardware: All OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: XFS Assignee: [email protected] Reporter: [email protected] Regression: NoThe functions
xfs_trans_ail_update_bulk()andxfs_inode_item_format_core()are concurrently executed at runtime in the following call contexts:Thread 1:
xlog_ioend_work()
xlog_state_done_syncing()
xlog_state_do_callback()
xlog_state_do_iclog_callbacks()
xlog_cil_process_committed()
xlog_cil_committed()
xfs_trans_committed_bulk()
xfs_log_item_batch_insert()
xfs_trans_ail_update_bulk()Thread 2:
xfs_file_write_iter()
xfs_file_buffered_aio_write()xfs_file_aio_write_checks() xfs_vn_update_time() xfs_trans_commit() __xfs_trans_commit() xfs_log_commit_cil() xlog_cil_insert_items() xlog_cil_insert_format_items() xfs_inode_item_format() xfs_inode_item_format_core()
Quoted 5 lines
In
xfs_trans_ail_update_bulk():
lip->li_lsn= lsn;In
xfs_inode_item_format_core():
xfs_inode_to_log_dinode(ip, dic, ip->i_itemp->ili_item.li_lsn);
Probably a bug on 32 bit systems where a torn write can be seen. Likely should use xfs_trans_ail_copy_lsn() to sample the lsn out of the log item.
Cheers,
Dave.
Signature · 2 lines
Dave Chinner [email protected]
[Bug 207715] xfs: data race on lip->li_lsn in xfs_trans_ail_update_bulk()
In reply to [email protected]https://bugzilla.kernel.org/show_bug.cgi?id=207715
--- Comment #2 from Jia-Ju Bai ([email protected]) --- Okay, thanks for the reply.
Signature · 2 lines
You are receiving this mail because: You are watching the assignee of the bug.