Skip to contentSkip to conversation

New: Distorted Audio Output Through USB C Docking Station

Bug 208353 [email protected] 2 participants 14 messages Jun 28, 2020 – Jul 9, 2020 USB

lore
Share & tools
lore
#0 lore raw

https://bugzilla.kernel.org/show_bug.cgi?id=208353

            Bug ID: 208353
           Summary: Distorted Audio Output Through USB C Docking Station
           Product: Drivers
           Version: 2.5
    Kernel Version: 5.4.49
          Hardware: All
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: USB
          Assignee: [email protected]
          Reporter: [email protected]
        Regression: No

Created attachment 289909
--> https://bugzilla.kernel.org/attachment.cgi?id=289909&action=edit
Output of alsa-info.sh

With kernel 5.4.49 the audio output through my Dell WD19 Docking station is now laggy and distorted (sounds like only bass frequencies are emitted). Previously, audio output through the dock worked just fine with all versions of 4.19.x and 5.4.x.

After looking through the changelog for 5.4.49, I was able to locate the offending patch:

https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/patch/?id=aba41867dd66939d336fdf604e4d73b805d8039f

Reverting this patch allows audio to play normally through my docking station.

Signature · 2 lines
You are receiving this mail because:
You are watching the assignee of the bug.
#1 lore raw

Bring this to the attention of the person who wrote the offending commit:

Quoted 27 lines · On Sun, Jun 28, 2020 at 03:19:06PM +0000, [email protected]…

https://bugzilla.kernel.org/show_bug.cgi?id=208353

            Bug ID: 208353
           Summary: Distorted Audio Output Through USB C Docking Station
           Product: Drivers
           Version: 2.5
    Kernel Version: 5.4.49
          Hardware: All
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: USB
          Assignee: [email protected]
          Reporter: [email protected]
        Regression: No

Created attachment 289909
--> https://bugzilla.kernel.org/attachment.cgi?id=289909&action=edit
Output of alsa-info.sh

With kernel 5.4.49 the audio output through my Dell WD19 Docking station is now laggy and distorted (sounds like only bass frequencies are emitted). Previously, audio output through the dock worked just fine with all versions of 4.19.x and 5.4.x.

Quoted 4 lines

After looking through the changelog for 5.4.49, I was able to locate the offending patch:

https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/patch/?id=aba41867dd66939d336fdf604e4d73b805d8039f

This is upstream commit f0bd62b64016 ("ALSA: usb-audio: Improve frames size computation").

Alan Stern

Quoted 1 line

Reverting this patch allows audio to play normally through my docking station.

#2 lore raw

[Bug 208353] Distorted Audio Output Through USB C Docking Station

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=208353

--- Comment #1 from Alan Stern ([email protected]) --- Bring this to the attention of the person who wrote the offending commit:

Quoted 29 lines · On Sun, Jun 28, 2020 at 03:19:06PM +0000, [email protected]…

https://bugzilla.kernel.org/show_bug.cgi?id=208353

            Bug ID: 208353
           Summary: Distorted Audio Output Through USB C Docking Station
           Product: Drivers
           Version: 2.5
    Kernel Version: 5.4.49
          Hardware: All
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: USB
          Assignee: [email protected]
          Reporter: [email protected]
        Regression: No

Created attachment 289909
--> https://bugzilla.kernel.org/attachment.cgi?id=289909&action=edit
Output of alsa-info.sh

With kernel 5.4.49 the audio output through my Dell WD19 Docking station is now
laggy and distorted (sounds like only bass frequencies are emitted). Previously, audio output through the dock worked just fine with all versions of
4.19.x and 5.4.x.

Quoted 5 lines

After looking through the changelog for 5.4.49, I was able to locate the offending patch:

https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/patch/?id=aba41867dd66939d336fdf604e4d73b805d8039f

This is upstream commit f0bd62b64016 ("ALSA: usb-audio: Improve frames size computation").

Alan Stern

Quoted 2 lines

Reverting this patch allows audio to play normally through my docking station.

Signature · 2 lines
You are receiving this mail because:
You are watching the assignee of the bug.
#4 lore raw

[Bug 208353] Distorted Audio Output Through USB C Docking Station

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=208353

Alexander Tsoy ([email protected]) changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |[email protected]

--- Comment #4 from Alexander Tsoy ([email protected]) --- Thanks! I think I've completely missed datainterval in my calculations. I'll prepare a patch for you to test.

(Also CCing Takashi)

Signature · 2 lines
You are receiving this mail because:
You are watching the assignee of the bug.
#5 lore raw

[Bug 208353] Distorted Audio Output Through USB C Docking Station

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=208353

--- Comment #5 from Alexander Tsoy ([email protected]) --- Created attachment 289917
--> https://bugzilla.kernel.org/attachment.cgi?id=289917&action=edit
test.patch

Here is a quick patch to test my theory. Please give it a try.

Signature · 2 lines
You are receiving this mail because:
You are watching the assignee of the bug.
#6 lore raw

[Bug 208353] Distorted Audio Output Through USB C Docking Station

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=208353

--- Comment #9 from Hans de Goede ([email protected]) --- Fedora is shipping 5.7.z kernels in our updates repo and it is raining bug-reports because of this issue.

Can we please get a non test-patch fix for this ASAP?

Or get a revert of the commit causing this regression queued up for all the stable series where this got added and is causing regressions (also ASAP)?

Signature · 2 lines
You are receiving this mail because:
You are watching the assignee of the bug.
#7 lore raw

[Bug 208353] Distorted Audio Output Through USB C Docking Station

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=208353

--- Comment #10 from Hans de Goede ([email protected]) --- Also see: bug 208311, bug 208317 and:

https://bugzilla.redhat.com/show_bug.cgi?id=1852564
https://bugzilla.redhat.com/show_bug.cgi?id=1853707
https://bugzilla.redhat.com/show_bug.cgi?id=1854166

Signature · 2 lines
You are receiving this mail because:
You are watching the assignee of the bug.
#8 lore raw

[Bug 208353] Distorted Audio Output Through USB C Docking Station

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=208353

Florian Engelhardt ([email protected]) changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |[email protected]

--- Comment #11 from Florian Engelhardt ([email protected]) ---
I too can confirm the patch works, applied it to the Fedora 32 5.7.7 kernel and the problem is solved. Thanks for the fix!

Signature · 2 lines
You are receiving this mail because:
You are watching the assignee of the bug.
#9 lore raw

[Bug 208353] Distorted Audio Output Through USB C Docking Station

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=208353

[email protected] changed:

What |Removed |Added
----------------------------------------------------------------------------

                 CC|                            |pnqkernelbugzilla@inkvizice
                   |                            |.org

--- Comment #12 from [email protected] ---
I have similar issue with audio output from Dell WD15 USB-C Dock. I decoded notorious song "Never Gonna Give You Up" to raw audio and ran it throug aplay. Before the commit it plays normally, since the commit it plays like this:
https://central.szn.cz/s/tr9otisNwiFEE2A

The first official release with the issue is 5.7.6, it is still present in 5.8-rc4. Bisecting found the following commit d288dc74f8cf95cb7ae0aaf245b7128627a49bf3 (ALSA: usb-audio: Improve frames size computation), which is based on upstream commit f0bd62b64016508938df9babe47f65c2c727d25c.

Release 5.7.7 with the patch from comment #5 seems okay.

Signature · 2 lines
You are receiving this mail because:
You are watching the assignee of the bug.
#10 lore raw

[Bug 208353] Distorted Audio Output Through USB C Docking Station

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=208353

Takashi Iwai ([email protected]) changed:

What |Removed |Added
----------------------------------------------------------------------------

             Status|NEW                         |RESOLVED
         Resolution|---                         |CODE_FIX

--- Comment #13 from Takashi Iwai ([email protected]) ---
The fix patch landed in Linus tree yesterday. Sorry that it took long, as I've been off.

FWIW, Greg already reverted the original commit that caused a problem on stable trees.

Signature · 2 lines
You are receiving this mail because:
You are watching the assignee of the bug.
#11 lore raw

[Bug 208353] Distorted Audio Output Through USB C Docking Station

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=208353

Takashi Iwai ([email protected]) changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |[email protected]

--- Comment #14 from Takashi Iwai ([email protected]) --- *** Bug 208403 has been marked as a duplicate of this bug. ***

Signature · 2 lines
You are receiving this mail because:
You are watching the assignee of the bug.
#12 lore raw

[Bug 208353] Distorted Audio Output Through USB C Docking Station

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=208353

Takashi Iwai ([email protected]) changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |[email protected]

--- Comment #15 from Takashi Iwai ([email protected]) --- *** Bug 208317 has been marked as a duplicate of this bug. ***

Signature · 2 lines
You are receiving this mail because:
You are watching the assignee of the bug.
#13 lore raw

[Bug 208353] Distorted Audio Output Through USB C Docking Station

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=208353

Takashi Iwai ([email protected]) changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |[email protected]

--- Comment #16 from Takashi Iwai ([email protected]) --- *** Bug 208501 has been marked as a duplicate of this bug. ***

Signature · 2 lines
You are receiving this mail because:
You are watching the assignee of the bug.