net/ntnic: mulitple issues detected with GCC -fanalyzer

https://bugs.dpdk.org/show_bug.cgi?id=2115

            Bug ID: 2115
           Summary: net/ntnic: mulitple issues detected with GCC
                    -fanalyzer
           Product: DPDK
           Version: 26.11
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: minor
          Priority: Normal
         Component: ethdev
          Assignee: [email protected]
          Reporter: [email protected]

Target Milestone: ---

23. net/ntnic: FPGA model constructors return unchecked malloc
Component: ethdev | Severity: minor | Confidence: single pass

nthw_fpga_model_new, nthw_module_new, nthw_register_new, nthw_field_new, nthw_param_new (drivers/net/ntnic/nthw/model/nthw_fpga_model.c) return malloc() directly and callers pass the result to *_init(), which dereferences it (:186, :245, :296, :317, :418). Same in nthw_id_table_create() (nthw/flow_api/flow_id_table.c:68, calloc dereferenced at :70).

24. net/ntnic: p_drv leaked on init failure
Component: ethdev | Severity: minor | Confidence: single pass

nthw_pci_dev_init() allocates p_drv at drivers/net/ntnic/ntnic_ethdev.c:2326 and stores it with store_pdrv() (:2380). The later return -1 paths (:2388, :2437, :2456, ...) do not free it or clear the stored pointer.

25. net/ntnic: NULL check after dereference in nthw_pci_dev_deinit()
Component: ethdev | Severity: trivial | Confidence: confirmed

drivers/net/ntnic/ntnic_ethdev.c:2680 dereferences internals; :2688 then loops on while (internals).

You are receiving this mail because:
You are the assignee for the bug.