Skip to contentSkip to conversation

New: [BISECT INCLUDED] scsi/sd Rework asynchronous resume support breaks S2idle and S3 on several systems

Bug 216413 [email protected] 1 participant 10 messages Aug 25, 2022 – Aug 29, 2022 SCSI

lore
Share & tools
lore
#0 lore raw

https://bugzilla.kernel.org/show_bug.cgi?id=216413

            Bug ID: 216413
           Summary: [BISECT INCLUDED] scsi/sd Rework asynchronous resume
                    support breaks S2idle and S3 on several systems
           Product: IO/Storage
           Version: 2.5
    Kernel Version: 6.0.0-rc1
          Hardware: Intel
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: blocking
          Priority: P1
         Component: SCSI
          Assignee: [email protected]
          Reporter: [email protected]
                CC: [email protected], [email protected],
                    [email protected], [email protected]
            Blocks: 178231
        Regression: No

A commit in 6.0.0-rc1 has caused S2idle and S3 (freeze & mem) to completely hang the system on these 4 machines in our lab:

1) Clevo System76 Lemur 6
2) Lenovo Yoga 2 Pro
3) Dell Inspiron 3493
4) HP Pavillion x360

To reproduce the issue simply run kernel 6.0.0-rc1 or newer on these systems and run "sudo sleepgraph -m freeze" or "sudo sleepgraph -m mem". The system will hang after that.

I've bisected the problem to this specific commit:

88f1669019bd62b3009a3cebf772fbaaa21b9f38 is the first bad commit commit 88f1669019bd62b3009a3cebf772fbaaa21b9f38

Author: Bart Van Assche <[email protected]>
Date:   Thu Jun 30 12:57:03 2022 -0700

scsi: sd: Rework asynchronous resume support

For some technologies, e.g. an ATA bus, resuming can take multiple seconds. Waiting for resume to finish can cause a very noticeable delay. Hence this commit that restores the behavior from before "scsi: core: pm:
Rely on the device driver core for async power management" for most SCSI devices.

This commit introduces a behavior change: if the START command fails, do not consider this as a SCSI disk resume failure.

Fixes a19a93e4c6a9 ("scsi: core: pm: Rely on the device driver core for

async power management")

:040000 040000 dbd390c19cfddba2b559b06691404aee4c165384
54c7fa67e3a1605878999bdf1e39a95ca793238a M drivers

Referenced Bugs:

https://bugzilla.kernel.org/show_bug.cgi?id=178231
[Bug 178231] Meta-bug: Linux suspend-to-mem and freeze performance optimization

Signature · 4 lines
You may reply to this email to add a comment.

You are receiving this mail because:
You are on the CC list for the bug.
#1 lore raw

[Bug 216413] [BISECT INCLUDED] scsi/sd Rework asynchronous resume support breaks S2idle and S3 on several systems

https://bugzilla.kernel.org/show_bug.cgi?id=216413

--- Comment #1 from Bart Van Assche ([email protected]) --- A revert for that patch has been posted:
https://lore.kernel.org/linux-scsi/[email protected]/

Signature · 4 lines
You may reply to this email to add a comment.

You are receiving this mail because:
You are on the CC list for the bug.
#2 lore raw

[Bug 216413] [BISECT INCLUDED] scsi/sd Rework asynchronous resume support breaks S2idle and S3 on several systems

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=216413

--- Comment #2 from Todd Brandt ([email protected]) --- Created attachment 301662
--> https://bugzilla.kernel.org/attachment.cgi?id=301662&action=edit
otcpl-hp-x360-bsw-dmesg.txt

S3 suspend fail dmesg log for the HP Pavillion x360

Signature · 4 lines
You may reply to this email to add a comment.

You are receiving this mail because:
You are on the CC list for the bug.
#3 lore raw

[Bug 216413] [BISECT INCLUDED] scsi/sd Rework asynchronous resume support breaks S2idle and S3 on several systems

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=216413

--- Comment #3 from Todd Brandt ([email protected]) ---
One other thing to note, I tried removing this one commit from the very latest 6.0.0-rc2 code upstream and it fixed it completely. So there's no doubt this one commit is the sole cause of the hang.

Signature · 4 lines
You may reply to this email to add a comment.

You are receiving this mail because:
You are on the CC list for the bug.
#4 lore raw

[Bug 216413] [BISECT INCLUDED] scsi/sd Rework asynchronous resume support breaks S2idle and S3 on several systems

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=216413

--- Comment #4 from Todd Brandt ([email protected]) --- Created attachment 301663
--> https://bugzilla.kernel.org/attachment.cgi?id=301663&action=edit
otcpl-hp-x360-system-info.txt

System info for the HP Pavillion x360

Signature · 4 lines
You may reply to this email to add a comment.

You are receiving this mail because:
You are on the CC list for the bug.
#5 lore raw

[Bug 216413] [BISECT INCLUDED] scsi/sd Rework asynchronous resume support breaks S2idle and S3 on several systems

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=216413

--- Comment #5 from Todd Brandt ([email protected]) --- Created attachment 301664
--> https://bugzilla.kernel.org/attachment.cgi?id=301664&action=edit
otcpl-dell-3493-icl-system-info.txt

Dell Inspiron 3493 system info

Signature · 4 lines
You may reply to this email to add a comment.

You are receiving this mail because:
You are on the CC list for the bug.
#6 lore raw

[Bug 216413] [BISECT INCLUDED] scsi/sd Rework asynchronous resume support breaks S2idle and S3 on several systems

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=216413

--- Comment #6 from Todd Brandt ([email protected]) --- (In reply to Bart Van Assche from comment #1)

Quoted 3 lines

A revert for that patch has been posted:
https://lore.kernel.org/linux-scsi/20220816172638.538734-1-bvanassche@acm.
org/

When will this make it upstream? In 6.0.0-rc3 hopefully?

Signature · 4 lines
You may reply to this email to add a comment.

You are receiving this mail because:
You are on the CC list for the bug.
#7 lore raw

[Bug 216413] [BISECT INCLUDED] scsi/sd Rework asynchronous resume support breaks S2idle and S3 on several systems

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=216413

--- Comment #7 from Bart Van Assche ([email protected]) ---

Quoted 1 line · On 8/25/22 14:46, [email protected] wrote:

When will this make it upstream? In 6.0.0-rc3 hopefully?

I'm not sure. This depends on the SCSI maintainer.

Signature · 4 lines
You may reply to this email to add a comment.

You are receiving this mail because:
You are on the CC list for the bug.
#8 lore raw

[Bug 216413] [BISECT INCLUDED] scsi/sd Rework asynchronous resume support breaks S2idle and S3 on several systems

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=216413

--- Comment #8 from Todd Brandt ([email protected]) --- (In reply to Bart Van Assche from comment #7)

Quoted 4 lines · On 8/25/22 14:46, [email protected] wrote:
Quoted 1 line

When will this make it upstream? In 6.0.0-rc3 hopefully?

I'm not sure. This depends on the SCSI maintainer.

ok, thank you, I'll keep monitoring and will close this bug when it lands upstream.

Signature · 4 lines
You may reply to this email to add a comment.

You are receiving this mail because:
You are on the CC list for the bug.
#9 lore raw

[Bug 216413] [BISECT INCLUDED] scsi/sd Rework asynchronous resume support breaks S2idle and S3 on several systems

In reply to [email protected]

https://bugzilla.kernel.org/show_bug.cgi?id=216413

Todd Brandt ([email protected]) changed:

What |Removed |Added
----------------------------------------------------------------------------

             Status|NEW                         |RESOLVED
         Resolution|---                         |CODE_FIX

--- Comment #9 from Todd Brandt ([email protected]) --- Looks like the commit was successfully reverted in 6.0.0-rc3. S2idle works again on the HP Pavillion x360 and Dell Inspiron 3493.

Signature · 4 lines
You may reply to this email to add a comment.

You are receiving this mail because:
You are on the CC list for the bug.